zendesk_apps_support 3.3.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a9e45de07d4fc43d38abc3c8acc5181bc91e2186
-  data.tar.gz: 641719f94991cc135fa59d776cf1323dba3f93a1
+  metadata.gz: 3a1d4762759c095666773057863636dd265660b4
+  data.tar.gz: db3af1a717e997011b0923282de990f6c90d1112
 SHA512:
-  metadata.gz: 8317dae950108e25ade2c756ab55687dfa72c01cc5d114470e3ed531c4b1be4ff17cd9fbce201568b0116b688daace243ea7147c3cb7a7dd561e6ae26e2e0cd3
-  data.tar.gz: 1bc68d32b49422d96f9d1f74572d7393f6a26def3140d558a4629426c1918687d94a49c847ec77171ce30179ac08c36dcdbaa7a4ed0d4a288f7f7e0a92d5c841
+  metadata.gz: d69521929f65a21a69aba7ab2ec3be6328b2337a8acd191c38d9858609a13ae45825debea2fd404ffbda0400b55625243adf17991883d1660402171b40b8084c
+  data.tar.gz: 4442c141c1a0b58afed6d95c6232d6d3bb026481adf668ea155a905f87714f5da0c984dcab4be0d6ec4f40bdce68e7dac711abad5755aabb8435cfa78237f63e

data/config/locales/en.yml

@@ -9,6 +9,9 @@ en:
             jshint:
               one: 'JSHint error in %{file}: %{errors}'
               other: 'JSHint errors in %{file}: %{errors}'
+            no_template_deprecated_in_v2: 'noTemplate is deprecated and cannot be
+              used with frameworkVersion 2 or above. Set the autoLoad or autoHide
+              property for each specific location instead. Learn more: %{link}.'
             no_parameters_required: Parameters can't be defined for marketing-only
               apps
             no_location_required: Locations can't be defined when you specify requirements

data/config/locales/translations/zendesk_apps_support.yml

@@ -15,6 +15,10 @@ parts:
       key: "txt.apps.admin.error.app_build.jshint.other"
       title: "App builder job: JSHint error messages"
       value: "JSHint errors in %{file}: %{errors}"
+  - translation:
+      key: "txt.apps.admin.error.app_build.no_template_deprecated_in_v2"
+      title: "App builder job: prevent using noTemplate in v2 apps and give advice on how to migrate"
+      value: "noTemplate is deprecated and cannot be used with frameworkVersion 2 or above. Set the autoLoad or autoHide property for each specific location instead. Learn more: %{link}."
   - translation:
       key: "txt.apps.admin.error.app_build.no_parameters_required"
       title: "App builder job: prevent adding parameters while marketing only"

data/lib/zendesk_apps_support/app_file.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   class AppFile
     attr_reader :relative_path

data/lib/zendesk_apps_support/app_requirement.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   class AppRequirement
     TYPES = %w(automations channel_integrations macros targets views ticket_fields triggers user_fields).freeze

data/lib/zendesk_apps_support/app_version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   # At any point in time, we support up to three versions:
   #  * deprecated -- we will still serve apps targeting the deprecated version,
@@ -8,9 +9,9 @@ module ZendeskAppsSupport
   #                  newly created or updates apps MAY target it, but it
   #                  may change without notice
   class AppVersion
-    DEPRECATED = '0.5'.freeze
-    CURRENT    = '1.0'.freeze
-    FUTURE     = '2.0'.freeze
+    DEPRECATED = '0.5'
+    CURRENT    = '1.0'
+    FUTURE     = '2.0'
 
     TO_BE_SERVED     = [DEPRECATED, CURRENT, FUTURE].compact.freeze
     VALID_FOR_UPDATE = [CURRENT, FUTURE].compact.freeze

data/lib/zendesk_apps_support/build_translation.rb

@@ -1,14 +1,15 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   module BuildTranslation
     I18N_TITLE_KEY = 'title'
     I18N_VALUE_KEY = 'value'
-    I18N_KEYS      = [I18N_TITLE_KEY, I18N_VALUE_KEY]
+    I18N_KEYS      = [I18N_TITLE_KEY, I18N_VALUE_KEY].freeze
 
     def to_flattened_namespaced_hash(hash, target_key = nil, prefix = nil)
-      hash.inject({}) do |result, (key, value)|
+      hash.each_with_object({}) do |(key, value), result|
         key = [prefix, key].compact.join('.')
         if value.is_a?(Hash)
-          if target_key && is_translation_hash?(value)
+          if target_key && translation_hash?(value)
             result[key] = value[target_key]
           else
             result.update(to_flattened_namespaced_hash(value, target_key, key))
@@ -16,7 +17,6 @@ module ZendeskAppsSupport
         else
           result[key] = value
         end
-        result
       end
     end
 
@@ -26,7 +26,7 @@ module ZendeskAppsSupport
 
         if context.is_a?(Hash)
 
-          if is_translation_hash?(context)
+          if translation_hash?(context)
             translations[key] = context[I18N_VALUE_KEY]
           else
             translations[key] ||= {}
@@ -43,7 +43,7 @@ module ZendeskAppsSupport
 
     private
 
-    def is_translation_hash?(hash)
+    def translation_hash?(hash)
       hash.keys.sort == I18N_KEYS
     end
   end

data/lib/zendesk_apps_support/engine.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 if Object.const_defined?(:Rails) && Rails.const_defined?(:Engine)
 
   module ZendeskAppsSupport

data/lib/zendesk_apps_support/finders.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   module Finders
     class RecordNotFound < StandardError
@@ -12,7 +13,7 @@ module ZendeskAppsSupport
 
     def find_by!(arg)
       found = find_by(arg)
-      fail RecordNotFound.new("Unable to find #{self.name} with #{arg.inspect}") if found.nil?
+      raise(RecordNotFound, "Unable to find #{name} with #{arg.inspect}") if found.nil?
       found
     end
 

data/lib/zendesk_apps_support/i18n.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   module I18n
     class << self
@@ -5,10 +6,6 @@ module ZendeskAppsSupport
         i18n.t(key, *args)
       end
 
-      def set_locale(locale)
-        i18n.locale = locale
-      end
-
       def set_load_path
         i18n
         nil

data/lib/zendesk_apps_support/installation.rb

@@ -1,6 +1,6 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   class Installation
-
     attr_accessor :id, :app_id, :app_name, :requirements, :settings, :enabled, :updated_at, :created_at
 
     def initialize(options)
@@ -11,8 +11,8 @@ module ZendeskAppsSupport
 
     def to_json
       hash = {}
-      self.instance_variables.each do |var|
-        hash[var.to_s.sub('@', '')] = self.instance_variable_get var
+      instance_variables.each do |var|
+        hash[var.to_s.sub('@', '')] = instance_variable_get var
       end
       hash.to_json
     end

data/lib/zendesk_apps_support/installed.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'erubis'
 
 module ZendeskAppsSupport

data/lib/zendesk_apps_support/location.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   class Location
     extend ZendeskAppsSupport::Finders

data/lib/zendesk_apps_support/manifest.rb

@@ -160,11 +160,11 @@ module ZendeskAppsSupport
 
     def replace_string_uris(product_locations)
       product_locations.each_with_object({}) do |(k, v), new_locations|
-        if v.is_a? Hash
-          new_locations[k] = v
-        else
-          new_locations[k] = { 'url' => v }
-        end
+        new_locations[k] = if v.is_a? Hash
+                             v
+                           else
+                             { 'url' => v }
+                           end
       end
     end
 

data/lib/zendesk_apps_support/package.rb

@@ -15,7 +15,7 @@ module ZendeskAppsSupport
     DEFAULT_SCSS   = File.read(File.expand_path('../assets/default_styles.scss', __FILE__))
     SRC_TEMPLATE   = Erubis::Eruby.new(File.read(File.expand_path('../assets/src.js.erb', __FILE__)))
 
-    LOCATIONS_WITH_ICONS = %w(top_bar nav_bar system_top_bar).freeze
+    LOCATIONS_WITH_ICONS = %w(top_bar nav_bar system_top_bar ticket_editor).freeze
 
     attr_reader :lib_root, :root, :warnings
 
@@ -42,9 +42,7 @@ module ZendeskAppsSupport
           end
         end
 
-        if has_banner?
-          errors << Validations::Banner.call(self)
-        end
+        errors << Validations::Banner.call(self) if has_banner?
 
         errors.flatten!.compact!
       end
@@ -52,9 +50,7 @@ module ZendeskAppsSupport
 
     def validate!(marketplace: true)
       errors = validate(marketplace: marketplace)
-      if errors.any?
-        raise errors.first
-      end
+      raise errors.first if errors.any?
       true
     end
 
@@ -80,27 +76,27 @@ module ZendeskAppsSupport
       files = []
       Dir[root.join('**/**')].each do |f|
         next unless File.file?(f)
-        relative_file_name = f.sub(/#{root}\/?/, '')
-        next if relative_file_name =~ /^tmp\//
+        relative_file_name = f.sub(%r{#{root}/?}, '')
+        next if relative_file_name =~ %r{^tmp/}
         files << AppFile.new(self, relative_file_name)
       end
       files
     end
 
     def js_files
-      @js_files ||= files.select { |f| f.to_s == 'app.js' || ( f.to_s.start_with?('lib/') && f.to_s.end_with?('.js') ) }
+      @js_files ||= files.select { |f| f.to_s == 'app.js' || (f.to_s.start_with?('lib/') && f.to_s.end_with?('.js')) }
     end
 
     def lib_files
-      @lib_files ||= js_files.select { |f| f =~ /^lib\// }
+      @lib_files ||= js_files.select { |f| f =~ %r{^lib/} }
     end
 
     def template_files
-      files.select { |f| f =~ /^templates\/.*\.hdbs$/ }
+      files.select { |f| f =~ %r{^templates/.*\.hdbs$} }
     end
 
     def translation_files
-      files.select { |f| f =~ /^translations\// }
+      files.select { |f| f =~ %r{^translations/} }
     end
 
     def compile_js(options)
@@ -161,7 +157,8 @@ module ZendeskAppsSupport
     deprecate :no_template_locations, 'manifest.no_template_locations', 2016, 9
 
     def compiled_templates(app_id, asset_url_prefix)
-      compiled_css = ZendeskAppsSupport::StylesheetCompiler.new(DEFAULT_SCSS + app_css, app_id, asset_url_prefix).compile
+      compiler = ZendeskAppsSupport::StylesheetCompiler.new(DEFAULT_SCSS + app_css, app_id, asset_url_prefix)
+      compiled_css = compiler.compile
 
       layout = templates['layout'] || DEFAULT_LAYOUT.result
 
@@ -185,9 +182,9 @@ module ZendeskAppsSupport
     end
 
     def app_css
-      css_file = path_to('app.css')
-      scss_file = path_to('app.scss')
-      File.exist?(scss_file) ? File.read(scss_file) : ( File.exist?(css_file) ? File.read(css_file) : '' )
+      return File.read(path_to('app.scss')) if has_file?('app.scss')
+      return File.read(path_to('app.css')) if has_file?('app.css')
+      ''
     end
 
     def iframe_only?
@@ -207,8 +204,8 @@ module ZendeskAppsSupport
     end
 
     def templates
-      templates_dir = File.join(root, 'templates')
-      Dir["#{templates_dir}/*.hdbs"].inject({}) do |memo, file|
+      templates_dir = path_to('templates')
+      Dir["#{templates_dir}/*.hdbs"].each_with_object({}) do |file, memo|
         str = File.read(file)
         str.chomp!
         memo[File.basename(file, File.extname(file))] = str
@@ -220,30 +217,29 @@ module ZendeskAppsSupport
       return @translations if @is_cached && @translations
 
       @translations = begin
-        translation_dir = File.join(root, 'translations')
+        translation_dir = path_to('translations')
         return {} unless File.directory?(translation_dir)
 
         locale_path = "#{translation_dir}/#{manifest.default_locale}.json"
         default_translations = process_translations(locale_path)
 
-        Dir["#{translation_dir}/*.json"].inject({}) do |memo, path|
+        Dir["#{translation_dir}/*.json"].each_with_object({}) do |path, memo|
           locale = File.basename(path, File.extname(path))
 
           locale_translations = if locale == manifest.default_locale
-            default_translations
-          else
-            deep_merge_hash(default_translations, process_translations(path))
-          end
+                                  default_translations
+                                else
+                                  deep_merge_hash(default_translations, process_translations(path))
+                                end
 
           memo[locale] = locale_translations
-          memo
         end
       end
     end
 
     def process_translations(locale_path)
       translations = File.exist?(locale_path) ? JSON.parse(File.read(locale_path)) : {}
-      translations['app'].delete('package') if translations.has_key?('app')
+      translations['app'].delete('package') if translations.key?('app')
       remove_zendesk_keys(translations)
     end
 
@@ -272,18 +268,36 @@ module ZendeskAppsSupport
 
           host = location_options.location.product.name
           location = location_options.location.name
-          location_icons[host][location] = if (has_file?("assets/icon_#{location}.svg"))
-            cache_busting_param = "?#{Time.now.to_i}" unless @is_cached
-            { 'svg' => "icon_#{location}.svg#{cache_busting_param}" }
-          elsif (has_file?("assets/icon_#{location}_inactive.png"))
-            {
-              'inactive' => "icon_#{location}_inactive.png",
-              'active' => has_file?("assets/icon_#{location}_active.png") ? "icon_#{location}_active.png" : "icon_#{location}_inactive.png",
-              'hover' => has_file?("assets/icon_#{location}_hover.png") ? "icon_#{location}_hover.png" : "icon_#{location}_inactive.png"
-            }
-          else
-            {}
-          end
+          location_icons[host][location] = build_location_icons_hash(location)
+        end
+      end
+    end
+
+    def build_location_icons_hash(location)
+      inactive_png = "icon_#{location}_inactive.png"
+      if has_file?("assets/icon_#{location}.svg")
+        build_svg_icon_hash(location)
+      elsif has_file?("assets/#{inactive_png}")
+        build_png_icons_hash(location)
+      else
+        {}
+      end
+    end
+
+    def build_svg_icon_hash(location)
+      cache_busting_param = "?#{Time.now.to_i}" unless @is_cached
+      { 'svg' => "icon_#{location}.svg#{cache_busting_param}" }
+    end
+
+    def build_png_icons_hash(location)
+      inactive_png = "icon_#{location}_inactive.png"
+      {
+        'inactive' => inactive_png
+      }.tap do |icon_state_hash|
+        %w(active hover).each do |state|
+          specific_png = "icon_#{location}_#{state}.png"
+          selected_png = has_file?("assets/#{specific_png}") ? specific_png : inactive_png
+          icon_state_hash[state] = selected_png
         end
       end
     end
@@ -301,11 +315,11 @@ module ZendeskAppsSupport
     def deep_merge_hash(h, another_h)
       result_h = h.dup
       another_h.each do |key, value|
-        if h.has_key?(key) && h[key].is_a?(Hash) && value.is_a?(Hash)
-          result_h[key] = deep_merge_hash(h[key], value)
-        else
-          result_h[key] = value
-        end
+        result_h[key] = if h.key?(key) && h[key].is_a?(Hash) && value.is_a?(Hash)
+                          deep_merge_hash(h[key], value)
+                        else
+                          value
+                        end
       end
       result_h
     end
@@ -316,9 +330,7 @@ module ZendeskAppsSupport
 
     def read_json(path, parser_opts = {})
       file = read_file(path)
-      unless file.nil?
-        JSON.parse(read_file(path), parser_opts)
-      end
+      JSON.parse(read_file(path), parser_opts) unless file.nil?
     end
   end
 end

data/lib/zendesk_apps_support/product.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   class Product
     extend ZendeskAppsSupport::Finders

data/lib/zendesk_apps_support/sass_functions.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'sass'
 
 module Sass::Script::Functions

data/lib/zendesk_apps_support/stylesheet_compiler.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
 require 'sass'
 require 'zendesk_apps_support/sass_functions'
 
 module ZendeskAppsSupport
   class StylesheetCompiler
     def initialize(source, app_id, url_prefix)
-      @source, @app_id, @url_prefix = source, app_id, url_prefix
+      @source = source
+      @app_id = app_id
+      @url_prefix = url_prefix
     end
 
     def compile

data/lib/zendesk_apps_support/validations/banner.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'image_size'
 
 module ZendeskAppsSupport

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'uri'
 
 module ZendeskAppsSupport
@@ -6,6 +7,7 @@ module ZendeskAppsSupport
       RUBY_TO_JSON = ZendeskAppsSupport::Manifest::RUBY_TO_JSON
       REQUIRED_MANIFEST_FIELDS = RUBY_TO_JSON.select { |k| %i(author default_locale).include? k }.freeze
       OAUTH_REQUIRED_FIELDS    = %w(client_id client_secret authorize_uri access_token_uri).freeze
+      PARAMETER_TYPES = ZendeskAppsSupport::Manifest::Parameter::TYPES
 
       class <<self
         def call(package)
@@ -28,6 +30,8 @@ module ZendeskAppsSupport
           errors << boolean_error(manifest)
           errors << default_locale_error(manifest, package)
 
+          errors << ban_no_template(manifest) if manifest.iframe_only?
+
           if manifest.requirements_only? || manifest.marketing_only?
             errors << ban_location(manifest)
             errors << ban_framework_version(manifest)
@@ -69,6 +73,13 @@ module ZendeskAppsSupport
           end
         end
 
+        def ban_no_template(manifest)
+          no_template_migration_link = 'https://developer.zendesk.com/apps/docs/apps-v2/manifest#location'
+          if manifest.no_template? || !manifest.no_template_locations.empty?
+            ValidationError.new(:no_template_deprecated_in_v2, link: no_template_migration_link)
+          end
+        end
+
         def ban_parameters(manifest)
           ValidationError.new(:no_parameters_required) unless manifest.parameters.empty?
         end
@@ -131,7 +142,7 @@ module ZendeskAppsSupport
           unless default_locale.nil?
             if default_locale !~ Translations::VALID_LOCALE
               ValidationError.new(:invalid_default_locale, default_locale: default_locale)
-            elsif package.translation_files.detect { |file| file.relative_path == "translations/#{default_locale}.json" }.nil?
+            elsif package.translation_files.detect { |f| f.relative_path == "translations/#{default_locale}.json" }.nil?
               ValidationError.new(:missing_translation_file, default_locale: default_locale)
             end
           end
@@ -155,9 +166,9 @@ module ZendeskAppsSupport
             invalid_locations = package.manifest.unknown_locations(product.name)
             next if invalid_locations.empty?
             errors << ValidationError.new(:invalid_location,
-                                    invalid_locations: invalid_locations.join(', '),
-                                    host_name: product.name,
-                                    count: invalid_locations.length)
+                                          invalid_locations: invalid_locations.join(', '),
+                                          host_name: product.name,
+                                          count: invalid_locations.length)
           end
 
           package.manifest.unknown_hosts.each do |unknown_host|
@@ -199,7 +210,9 @@ module ZendeskAppsSupport
           end
 
           unless valid_to_serve.include?(target_version)
-            return ValidationError.new(:invalid_version, target_version: target_version, available_versions: valid_to_serve.join(', '))
+            return ValidationError.new(:invalid_version,
+                                       target_version: target_version,
+                                       available_versions: valid_to_serve.join(', '))
           end
         end
 
@@ -213,7 +226,9 @@ module ZendeskAppsSupport
           invalid_params = manifest.parameters.select { |p| p.type == 'hidden' && p.required }.map(&:name)
 
           if invalid_params.any?
-            ValidationError.new(:invalid_hidden_parameter, invalid_params: invalid_params.join(', '), count: invalid_params.length)
+            ValidationError.new(:invalid_hidden_parameter,
+                                invalid_params: invalid_params.join(', '),
+                                count: invalid_params.length)
           end
         end
 
@@ -222,7 +237,7 @@ module ZendeskAppsSupport
           manifest.parameters.each do |parameter|
             parameter_type = parameter.type
 
-            invalid_types << parameter_type unless ZendeskAppsSupport::Manifest::Parameter::TYPES.include?(parameter_type)
+            invalid_types << parameter_type unless PARAMETER_TYPES.include?(parameter_type)
           end
 
           if invalid_types.any?
@@ -233,7 +248,9 @@ module ZendeskAppsSupport
         end
 
         def missing_keys_validation_error(missing_keys)
-          ValidationError.new('manifest_keys.missing', missing_keys: missing_keys.join(', '), count: missing_keys.length)
+          ValidationError.new('manifest_keys.missing',
+                              missing_keys: missing_keys.join(', '),
+                              count: missing_keys.length)
         end
 
         def location_framework_mismatch(manifest)

data/lib/zendesk_apps_support/validations/requirements.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   module Validations
     module Requirements
@@ -47,10 +48,8 @@ module ZendeskAppsSupport
         end
 
         def excessive_requirements(requirements)
-          requirement_count = requirements.values.map(&:values).flatten.size
-          if requirement_count > MAX_REQUIREMENTS
-            ValidationError.new(:excessive_requirements, max: MAX_REQUIREMENTS, count: requirement_count)
-          end
+          count = requirements.values.map(&:values).flatten.size
+          ValidationError.new(:excessive_requirements, max: MAX_REQUIREMENTS, count: count) if count > MAX_REQUIREMENTS
         end
 
         def invalid_user_fields(requirements)
@@ -83,7 +82,9 @@ module ZendeskAppsSupport
           invalid_types = requirements.keys - ZendeskAppsSupport::AppRequirement::TYPES
 
           unless invalid_types.empty?
-            ValidationError.new(:invalid_requirements_types, invalid_types: invalid_types.join(', '), count: invalid_types.length)
+            ValidationError.new(:invalid_requirements_types,
+                                invalid_types: invalid_types.join(', '),
+                                count: invalid_types.length)
           end
         end
       end

data/lib/zendesk_apps_support/validations/source.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'jshintrb'
 
 module ZendeskAppsSupport

data/lib/zendesk_apps_support/validations/stylesheets.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'zendesk_apps_support/stylesheet_compiler'
 
 module ZendeskAppsSupport
@@ -5,11 +6,8 @@ module ZendeskAppsSupport
     module Stylesheets
       class << self
         def call(package)
-          if css_error = validate_styles(package.app_css)
-            [css_error]
-          else
-            []
-          end
+          css_error = validate_styles(package.app_css)
+          css_error ? [css_error] : []
         end
 
         private

data/lib/zendesk_apps_support/validations/templates.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   module Validations
     module Templates

data/lib/zendesk_apps_support/validations/translations.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'jshintrb'
 require 'json'
 
@@ -12,11 +13,11 @@ module ZendeskAppsSupport
 
       class << self
         def call(package)
-          package.files.inject([]) do |errors, file|
-            if path_match = TRANSLATIONS_PATH.match(file.relative_path)
+          package.files.each_with_object([]) do |file, errors|
+            path_match = TRANSLATIONS_PATH.match(file.relative_path)
+            if path_match
               errors << locale_error(file, path_match[1]) << json_error(file)
             end
-            errors
           end.compact
         end
 
@@ -28,7 +29,7 @@ module ZendeskAppsSupport
         end
 
         def json_error(file)
-          json = JSON.load(file.read)
+          json = JSON.parse(file.read)
           if json.is_a?(Hash)
             if json['app'] && json['app']['package']
               json['app'].delete('package')
@@ -48,7 +49,7 @@ module ZendeskAppsSupport
 
         def validate_translation_format(json)
           json.keys.each do |key|
-            fail TranslationFormatError.new("'#{key}': '#{json[key]}'") unless json[key].is_a? Hash
+            raise TranslationFormatError, "'#{key}': '#{json[key]}'" unless json[key].is_a? Hash
 
             if json[key].keys.sort == BuildTranslation::I18N_KEYS &&
                json[key][BuildTranslation::I18N_TITLE_KEY].class == String &&

data/lib/zendesk_apps_support/validations/validation_error.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 require 'json'
 
 module ZendeskAppsSupport
   module Validations
     class ValidationError < StandardError
-      KEY_PREFIX = 'txt.apps.admin.error.app_build.'.freeze
+      KEY_PREFIX = 'txt.apps.admin.error.app_build.'
 
       class DeserializationError < StandardError
         def initialize(serialized)
@@ -14,17 +15,17 @@ module ZendeskAppsSupport
       class << self
         # Turn a JSON string into a ValidationError.
         def from_json(json)
-          hash = JSON.load(json)
-          fail DeserializationError.new(json) unless hash.is_a?(Hash)
+          hash = JSON.parse(json)
+          raise DeserializationError, json unless hash.is_a?(Hash)
           from_hash(hash)
         rescue JSON::ParserError, NameError
-          raise DeserializationError.new(json)
+          raise DeserializationError, json
         end
 
         def from_hash(hash)
-          fail DeserializationError.new(hash) unless hash['class']
+          raise DeserializationError, hash unless hash['class']
           klass = constantize(hash['class'])
-          fail DeserializationError.new(hash) unless klass <= self
+          raise DeserializationError, hash unless klass <= self
           klass.vivify(hash)
         end
 
@@ -36,14 +37,15 @@ module ZendeskAppsSupport
         private
 
         def constantize(klass)
-          klass.to_s.split('::').inject(Object) { |klass, part| klass.const_get(part) }
+          klass.to_s.split('::').inject(Object) { |superclass, part| superclass.const_get(part) }
         end
       end
 
       attr_reader :key, :data
 
       def initialize(key, data = nil)
-        @key, @data = key, symbolize_keys(data || {})
+        @key = key
+        @data = symbolize_keys(data || {})
       end
 
       def to_s
@@ -65,9 +67,8 @@ module ZendeskAppsSupport
       private
 
       def symbolize_keys(hash)
-        hash.inject({}) do |result, (key, value)|
+        hash.each_with_object({}) do |(key, value), result|
           result[key.to_sym] = value
-          result
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.3.1
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-05 00:00:00.000000000 Z
+date: 2016-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -216,7 +216,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.