zendesk_apps_support 1.3.0 → 1.4.1

data/config/locales/en.yml

@@ -46,6 +46,6 @@ en:
               other: ! '%{invalid_types} are invalid parameter types.'
         warning:
           app_build:
-            deprecated_version: You are targeting a deprecated version of the framework,
-              your App will still work but might break as soon as the new framework
-              version is deployed.
+            deprecated_version: You are targeting a deprecated version of the framework.
+              Your app will work, but it might break when the new framework version
+              is deployed.

data/config/locales/translations/zendesk_apps_support.yml

@@ -74,7 +74,7 @@ parts:
   - translation:
       key: "txt.apps.admin.warning.app_build.deprecated_version"
       title: "App builder job: deprecated version specified"
-      value: 'You are targeting a deprecated version of the framework, your App will still work but might break as soon as the new framework version is deployed.'
+      value: 'You are targeting a deprecated version of the framework. Your app will work, but it might break when the new framework version is deployed.'
   - translation:
       key: "txt.apps.admin.error.app_build.invalid_version"
       title: "App builder job: invalid framework version"

data/lib/zendesk_apps_support/assets/default_template.html.erb

@@ -0,0 +1,10 @@
+<header>
+  <span class="logo"/>
+  <h3>{{setting "name"}}</h3>
+</header>
+<section data-main />
+<footer>
+  <a href="mailto:{{author.email}}">
+    {{author.name}}
+  </a>
+</footer>

data/lib/zendesk_apps_support/package.rb

@@ -5,8 +5,9 @@ require 'json'
 module ZendeskAppsSupport
   class Package
 
-    DEFAULT_SCSS   = File.read(File.expand_path('../default_styles.scss', __FILE__))
-    SRC_TEMPLATE = Erubis::Eruby.new( File.read(File.expand_path('../src.js.erb', __FILE__)) )
+    DEFAULT_LAYOUT = Erubis::Eruby.new( File.read(File.expand_path('../assets/default_template.html.erb', __FILE__)) )
+    DEFAULT_SCSS   = File.read(File.expand_path('../assets/default_styles.scss', __FILE__))
+    SRC_TEMPLATE = Erubis::Eruby.new( File.read(File.expand_path('../assets/src.js.erb', __FILE__)) )
 
     attr_reader :root, :warnings
 
@@ -48,7 +49,7 @@ module ZendeskAppsSupport
       author = manifest[:author]
       translations = JSON.parse(File.read(File.join(root, "translations/en.json")))
       framework_version = manifest[:frameworkVersion]
-      templates = compiled_templates(app_id, asset_url_prefix)
+      templates = manifest[:noTemplate] ? {} : compiled_templates(app_id, asset_url_prefix)
 
       settings["title"] = name
 
@@ -86,8 +87,10 @@ module ZendeskAppsSupport
         end
       end
 
+      layout = templates['layout'] || DEFAULT_LAYOUT.result
+
       templates.tap do |templates|
-        templates['layout'] = "<style>\n#{compiled_css}</style>\n#{templates['layout']}"
+        templates['layout'] = "<style>\n#{compiled_css}</style>\n#{layout}"
       end
     end
 

data/spec/package_spec.rb

@@ -8,7 +8,7 @@ describe ZendeskAppsSupport::Package do
 
   describe 'files' do
     it 'should return all the files within the app folder excluding files in tmp folder' do
-      @package.files.map(&:relative_path).should == %w(app.css app.js assets/logo-small.png assets/logo.png manifest.json templates/layout.hdbs translations/en.json)
+      @package.files.map(&:relative_path).should =~ %w(app.css app.js assets/logo-small.png assets/logo.png manifest.json templates/layout.hdbs translations/en.json)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-14 00:00:00.000000000 Z
+date: 2013-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -150,12 +150,13 @@ extra_rdoc_files: []
 files:
 - lib/zendesk_apps_support/app_file.rb
 - lib/zendesk_apps_support/app_version.rb
-- lib/zendesk_apps_support/default_styles.scss
+- lib/zendesk_apps_support/assets/default_styles.scss
+- lib/zendesk_apps_support/assets/default_template.html.erb
+- lib/zendesk_apps_support/assets/src.js.erb
 - lib/zendesk_apps_support/engine.rb
 - lib/zendesk_apps_support/i18n.rb
 - lib/zendesk_apps_support/package.rb
 - lib/zendesk_apps_support/sass_functions.rb
-- lib/zendesk_apps_support/src.js.erb
 - lib/zendesk_apps_support/stylesheet_compiler.rb
 - lib/zendesk_apps_support/validations/manifest.rb
 - lib/zendesk_apps_support/validations/source.rb
@@ -207,7 +208,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Support to help you develop Zendesk Apps.