zendesk_apps_support 1.17.0 → 1.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 42c552214dd0abe4fbb075e17732e01a59a26f21
-  data.tar.gz: 880a3e8adc66819e998579f674bdb3c5deecb14f
+  metadata.gz: 4652177f210c7e96e96dda1dd85b981b2d9017c1
+  data.tar.gz: 707731e9c4eb073339dc46ba1529416b43d63aa0
 SHA512:
-  metadata.gz: b1b7b06895b7a189c1f97e9ca6944b7ca8e66335f653bf80c2495ee718211edc50ea2ae6aab372f1915495247cfcc1ca12b6ddbcdb8d4336b30e7fde450f06e0
-  data.tar.gz: 98ceea08abd04d55e09153fb28ed7056ce49396f21a30579e0088312d9d2011759d17713e319b0a21ed71f069774d80b897bba6688f82e98258532413da0cdeb
+  metadata.gz: 8b31cb09a925f5987c82290c4f4cae89ea09e41ade156db05bd1409d20a4f6e4bb7426ef2cf1710f892579ea5be834b211e863a11a7547d0ba7459518c31c054
+  data.tar.gz: 3b3d587b40cebbcbfba5d704371eb83c8bcd4d3395fe64243ebddf50e3b292d98427ee7fc0b60b91c0d8151ad8d8ee7089cb6b907d6022feb46a39b05075da53

data/lib/zendesk_apps_support.rb

@@ -1,5 +1,4 @@
 module ZendeskAppsSupport
-
   require 'zendesk_apps_support/sass_functions'
   require 'zendesk_apps_support/engine'
 

data/lib/zendesk_apps_support/app_file.rb

@@ -1,7 +1,5 @@
 module ZendeskAppsSupport
-
   class AppFile
-
     attr_reader :relative_path
     attr_reader :absolute_path
 
@@ -16,7 +14,11 @@ module ZendeskAppsSupport
     end
 
     def =~(regex)
-      @relative_path =~ regex
+      relative_path =~ regex
+    end
+
+    def match(regex)
+      self =~ regex
     end
 
     alias_method :to_s, :relative_path
@@ -38,7 +40,5 @@ module ZendeskAppsSupport
     def respond_to_missing?(sym, include_private = false)
       @file.send(:respond_to_missing?, sym, include_private) || super
     end
-
   end
-
 end

data/lib/zendesk_apps_support/app_version.rb

@@ -1,7 +1,6 @@
 require 'multi_json'
 
 module ZendeskAppsSupport
-
   # At any point in time, we support up to three versions:
   #  * deprecated -- we will still serve apps targeting the deprecated version,
   #                  but newly created or updated apps CANNOT target it
@@ -11,13 +10,12 @@ module ZendeskAppsSupport
   #                  newly created or updates apps MAY target it, but it
   #                  may change without notice
   class AppVersion
-
     DEPRECATED = '0.4'.freeze
     CURRENT    = '0.5'.freeze
     FUTURE     = '1.0'.freeze
 
-    TO_BE_SERVED     = [ DEPRECATED, CURRENT, FUTURE ].compact.freeze
-    VALID_FOR_UPDATE = [ CURRENT, FUTURE ].compact.freeze
+    TO_BE_SERVED     = [DEPRECATED, CURRENT, FUTURE].compact.freeze
+    VALID_FOR_UPDATE = [CURRENT, FUTURE].compact.freeze
 
     def initialize(version)
       @version = version.to_s
@@ -53,16 +51,14 @@ module ZendeskAppsSupport
       @version
     end
 
-    def to_json(*options)
+    def to_json(*)
       MultiJson.encode(@version)
     end
 
     def ==(other)
       @version == other.to_s
     end
-
   end
 
   AppVersion.freeze
-
 end

data/lib/zendesk_apps_support/build_translation.rb

@@ -1,6 +1,5 @@
 module ZendeskAppsSupport
   module BuildTranslation
-
     I18N_TITLE_KEY = 'title'
     I18N_VALUE_KEY = 'value'
     I18N_KEYS      = [I18N_TITLE_KEY, I18N_VALUE_KEY]
@@ -8,7 +7,7 @@ module ZendeskAppsSupport
     def to_flattened_namespaced_hash(hash, target_key = nil, prefix = nil)
       hash.inject({}) do |result, (key, value)|
         key = [prefix, key].compact.join('.')
-        if value.kind_of?(Hash)
+        if value.is_a?(Hash)
           if target_key && is_translation_hash?(value)
             result[key] = value[target_key]
           else
@@ -22,7 +21,6 @@ module ZendeskAppsSupport
     end
 
     def remove_zendesk_keys(scope, translations = {})
-
       scope.each_key do |key|
         context = scope[key]
 
@@ -48,6 +46,5 @@ module ZendeskAppsSupport
     def is_translation_hash?(hash)
       hash.keys.sort == I18N_KEYS
     end
-
   end
 end

data/lib/zendesk_apps_support/engine.rb

@@ -1,11 +1,9 @@
 if Object.const_defined?(:Rails) && Rails.const_defined?(:Engine)
 
   module ZendeskAppsSupport
-
     class Engine < Rails::Engine
       engine_name 'zendesk_apps_support'
     end
-
   end
 
 end

data/lib/zendesk_apps_support/i18n.rb

@@ -20,8 +20,8 @@ module ZendeskAppsSupport
       end
 
       def locale_files
-        Dir[ File.expand_path('../../../config/locales/*.yml', __FILE__) ] -
-          Dir[ File.expand_path('../../../config/locales/*.zendesk.yml', __FILE__) ]
+        Dir[File.expand_path('../../../config/locales/*.yml', __FILE__)] -
+          Dir[File.expand_path('../../../config/locales/*.zendesk.yml', __FILE__)]
       end
     end
   end

data/lib/zendesk_apps_support/package.rb

@@ -6,9 +6,9 @@ module ZendeskAppsSupport
   class Package
     include ZendeskAppsSupport::BuildTranslation
 
-    DEFAULT_LAYOUT = Erubis::Eruby.new( File.read(File.expand_path('../assets/default_template.html.erb', __FILE__)) )
+    DEFAULT_LAYOUT = Erubis::Eruby.new(File.read(File.expand_path('../assets/default_template.html.erb', __FILE__)))
     DEFAULT_SCSS   = File.read(File.expand_path('../assets/default_styles.scss', __FILE__))
-    SRC_TEMPLATE   = Erubis::Eruby.new( File.read(File.expand_path('../assets/src.js.erb', __FILE__)) )
+    SRC_TEMPLATE   = Erubis::Eruby.new(File.read(File.expand_path('../assets/src.js.erb', __FILE__)))
 
     attr_reader :lib_root, :root, :warnings
     attr_accessor :requirements_only
@@ -22,7 +22,6 @@ module ZendeskAppsSupport
 
     def validate
       [].tap do |errors|
-
         errors << Validations::Manifest.call(self)
 
         if has_manifest?
@@ -48,7 +47,7 @@ module ZendeskAppsSupport
     end
 
     def app_js
-      read_file("app.js")
+      read_file('app.js')
     end
 
     def commonjs_modules
@@ -78,22 +77,22 @@ module ZendeskAppsSupport
     end
 
     def manifest_json
-      read_json("manifest.json")
+      read_json('manifest.json')
     end
 
     def requirements_json
-      read_json("requirements.json")
+      read_json('requirements.json')
     end
 
     def translations
-      read_json("translations/en.json", false)
+      read_json('translations/en.json', false)
     end
 
     def app_translations
       remove_zendesk_keys(translations)
     end
 
-    def readified_js(app_name, app_id, asset_url_prefix, settings={})
+    def readified_js(app_name, app_id, asset_url_prefix, settings = {})
       manifest = manifest_json
       source = app_js
       name = app_name || manifest[:name] || 'Local App'
@@ -105,37 +104,37 @@ module ZendeskAppsSupport
       no_template = manifest[:noTemplate]
       templates = no_template ? {} : compiled_templates(app_id, asset_url_prefix)
 
-      settings["title"] = name
+      settings['title'] = name
 
       app_settings = {
-        :location => location,
-        :noTemplate => no_template,
-        :singleInstall => single_install
-      }.select { |k,v| !v.nil? }
+        location: location,
+        noTemplate: no_template,
+        singleInstall: single_install
+      }.select { |_k, v| !v.nil? }
 
       SRC_TEMPLATE.result(
-          :name => name,
-          :source => source,
-          :app_settings => app_settings,
-          :asset_url_prefix => asset_url_prefix,
-          :app_class_name => app_class_name,
-          :author => author,
-          :translations => app_translations,
-          :framework_version => framework_version,
-          :templates => templates,
-          :settings => settings,
-          :app_id => app_id,
-          :modules => commonjs_modules
+          name: name,
+          source: source,
+          app_settings: app_settings,
+          asset_url_prefix: asset_url_prefix,
+          app_class_name: app_class_name,
+          author: author,
+          translations: app_translations,
+          framework_version: framework_version,
+          templates: templates,
+          settings: settings,
+          app_id: app_id,
+          modules: commonjs_modules
       )
     end
 
     def customer_css
       css_file = file_path('app.css')
-      customer_css = File.exist?(css_file) ? File.read(css_file) : ""
+      File.exist?(css_file) ? File.read(css_file) : ''
     end
 
     def has_js?
-      file_exists?("app.js")
+      file_exists?('app.js')
     end
 
     def has_lib_js?
@@ -143,7 +142,7 @@ module ZendeskAppsSupport
     end
 
     def has_manifest?
-      file_exists?("manifest.json")
+      file_exists?('manifest.json')
     end
 
     def has_location?
@@ -151,11 +150,11 @@ module ZendeskAppsSupport
     end
 
     def has_requirements?
-      file_exists?("requirements.json")
+      file_exists?('requirements.json')
     end
 
     def has_banner?
-      file_exists?("assets/banner.png")
+      file_exists?('assets/banner.png')
     end
 
     def file_path(path)
@@ -168,7 +167,7 @@ module ZendeskAppsSupport
       compiled_css = ZendeskAppsSupport::StylesheetCompiler.new(DEFAULT_SCSS + customer_css, app_id, asset_url_prefix).compile
 
       templates = begin
-        Dir["#{root.to_s}/templates/*.hdbs"].inject({}) do |h, file|
+        Dir["#{root}/templates/*.hdbs"].inject({}) do |h, file|
           str = File.read(file)
           str.chomp!
           h[File.basename(file, File.extname(file))] = str
@@ -185,7 +184,7 @@ module ZendeskAppsSupport
 
     def non_tmp_files
       files = []
-      Dir[ root.join('**/**') ].each do |f|
+      Dir[root.join('**/**')].each do |f|
         next unless File.file?(f)
         relative_file_name = f.sub(/#{root}\/?/, '')
         next if relative_file_name =~ /^tmp\//
@@ -205,7 +204,7 @@ module ZendeskAppsSupport
     def read_json(path, symbolize_names = true)
       file = read_file(path)
       unless file.nil?
-        JSON.parse(read_file(path), :symbolize_names => symbolize_names)
+        JSON.parse(read_file(path), symbolize_names: symbolize_names)
       end
     end
   end

data/lib/zendesk_apps_support/sass_functions.rb

@@ -1,11 +1,10 @@
 require 'sass'
 
 module Sass::Script::Functions
-
   module AppAssetUrl
     def app_asset_url(name)
       assert_type name, :String
-      result = %Q{url("#{app_asset_url_helper(name)}")}
+      result = %{url("#{app_asset_url_helper(name)}")}
       Sass::Script::String.new(result)
     end
 
@@ -18,5 +17,4 @@ module Sass::Script::Functions
   end
 
   include AppAssetUrl
-
 end

data/lib/zendesk_apps_support/stylesheet_compiler.rb

@@ -2,13 +2,12 @@ require 'sass'
 
 module ZendeskAppsSupport
   class StylesheetCompiler
-
     def initialize(source, app_id, url_prefix)
       @source, @app_id, @url_prefix = source, app_id, url_prefix
     end
 
     def compile
-      Sass::Engine.new(wrapped_source, :syntax => :scss, :app_asset_url_builder => self).render
+      Sass::Engine.new(wrapped_source, syntax: :scss, app_asset_url_builder: self).render
     end
 
     def app_asset_url(name)
@@ -20,6 +19,5 @@ module ZendeskAppsSupport
     def wrapped_source
       ".app-#{@app_id} {#{@source}}"
     end
-
   end
 end

data/lib/zendesk_apps_support/validations/banner.rb

@@ -17,11 +17,11 @@ module ZendeskAppsSupport
               end
 
               unless (image.width == BANNER_WIDTH && image.height == BANNER_HEIGHT) ||
-                     (image.width == 2*BANNER_WIDTH && image.height == 2*BANNER_HEIGHT)
-                return [ValidationError.new('banner.invalid_size', :required_banner_width => BANNER_WIDTH,
-                                                                   :required_banner_height => BANNER_HEIGHT)]
+                     (image.width == 2 * BANNER_WIDTH && image.height == 2 * BANNER_HEIGHT)
+                return [ValidationError.new('banner.invalid_size', required_banner_width: BANNER_WIDTH,
+                                                                   required_banner_height: BANNER_HEIGHT)]
               end
-            rescue => e
+            rescue
               return [ValidationError.new('banner.invalid_format')]
             end
           end

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -3,11 +3,10 @@ require 'multi_json'
 module ZendeskAppsSupport
   module Validations
     module Manifest
-
       REQUIRED_MANIFEST_FIELDS = %w( author defaultLocale ).freeze
       OAUTH_REQUIRED_FIELDS    = %w( client_id client_secret authorize_uri access_token_uri ).freeze
       LOCATIONS_AVAILABLE      = %w( top_bar nav_bar ticket_sidebar new_ticket_sidebar user_sidebar ).freeze
-      TYPES_AVAILABLE          = %W( text password checkbox url number multiline hidden ).freeze
+      TYPES_AVAILABLE          = %w( text password checkbox url number multiline hidden ).freeze
 
       class <<self
         def call(package)
@@ -42,7 +41,7 @@ module ZendeskAppsSupport
             errors.compact!
           end
         rescue MultiJson::DecodeError => e
-          return [ValidationError.new(:manifest_not_json, :errors => e)]
+          return [ValidationError.new(:manifest_not_json, errors: e)]
         end
 
         private
@@ -63,22 +62,21 @@ module ZendeskAppsSupport
           end
 
           if missing.any?
-            ValidationError.new('oauth_keys.missing', :missing_keys => missing.join(', '), :count => missing.length)
+            ValidationError.new('oauth_keys.missing', missing_keys: missing.join(', '), count: missing.length)
           end
-
         end
 
         def parameters_error(manifest)
           return unless manifest['parameters']
 
-          unless manifest['parameters'].kind_of?(Array)
+          unless manifest['parameters'].is_a?(Array)
             return ValidationError.new(:parameters_not_an_array)
           end
 
-          para_names = manifest['parameters'].collect{|para| para['name']}
-          duplicate_parameters = para_names.select {|name| para_names.count(name) > 1}.uniq
+          para_names = manifest['parameters'].collect { |para| para['name'] }
+          duplicate_parameters = para_names.select { |name| para_names.count(name) > 1 }.uniq
           unless duplicate_parameters.empty?
-            return ValidationError.new(:duplicate_parameters, :duplicate_parameters => duplicate_parameters)
+            return ValidationError.new(:duplicate_parameters, duplicate_parameters: duplicate_parameters)
           end
         end
 
@@ -92,11 +90,11 @@ module ZendeskAppsSupport
 
         def default_locale_error(manifest, package)
           default_locale = manifest['defaultLocale']
-          if !default_locale.nil?
+          unless default_locale.nil?
             if default_locale !~ Translations::VALID_LOCALE
-              ValidationError.new(:invalid_default_locale, :defaultLocale => default_locale)
+              ValidationError.new(:invalid_default_locale, defaultLocale: default_locale)
             elsif package.translation_files.detect { |file| file.relative_path == "translations/#{default_locale}.json" }.nil?
-              ValidationError.new(:missing_translation_file, :defaultLocale => default_locale)
+              ValidationError.new(:missing_translation_file, defaultLocale: default_locale)
             end
           end
         end
@@ -108,7 +106,7 @@ module ZendeskAppsSupport
         def invalid_location_error(manifest)
           invalid_locations = [*manifest['location']] - LOCATIONS_AVAILABLE
           unless invalid_locations.empty?
-            ValidationError.new(:invalid_location, :invalid_locations => invalid_locations.join(', '), :count => invalid_locations.length)
+            ValidationError.new(:invalid_location, invalid_locations: invalid_locations.join(', '), count: invalid_locations.length)
           end
         end
 
@@ -117,7 +115,7 @@ module ZendeskAppsSupport
           duplicate_locations = *locations.select { |location| locations.count(location) > 1 }.uniq
 
           unless duplicate_locations.empty?
-            ValidationError.new(:duplicate_location, :duplicate_locations => duplicate_locations.join(', '), :count => duplicate_locations.length)
+            ValidationError.new(:duplicate_location, duplicate_locations: duplicate_locations.join(', '), count: duplicate_locations.length)
           end
         end
 
@@ -134,12 +132,12 @@ module ZendeskAppsSupport
           end
 
           unless valid_to_serve.include?(target_version)
-            return ValidationError.new(:invalid_version, :target_version => target_version, :available_versions => valid_to_serve.join(', '))
+            return ValidationError.new(:invalid_version, target_version: target_version, available_versions: valid_to_serve.join(', '))
           end
         end
 
         def name_as_parameter_name_error(manifest)
-          if manifest['parameters'].kind_of?(Array)
+          if manifest['parameters'].is_a?(Array)
             if manifest['parameters'].any? { |p| p['name'] == 'name' }
               ValidationError.new(:name_as_parameter_name)
             end
@@ -149,35 +147,34 @@ module ZendeskAppsSupport
         def invalid_hidden_parameter_error(manifest)
           invalid_params = []
 
-          if manifest.has_key?('parameters')
+          if manifest.key?('parameters')
             invalid_params = manifest['parameters'].select { |p| p['type'] == 'hidden' && p['required'] }.map { |p| p['name'] }
           end
 
           if invalid_params.any?
-            ValidationError.new(:invalid_hidden_parameter, :invalid_params => invalid_params.join(', '), :count => invalid_params.length)
+            ValidationError.new(:invalid_hidden_parameter, invalid_params: invalid_params.join(', '), count: invalid_params.length)
           end
         end
 
         def invalid_type_error(manifest)
-          return unless manifest['parameters'].kind_of?(Array)
+          return unless manifest['parameters'].is_a?(Array)
 
           invalid_types = []
 
-          manifest["parameters"].each do |parameter|
-            parameter_type = parameter.fetch("type", '')
+          manifest['parameters'].each do |parameter|
+            parameter_type = parameter.fetch('type', '')
 
             invalid_types << parameter_type unless TYPES_AVAILABLE.include?(parameter_type)
           end
 
           if invalid_types.any?
-            ValidationError.new(:invalid_type_parameter, :invalid_types => invalid_types.join(', '), :count => invalid_types.length)
+            ValidationError.new(:invalid_type_parameter, invalid_types: invalid_types.join(', '), count: invalid_types.length)
           end
         end
 
         def missing_keys_validation_error(missing_keys)
-          ValidationError.new('manifest_keys.missing', :missing_keys => missing_keys.join(', '), :count => missing_keys.length)
+          ValidationError.new('manifest_keys.missing', missing_keys: missing_keys.join(', '), count: missing_keys.length)
         end
-
       end
     end
   end

data/lib/zendesk_apps_support/validations/requirements.rb

@@ -4,7 +4,6 @@ require 'json/stream'
 module ZendeskAppsSupport
   module Validations
     module Requirements
-
       MAX_REQUIREMENTS = 5000
 
       class <<self
@@ -16,7 +15,7 @@ module ZendeskAppsSupport
           requirements_stream = requirements_file.read
           duplicates = non_unique_type_keys(requirements_stream)
           unless duplicates.empty?
-            return [ValidationError.new(:duplicate_requirements, :duplicate_keys => duplicates.join(', '), :count => duplicates.length)]
+            return [ValidationError.new(:duplicate_requirements, duplicate_keys: duplicates.join(', '), count: duplicates.length)]
           end
 
           requirements = MultiJson.load(requirements_stream)
@@ -28,7 +27,7 @@ module ZendeskAppsSupport
             errors.compact!
           end
         rescue MultiJson::DecodeError => e
-          return [ValidationError.new(:requirements_not_json, :errors => e)]
+          return [ValidationError.new(:requirements_not_json, errors: e)]
         end
 
         private
@@ -38,14 +37,14 @@ module ZendeskAppsSupport
             requirements.values.each do |requirement|
               requirement.each do |identifier, fields|
                 next if fields.include? 'title'
-                errors << ValidationError.new(:missing_required_fields, :field => 'title', :identifier => identifier)
+                errors << ValidationError.new(:missing_required_fields, field: 'title', identifier: identifier)
               end
             end
 
             unless requirements['user_fields'].nil?
               requirements['user_fields'].each do |identifier, fields|
                 next if fields.include? 'key'
-                errors << ValidationError.new(:missing_required_fields, :field => 'key', :identifier => identifier)
+                errors << ValidationError.new(:missing_required_fields, field: 'key', identifier: identifier)
               end
             end
           end
@@ -54,7 +53,7 @@ module ZendeskAppsSupport
         def excessive_requirements(requirements)
           requirement_count = requirements.values.map(&:values).flatten.size
           if requirement_count > MAX_REQUIREMENTS
-            ValidationError.new(:excessive_requirements, :max => MAX_REQUIREMENTS, :count => requirement_count)
+            ValidationError.new(:excessive_requirements, max: MAX_REQUIREMENTS, count: requirement_count)
           end
         end
 
@@ -62,7 +61,7 @@ module ZendeskAppsSupport
           invalid_types = requirements.keys - ZendeskAppsSupport::AppRequirement::TYPES
 
           unless invalid_types.empty?
-            ValidationError.new(:invalid_requirements_types, :invalid_types => invalid_types.join(', '), :count => invalid_types.length)
+            ValidationError.new(:invalid_requirements_types, invalid_types: invalid_types.join(', '), count: invalid_types.length)
           end
         end
 
@@ -78,7 +77,6 @@ module ZendeskAppsSupport
 
           duplicates
         end
-
       end
     end
   end

data/lib/zendesk_apps_support/validations/source.rb

@@ -3,21 +3,20 @@ require 'jshintrb'
 module ZendeskAppsSupport
   module Validations
     module Source
-
       LINTER_OPTIONS = {
         # enforcing options:
-        :noarg => true,
-        :undef => true,
+        noarg: true,
+        undef: true,
 
         # relaxing options:
-        :eqnull => true,
-        :laxcomma => true,
-        :sub => true,
+        eqnull: true,
+        laxcomma: true,
+        sub: true,
 
         # predefined globals:
-        :predef => %w(_ console services helpers alert window document self
-                      JSON Base64 clearInterval clearTimeout setInterval setTimeout
-                      require module exports top frames parent moment)
+        predef: %w(_ console services helpers alert window document self
+                   JSON Base64 clearInterval clearTimeout setInterval setTimeout
+                   require module exports top frames parent moment)
       }.freeze
 
       class <<self
@@ -26,10 +25,10 @@ module ZendeskAppsSupport
           files = package.lib_files << app
 
           if package.requirements_only
-            return app ? [ ValidationError.new(:no_app_js_required) ] : []
+            return app ? [ValidationError.new(:no_app_js_required)] : []
           end
 
-          return [ ValidationError.new(:missing_source) ] unless app
+          return [ValidationError.new(:missing_source)] unless app
 
           jshint_errors(files).flatten!
         end
@@ -38,7 +37,7 @@ module ZendeskAppsSupport
 
         def jshint_error(file)
           errors = linter.lint(file.read)
-          [ JSHintValidationError.new(file.relative_path, errors) ] if errors.any?
+          [JSHintValidationError.new(file.relative_path, errors)] if errors.any?
         end
 
         def jshint_errors(files)
@@ -51,7 +50,6 @@ module ZendeskAppsSupport
         def linter
           Jshintrb::Lint.new(LINTER_OPTIONS)
         end
-
       end
     end
   end

data/lib/zendesk_apps_support/validations/stylesheets.rb

@@ -3,9 +3,7 @@ require 'zendesk_apps_support/stylesheet_compiler'
 module ZendeskAppsSupport
   module Validations
     module Stylesheets
-
       class << self
-
         def call(package)
           if css_error = validate_styles(package.customer_css)
             [css_error]
@@ -21,11 +19,10 @@ module ZendeskAppsSupport
           begin
             compiler.compile
           rescue Sass::SyntaxError => e
-            return ValidationError.new(:stylesheet_error, :sass_error => e.message)
+            return ValidationError.new(:stylesheet_error, sass_error: e.message)
           end
           nil
         end
-
       end
     end
   end

data/lib/zendesk_apps_support/validations/templates.rb

@@ -1,20 +1,18 @@
 module ZendeskAppsSupport
   module Validations
     module Templates
-
       class <<self
         def call(package)
           errors = []
           package.template_files.each do |template|
             contents = template.read
             if contents =~ /<\s*style\b/
-              errors << ValidationError.new(:style_in_template, :template => template.relative_path)
+              errors << ValidationError.new(:style_in_template, template: template.relative_path)
             end
           end
           errors
         end
       end
-
     end
   end
 end

data/lib/zendesk_apps_support/validations/translations.rb

@@ -23,35 +23,35 @@ module ZendeskAppsSupport
 
         def locale_error(file, locale)
           return nil if VALID_LOCALE =~ locale
-          ValidationError.new('translation.invalid_locale', :file => file.relative_path)
+          ValidationError.new('translation.invalid_locale', file: file.relative_path)
         end
 
         def json_error(file)
           json = MultiJson.load(file.read)
-          if json.kind_of?(Hash)
-            if json["app"] && json["app"]["package"]
-              json["app"].delete("package")
+          if json.is_a?(Hash)
+            if json['app'] && json['app']['package']
+              json['app'].delete('package')
               begin
                 validate_translation_format(json)
                 return
               rescue TranslationFormatError => e
-                ValidationError.new('translation.invalid_format', :field => e.message)
+                ValidationError.new('translation.invalid_format', field: e.message)
               end
             end
           else
-            ValidationError.new('translation.not_json_object', :file => file.relative_path)
+            ValidationError.new('translation.not_json_object', file: file.relative_path)
           end
         rescue MultiJson::DecodeError => e
-          ValidationError.new('translation.not_json', :file => file.relative_path, :errors => e)
+          ValidationError.new('translation.not_json', file: file.relative_path, errors: e)
         end
 
         def validate_translation_format(json)
           json.keys.each do |key|
-            raise TranslationFormatError.new("'#{key}': '#{json[key]}'") unless json[key].kind_of? Hash
+            fail TranslationFormatError.new("'#{key}': '#{json[key]}'") unless json[key].is_a? Hash
 
             if json[key].keys.sort == BuildTranslation::I18N_KEYS &&
-              json[key][BuildTranslation::I18N_TITLE_KEY].class == String &&
-              json[key][BuildTranslation::I18N_VALUE_KEY].class == String
+               json[key][BuildTranslation::I18N_TITLE_KEY].class == String &&
+               json[key][BuildTranslation::I18N_VALUE_KEY].class == String
               next
             else
               validate_translation_format(json[key])

data/lib/zendesk_apps_support/validations/validation_error.rb

@@ -2,7 +2,6 @@ require 'multi_json'
 
 module ZendeskAppsSupport
   module Validations
-
     class ValidationError
       KEY_PREFIX = 'txt.apps.admin.error.app_build.'.freeze
 
@@ -13,20 +12,19 @@ module ZendeskAppsSupport
       end
 
       class << self
-
         # Turn a JSON string into a ValidationError.
         def from_json(json)
           hash = MultiJson.decode(json)
-          raise DeserializationError.new(json) unless hash.is_a?(Hash)
+          fail DeserializationError.new(json) unless hash.is_a?(Hash)
           from_hash(hash)
         rescue MultiJson::DecodeError, NameError
           raise DeserializationError.new(json)
         end
 
         def from_hash(hash)
-          raise DeserializationError.new(hash) unless hash['class']
+          fail DeserializationError.new(hash) unless hash['class']
           klass = constantize(hash['class'])
-          raise DeserializationError.new(hash) unless klass <= self
+          fail DeserializationError.new(hash) unless klass <= self
           klass.vivify(hash)
         end
 
@@ -38,7 +36,7 @@ module ZendeskAppsSupport
         private
 
         def constantize(klass)
-          klass.to_s.split('::').inject(Object) { |klass, part| klass = klass.const_get(part) }
+          klass.to_s.split('::').inject(Object) { |klass, part| klass.const_get(part) }
         end
       end
 
@@ -52,11 +50,11 @@ module ZendeskAppsSupport
         ZendeskAppsSupport::I18n.t("#{KEY_PREFIX}#{key}", data)
       end
 
-      def to_json(*options)
+      def to_json(*)
         MultiJson.encode(as_json)
       end
 
-      def as_json(*options)
+      def as_json(*)
         {
           'class' => self.class.to_s,
           'key'   => key,
@@ -85,13 +83,13 @@ module ZendeskAppsSupport
         errors = jshint_errors.compact.map { |err| "\n  L#{err['line']}: #{err['reason']}" }.join('')
         @filename = filename, @jshint_errors = jshint_errors
         super(:jshint, {
-          :file => filename,
-          :errors => errors,
-          :count => jshint_errors.length
+          file: filename,
+          errors: errors,
+          count: jshint_errors.length
         })
       end
 
-      def as_json(*options)
+      def as_json(*)
         {
           'class' => self.class.to_s,
           'filename' => filename,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 1.17.0
+  version: 1.17.1
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-12 00:00:00.000000000 Z
+date: 2015-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -131,14 +131,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: bump
   requirement: !ruby/object:Gem::Requirement