zendesk_apps_support 1.14.1 → 1.14.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ff91ddf8a42e1a811c7977b9a2fb85ea82aa13c6
-  data.tar.gz: 1039d296431910264fba28bd36680e43303b0853
+  metadata.gz: 1a65ad117b4b76cb73350744aff8a7610232328d
+  data.tar.gz: d0c48b908ca459449a062c89ecbb2027ed04e269
 SHA512:
-  metadata.gz: d8136eda748d759dab69601755fd0ee0c3715e720b1b6e8dc5e613f77814095e262f8f73823fbf15956525a79de9fdc6a25b969c548fc71779e3787db0c14ab3
-  data.tar.gz: abf65acc9c675aa0646c4b4efe9ff59aecc6b54e2373eb3d62de0983f4be6864261a45bea8ac04f0652d58a75a9cb0e464e00ed0dd4289addaff2420613ae6a4
+  metadata.gz: 8ff204e16b723f994bfd1b12821ed71c4cd936a6333f2235c1ad70917319a45aaa9022f443ab4415fa06d2599455b1ff2453846a33aff602f680c3c9ef89090d
+  data.tar.gz: 85fccefd5f869486d28ea3c4e7de81929f448301c1fd30c483a0b1af63e1f95a1c828084c1acd26884b1682c4e68220310311796c7b6d0a8aa6c020744ece5ea

data/config/locales/en.yml

@@ -9,12 +9,12 @@ en:
             jshint:
               one: 'JSHint error in %{file}: %{errors}'
               other: 'JSHint errors in %{file}: %{errors}'
-            missing_location_and_requirements: Missing app location or requirements
-            no_location_required: Having location defined while requirements only
-              is true
-            no_framework_version_required: Having framework version defined while
-              requirements only is true
-            no_app_js_required: Having app.js present while requirements only is true
+            no_location_required: Locations can't be defined when you specify requirements
+              only
+            no_framework_version_required: Framework versions can't be set when you
+              specify requirements only
+            no_app_js_required: Do not set your app to requirements only if you need
+              app.js
             manifest_not_json: manifest is not proper JSON. %{errors}
             missing_manifest: Could not find manifest.json
             missing_requirements: Could not find requirements.json

data/config/locales/translations/zendesk_apps_support.yml

@@ -16,22 +16,18 @@ parts:
       key: "txt.apps.admin.error.app_build.jshint.other"
       title: "App builder job: JSHint error messages"
       value: "JSHint errors in %{file}: %{errors}"
-  - translation:
-      key: "txt.apps.admin.error.app_build.missing_location_and_requirements"
-      title: "App builder job: missing location and requirements error"
-      value: "Missing app location or requirements"
   - translation:
       key: "txt.apps.admin.error.app_build.no_location_required"
       title: "App builder job: ban location while requirements only"
-      value: "Having location defined while requirements only is true"
+      value: "Locations can't be defined when you specify requirements only"
   - translation:
       key: "txt.apps.admin.error.app_build.no_framework_version_required"
       title: "App builder job: ban framework version while requirements only"
-      value: "Having framework version defined while requirements only is true"
+      value: "Framework versions can't be set when you specify requirements only"
   - translation:
       key: "txt.apps.admin.error.app_build.no_app_js_required"
       title: "App builder job: ban app.js while requirements only"
-      value: "Having app.js present while requirements only is true"
+      value: "Do not set your app to requirements only if you need app.js"
   - translation:
       key: "txt.apps.admin.error.app_build.manifest_not_json"
       title: "App builder job: manifest is invalid JSON error"

data/lib/zendesk_apps_support.rb

@@ -12,7 +12,6 @@ module ZendeskAppsSupport
 
   module Validations
     autoload :ValidationError,       'zendesk_apps_support/validations/validation_error'
-    autoload :Package,               'zendesk_apps_support/validations/package'
     autoload :Manifest,              'zendesk_apps_support/validations/manifest'
     autoload :Source,                'zendesk_apps_support/validations/source'
     autoload :Templates,             'zendesk_apps_support/validations/templates'

data/lib/zendesk_apps_support/package.rb

@@ -25,10 +25,8 @@ module ZendeskAppsSupport
         errors << Validations::Manifest.call(self)
 
         if has_manifest?
-          errors << Validations::Package.call(self)
-          errors << Validations::Translations.call(self)
-
           errors << Validations::Source.call(self)
+          errors << Validations::Translations.call(self)
 
           unless @requirements_only
             errors << Validations::Templates.call(self)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 1.14.1
+  version: 1.14.2
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-21 00:00:00.000000000 Z
+date: 2014-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -163,7 +163,6 @@ files:
 - lib/zendesk_apps_support/sass_functions.rb
 - lib/zendesk_apps_support/stylesheet_compiler.rb
 - lib/zendesk_apps_support/validations/manifest.rb
-- lib/zendesk_apps_support/validations/package.rb
 - lib/zendesk_apps_support/validations/requirements.rb
 - lib/zendesk_apps_support/validations/source.rb
 - lib/zendesk_apps_support/validations/stylesheets.rb
@@ -190,7 +189,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.

data/lib/zendesk_apps_support/validations/package.rb

@@ -1,24 +0,0 @@
-module ZendeskAppsSupport
-  module Validations
-    module Package
-
-      class <<self
-        def call(package)
-          [].tap do |errors|
-            errors << has_location_or_requirements(package)
-            errors.compact!
-          end
-        end
-
-        private
-
-        def has_location_or_requirements(package)
-          if !package.has_location? && !package.has_requirements?
-            ValidationError.new('missing_location_and_requirements')
-          end
-        end
-
-      end
-    end
-  end
-end