zendesk_apps_support 1.12.0 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9d77a73de7a3e75fcae675994285e086f9c86cc
-  data.tar.gz: a4451063938bc04fa59d98831b05b6939c6eb2ab
+  metadata.gz: 98a8a5e9ae9adf2d6f9ff72b7245bcda107eaa99
+  data.tar.gz: 917035d5d9622e79422d82faf385819a1ca90650
 SHA512:
-  metadata.gz: f2dd54326aa0dab31f9c6b5325378e088a38ec8b655d1409eba64eb6864db08cdb2d867706afbe468bf36c25315f15d17273e54fd76a7e58f6db4c01b3960672
-  data.tar.gz: 7ed3221747e4b490502da442caeae6c0e82f3d806c2f2ea51b3a49360ab7ea226bc0e926a8a4c09ad2c64dcb662f8ce6c55c9b99f86c7f393eca5e148a629a33
+  metadata.gz: 4c67cbc1a9d897390b1f74985008eec6f97370a8271b883021a03a67dc5e194bd676011fbfb8dae8ee363192d094b52cd2ad5182c58051a853e6c01667443eab
+  data.tar.gz: 24d926b6e780372cd93b94bf7b08e6d116ac73518763d2eb8d44706fa1d92fe458ab38429b4d311bc4c5d7df76dad9ad27782f3216516ed8b23b9dc1f55e9e2f

data/lib/zendesk_apps_support/app_file.rb

@@ -36,7 +36,7 @@ module ZendeskAppsSupport
 
     # If Ruby 1.9
     def respond_to_missing?(sym, include_private = false)
-      @file.respond_to_missing?(sym, include_private) || super
+      @file.send(:respond_to_missing?, sym, include_private) || super
     end
 
   end

data/lib/zendesk_apps_support/package.rb

@@ -103,7 +103,7 @@ module ZendeskAppsSupport
     end
 
     def has_requirements?
-      !requirements_json.nil?
+      File.exist?(File.join(root, "requirements.json"))
     end
 
     def is_requirements_only?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.13.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-04 00:00:00.000000000 Z
+date: 2014-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -156,30 +156,6 @@ files:
 - config/locales/translations/zendesk_apps_support.yml
 - README.md
 - LICENSE
-- spec/app/app.css
-- spec/app/app.js
-- spec/app/assets/logo-small.png
-- spec/app/assets/logo.png
-- spec/app/manifest.json
-- spec/app/templates/layout.hdbs
-- spec/app/translations/en.json
-- spec/app_file_spec.rb
-- spec/app_version_spec.rb
-- spec/build_translation_spec.rb
-- spec/i18n_spec.rb
-- spec/package_spec.rb
-- spec/spec_helper.rb
-- spec/validations/fixture/invalid_en.json
-- spec/validations/fixture/requirements.json
-- spec/validations/fixture/valid_en.json
-- spec/validations/jshint_error_spec.rb
-- spec/validations/manifest_spec.rb
-- spec/validations/requirements_spec.rb
-- spec/validations/source_spec.rb
-- spec/validations/stylesheets_spec.rb
-- spec/validations/templates_spec.rb
-- spec/validations/translations_spec.rb
-- spec/validations/validation_serialization_spec.rb
 homepage: http://github.com/zendesk/zendesk_apps_support
 licenses:
 - Apache License Version 2.0
@@ -204,28 +180,4 @@ rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.
-test_files:
-- spec/app/app.css
-- spec/app/app.js
-- spec/app/assets/logo-small.png
-- spec/app/assets/logo.png
-- spec/app/manifest.json
-- spec/app/templates/layout.hdbs
-- spec/app/translations/en.json
-- spec/app_file_spec.rb
-- spec/app_version_spec.rb
-- spec/build_translation_spec.rb
-- spec/i18n_spec.rb
-- spec/package_spec.rb
-- spec/spec_helper.rb
-- spec/validations/fixture/invalid_en.json
-- spec/validations/fixture/requirements.json
-- spec/validations/fixture/valid_en.json
-- spec/validations/jshint_error_spec.rb
-- spec/validations/manifest_spec.rb
-- spec/validations/requirements_spec.rb
-- spec/validations/source_spec.rb
-- spec/validations/stylesheets_spec.rb
-- spec/validations/templates_spec.rb
-- spec/validations/translations_spec.rb
-- spec/validations/validation_serialization_spec.rb
+test_files: []

data/spec/app/app.css

@@ -1,6 +0,0 @@
-h1 {
-  color: red;
-  span {
-    color: green;
-  }
-}

data/spec/app/app.js

@@ -1,12 +0,0 @@
-(function() {
-
-  return {
-    events: {
-      'app.activated':'doSomething'
-    },
-
-    doSomething: function() {
-    }
-  };
-
-}());

data/spec/app/manifest.json

@@ -1,11 +0,0 @@
-{
-  "name": "ABC",
-  "author": {
-    "name": "John Smith",
-    "email": "john@example.com"
-  },
-  "defaultLocale": "en",
-  "private": true,
-  "location": "ticket_sidebar",
-  "frameworkVersion": "0.5"
-}

data/spec/app/templates/layout.hdbs

@@ -1,11 +0,0 @@
-<header>
-  <span class="logo"/>
-  <h3>{{setting "name"}}</h3>
-</header>
-<section data-main/>
-<footer>
-  <a href="mailto:{{author.email}}">
-    {{author.name}}
-  </a>
-</footer>
-</div>

data/spec/app/translations/en.json

@@ -1,5 +0,0 @@
-{
-  "app": {
-    "name":         "Buddha Machine"
-  }
-}

data/spec/app_file_spec.rb

@@ -1,27 +0,0 @@
-require 'zendesk_apps_support'
-
-describe ZendeskAppsSupport::AppFile do
-
-  before do
-    package = mock('Package', :root => Pathname("spec/app/templates/"))
-    @file = ZendeskAppsSupport::AppFile.new(package, 'layout.hdbs')
-  end
-
-  describe '=~' do
-    it 'should test against the relative path of the file' do
-      @file.should =~ /layout/
-    end
-  end
-
-  describe 'read' do
-    it 'should read file content' do
-      @file.read.should =~ /<header>/
-    end
-  end
-
-  describe 'to_s' do
-    it 'should return file name' do
-      @file.to_s.should == 'layout.hdbs'
-    end
-  end
-end

data/spec/app_version_spec.rb

@@ -1,61 +0,0 @@
-require 'zendesk_apps_support'
-
-describe ZendeskAppsSupport::AppVersion do
-
-  describe 'the current version' do
-    subject do
-      ZendeskAppsSupport::AppVersion.new(ZendeskAppsSupport::AppVersion::CURRENT)
-    end
-
-    it { should be_frozen }
-    it { should be_present }
-    it { should be_servable }
-    it { should be_valid_for_update }
-    it { should_not be_blank }
-    it { should_not be_deprecated }
-    it { should_not be_obsolete }
-    it { should == ZendeskAppsSupport::AppVersion.new(ZendeskAppsSupport::AppVersion::CURRENT) }
-    it { should_not == ZendeskAppsSupport::AppVersion.new('0.2') }
-
-    its(:to_s) { should == ZendeskAppsSupport::AppVersion::CURRENT }
-    its(:to_json) { should == ZendeskAppsSupport::AppVersion::CURRENT.to_json }
-  end
-
-  describe 'the deprecated version' do
-    subject do
-      ZendeskAppsSupport::AppVersion.new(ZendeskAppsSupport::AppVersion::DEPRECATED)
-    end
-
-    it { should be_frozen }
-    it { should be_present }
-    it { should be_servable }
-    it { should_not be_valid_for_update }
-    it { should_not be_blank }
-    it { should be_deprecated }
-    it { should_not be_obsolete }
-    it { should == ZendeskAppsSupport::AppVersion.new(ZendeskAppsSupport::AppVersion::DEPRECATED) }
-    it { should_not == ZendeskAppsSupport::AppVersion.new('0.2') }
-
-    its(:to_s) { should == ZendeskAppsSupport::AppVersion::DEPRECATED }
-    its(:to_json) { should == ZendeskAppsSupport::AppVersion::DEPRECATED.to_json }
-  end
-
-  describe 'a really old version' do
-    subject do
-      ZendeskAppsSupport::AppVersion.new('0.1')
-    end
-
-    it { should be_frozen }
-    it { should be_present }
-    it { should_not be_servable }
-    it { should_not be_valid_for_update }
-    it { should_not be_blank }
-    it { should_not be_deprecated }
-    it { should be_obsolete }
-    it { should == ZendeskAppsSupport::AppVersion.new('0.1') }
-    it { should_not == ZendeskAppsSupport::AppVersion.new('0.2') }
-
-    its(:to_s) { should == '0.1' }
-    its(:to_json) { should == '0.1'.to_json }
-  end
-end

data/spec/build_translation_spec.rb

@@ -1,90 +0,0 @@
-require 'zendesk_apps_support'
-include ZendeskAppsSupport::BuildTranslation
-
-describe ZendeskAppsSupport::BuildTranslation do
-
-  let(:en_json) {
-    {
-      "app" => {
-        "abc" => {
-          "title" => "description for abc field",
-          "value" => "value of abc"
-        }
-      },
-      "a"   => {
-        "a1" => {
-          "title" => "description for a1 field",
-          "value" => "value of a1"
-        },
-        "b"  => {
-          "b1" => {
-            "title" => "description for b1 field",
-            "value" => "value of b1"
-          }
-        }
-      }
-    }
-  }
-
-  describe '#to_flattened_namespaced_hash' do
-
-    context "not zendesk i18n format" do
-      it "should flatten hash without removing zendesk keys" do
-        expected = {
-          "app.abc.title" => "description for abc field",
-          "app.abc.value" => "value of abc",
-          "a.a1.title"    => "description for a1 field",
-          "a.a1.value"    => "value of a1",
-          "a.b.b1.title"  => "description for b1 field",
-          "a.b.b1.value"  => "value of b1"
-        }
-
-        to_flattened_namespaced_hash(en_json).should == expected
-      end
-    end
-
-    context 'zendesk i18n format' do
-      context 'flatten value keys' do
-        it "should flatten hash by removing zendesk title keys" do
-          expected = {
-            "app.abc" => "value of abc",
-            "a.a1"    => "value of a1",
-            "a.b.b1"  => "value of b1"
-          }
-
-          to_flattened_namespaced_hash(en_json, I18N_VALUE_KEY).should == expected
-        end
-      end
-
-      context 'flatten title keys' do
-        it "should flatten hash by removing zendesk value keys" do
-          expected = {
-            "app.abc" => "description for abc field",
-            "a.a1"    => "description for a1 field",
-            "a.b.b1"  => "description for b1 field"
-          }
-
-          to_flattened_namespaced_hash(en_json, I18N_TITLE_KEY).should == expected
-        end
-      end
-    end
-
-  end
-
-  describe '#remove_zendesk_keys' do
-    it "should remove zendesk translation keys" do
-      expected = {
-        "app" => {
-          "abc" => "value of abc"
-        },
-        "a"   => {
-          "a1" => "value of a1",
-          "b"  => {
-            "b1" => "value of b1"
-          }
-        }
-      }
-      remove_zendesk_keys(en_json).should == expected
-    end
-  end
-end

data/spec/i18n_spec.rb

@@ -1,22 +0,0 @@
-require 'zendesk_apps_support'
-require 'pathname'
-
-describe ZendeskAppsSupport::I18n do
-
-  it 'should translate error messages' do
-    key_prefix = ZendeskAppsSupport::Validations::ValidationError::KEY_PREFIX
-    ZendeskAppsSupport::I18n.t("#{key_prefix}.missing_manifest").should == 'Could not find manifest.json'
-  end
-
-end
-
-describe 'translations' do
-
-  it 'should be up-to-date' do
-    project_root = Pathname.new(File.expand_path('../../', __FILE__))
-    zendesk_version  = project_root.join('config/locales/translations/zendesk_apps_support.yml')
-    standard_version = project_root.join('config/locales/en.yml')
-    File.mtime(zendesk_version).to_i.should be <= File.mtime(standard_version).to_i
-  end
-
-end

data/spec/package_spec.rb

@@ -1,84 +0,0 @@
-require 'zendesk_apps_support'
-
-describe ZendeskAppsSupport::Package do
-
-  before do
-    @package = ZendeskAppsSupport::Package.new('spec/app')
-  end
-
-  describe 'files' do
-    it 'should return all the files within the app folder excluding files in tmp folder' do
-      @package.files.map(&:relative_path).should =~ %w(app.css app.js assets/logo-small.png assets/logo.png manifest.json templates/layout.hdbs translations/en.json)
-    end
-  end
-
-  describe 'template_files' do
-    it 'should return all the files in the templates folder within the app folder' do
-      @package.template_files.map(&:relative_path).should == %w(templates/layout.hdbs)
-    end
-  end
-
-  describe 'translation_files' do
-    it 'should return all the files in the translations folder within the app folder' do
-      @package.translation_files.map(&:relative_path).should == %w(translations/en.json)
-    end
-  end
-
-  describe 'manifest_json' do
-    it 'should return manifest json' do
-      manifest = @package.manifest_json
-      manifest[:name].should == 'ABC'
-      manifest[:author][:name].should == 'John Smith'
-      manifest[:author][:email].should == 'john@example.com'
-      manifest[:defaultLocale].should == 'en'
-      manifest[:private].should == true
-      manifest[:location].should == 'ticket_sidebar'
-      manifest[:frameworkVersion].should == '0.5'
-    end
-  end
-
-  describe 'readified_js' do
-    it 'should generate js ready for installation' do
-      js = @package.readified_js(nil, 0, 'http://localhost:4567/')
-      expected =<<HERE
-(function() {
-    with( require('apps/framework/app_scope') ) {
-
-        var source = (function() {
-
-  return {
-    events: {
-      'app.activated':'doSomething'
-    },
-
-    doSomething: function() {
-    }
-  };
-
-}());
-;
-
-        ZendeskApps["ABC"] = ZendeskApps.defineApp(source)
-                .reopenClass({ location: "ticket_sidebar" })
-                .reopen({
-                    assetUrlPrefix: "http://localhost:4567/",
-                    appClassName: "app-0",
-                    author: {
-                        name: "John Smith",
-                        email: "john@example.com"
-                    },
-                    translations: {"app":{\"name\":\"Buddha Machine\"}},
-                    templates: {"layout":"<style>\\n.app-0 header .logo {\\n  background-image: url(\\"http://localhost:4567/logo-small.png\\"); }\\n.app-0 h1 {\\n  color: red; }\\n  .app-0 h1 span {\\n    color: green; }\\n</style>\\n<header>\\n  <span class=\\"logo\\"/>\\n  <h3>{{setting \\"name\\"}}</h3>\\n</header>\\n<section data-main/>\\n<footer>\\n  <a href=\\"mailto:{{author.email}}\\">\\n    {{author.name}}\\n  </a>\\n</footer>\\n</div>"},
-                    frameworkVersion: "0.5"
-                });
-
-    }
-
-    ZendeskApps["ABC"].install({"id": 0, "app_id": 0, "settings": {\"title\":\"ABC\"}});
-
-}());
-HERE
-      js.should == expected
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,3 +0,0 @@
-def read_fixture_file(file)
-  File.read("#{File.dirname(__FILE__)}/validations/fixture/#{file}")
-end

data/spec/validations/fixture/invalid_en.json

@@ -1,20 +0,0 @@
-{
-  "app": {
-    "package" : "my_app",
-    "abc" : {
-      "title" : "description for abc field",
-      "value" : "value of abc"
-    }
-  },
-  "a": {
-    "a1": {
-      "title": "description for a1 field",
-      "value": "value of a1"
-    },
-    "b": {
-      "b1": {
-        "value": "value of b1"
-      }
-    }
-  }
-}

data/spec/validations/fixture/requirements.json

@@ -1,22 +0,0 @@
-{
-  "targets": {
-    "jira_story_target": {
-      "title": "blah",
-      "type": "jira_target",
-      "active": true,
-      "target_url": "http://example.org"
-    }
-  },
-
-  "triggers": {
-    "submit_trigger": {
-      "title": "whatever",
-      "position": "whatever",
-      "active": true,
-      "conditions": {
-        "all": [{ "field": "status", "operator": "less_than", "value": "solved" }]
-      },
-      "actions" : []
-    }
-  }
-}

data/spec/validations/fixture/valid_en.json

@@ -1,21 +0,0 @@
-{
-  "app": {
-    "package" : "my_app",
-    "abc" : {
-      "title" : "description for abc field",
-      "value" : "value of abc"
-    }
-  },
-  "a": {
-    "a1": {
-      "title": "description for a1 field",
-      "value": "value of a1"
-    },
-    "b": {
-      "b1": {
-        "title": "description for b1 field",
-        "value": "value of b1"
-      }
-    }
-  }
-}

data/spec/validations/jshint_error_spec.rb

@@ -1,17 +0,0 @@
-require 'zendesk_apps_support'
-
-describe ZendeskAppsSupport::Validations::JSHintValidationError do
-
-  let(:filename) { 'foo.js' }
-
-  context 'with nil errors' do
-
-    let(:errors) { [ nil, { 'line' => 12, 'reason' => 'eval is evil' }, nil ] }
-    let(:error) { ZendeskAppsSupport::Validations::JSHintValidationError.new(filename, errors) }
-
-    it 'ignores nil errors' do
-      error.to_s.should =~ /eval is evil/
-    end
-  end
-
-end

data/spec/validations/manifest_spec.rb

@@ -1,219 +0,0 @@
-require 'zendesk_apps_support'
-require 'json'
-
-describe ZendeskAppsSupport::Validations::Manifest do
-
-  def default_required_params(overrides = {})
-    valid_fields = ZendeskAppsSupport::Validations::Manifest::REQUIRED_MANIFEST_FIELDS.inject({}) do |fields, name|
-      fields[name] = name
-      fields
-    end
-
-    valid_fields.merge(overrides)
-  end
-
-  def create_package(parameter_hash)
-    params = default_required_params(parameter_hash)
-    manifest = mock('AppFile', :relative_path => 'manifest.json', :read => JSON.dump(params))
-    mock('Package', :files => [manifest], :has_location? => true)
-  end
-
-  it 'should have an error when manifest.json is missing' do
-    files = [mock('AppFile', :relative_path => 'abc.json')]
-    package = mock('Package', :files => files)
-    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
-
-    errors.first().to_s.should eql 'Could not find manifest.json'
-  end
-
-  it 'should have an error when required field is missing' do
-    manifest = mock('AppFile', :relative_path => 'manifest.json', :read => "{}")
-    package = mock('Package', :files => [manifest], :has_location? => true)
-    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
-
-    errors.first().to_s.should eql 'Missing required fields in manifest: author, defaultLocale, frameworkVersion'
-  end
-
-  it 'should have an error when the defaultLocale is invalid' do
-    manifest = { 'defaultLocale' => 'pt-BR-1' }
-    manifest_file = mock('AppFile', :relative_path => 'manifest.json', :read => JSON.dump(manifest))
-    package = mock('Package', :files => [manifest_file], :has_location? => true)
-    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
-
-    locale_error = errors.find { |e| e.to_s =~ /default locale/ }
-    locale_error.should_not be_nil
-  end
-
-  it 'should have an error when the translation file is missing for the defaultLocale' do
-    manifest = { 'defaultLocale' => 'pt' }
-    manifest_file = mock('AppFile', :relative_path => 'manifest.json', :read => JSON.dump(manifest))
-    translation_files = mock('AppFile', :relative_path => 'translations/en.json')
-    package = mock('Package', :files => [manifest_file], :has_location? => true, :translation_files => [translation_files])
-    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
-
-    locale_error = errors.find { |e| e.to_s =~ /Missing translation file/ }
-    locale_error.should_not be_nil
-  end
-
-  it 'should have an error when the location is invalid' do
-    manifest = { 'location' => ['ticket_sidebar', 'a_invalid_location'] }
-    manifest_file = mock('AppFile', :relative_path => 'manifest.json', :read => JSON.dump(manifest))
-    package = mock('Package', :files => [manifest_file], :has_location? => true)
-    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
-
-    locations_error = errors.find { |e| e.to_s =~ /invalid location/ }
-    locations_error.should_not be_nil
-  end
-
-  it 'should have an error when there are duplicate locations' do
-    manifest = { 'location' => ['ticket_sidebar', 'ticket_sidebar'] }
-    manifest_file = mock('AppFile', :relative_path => 'manifest.json', :read => JSON.dump(manifest))
-    package = mock('Package', :files => [manifest_file], :has_location? => true)
-    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
-
-    locations_error = errors.find { |e| e.to_s =~ /duplicate/ }
-    locations_error.should_not be_nil
-  end
-
-  it 'should have an error when the version is not supported' do
-    manifest = { 'frameworkVersion' => '0.7' }
-    manifest_file = mock('AppFile', :relative_path => 'manifest.json', :read => JSON.dump(manifest))
-    package = mock('Package', :files => [manifest_file], :has_location? => true)
-    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
-
-    version_error = errors.find { |e| e.to_s =~ /not a valid framework version/ }
-    version_error.should_not be_nil
-  end
-
-  it 'should have an error when a hidden parameter is set to required' do
-    manifest = {
-      'parameters' => [
-        'name'     => 'a parameter',
-        'type'     => 'hidden',
-        'required' => true
-      ]
-    }
-
-    manifest_file = mock('AppFile', :relative_path => 'manifest.json', :read => JSON.dump(manifest))
-    package = mock('Package', :files => [manifest_file], :has_location? => true)
-    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
-
-    hidden_params_error = errors.find { |e| e.to_s =~ /set to hidden and cannot be required/ }
-    hidden_params_error.should_not be_nil
-  end
-
-  it 'should have an error when manifest is not a valid json' do
-    manifest = mock('AppFile', :relative_path => 'manifest.json', :read => "}")
-    package = mock('Package', :files => [manifest], :has_location? => true)
-    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
-
-    errors.first().to_s.should =~ /^manifest is not proper JSON/
-  end
-
-  it "should have an error when required oauth fields are missing" do
-    oauth_hash = {
-      "oauth" => {}
-    }
-    errors = ZendeskAppsSupport::Validations::Manifest.call(create_package(default_required_params.merge(oauth_hash)))
-    oauth_error = errors.find { |e| e.to_s =~ /oauth field/ }
-    oauth_error.to_s.should == "Missing required oauth fields in manifest: client_id, client_secret, authorize_uri, access_token_uri"
-  end
-
-  context 'with invalid parameters' do
-
-    before do
-      ZendeskAppsSupport::Validations::Manifest.stub(:default_locale_error)
-      ZendeskAppsSupport::Validations::Manifest.stub(:invalid_location_error)
-      ZendeskAppsSupport::Validations::Manifest.stub(:invalid_version_error)
-    end
-
-    it 'has an error when the app parameters are not an array' do
-      parameter_hash = {
-          'parameters' => {
-              'name' => 'a parameter',
-              'type' => 'text'
-          }
-      }
-
-      errors = ZendeskAppsSupport::Validations::Manifest.call(create_package(parameter_hash))
-      errors.map(&:to_s).should == ['App parameters must be an array.']
-    end
-
-    it 'has an error when there is a parameter called "name"' do
-      parameter_hash = {
-          'parameters' => [{
-              'name' => 'name',
-              'type' => 'text'
-          }]
-      }
-
-      errors = ZendeskAppsSupport::Validations::Manifest.call(create_package(parameter_hash))
-      errors.map(&:to_s).should == ["Can't call a parameter 'name'"]
-    end
-
-    it "doesn't have an error with an array of app parameters" do
-      parameter_hash = {
-          'parameters' => [{
-              'name' => 'a parameter',
-              'type' => 'text'
-          }]
-      }
-
-      errors = ZendeskAppsSupport::Validations::Manifest.call(create_package(parameter_hash))
-      errors.should be_empty
-    end
-
-    it 'behaves when the manifest does not have parameters' do
-      errors = ZendeskAppsSupport::Validations::Manifest.call(create_package(default_required_params))
-      errors.should be_empty
-    end
-
-    it 'shows error when duplicate parameters are defined' do
-      parameter_hash = {
-        'parameters' => [
-          {
-            'name' => 'url',
-            'type' => 'text'
-          },
-          {
-            'name' => 'url',
-            'type' => 'text'
-          }
-        ]
-      }
-
-      errors = ZendeskAppsSupport::Validations::Manifest.call(create_package(parameter_hash))
-      errors.map(&:to_s).should == ['Duplicate app parameters defined: ["url"]']
-    end
-
-    it 'has an error when the parameter type is not valid' do
-      parameter_hash = {
-        'parameters' =>
-        [
-         {
-           'name' => 'should be number',
-           'type' => 'integer'
-         }
-        ]
-      }
-      errors = ZendeskAppsSupport::Validations::Manifest.call(create_package(default_required_params.merge(parameter_hash)))
-
-      expect(errors.count).to eq 1
-      expect(errors.first.to_s).to eq "integer is an invalid parameter type."
-    end
-
-    it "doesn't have an error with a correct parameter type" do
-      parameter_hash = {
-        'parameters' =>
-        [
-         {
-           'name' => 'valid type',
-           'type' => 'number'
-         }
-        ]
-      }
-      errors = ZendeskAppsSupport::Validations::Manifest.call(create_package(default_required_params.merge(parameter_hash)))
-      expect(errors).to be_empty
-    end
-  end
-end

data/spec/validations/requirements_spec.rb

@@ -1,23 +0,0 @@
-require 'zendesk_apps_support'
-require 'spec_helper'
-
-describe ZendeskAppsSupport::Validations::Requirements do
-
-  it 'creates an error when the file is not valid JSON' do
-    requirements = mock('AppFile', :relative_path => 'requirements.json', :read => "{")
-    package = mock('Package', :files => [requirements])
-    errors = ZendeskAppsSupport::Validations::Requirements.call(package)
-
-    errors.first.key.should == :requirements_not_json
-  end
-
-  it "creates no error when the file is valid JSON" do
-    requirements = mock('AppFile', :relative_path => 'requirements.json',
-                                   :read => read_fixture_file('requirements.json'))
-    package = mock('Package', :files => [requirements])
-    errors = ZendeskAppsSupport::Validations::Requirements.call(package)
-
-    expect(errors).to be_empty
-  end
-
-end

data/spec/validations/source_spec.rb

@@ -1,21 +0,0 @@
-require 'zendesk_apps_support'
-
-describe ZendeskAppsSupport::Validations::Source do
-
-  it 'should have an error when app.js is missing' do
-    files = [mock('AppFile', :relative_path => 'abc.js')]
-    package = mock('Package', :files => files)
-    errors = ZendeskAppsSupport::Validations::Source.call(package)
-
-    errors.first().to_s.should eql 'Could not find app.js'
-  end
-
-  it 'should have a jslint error when missing semicolon' do
-    source = mock('AppFile', :relative_path => 'app.js', :read => "var a = 1")
-    package = mock('Package', :files => [source])
-    errors = ZendeskAppsSupport::Validations::Source.call(package)
-
-    errors.first().to_s.should eql "JSHint error in app.js: \n  L1: Missing semicolon."
-  end
-
-end

data/spec/validations/stylesheets_spec.rb

@@ -1,34 +0,0 @@
-require 'zendesk_apps_support'
-
-describe ZendeskAppsSupport::Validations::Stylesheets do
-  it 'does not return errors if there is no custom css' do
-
-    package = stub(:customer_css => "")
-    ZendeskAppsSupport::Validations::Stylesheets.call(package).should be_empty
-  end
-
-  it 'does not return errors for valid css' do
-    valid_css = <<-CSS
-.my-class {
-  border: solid 1px black;
-}
-    CSS
-    package = stub(:customer_css => valid_css)
-
-    errors = ZendeskAppsSupport::Validations::Stylesheets.call(package)
-    errors.should be_empty
-  end
-
-  it 'returns style sheet validation error for invalid css' do
-    invalid_css = <<-CSS
-.my-class {
-  border: }
-}
-    CSS
-    package = stub(:customer_css => invalid_css)
-
-    errors = ZendeskAppsSupport::Validations::Stylesheets.call(package)
-    errors.count.should == 1
-    errors.first.to_s.should match /Sass error: Invalid CSS after.*/
-  end
-end

data/spec/validations/templates_spec.rb

@@ -1,13 +0,0 @@
-require 'zendesk_apps_support'
-
-describe ZendeskAppsSupport::Validations::Templates do
-
-  it 'should have a jslint error when missing semicolon' do
-    template = mock('AppFile', :relative_path => 'layout.hdbs', :read => "<style>")
-    package = mock('Package', :template_files => [template])
-    errors = ZendeskAppsSupport::Validations::Templates.call(package)
-
-    errors.first().to_s.should eql "<style> tag in layout.hdbs. Use an app.css file instead."
-  end
-
-end

data/spec/validations/translations_spec.rb

@@ -1,83 +0,0 @@
-require 'zendesk_apps_support'
-require 'spec_helper'
-require 'json'
-
-
-describe ZendeskAppsSupport::Validations::Translations do
-
-  let(:package) { mock('Package', :files => translation_files) }
-  subject { ZendeskAppsSupport::Validations::Translations.call(package) }
-
-  context 'when there are no translation files' do
-    let(:translation_files) { [] }
-    it 'should be valid' do
-      subject.should be_empty
-    end
-  end
-
-  context 'when there is file with invalid JSON' do
-    let(:translation_files) do
-      [mock('AppFile', :relative_path => 'translations/en.json', :read => '}')]
-    end
-
-    it 'should report the error' do
-      subject.length.should == 1
-      subject[0].to_s.should =~ /JSON/
-    end
-  end
-
-  context 'when there is file with JSON representing a non-Object' do
-    let(:translation_files) do
-      [mock('AppFile', :relative_path => 'translations/en.json', :read => '"foo bar"')]
-    end
-
-    it 'should report the error' do
-      subject.length.should == 1
-      subject[0].to_s.should =~ /JSON/
-    end
-  end
-
-  context 'when there is a file with an invalid locale for a name' do
-    let(:translation_files) do
-      [mock('AppFile', :relative_path => 'translations/en-US-1.json', :read => '{}')]
-    end
-
-    it 'should report the error' do
-      subject.length.should == 1
-      subject[0].to_s.should =~ /locale/
-    end
-  end
-
-  context 'when there is a file with a valid locale containing valid JSON' do
-    let(:translation_files) do
-      [mock('AppFile', :relative_path => 'translations/en-US.json', :read => '{}')]
-    end
-
-    it 'should be valid' do
-      subject.length.should == 0
-    end
-  end
-
-  context 'validate translation format when "package" is defined inside "app"' do
-    context 'all the leaf nodes have defined "title" and "value"' do
-      let(:translation_files) do
-        [mock('AppFile', :relative_path => 'translations/en-US.json', :read => read_fixture_file("valid_en.json"))]
-      end
-
-      it 'should be valid' do
-        subject.length.should == 0
-      end
-    end
-
-    context 'when the "title" field is not defined on one leaf node' do
-      let(:translation_files) do
-        [mock('AppFile', :relative_path => 'translations/en-US.json', :read => read_fixture_file("invalid_en.json"))]
-      end
-
-      it 'should be invalid' do
-        subject.length.should == 1
-        subject[0].to_s.should =~ /is invalid for translation/
-      end
-    end
-  end
-end

data/spec/validations/validation_serialization_spec.rb

@@ -1,96 +0,0 @@
-require 'zendesk_apps_support'
-require 'json'
-
-describe ZendeskAppsSupport::Validations::ValidationError do
-
-  ValidationError = ZendeskAppsSupport::Validations::ValidationError
-
-  it 'symbolizes the keys in its data' do
-    error = ValidationError.new(:foo, 'bar' => 'baz')
-    error.data[:bar].should == 'baz'
-  end
-
-  describe '#to_json' do
-    let(:key)   { 'foo.bar' }
-    let(:data)  { { 'baz' => 'quux' } }
-    let(:error) { ValidationError.new(key, data) }
-    subject     { error.to_json }
-
-    it do
-      should == {
-                  'class' => error.class.to_s,
-                  'key'   => error.key,
-                  'data'  => error.data
-                }.to_json
-    end
-  end
-
-  describe '.from_hash' do
-
-    subject { ValidationError.from_hash(hash) }
-
-    context 'for a generic error' do
-      let(:hash) do
-        {
-          'class' => 'ZendeskAppsSupport::Validations::ValidationError',
-          'key'   => 'foo.bar.baz',
-          'data'  => { 'quux' => 'yargle' }
-        }
-      end
-
-      it { should be_a(ValidationError) }
-
-      its(:key) { should == 'foo.bar.baz' }
-
-      its(:data) { should == { :quux => 'yargle' } }
-      its(:data) { should}
-    end
-
-    context 'for a JSHint error' do
-      let(:hash) do
-        {
-          'class'         => 'ZendeskAppsSupport::Validations::JSHintValidationError',
-          'file'          => 'foo.js',
-          'jshint_errors' => [ { 'line' => 55, 'reason' => 'Yuck' } ]
-        }
-      end
-
-      it { should be_a(ZendeskAppsSupport::Validations::JSHintValidationError) }
-
-      its(:key) { should == :jshint }
-
-      its(:jshint_errors) do
-        should == [ { 'line' => 55, 'reason' => 'Yuck' } ]
-      end
-    end
-
-    context 'for a non-ValidationError hash' do
-      let(:hash) do
-        {
-          :foo => 'bar'
-        }
-      end
-
-      it 'raises a DeserializationError' do
-        lambda { subject }.should raise_error(ValidationError::DeserializationError)
-      end
-    end
-
-  end
-
-  describe '.from_json' do
-
-    it 'decodes a JSON hash and passes it to .from_hash' do
-      ValidationError.should_receive(:from_hash).with('foo' => 'bar')
-      ValidationError.from_json(MultiJson.encode({ 'foo' => 'bar' }))
-    end
-
-    it 'raises a DeserializationError when passed non-JSON' do
-      lambda {
-        ValidationError.from_json('}}}')
-      }.should raise_error(ValidationError::DeserializationError)
-    end
-
-  end
-
-end