zendesk_api 1.7.4 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8948d931b11f08405b40659d98a49f4a32e4f87b
-  data.tar.gz: e48fe6a1a5811348b80e6ada0d4087d3d95321ab
+  metadata.gz: 7a8136e8dbb6d7205f9e621716c932ab3cc126fd
+  data.tar.gz: e3172fe0c372455575eacbff2fb1cb561fdfaa6e
 SHA512:
-  metadata.gz: 3a967c0cfd4da0b6403f7e0c60a9b5f51a0e261a8ee3d4dafbee8c24bbcdd61edd707e9da20ee8e94c3d2b8eb3a324c740574b3745417acfd52e82411b5f2680
-  data.tar.gz: 36cf68c6eeab88cdea48502a614db287c6b81645857ad1bf8c57734226ce124d771138fb2a0b190fdc413c4f086fbadda711e5fcc167791ac316a8768b279db8
+  metadata.gz: 3ffb325cdc67e9f8023cf13d106508372ca51a970dc29b32a986e47f947cf048944dca5ee6efcc5f8261da53d574b85a03f2d248e93c887e18ffbe7e89d40333
+  data.tar.gz: e3b4ba19b901378f884a1af3352fd28d4103af5f46d75c859ec687a3e22b9ecc5fea92996dddd46a8b7b9d975735a01c40f08d3d9f04576dfeadb3304045f2c1

data/README.md

@@ -19,6 +19,7 @@ Please check out the [wiki](https://github.com/zendesk/zendesk_api_client_rb/wik
 * Version >= 1.0 and < 1.4.2 had a bug where non application/json response bodies were discarded
 * Version 1.5.0 removed support for Ruby 1.8
 * Version 1.6.0 ZendeskAPI::Voice::CertificationAddress is now ZendeskAPI::Voice::Address
+* Version 1.8.0 no longer considers 1XX and 3XX (except 304) response status codes valid and will raise a NetworkError
 
 ## Installation
 

data/lib/zendesk_api/middleware/response/raise_error.rb

@@ -17,7 +17,7 @@ module ZendeskAPI
             raise Error::RecordNotFound.new(env)
           when 422, 413
             raise Error::RecordInvalid.new(env)
-          when 400...600
+          when 100..199, 400..599, 300..303, 305..399
             raise Error::NetworkError.new(env)
           end
         end

data/lib/zendesk_api/version.rb

@@ -1,3 +1,3 @@
 module ZendeskAPI
-  VERSION = "1.7.4"
+  VERSION = "1.8.0"
 end

data/spec/core/middleware/response/raise_error_spec.rb

@@ -47,6 +47,30 @@ describe ZendeskAPI::Middleware::Response::RaiseError do
       end
     end
 
+    context "with status in 1XX" do
+      let(:status) { 100 }
+
+      it "should raise NetworkError" do
+        expect { client.connection.get "/non_existent" }.to raise_error(ZendeskAPI::Error::NetworkError)
+      end
+    end
+
+    context "with status = 304" do
+      let(:status) { 304 }
+
+      it "should not raise" do
+        client.connection.get "/abcdef"
+      end
+    end
+
+    context "with status in 3XX" do
+      let(:status) { 302 }
+
+      it "should raise NetworkError" do
+        expect { client.connection.get "/non_existent" }.to raise_error(ZendeskAPI::Error::NetworkError)
+      end
+    end
+
     context "with status = 422" do
       let(:status) { 422 }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_api
 version: !ruby/object:Gem::Version
-  version: 1.7.4
+  version: 1.8.0
 platform: ruby
 authors:
 - Steven Davidovitz
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-07 00:00:00.000000000 Z
+date: 2015-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bump
@@ -351,7 +351,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.7
 signing_key: 
 specification_version: 4
 summary: Zendesk REST API Client