zendesk_api 1.3.8 → 1.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9b5cc8be9234d6da4cd1b90cbdf4462bf7d1fa7
-  data.tar.gz: ae424a078cd9a89561d9acc2be8e31b979611139
+  metadata.gz: 29e998ef5ac29f169434e9f790efadefacb2643f
+  data.tar.gz: 4c04948d4dbe97717235756b3d966f90de072b5a
 SHA512:
-  metadata.gz: 9fc5f11d463221cb917757de68241566ea3ea972ccacb68a10d8e2ecd4f7a17101493af05de639f18cc04263fe02d292083bff7acbdfb60f21fb2c9712730083
-  data.tar.gz: 40bbdf4e474b4662f395deaf59c04ccd854c74d609da8af4187be052c30d79ebc54c3a0671efb15d22a02eb1e0a6d656b866c71d1e8072fecff6d8fc2ea18881
+  metadata.gz: 1ff31fb5fc88df8a3eba6d624fc838a6e2a339184dbd66749cefe7a097a6e01877524a95215f75bb8d7cb5625c43719aaf247a2df61df23dc2bc99368b364824
+  data.tar.gz: 9a02b1a2563b332facca8b17a3a2469e3765a406c46ae1f5a39110b8a3cb206cd39417f5764903f48dd23626f4e0dcf81c64e06e25e2ee9cc5a8b10cb63363aa

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    zendesk_api (1.3.8)
+    zendesk_api (1.3.9)
       faraday (~> 0.9)
       hashie (>= 1.2)
       inflection

data/README.md

@@ -15,6 +15,7 @@ Please check out the [wiki](https://github.com/zendesk/zendesk_api_client_rb/wik
 * Version 0.3.2 introduced a regression when side-loading roles on users. This was fixed in 0.3.4.
 * Version 1.0.0 changes the way errors are handled. Please see the [wiki page](https://github.com/zendesk/zendesk_api_client_rb/wiki/Errors) for more info.
 * Version 1.3.0 updates the Faraday dependency to 0.9. Since Faraday did not bump a major version we have not either, but there is no guarantee >= 1.3.0 works with Faraday < 0.9
+* Version 1.3.8 had a bug where attachments were created, but the response was not handled properly
 
 ## Installation
 

data/lib/zendesk_api/actions.rb

@@ -1,5 +1,15 @@
 module ZendeskAPI
+  module ResponseHandler
+    def handle_response(response)
+      if response.body && response.body[self.class.singular_resource_name]
+        @attributes.replace(@attributes.deep_merge(response.body[self.class.singular_resource_name]))
+      end
+    end
+  end
+
   module Save
+    include ResponseHandler
+
     # If this resource hasn't been deleted, then create or save it.
     # Executes a POST if it is a {Data#new_record?}, otherwise a PUT.
     # Merges returned attributes on success.
@@ -75,6 +85,7 @@ module ZendeskAPI
   module Read
     def self.extended(klass)
       klass.send(:include, ZendeskAPI::Sideloading)
+      klass.send(:include, ResponseHandler)
     end
 
     # Finds a resource by an id and any options passed in.

data/lib/zendesk_api/resource.rb

@@ -143,12 +143,6 @@ module ZendeskAPI
   class DataResource < Data
     attr_accessor :error, :error_message
     extend Verbs
-
-    def handle_response(response)
-      if response.body && response.body[self.class.singular_resource_name]
-        @attributes.replace(@attributes.deep_merge(response.body[self.class.singular_resource_name]))
-      end
-    end
   end
 
   # Represents a resource that can only GET

data/lib/zendesk_api/version.rb

@@ -1,3 +1,3 @@
 module ZendeskAPI
-  VERSION = "1.3.8"
+  VERSION = "1.3.9"
 end

data/spec/core/spec_helper.rb

@@ -78,6 +78,15 @@ def client
 
     client.config.logger.level = (ENV["LOG"] ? Logger::DEBUG : Logger::WARN)
     client.config.cache.size = 0
+    client.callbacks.clear
+
+    client.insert_callback do |env|
+      warning = env[:response_headers]["X-Zendesk-API-Warn"]
+
+      if warning && warning !~ /\["access_token"\]/ && client.config.logger
+        client.config.logger.warn "WARNING: #{warning}"
+      end
+    end
 
     client
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_api
 version: !ruby/object:Gem::Version
-  version: 1.3.8
+  version: 1.3.9
 platform: ruby
 authors:
 - Steven Davidovitz
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-17 00:00:00.000000000 Z
+date: 2014-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bump