zendesk_api 1.3.0.rc3 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e0af96893eadf039d7ee2f55140c99a2ebb6493b
-  data.tar.gz: 3cece9eb1e9d0e1d6028741316148efd0d81aff5
+  metadata.gz: 9b310b67f1f0ce7aab3145806d7048e85b2a3803
+  data.tar.gz: bcc2ab5a29bc5779f2cd946753db97079ed11aa4
 SHA512:
-  metadata.gz: d9a690f20225ad74dc19f0991786edef89b6fcfe721f81850897cca6d9b3b931f1d4c362c2baf26f81a9a21983db4f8479b239c7571999bc26e52cb0f2fc9b07
-  data.tar.gz: ca2b7c76939a390ae9d7ae464e8a5780e69a13afe42e219080444dc9f2f812d9db1b770832da1bc99869e01db02997c9029b6895448b29dcc5cfad1cd0b01831
+  metadata.gz: 173b1e1da892d91d642d415c51cc91adf838f947550fdbec70a8cf3caeef0ff2b800aef04b51bb9e1a201f6a67042911df8d7b5d226d1f8ded5c9cfd61f39a8e
+  data.tar.gz: a5f27802163083b8b3932e6573dafd3ac7319bece572e582d05ad521e73c17e58ceb341daf180343b6003f2b2ffc8ea0e4373988e3ce35ad5644f37b6eaf80f2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    zendesk_api (1.3.0.rc3)
+    zendesk_api (1.3.0)
       faraday (~> 0.9)
       hashie (>= 1.2)
       inflection

data/lib/zendesk_api/version.rb

@@ -1,3 +1,3 @@
 module ZendeskAPI
-  VERSION = "1.3.0.rc3"
+  VERSION = "1.3.0"
 end

data/spec/core/middleware/request/encode_json_spec.rb

@@ -0,0 +1,73 @@
+require 'core/spec_helper'
+
+describe ZendeskAPI::Middleware::Request::EncodeJson do
+  let(:app) do
+    ZendeskAPI::Middleware::Request::EncodeJson.new(lambda {|x| x})
+  end
+
+  let(:response) { app.call({ :request_headers => {} }.merge(env)) }
+
+  context 'with a nil body' do
+    let(:env) {{ :body => nil }}
+
+    it 'should not return json' do
+      response[:body].should be_nil
+    end
+  end
+
+  context 'with an empty body' do
+    let(:env) {{ :body => '' }}
+
+    it 'should not return json' do
+      response[:body].should == ''
+    end
+  end
+
+  context 'with a proper mime type' do
+    context 'empty' do
+      let(:env) {{ :body => { :a => :b } }}
+
+      it 'encodes json' do
+        response[:body].should == JSON.dump(:a => :b)
+      end
+
+      it 'sets the content type' do
+        response[:request_headers]['Content-Type'].should == 'application/json'
+      end
+    end
+
+    context 'application/json' do
+      let(:env) {{
+        :body => { :a => :b },
+        :request_headers => {
+          'Content-Type' => 'application/json'
+        }
+      }}
+
+      it 'encodes json' do
+        response[:body].should == JSON.dump(:a => :b)
+      end
+
+      it 'keeps the content type' do
+        response[:request_headers]['Content-Type'].should == 'application/json'
+      end
+    end
+
+    context 'application/json; encoding=utf-8' do
+      let(:env) {{
+        :body => { :a => :b },
+        :request_headers => {
+          'Content-Type' => 'application/json; encoding=utf-8'
+        }
+      }}
+
+      it 'encodes json' do
+        response[:body].should == JSON.dump(:a => :b)
+      end
+
+      it 'keeps the content type' do
+        response[:request_headers]['Content-Type'].should == 'application/json; encoding=utf-8'
+      end
+    end
+  end
+end

data/spec/core/middleware/response/parse_json_spec.rb

@@ -0,0 +1,53 @@
+require 'core/spec_helper'
+
+describe ZendeskAPI::Middleware::Response::ParseJson do
+  context "with another content-type" do
+    before(:each) do
+      stub_request(:get, %r{blergh}).to_return(
+        :headers => {
+          :content_type => "application/xml"
+        },
+        :body => '<nope></nope>'
+      )
+    end
+
+    it "should return nil body" do
+      client.connection.get("blergh").body.should be_nil
+    end
+  end
+
+  context "with content-type = 'application/json'" do
+    before(:each) do
+      stub_request(:get, %r{blergh}).to_return(
+        :headers => {
+          :content_type => "application/json"
+        },
+        :body => body
+      )
+    end
+
+    context "with a nil body" do
+      let(:body) { nil }
+
+      it "should return nil body" do
+        client.connection.get("blergh").body.should be_nil
+      end
+    end
+
+    context "with a empty body" do
+      let(:body) { '' }
+
+      it "should return nil body" do
+        client.connection.get("blergh").body.should be_nil
+      end
+    end
+
+    context 'proper json' do
+      let(:body) { '{ "TESTDATA": true }' }
+
+      it "should parse returned body" do
+        client.connection.get("blergh").body['TESTDATA'].should be_true
+      end
+    end
+  end
+end

data/zendesk_api.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
   s.description = %q{Ruby wrapper for the REST API at http://www.zendesk.com. Documentation at http://developer.zendesk.com.}
   s.license     = 'Apache License Version 2.0'
 
-  s.required_ruby_version     = ">= 1.8.7"
+  s.required_ruby_version     = ">= 1.9.0"
   s.required_rubygems_version = ">= 1.3.6"
 
   s.add_development_dependency "bump"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_api
 version: !ruby/object:Gem::Version
-  version: 1.3.0.rc3
+  version: 1.3.0
 platform: ruby
 authors:
 - Steven Davidovitz
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-14 00:00:00.000000000 Z
+date: 2014-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bump
@@ -411,6 +411,7 @@ files:
 - spec/core/data_resource_spec.rb
 - spec/core/inflection_spec.rb
 - spec/core/lru_cache_spec.rb
+- spec/core/middleware/request/encode_json_spec.rb
 - spec/core/middleware/request/etag_cache_spec.rb
 - spec/core/middleware/request/retry_spec.rb
 - spec/core/middleware/request/test.jpg
@@ -419,6 +420,7 @@ files:
 - spec/core/middleware/response/deflate_spec.rb
 - spec/core/middleware/response/gzip_spec.rb
 - spec/core/middleware/response/parse_iso_dates_spec.rb
+- spec/core/middleware/response/parse_json_spec.rb
 - spec/core/middleware/response/raise_error_spec.rb
 - spec/core/read_resource_spec.rb
 - spec/core/resource_spec.rb
@@ -501,7 +503,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.8.7
+      version: 1.9.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -522,6 +524,7 @@ test_files:
 - spec/core/data_resource_spec.rb
 - spec/core/inflection_spec.rb
 - spec/core/lru_cache_spec.rb
+- spec/core/middleware/request/encode_json_spec.rb
 - spec/core/middleware/request/etag_cache_spec.rb
 - spec/core/middleware/request/retry_spec.rb
 - spec/core/middleware/request/test.jpg
@@ -530,6 +533,7 @@ test_files:
 - spec/core/middleware/response/deflate_spec.rb
 - spec/core/middleware/response/gzip_spec.rb
 - spec/core/middleware/response/parse_iso_dates_spec.rb
+- spec/core/middleware/response/parse_json_spec.rb
 - spec/core/middleware/response/raise_error_spec.rb
 - spec/core/read_resource_spec.rb
 - spec/core/resource_spec.rb