zendesk_api 1.9.6 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eacb42e0c2633d103613e2599756158b0681d0ff
-  data.tar.gz: 9d963ed17977f4e49d2c1d901c132fb5f2f03773
+  metadata.gz: da5e205a53c59a1cdccc0a3f67bf6208e5d37133
+  data.tar.gz: e64ed5636f4614e4e479c5171d5098ab324d6658
 SHA512:
-  metadata.gz: 0cb6a37290dafb6ed727220b189e9f3a72f4a8d15cdd7e9f8bf58bd4579cc48e66ff25e762b5dc3972fc7d6d16d84b959db3b1a4f8f1d0e69f0eaaed5aee7cad
-  data.tar.gz: 0620eda1af21db8c402478e39d03387d750ecbd36a168d057520a50ad307376ab90354b44e61eb4d72a3b18693285e8bd9f3a6dd4de0b8b45a81de31f75e4292
+  metadata.gz: f645fd48ebb0412eb4e60393333913c49a5872ab05d79d4d4305423cd08cd4d9234996d4fd73b7a6b968cb3767b78bbf61d35a503f7ed7d6ec72dfd90f72a54f
+  data.tar.gz: 5d46573d73d32acadbf7be41f10db1b29bda215661b61a0c90ec1c370c223c05d9cc9c036efab76b8911ed31f712aad81b1cce58c1073279e35a3fa391f203b9

data/lib/zendesk_api/configuration.rb

@@ -53,7 +53,7 @@ module ZendeskAPI
         :headers => {
           :accept => 'application/json',
           :accept_encoding => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
-          :user_agent => "ZendeskAPI API #{ZendeskAPI::VERSION}"
+          :user_agent => "ZendeskAPI Ruby #{ZendeskAPI::VERSION}"
         },
         :request => {
           :open_timeout => 10

data/lib/zendesk_api/resources.rb

@@ -182,8 +182,7 @@ module ZendeskAPI
 
   class Topic < Resource
     class TopicComment < TopicComment
-      extend Read
-
+      include Read
       include Create
       include Update
       include Destroy
@@ -326,8 +325,12 @@ module ZendeskAPI
       has :author, :class => User
 
       def save
-        save_associations
-        true
+        if new_record?
+          save_associations
+          true
+        else
+          false
+        end
       end
 
       alias :save! :save
@@ -352,7 +355,7 @@ module ZendeskAPI
   class TicketField < Resource; end
 
   class TicketMetric < DataResource
-    extend Read
+    include Read
   end
 
   class TicketRelated < DataResource; end
@@ -394,8 +397,12 @@ module ZendeskAPI
       has :author, :class => User
 
       def save
-        save_associations
-        true
+        if new_record?
+          save_associations
+          true
+        else
+          false
+        end
       end
 
       alias :save! :save
@@ -627,7 +634,7 @@ module ZendeskAPI
 
   class User < Resource
     class TopicComment < TopicComment
-      extend Read
+      include Read
     end
 
     class Identity < Resource

data/lib/zendesk_api/version.rb

@@ -1,3 +1,3 @@
 module ZendeskAPI
-  VERSION = "1.9.6"
+  VERSION = "1.10.0"
 end

data/spec/core/configuration_spec.rb

@@ -14,7 +14,7 @@ describe ZendeskAPI::Configuration do
   end
 
   it "should set user agent header properly" do
-    expect(subject.options[:headers][:user_agent]).to match(/ZendeskAPI API/)
+    expect(subject.options[:headers][:user_agent]).to match(/ZendeskAPI Ruby/)
   end
 
   it "should set a default open_timeout" do

data/spec/core/create_resource_spec.rb

@@ -32,7 +32,7 @@ describe ZendeskAPI::CreateResource do
     end
 
     it "should raise if save fails" do
-      expect { subject.create!(client, :test_field => "blah") }.to raise_error
+      expect { subject.create!(client, :test_field => "blah") }.to raise_error(ZendeskAPI::Error::NetworkError)
     end
   end
 end

data/spec/core/middleware/response/callback_spec.rb

@@ -8,7 +8,7 @@ describe ZendeskAPI::Middleware::Response::Callback do
       env[:body] = response
     end
 
-    stub_request(:get, %r{test_endpoint}).to_return(:body => MultiJson.dump({ "ABC" => "DEF" }))
+    stub_request(:get, %r{test_endpoint}).to_return(:body => JSON.dump({ "ABC" => "DEF" }))
   end
 
   it "should call callbacks " do

data/spec/core/middleware/response/raise_error_spec.rb

@@ -79,7 +79,7 @@ describe ZendeskAPI::Middleware::Response::RaiseError do
       end
 
       context "with a body" do
-        let(:body) { MultiJson.dump(:details => "hello") }
+        let(:body) { JSON.dump(:details => "hello") }
 
         it "should return RecordInvalid with proper message" do
           begin
@@ -102,7 +102,7 @@ describe ZendeskAPI::Middleware::Response::RaiseError do
       end
 
       context "with a body" do
-        let(:body) { MultiJson.dump(:details => "big file is big") }
+        let(:body) { JSON.dump(:details => "big file is big") }
 
         it "should return RecordInvalid with proper message" do
           begin

data/spec/core/resource_spec.rb

@@ -103,7 +103,7 @@ describe ZendeskAPI::Resource do
     end
 
     it "should raise if save fails" do
-      expect { subject.save! }.to raise_error
+      expect { subject.save! }.to raise_error(ZendeskAPI::Error::RecordInvalid)
     end
   end
 

data/spec/core/spec_helper.rb

@@ -13,7 +13,6 @@ require 'zendesk_api'
 require 'vcr'
 require 'logger'
 require 'stringio'
-require 'multi_json'
 
 begin
   require 'byebug'
@@ -114,7 +113,7 @@ module TestHelper
   end
 
   def json(body = {})
-    MultiJson.dump(body)
+    JSON.dump(body)
   end
 
   def stub_json_request(verb, path_matcher, body = json, options = {})

data/spec/live/app_installation_spec.rb

@@ -29,10 +29,10 @@ describe ZendeskAPI::AppInstallation do
 
     app.id = body["app_id"]
 
-    attributes = { :app_id => app.id, :settings => {
-        :name => "My App",
-        "Custom_Field_ID" => "123",
-        "Custom_Field_Default" => "Default"
+    attributes = {
+      :app_id => app.id,
+      :settings => {
+        :name => "My App"
       }
     }
 

data/spec/live/ticket_spec.rb

@@ -25,9 +25,7 @@ describe ZendeskAPI::Ticket do
   context "recent tickets" do
     before(:all) do
       VCR.use_cassette("visit_recent_ticket") do
-        client.connection.get("/tickets/1") do |req|
-          req.headers[:Accept] = "*/*"
-        end
+        client.tickets.find(id: 1)
 
         sleep(5)
       end

data/zendesk_api.gemspec

@@ -28,7 +28,6 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "faraday", "~> 0.9"
   s.add_runtime_dependency "hashie", ">= 1.2", "< 4.0", "!= 3.3.0"
   s.add_runtime_dependency "inflection"
-  s.add_runtime_dependency "multi_json"
   s.add_runtime_dependency "multipart-post", "~> 2.0"
   s.add_runtime_dependency "mime-types"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_api
 version: !ruby/object:Gem::Version
-  version: 1.9.6
+  version: 1.10.0
 platform: ruby
 authors:
 - Steven Davidovitz
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-16 00:00:00.000000000 Z
+date: 2015-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bump
@@ -149,20 +149,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: multi_json
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: multipart-post
   requirement: !ruby/object:Gem::Requirement