zendesk2 1.3.1 → 1.3.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: b95ffa24bf712a96c513713ff2391292f4ec0ce2
4
- data.tar.gz: 32e7be8ce3b6ad0cc881294ef508d0689a482126
3
+ metadata.gz: ed5cd2b9f54357316f66656d811ef3e6718eba22
4
+ data.tar.gz: ea10043b0c18a118eb7a93de954c56059076e0a2
5
5
  SHA512:
6
- metadata.gz: abdb21b9a7e04733d3144d0e828eed85740a463270a15c6dc8db0c9b91940f0b245ab4f4f3d4857968ee92da819202cbae494cb90a60acbf0b67cb3eaa563597
7
- data.tar.gz: 1ac672a42025afcb24e7dcbf0c0ac9a88a8ecc2154bc81f624630dbc7cc5ea115195c03bc445429a6613b837e8f4fb7fc7d2c5f2b332d0adbcf0b5d8f785caab
6
+ metadata.gz: fbfa268c8848d68edc143372334c332f96b5cd4daee18cec251404f563abb52564a4974fa0edeabab99e5e347573cb9d1c9468a213d44e1dee395268740494de
7
+ data.tar.gz: 7633461afdc6c38b878aa9893baf69bbad65e23ad21f37721c3b87126cf7df91839e73c222402a61fb89a75619cb26ac92c1ec0badc2217d91942b415c120be1
@@ -90,7 +90,7 @@ class Zendesk2::Client < Cistern::Service
90
90
  page_index = (page_params["page"] || 1).to_i
91
91
  offset = (page_index - 1) * page_size
92
92
  filter = options[:filter]
93
- resources = self.data[collection].values
93
+ resources = options[:resources] || self.data[collection].values
94
94
  resources = filter.call(resources) if filter
95
95
  count = resources.size
96
96
  total_pages = (count / page_size) + 1
@@ -1,7 +1,8 @@
1
1
  class Zendesk2::Client
2
2
  class Real
3
3
  def get_ticket_comments(params={})
4
- ticket_id = params["ticket_id"]
4
+ ticket_id = require_parameters(params, "ticket_id")
5
+
5
6
  request(
6
7
  :method => :get,
7
8
  :path => "/tickets/#{ticket_id}/comments.json"
@@ -11,12 +12,12 @@ class Zendesk2::Client
11
12
 
12
13
  class Mock
13
14
  def get_ticket_comments(params={})
14
- ticket_id = params["ticket_id"]
15
+ ticket_id = require_parameters(params, "ticket_id")
15
16
 
16
17
  page(params,
17
18
  :ticket_comments,
18
19
  "/tickets/#{ticket_id}/comments.json",
19
- "comments")
20
+ "comments", filter: lambda { |comments| comments.select { |comment| comment["ticket_id"].to_s == ticket_id.to_s } })
20
21
  end
21
22
  end # Mock
22
23
  end
@@ -29,6 +29,7 @@ class Zendesk2::Client
29
29
  "public" => comment["public"].nil? ? true : comment["public"],
30
30
  "trusted" => comment["trusted"].nil? ? true : comment["trusted"],
31
31
  "attachments" => comment["attachments"] || [],
32
+ "ticket_id" => ticket_id,
32
33
  }
33
34
 
34
35
  audit_id = self.class.new_id
@@ -1,3 +1,3 @@
1
1
  module Zendesk2
2
- VERSION = "1.3.1"
2
+ VERSION = "1.3.2"
3
3
  end
data/spec/tickets_spec.rb CHANGED
@@ -93,6 +93,18 @@ describe "Zendesk2::Client" do
93
93
  end
94
94
  end
95
95
 
96
+ describe "ticket#comments" do
97
+ let!(:ticket) { client.tickets.create!(subject: mock_uuid, description: mock_uuid) }
98
+ let!(:another_ticket) { client.tickets.create!(subject: mock_uuid, description: mock_uuid) }
99
+
100
+ it "should scope the comments to the source ticket" do
101
+ target_comments = 2.times.map { ticket.comment(mock_uuid) }
102
+ 2.times.map { another_ticket.comment(mock_uuid) }
103
+
104
+ expect(ticket.comments.all).to match_array(target_comments)
105
+ end
106
+ end
107
+
96
108
  describe "ticket comments" do
97
109
  let(:ticket) { client.tickets.create!(subject: mock_uuid, description: mock_uuid) }
98
110
 
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: zendesk2
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.3.1
4
+ version: 1.3.2
5
5
  platform: ruby
6
6
  authors:
7
7
  - Josh Lane
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2014-11-05 00:00:00.000000000 Z
11
+ date: 2014-11-06 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: addressable