zendesk2 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b95ffa24bf712a96c513713ff2391292f4ec0ce2
-  data.tar.gz: 32e7be8ce3b6ad0cc881294ef508d0689a482126
+  metadata.gz: ed5cd2b9f54357316f66656d811ef3e6718eba22
+  data.tar.gz: ea10043b0c18a118eb7a93de954c56059076e0a2
 SHA512:
-  metadata.gz: abdb21b9a7e04733d3144d0e828eed85740a463270a15c6dc8db0c9b91940f0b245ab4f4f3d4857968ee92da819202cbae494cb90a60acbf0b67cb3eaa563597
-  data.tar.gz: 1ac672a42025afcb24e7dcbf0c0ac9a88a8ecc2154bc81f624630dbc7cc5ea115195c03bc445429a6613b837e8f4fb7fc7d2c5f2b332d0adbcf0b5d8f785caab
+  metadata.gz: fbfa268c8848d68edc143372334c332f96b5cd4daee18cec251404f563abb52564a4974fa0edeabab99e5e347573cb9d1c9468a213d44e1dee395268740494de
+  data.tar.gz: 7633461afdc6c38b878aa9893baf69bbad65e23ad21f37721c3b87126cf7df91839e73c222402a61fb89a75619cb26ac92c1ec0badc2217d91942b415c120be1

data/lib/zendesk2/client/mock.rb

@@ -90,7 +90,7 @@ class Zendesk2::Client < Cistern::Service
       page_index  = (page_params["page"] || 1).to_i
       offset      = (page_index - 1) * page_size
       filter      = options[:filter]
-      resources   = self.data[collection].values
+      resources   = options[:resources] || self.data[collection].values
       resources   = filter.call(resources) if filter
       count       = resources.size
       total_pages = (count / page_size) + 1

data/lib/zendesk2/client/requests/get_ticket_comments.rb

@@ -1,7 +1,8 @@
 class Zendesk2::Client
   class Real
     def get_ticket_comments(params={})
-      ticket_id = params["ticket_id"]
+      ticket_id = require_parameters(params, "ticket_id")
+
       request(
         :method => :get,
         :path => "/tickets/#{ticket_id}/comments.json"
@@ -11,12 +12,12 @@ class Zendesk2::Client
 
   class Mock
     def get_ticket_comments(params={})
-      ticket_id = params["ticket_id"]
+      ticket_id = require_parameters(params, "ticket_id")
 
       page(params,
            :ticket_comments,
            "/tickets/#{ticket_id}/comments.json",
-           "comments")
+           "comments", filter: lambda { |comments| comments.select { |comment| comment["ticket_id"].to_s == ticket_id.to_s } })
     end
   end # Mock
 end

data/lib/zendesk2/client/requests/update_ticket.rb

@@ -29,6 +29,7 @@ class Zendesk2::Client
             "public"      => comment["public"].nil? ? true : comment["public"],
             "trusted"     => comment["trusted"].nil? ? true : comment["trusted"],
             "attachments" => comment["attachments"] || [],
+            "ticket_id"   => ticket_id,
         }
 
         audit_id = self.class.new_id

data/lib/zendesk2/version.rb

@@ -1,3 +1,3 @@
 module Zendesk2
-  VERSION = "1.3.1"
+  VERSION = "1.3.2"
 end

data/spec/tickets_spec.rb

@@ -93,6 +93,18 @@ describe "Zendesk2::Client" do
     end
   end
 
+  describe "ticket#comments" do
+    let!(:ticket)         { client.tickets.create!(subject: mock_uuid, description: mock_uuid) }
+    let!(:another_ticket) { client.tickets.create!(subject: mock_uuid, description: mock_uuid)  }
+
+    it "should scope the comments to the source ticket" do
+      target_comments = 2.times.map { ticket.comment(mock_uuid) }
+      2.times.map { another_ticket.comment(mock_uuid) }
+
+      expect(ticket.comments.all).to match_array(target_comments)
+    end
+  end
+
   describe "ticket comments" do
     let(:ticket) { client.tickets.create!(subject: mock_uuid, description: mock_uuid) }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zendesk2
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Josh Lane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-05 00:00:00.000000000 Z
+date: 2014-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable