zencoder-flix_cloud-gem 0.4.0 → 0.5.0

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :major: 0
-:minor: 4
+:minor: 5
 :patch: 0

data/lib/flix_cloud/record.rb

@@ -34,9 +34,9 @@ protected
     begin
       FlixCloud::Response.new(RestClient::Resource.new("https://flixcloud.com/#{path}",
                                                        :verify_ssl => OpenSSL::SSL::VERIFY_PEER).post(body, :content_type => 'application/xml', :accept => 'application/xml'))
-    rescue RestClient::Unauthorized
-      raise FlixCloud::Unauthorized
-    rescue RestClient::RequestFailed
+    rescue RestClient::ServerBrokeConnection
+      raise FlixCloud::ServerBrokeConnection
+    rescue RestClient::RequestTimeout
       raise FlixCloud::RequestFailed
     end
   end

data/lib/flix_cloud/response.rb

@@ -11,7 +11,7 @@ class FlixCloud::Response
   end
 
   def success?
-    errors.empty?
+    201 == code.to_i
   end
 
 

data/test/flix_cloud/job_test.rb

@@ -191,26 +191,44 @@ class FlixCloud::JobTest < Test::Unit::TestCase
 
     context "when saving with malformed xml (should really never happen, but what if?)" do
       setup do
-        FakeWeb.register_uri(:post, 'https://flixcloud.com/jobs', :status => ['400', 'Bad Request'])
+        FakeWeb.register_uri(:post, 'https://flixcloud.com/jobs', :string => %{<?xml version="1.0" encoding="UTF-8"?><errors><error>Malformed XML</error></errors>},
+                                                                  :status => ['400', 'Bad Request'])
       end
 
-      should "raise a RequestFailed error" do
-        assert_raises FlixCloud::RequestFailed do
-          @job.save
-        end
+      should "not be successful" do
+        assert !@job.save
+      end
+
+      should "have a 400 response code" do
+        @job.save
+        assert_equal 400, @job.response.code
+      end
+
+      should "store the errors on the job" do
+        @job.save
+        assert_equal ['Malformed XML'], @job.errors
       end
     end
 
 
-    context "when saving and the schema doesn't validate (should really never happen, but what if?)" do
+    context "when saving with an invalid schema (should really never happen, but what if?)" do
       setup do
-        FakeWeb.register_uri(:post, 'https://flixcloud.com/jobs', :status => ['400', 'Bad Request'])
+        FakeWeb.register_uri(:post, 'https://flixcloud.com/jobs', :string => %{<?xml version="1.0" encoding="UTF-8"?><errors><error>Schema is invalid</error></errors>},
+                                                                  :status => ['400', 'Bad Request'])
+      end
+
+      should "not be successful" do
+        assert !@job.save
       end
 
-      should "raise a RequestFailed error" do
-        assert_raises FlixCloud::RequestFailed do
-          @job.save
-        end
+      should "have a 400 response code" do
+        @job.save
+        assert_equal 400, @job.response.code
+      end
+
+      should "store the errors on the job" do
+        @job.save
+        assert_equal ['Schema is invalid'], @job.errors
       end
     end
 
@@ -220,10 +238,13 @@ class FlixCloud::JobTest < Test::Unit::TestCase
         FakeWeb.register_uri(:post, 'https://flixcloud.com/jobs', :status => ['401', 'Unauthorized'])
       end
 
-      should "raise an Unauthorized error" do
-        assert_raises FlixCloud::Unauthorized do
-          @job.save
-        end
+      should "not be successful" do
+        assert !@job.save
+      end
+
+      should "have a 401 response code" do
+        @job.save
+        assert_equal 401, @job.response.code
       end
     end
 
@@ -247,7 +268,7 @@ class FlixCloud::JobTest < Test::Unit::TestCase
     context "when saving was successful" do
       setup do
         FakeWeb.register_uri(:post, 'https://flixcloud.com/jobs', :string => %{<?xml version="1.0" encoding="UTF-8"?><job><id type="integer">1</id><initialized-job-at type="datetime">2009-04-07T23:15:33+02:00</initialized-job-at></job>},
-                                                                  :status => ['200', 'OK'])
+                                                                  :status => ['201', 'Created'])
       end
 
       should "return true" do
@@ -318,7 +339,7 @@ class FlixCloud::JobTest < Test::Unit::TestCase
     setup do
       FakeWeb.allow_net_connect = false
       FakeWeb.register_uri(:post, 'https://flixcloud.com/jobs', :string => %{<?xml version="1.0" encoding="UTF-8"?><job><id type="integer">1</id><initialized-job-at type="datetime">2009-04-07T23:15:33+02:00</initialized-job-at></job>},
-                                                                :status => ['200', 'OK'])
+                                                                :status => ['201', 'Created'])
       @job = FlixCloud::Job.new(:api_key => 'your-api-key',
                                 :recipe_id => 2,
                                 :input_url          => 'your-input-url',
@@ -360,7 +381,7 @@ class FlixCloud::JobTest < Test::Unit::TestCase
     setup do
       FakeWeb.allow_net_connect = false
       FakeWeb.register_uri(:post, 'https://flixcloud.com/jobs', :string => %{<?xml version="1.0" encoding="UTF-8"?><job><id type="integer">1</id><initialized-job-at type="datetime">2009-04-07T23:15:33+02:00</initialized-job-at></job>},
-                                                                :status => ['200', 'OK'])
+                                                                :status => ['201', 'Created'])
       @job = FlixCloud::Job.create(:api_key => 'your-api-key',
                                    :recipe_id => 2,
                                    :input_url          => 'your-input-url',
@@ -404,7 +425,7 @@ class FlixCloud::JobTest < Test::Unit::TestCase
     setup do
       FakeWeb.allow_net_connect = false
       FakeWeb.register_uri(:post, 'https://flixcloud.com/jobs', :string => %{<?xml version="1.0" encoding="UTF-8"?><job><id type="integer">1</id><initialized-job-at type="datetime">2009-04-07T23:15:33+02:00</initialized-job-at></job>},
-                                                                :status => ['200', 'OK'])
+                                                                :status => ['201', 'Created'])
       @job = FlixCloud::Job.create!(:api_key => 'your-api-key',
                                     :recipe_id => 2,
                                     :input_url          => 'your-input-url',

data/test/flix_cloud/response_test.rb

@@ -4,7 +4,7 @@ class FlixCloud::ResponseTest < Test::Unit::TestCase
 
   context "A response initialized with a rest client response" do
     setup do
-      @rest_client_response = stub_rest_client_response(200, '<?xml version="1.0" encoding="UTF-8"?><something>wonderful</something>')
+      @rest_client_response = stub_rest_client_response(201, '<?xml version="1.0" encoding="UTF-8"?><something>wonderful</something>')
       @response = FlixCloud::Response.new(@rest_client_response)
     end
 
@@ -27,7 +27,7 @@ class FlixCloud::ResponseTest < Test::Unit::TestCase
 
   context "A response initialized with a rest client response with a blank message body" do
     setup do
-      @response = FlixCloud::Response.new(stub_rest_client_response(200, ''))
+      @response = FlixCloud::Response.new(stub_rest_client_response(201, ''))
     end
 
     should "be successful" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: zencoder-flix_cloud-gem
 version: !ruby/object:Gem::Version 
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors: 
 - Nathan Sutton
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-04-13 00:00:00 -07:00
+date: 2009-04-16 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency