zen-plaid 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a6b519922fa379a6daeb4daab3532af7ce63fa46
-  data.tar.gz: cf7ee2f343ab48afc87a17ce65b5edca75333e40
+  metadata.gz: 0c3e87f8a6171381574d7e3e643f3cb6f23c7baa
+  data.tar.gz: 60efc4c37af64802d244e641b0647d2a487ea4be
 SHA512:
-  metadata.gz: 00ad929ef2b22e9c452b44d53c125b3921dc321332e376adcef981c3d517c72a27c626c43cd34756b6321eb85b7ba3e1ca76ce7f398d671cbfac0d1a9bb333ca
-  data.tar.gz: 05df053ed9761ecf194dd22c25a2a0cc6b1df1253b449540c3e8d8568359aaf11fbb5c82c6554803d961d3e4029ac88d86c841c41e16e4a7bcc055b569639800
+  metadata.gz: 33bf4ec03e57e8d21f4bbcf067c85c65e9603dce1281be7cd91a94fa8e7b3208770c697d4d5facc224a0b595875e73369788d019ad8362f93c23aa44470d84bf
+  data.tar.gz: 5ade6cc8a485d42e881c4d2ddd1b7a8a7ffd0fa06b6ef390cf652e74c1319c3ff1b671635b2bf67bf97a9dffe92694e1becfcf88a49e09d708da26b597202645

data/.rspec

@@ -1 +1,2 @@
 --color
+--format documentation

data/lib/zen-plaid/auth.rb

@@ -1,7 +1,7 @@
 module Plaid
   class Auth
     def self.add(params)
-      Plaid.request(:post, '/auth', params)
+      Plaid.request(:post, '/auth', Plaid::Util.credentials_params(params))
     end
   end
 end

data/lib/zen-plaid/connect.rb

@@ -5,7 +5,7 @@ module Plaid
     end
 
     def self.add(params)
-      Plaid.request(:post, '/connect', params)
+      Plaid.request(:post, '/connect', Plaid::Util.credentials_params(params))
     end
 
     def self.mfa_step(params)

data/lib/zen-plaid/util.rb

@@ -63,5 +63,22 @@ module Plaid
       end
       result
     end
+
+    def self.credentials_params(params)
+      unless params.has_key?(:credentials)
+        warn "You should use credentials to pass in username/password/pin"
+
+        params[:credentials] = {}
+        params[:credentials][:username] = params[:username] if params[:username]
+        params[:credentials][:password] = params[:password] if params[:password]
+        params[:credentials][:pin] = params[:pin] if params[:pin]
+      end
+
+      params.delete(:username)
+      params.delete(:password)
+      params.delete(:pin)
+
+      params
+    end
   end
 end

data/lib/zen-plaid/version.rb

@@ -1,3 +1,3 @@
 module Plaid
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/auth_spec.rb

@@ -9,9 +9,9 @@ describe Plaid::Auth do
   end
 
   context 'missing password' do
-    it "returns 400 http code" do
+    it "returns 402 http code" do
       connection = Plaid::Auth.add({type: 'bofa', username: 'plaid_test'})
-      expect(connection[:code]).to eq(400)
+      expect(connection[:code]).to eq(402)
     end
   end
 
@@ -75,22 +75,17 @@ describe Plaid::Auth do
     end
   end
 
-  # context 'correct credentials with pin' do
-  #   it "returns 200 http code" do
-  #     connection = Plaid::Auth.add({type: 'usaa', username: 'plaid_test', password: 'plaid_good', pin: 1234})
-  #     expect(connection[:code]).to eq(200)
-  #   end
-
-  #   it "returns accounts" do
-  #     connection = Plaid::Auth.add({type: 'usaa', username: 'plaid_test', password: 'plaid_good', pin: 1234})
-  #     expect(connection[:message]).to have_key(:accounts)
-  #   end
-
-  #   it "returns transactions" do
-  #     connection = Plaid::Auth.add({type: 'usaa', username: 'plaid_test', password: 'plaid_good', pin: 1234})
-  #     expect(connection[:message]).to have_key(:transactions)
-  #   end
-  # end
+  context 'correct credentials with pin' do
+    it "returns 201 http code" do
+      connection = Plaid::Auth.add({type: 'usaa', username: 'plaid_test', password: 'plaid_good', pin: 1234})
+      expect(connection[:code]).to eq(201)
+    end
+
+    it "returns mfa question" do
+      connection = Plaid::Auth.add({type: 'usaa', username: 'plaid_test', password: 'plaid_good', pin: 1234})
+      expect(connection[:message]).to have_key(:mfa)
+    end
+  end
 
   context 'correct credentials with default chase mfa' do
     it "returns 201 http code" do

data/spec/connect_spec.rb

@@ -67,9 +67,9 @@ describe Plaid::Connect do
 
   describe "#add" do
     context 'missing password' do
-      it "returns 400 http code" do
+      it "returns 402 http code" do
         connection = Plaid::Connect.add({type: 'amex', username: 'plaid_test'})
-        expect(connection[:code]).to eq(400)
+        expect(connection[:code]).to eq(402)
       end
     end
 
@@ -156,19 +156,14 @@ describe Plaid::Connect do
     end
 
     context 'correct credentials with pin' do
-      it "returns 200 http code" do
-        connection = Plaid::Connect.add({type: 'amex', username: 'plaid_test', password: 'plaid_good', pin: 1234})
-        expect(connection[:code]).to eq(200)
-      end
-
-      it "returns accounts" do
-        connection = Plaid::Connect.add({type: 'amex', username: 'plaid_test', password: 'plaid_good', pin: 1234})
-        expect(connection[:message]).to have_key(:accounts)
+      it "returns 201 http code" do
+        connection = Plaid::Connect.add({type: 'usaa', username: 'plaid_test', password: 'plaid_good', pin: 1234})
+        expect(connection[:code]).to eq(201)
       end
 
-      it "returns transactions" do
-        connection = Plaid::Connect.add({type: 'amex', username: 'plaid_test', password: 'plaid_good', pin: 1234})
-        expect(connection[:message]).to have_key(:transactions)
+      it "returns mfa question" do
+        connection = Plaid::Auth.add({type: 'usaa', username: 'plaid_test', password: 'plaid_good', pin: 1234})
+        expect(connection[:message]).to have_key(:mfa)
       end
     end
 

data/spec/util_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper.rb'
+
+describe Plaid::Util do
+  describe ".credentials_params" do
+    context 'already has credentials' do
+      let(:params) { { credentials: {username: 'plaid_test', password: 'plaid_good'}, type: 'chase' } }
+      let(:fixed_params) { Plaid::Util.credentials_params(params) }
+
+      it { expect(fixed_params).to have_key(:credentials) }
+      it { expect(fixed_params[:credentials]).to have_key(:username) }
+      it { expect(fixed_params[:credentials]).to have_key(:password) }
+      it { expect(fixed_params[:credentials]).to_not have_key(:pin) }
+    end
+
+    context 'no credentials' do
+      let(:params) { { username: 'plaid_test', password: 'plaid_good', type: 'chase' } }
+      let(:fixed_params) { Plaid::Util.credentials_params(params) }
+
+      it { expect(fixed_params).to have_key(:credentials) }
+      it { expect(fixed_params[:credentials]).to have_key(:username) }
+      it { expect(fixed_params[:credentials]).to have_key(:password) }
+
+      it { expect(fixed_params).to_not have_key(:username) }
+      it { expect(fixed_params).to_not have_key(:password) }
+      it { expect(fixed_params[:credentials]).to_not have_key(:pin) }
+    end
+
+    context 'no credentials with pin' do
+      let(:params) { { username: 'plaid_test', password: 'plaid_good', pin: 1234, type: 'chase' } }
+      let(:fixed_params) { Plaid::Util.credentials_params(params) }
+
+      it { expect(fixed_params).to have_key(:credentials) }
+      it { expect(fixed_params[:credentials]).to have_key(:username) }
+      it { expect(fixed_params[:credentials]).to have_key(:password) }
+      it { expect(fixed_params[:credentials]).to have_key(:pin) }
+
+      it { expect(fixed_params).to_not have_key(:username) }
+      it { expect(fixed_params).to_not have_key(:password) }
+      it { expect(fixed_params).to_not have_key(:pin) }
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zen-plaid
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Sean McCann
@@ -96,6 +96,7 @@ files:
 - spec/entity_spec.rb
 - spec/institution_spec.rb
 - spec/spec_helper.rb
+- spec/util_spec.rb
 - zen-plaid.gemspec
 homepage: https://github.com/seanmccann/zen-plaid
 licenses: