zabbix-ruby-client 0.0.15 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1ee64f86d9fde1c3c037e228c7b1210063de95a4
-  data.tar.gz: cb9818f7a8a2a52c2b86be6210eae24c9d454908
+  metadata.gz: 9d21a9e419424ce57875b93ca1a3762d2b91ced6
+  data.tar.gz: 3a9009d18b91bcb35314d9c252f74758764fb8b4
 SHA512:
-  metadata.gz: 37097420a266843b8c5d3beb7747debcbf197117d62b3f5a0a15fec8ffe34d14f2820ccddebfb9f9ab2fe9335e231ec51fd9c920f11ac0d03d08543f4f31040e
-  data.tar.gz: 29485fb483e432aeb8458dc083f6e4ef1eee11c071e488b6ca554568802d693486c588945c95530c975d5468b5d7c15c6701bfad070b372d449cc3134b852925
+  metadata.gz: db3e39aafa5b8fd659a403759e96802a4020481a375a5fd6ce22d53ecb494a1e33ec2a9eb25dd564c904e22f8dbf4029fd07e46421db690ff75abb8d794d168f
+  data.tar.gz: 1d179f9c66d731f9b17b24554b4c5f37ff4a4b9df4bfa8d3dcde688de331a8c97fcda3da9ca79775e18b76683bbafc7fdfc91c0d7daa14af22f2da4fb226cf44

data/.coveralls.yml

@@ -0,0 +1 @@
+repo_token: Oej1FGJWwMJdJPP5si37KoXFU3EcLQH9v

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+cache: bundler
+rvm:
+  - 2.0.0

data/CHANGELOG.md

@@ -1,6 +1,13 @@
 Zabbbix Ruby Client Changelog
 -----------------------------
 
+### v0.0.16 - 2013-10-31
+
+* _if you have custom plugins_ the class ZabbixRubyClient is now a module just for namespacing, update your code! 
+* fix the logger
+* refactoring and more tests
+* adding travis and coverall to stimulate testing, also added gemnasium
+
 ### v0.0.15 - 2013-10-23
 
 * prototype of a way to keep data when sending fails and sending it again at next iteration

data/README.md

@@ -2,8 +2,13 @@ Zabbix Ruby Client
 ====================
 
 [![Gem Version](https://badge.fury.io/rb/zabbix-ruby-client.png)](http://rubygems.org/gems/zabbix-ruby-client)
+[![Build Status](https://travis-ci.org/eduvo/zabbix-ruby-client.png?branch=master)](https://travis-ci.org/eduvo/zabbix-ruby-client)
+[![Coverage Status](https://coveralls.io/repos/eduvo/zabbix-ruby-client/badge.png)](https://coveralls.io/r/eduvo/zabbix-ruby-client)
+[![Dependency Status](https://gemnasium.com/eduvo/zabbix-ruby-client.png)](https://gemnasium.com/eduvo/zabbix-ruby-client)
 [![Code Climate](https://codeclimate.com/github/eduvo/zabbix-ruby-client.png)](https://codeclimate.com/github/eduvo/zabbix-ruby-client)
 
+----
+
 This tool is designed to make easy to install zabbix reporter on monitored servers using zabbix-sender rather than zabbix-agent. It targets on monitoring mainly linux servers and is built on a plugin system so that you can decide what is going to be reported.
 
 The development is still in progress but it produces results and works in my case. Use at your own risk and read the code first. It is developed under ruby 2 but should work on 1.9.3 as well.

data/lib/zabbix-ruby-client.rb

@@ -3,79 +3,11 @@ require "zabbix-ruby-client/logger"
 require "zabbix-ruby-client/plugins"
 require "zabbix-ruby-client/store"
 require "zabbix-ruby-client/data"
+require "zabbix-ruby-client/runner"
 require "yaml"
 
-class ZabbixRubyClient
+module ZabbixRubyClient
 
-  def initialize(config_file, task_file)
-    begin
-      @config ||= YAML::load_file(config_file)
-      if File.exists? task_file
-        @tasks ||= YAML::load_file(task_file)
-      else
-        @tasks = @config["plugins"]
-      end
-    rescue Exception => e
-      puts "Configuration file cannot be read"
-      puts e.message
-      return
-    end
-
-    @store = Store.new(
-      @config['datadir'],
-      @config['zabbix']['host'],
-      File.basename(task_file,'.yml'),
-      @config['keepdata']
-    )
-
-    @data = Data.new(@config['host'])
-
-    @config["server"] = File.basename(config_file,'.yml')
-    @logsdir = makedir(@config['logsdir'],'logs')
-    @plugindirs = [ File.expand_path("../zabbix-ruby-client/plugins", __FILE__) ]
-    if @config["plugindirs"]
-      @plugindirs = @plugindirs + @config["plugindirs"]
-    end
-    Plugins.load_dirs @plugindirs
-    logger.debug @config.inspect
-  end
-
-  def collect
-    @tasks.each do |plugin|
-      @data.run_plugin(plugin['name'], plugin['args'])
-    end
-  end
-
-  def show
-    @data.merge.each do |line|
-      puts line
-    end
-  end
-
-  def upload
-    file = @store.record(@data.merge)
-    begin
-      res = `#{@config['zabbix']['sender']} -z #{@config['zabbix']['host']} -p #{@config['zabbix']['port']} -T -i #{file}`
-      if $?.to_i != 0
-        @store.keepdata(file)
-      end
-    rescue Exception => e
-      @store.keepdata(file)
-      logger.error "Sending failed."
-      logger.error e.message
-    end
-  end
-
-  def logger
-    @logger ||= Logger.get_logger(@logsdir, @config["loglevel"])
-  end
-
-  private
-
-  def makedir(configdir, defaultdir)
-    dir = configdir || defaultdir
-    FileUtils.mkdir dir unless Dir.exists? dir
-    dir
-  end
+  PLUGINDIR = File.expand_path("../zabbix-ruby-client/plugins", __FILE__)
 
 end

data/lib/zabbix-ruby-client/cli.rb

@@ -1,7 +1,7 @@
 require "thor"
-require "zabbix-ruby-client"
+require "zabbix-ruby-client/runner"
 
-class ZabbixRubyClient
+module ZabbixRubyClient
 
   class Cli < Thor
     include Thor::Actions
@@ -35,14 +35,30 @@ class ZabbixRubyClient
         say "No Gemfile found", :red
         abort
       end
-      zrc = ZabbixRubyClient.new(options[:configfile],options[:taskfile])
+      config = YAML::load_file(options[:configfile])
+      if File.exists? options[:taskfile]
+        tasks = YAML::load_file(options[:taskfile])
+      else
+        tasks = config['plugins']
+      end
+      config['server'] = File.basename(options[:configfile],'.yml')
+      config['taskfile'] = File.basename(options[:taskfile],'.yml')
+      zrc = ZabbixRubyClient::Runner.new(config, tasks)
       zrc.collect
       zrc.show
     end
 
     desc "upload", "Collects and sends data to the zabbix server"
     def upload
-      zrc = ZabbixRubyClient.new(options[:configfile],options[:taskfile])
+      config = YAML::load_file(options[:configfile])
+      if File.exists? options[:taskfile]
+        tasks = YAML::load_file(options[:taskfile])
+      else
+        tasks = config['plugins']
+      end
+      config['server'] = File.basename(options[:configfile],'.yml')
+      config['taskfile'] = File.basename(options[:taskfile],'.yml')
+      zrc = ZabbixRubyClient::Runner.new(config, tasks)
       zrc.collect
       zrc.upload
     end

data/lib/zabbix-ruby-client/data.rb

@@ -1,4 +1,6 @@
-class ZabbixRubyClient
+require "zabbix-ruby-client/logger"
+
+module ZabbixRubyClient
   class Data
 
     def initialize(host)
@@ -18,8 +20,8 @@ class ZabbixRubyClient
             @discover[key] << [ value ]
           end
         rescue Exception => e
-          logger.fatal "Oops"
-          logger.fatal e.message
+          Log.fatal "Oops"
+          Log.fatal e.message
         end
       end
     end

data/lib/zabbix-ruby-client/logger.rb

@@ -1,16 +1,42 @@
 require "logger"
 
-class ZabbixRubyClient
-  module Logger
+module ZabbixRubyClient
+  module Log
     extend self
 
-    def get_logger(dir, level)
-      logger = ::Logger.new(File.join(dir,"zrc.log"))
-      logger.level = get_level_constant(level)
-      logger.formatter = proc do |severity, datetime, progname, msg|
+    def set_logger(logfile, level="info")
+      if logfile.is_a?(String) && !Dir.exists?(File.dirname(logfile))
+        FileUtils.mkdir_p(File.dirname(logfile))
+      end
+      @logger = ::Logger.new(logfile)
+      @logger.level = get_level_constant(level)
+      @logger.formatter = proc do |severity, datetime, progname, msg|
         "[#{datetime.utc}] #{severity}: #{msg}\n"
       end
-      logger
+    end
+
+    def logger
+      @logger ||= ::Logger.new(STDOUT)
+    end
+
+    def debug(msg)
+      logger.debug(msg)
+    end
+
+    def info(msg)
+      logger.info(msg)
+    end
+
+    def warn(msg)
+      logger.warn(msg)
+    end
+
+    def error(msg)
+      logger.error(msg)
+    end
+
+    def fatal(msg)
+      logger.fatal(msg)
     end
 
     def get_level_constant(level)
@@ -26,4 +52,4 @@ class ZabbixRubyClient
     end
 
   end
-end
+end

data/lib/zabbix-ruby-client/plugins.rb

@@ -1,8 +1,8 @@
-class ZabbixRubyClient
+module ZabbixRubyClient
   module Plugins
     extend self
 
-    def load_dirs(dirs)
+    def scan_dirs(dirs)
       @available = {}
       @loaded = {}
       dirs.each do |d|
@@ -14,14 +14,14 @@ class ZabbixRubyClient
       end
     end
 
-    def register(plugin, klass)
-      @loaded[plugin] = klass
-    end
-
     def loaded
       @loaded ||= {}
     end
 
+    def register(plugin, klass)
+      @loaded[plugin] = klass
+    end
+
     def load(plugin)
       if @loaded[plugin]
         true
@@ -34,5 +34,10 @@ class ZabbixRubyClient
       end
     end
 
+    def reset
+      @loaded = {}
+      @available = {}
+    end
+
   end
-end
+end

data/lib/zabbix-ruby-client/plugins/apache.rb

@@ -1,6 +1,6 @@
 require "open-uri"
 
-class ZabbixRubyClient
+module ZabbixRubyClient
   module Plugins
     module Apache
       extend self

data/lib/zabbix-ruby-client/plugins/apt.rb

@@ -1,4 +1,6 @@
-class ZabbixRubyClient
+require "zabbix-ruby-client/logger"
+
+module ZabbixRubyClient
   module Plugins
     module Apt
       extend self
@@ -9,7 +11,7 @@ class ZabbixRubyClient
         if $?.to_i == 0
           security, pending = aptcheck.split(/;/).map(&:to_i)
         else
-          logger.warn "Are you running on ubuntu ?"
+          Log.warn "Are you running on ubuntu ?"
           return []
         end
         time = Time.now.to_i

data/lib/zabbix-ruby-client/plugins/cpu.rb

@@ -1,20 +1,20 @@
 # for more info check 
 # http://www.linuxhowtos.org/System/procstat.htm
 # http://juliano.info/en/Blog:Memory_Leak/Understanding_the_Linux_load_average
+require "zabbix-ruby-client/logger"
 
-class ZabbixRubyClient
+module ZabbixRubyClient
   module Plugins
     module Cpu
       extend self
 
       def collect(*args)
         host = args[0]
-        #cpuinfo = `mpstat | grep " all "`
         cpuinfo = `cat /proc/stat | grep "^cpu"`
         if $?.to_i == 0
           _, user, nice, sys, idle, wait, irq, soft, guest, steal = cpuinfo.split(/\s+/).map(&:to_i)
         else
-          logger.warn "Oh you don't have a /proc ?"
+          Log.warn "Oh you don't have a /proc ?"
           return []
         end
         used = user + nice + sys

data/lib/zabbix-ruby-client/plugins/disk.rb

@@ -1,8 +1,9 @@
 # some doc on
 # http://www.xaprb.com/blog/2010/01/09/how-linux-iostat-computes-its-results/
 # http://www.mjmwired.net/kernel/Documentation/iostats.txt
+require "zabbix-ruby-client/logger"
 
-class ZabbixRubyClient
+module ZabbixRubyClient
   module Plugins
     module Disk
       extend self
@@ -15,7 +16,7 @@ class ZabbixRubyClient
         if $?.to_i == 0
           _, size, used, available, percent_used, mount = diskspace.split(/\s+/)
         else
-          logger.error "df is not working... ouchie."
+          Log.error "df is not working... ouchie."
           return []
         end
         time = Time.now.to_i

data/lib/zabbix-ruby-client/plugins/load.rb

@@ -1,7 +1,8 @@
 # for more info check 
 # http://juliano.info/en/Blog:Memory_Leak/Understanding_the_Linux_load_average
+require "zabbix-ruby-client/logger"
 
-class ZabbixRubyClient
+module ZabbixRubyClient
   module Plugins
     module Load
       extend self
@@ -13,7 +14,7 @@ class ZabbixRubyClient
         if $?.to_i == 0
           one, five, fifteen, procs_t = cpuinfo.split(/\s+/)
         else
-          logger.warn "Oh you don't have a /proc ?"
+          Log.warn "Oh you don't have a /proc ?"
           return []
         end
 

data/lib/zabbix-ruby-client/plugins/memory.rb

@@ -1,4 +1,6 @@
-class ZabbixRubyClient
+require "zabbix-ruby-client/logger"
+
+module ZabbixRubyClient
   module Plugins
     module Memory
       extend self
@@ -9,7 +11,7 @@ class ZabbixRubyClient
         if $?.to_i == 0
           info = splitinfo(meminfo)
         else
-          logger.warn "Please install sysstat."
+          Log.warn "Please install sysstat."
           return []
         end
 

data/lib/zabbix-ruby-client/plugins/mysql.rb

@@ -1,4 +1,6 @@
-class ZabbixRubyClient
+require "zabbix-ruby-client/logger"
+
+module ZabbixRubyClient
   module Plugins
     module Mysql
       extend self
@@ -10,7 +12,7 @@ class ZabbixRubyClient
         if $?.to_i == 0
           status = get_status(mysqlstatus)
         else
-          self.logger.warn "The connection failed."
+          Log.warn "The connection failed."
           return []
         end
 

data/lib/zabbix-ruby-client/plugins/network.rb

@@ -1,4 +1,6 @@
-class ZabbixRubyClient
+require "zabbix-ruby-client/logger"
+
+module ZabbixRubyClient
   module Plugins
     module Network
       extend self
@@ -10,7 +12,7 @@ class ZabbixRubyClient
         if $?.to_i == 0
           _, _, rx_ok, rx_packets, rx_err, rx_drop, _, _, _, _, tx_ok, tx_packets, tx_err, tx_drop, _, _, _, _  = netinfo.split(/\s+/)
         else
-          logger.warn "Please install netstat."
+          Log.warn "proc not found."
           return []
         end
 

data/lib/zabbix-ruby-client/plugins/nginx.rb

@@ -1,6 +1,7 @@
 # uses http://wiki.nginx.org/HttpStubStatusModule
+require "zabbix-ruby-client/logger"
 
-class ZabbixRubyClient
+module ZabbixRubyClient
   module Plugins
     module Nginx
       extend self

data/lib/zabbix-ruby-client/plugins/redis.rb

@@ -1,6 +1,7 @@
 # this is a simple version for standalone redis server
+require "zabbix-ruby-client/logger"
 
-class ZabbixRubyClient
+module ZabbixRubyClient
   module Plugins
     module Redis
       extend self
@@ -13,7 +14,7 @@ class ZabbixRubyClient
         if $?.to_i == 0
           info = get_info(redisinfo)
         else
-          logger.warn "Redis connection failed."
+          Log.warn "Redis connection failed."
           return []
         end
 

data/lib/zabbix-ruby-client/plugins/sysinfo.rb

@@ -1,4 +1,6 @@
-class ZabbixRubyClient
+require "zabbix-ruby-client/logger"
+
+module ZabbixRubyClient
   module Plugins
     module Sysinfo
       extend self
@@ -10,7 +12,7 @@ class ZabbixRubyClient
           arch, hostname, kernel, kernel_version, machine, proc,
           _, _, _, _, _, _, _, platform, os = uname.split(/ /)
         else
-          logger.warn "Are you running on ubuntu ?"
+          Log.warn "Are you running on ubuntu ?"
           return []
         end
         time = Time.now.to_i

data/lib/zabbix-ruby-client/plugins/who.rb

@@ -1,4 +1,6 @@
-class ZabbixRubyClient
+require "zabbix-ruby-client/logger"
+
+module ZabbixRubyClient
   module Plugins
     module Who
       extend self
@@ -7,7 +9,7 @@ class ZabbixRubyClient
         host = args[0]
         who = get_who
         if $?.to_i != 0
-          logger.warn "Are you running on ubuntu ?"
+          Log.warn "Are you running on ubuntu ?"
           return []
         end
         time = Time.now.to_i

data/lib/zabbix-ruby-client/runner.rb

@@ -0,0 +1,58 @@
+module ZabbixRubyClient
+
+  class Runner
+
+    def initialize(config, tasks)
+      @config = config
+      @tasks = tasks
+
+      @store = ZabbixRubyClient::Store.new(
+        @config['datadir'],
+        @config['zabbix']['host'],
+        @config['taskfile'],
+        @config['keepdata']
+      )
+
+      @data = ZabbixRubyClient::Data.new(@config['host'])
+      @logsdir = makedir(@config['logsdir'], 'logs')
+      ZabbixRubyClient::Plugins.scan_dirs([ PLUGINDIR ] + @config['plugindirs'])
+      ZabbixRubyClient::Log.set_logger(File.join(@logsdir, 'zrc.log'), 'info')
+      ZabbixRubyClient::Log.debug @config.inspect
+    end
+
+    def collect
+      @tasks.each do |plugin|
+        @data.run_plugin(plugin['name'], plugin['args'])
+      end
+    end
+
+    def show
+      @data.merge.each do |line|
+        puts line
+      end
+    end
+
+    def upload
+      file = @store.record(@data.merge)
+      begin
+        res = `#{@config['zabbix']['sender']} -z #{@config['zabbix']['host']} -p #{@config['zabbix']['port']} -T -i #{file}`
+        if $?.to_i != 0
+          @store.keepdata(file)
+        end
+      rescue Exception => e
+        @store.keepdata(file)
+        logger.error "Sending failed."
+        logger.error e.message
+      end
+    end
+
+    private
+
+    def makedir(configdir, defaultdir)
+      dir = configdir || defaultdir
+      FileUtils.mkdir dir unless Dir.exists? dir
+      dir
+    end
+
+  end
+end

data/lib/zabbix-ruby-client/store.rb

@@ -1,4 +1,4 @@
-class ZabbixRubyClient
+module ZabbixRubyClient
   class Store
 
     def initialize(dir, server, task, keepdata=false)

data/lib/zabbix-ruby-client/version.rb

@@ -1,3 +1,3 @@
-class ZabbixRubyClient
-  VERSION ||= "0.0.15"
+module ZabbixRubyClient
+  VERSION ||= "0.0.16"
 end

data/spec/files/config.yml

@@ -4,18 +4,9 @@ logsdir: logs
 loglevel: info
 datadir: data
 keepdata: no # or yes
-plugindirs: 
+plugindirs:
   - plugins
 zabbix:
   host: zabbix.example.com
   port: 10051
   sender: /usr/bin/zabbix_sender
-plugins:
-  - name: memory
-  - name: cpu
-  - name: network
-    args: eth0
-  - name: disk
-    args: sda1
-  - name: network
-    args: eth0

data/spec/files/plugins/sample.rb

@@ -0,0 +1,11 @@
+module Sample
+  extend self
+
+  def collect(*args)
+    return ["localhost sample[foo] 123456789 42"]
+  end
+
+end
+
+ZabbixRubyClient::Plugins.register('sample', Sample)
+

data/spec/files/task.yml

@@ -0,0 +1,2 @@
+---
+- name: sample

data/spec/lib/logger_spec.rb

@@ -3,10 +3,31 @@
 require 'spec_helper'
 require "zabbix-ruby-client/logger"
 
-describe ZabbixRubyClient::Logger do
+describe ZabbixRubyClient::Log do
 
-  pending "get_logger returns a valid Logger instance"
-  pending "logged message are nicely formatted"
-  pending "loglevel is properly interpreted from argument"
+  before :all do
+    @logfile = File.expand_path("../../files/logs/testlog", __FILE__)
+  end
 
-end
+  after :each do
+    File.unlink(@logfile) if File.exists?(@logfile)
+  end
+
+  it "set_logger prepares the logger" do
+    ZabbixRubyClient::Log.set_logger(@logfile, 'info')
+    expect(ZabbixRubyClient::Log.instance_variable_get(:@logger)).to be_instance_of Logger
+    expect(ZabbixRubyClient::Log.logger.level).to be Logger::INFO
+  end
+
+  it "logged message are nicely formatted" do
+    ZabbixRubyClient::Log.set_logger(@logfile, 'debug')
+    ZabbixRubyClient::Log.logger.debug("ha")
+    expect(File.read(@logfile)).to match /\] DEBUG: ha\n/
+  end
+
+  it "loglevel is properly interpreted from argument" do
+    ZabbixRubyClient::Log.set_logger(@logfile, 'debug')
+    expect(ZabbixRubyClient::Log.instance_variable_get(:@logger).level).to be Logger::DEBUG
+  end
+
+end

data/spec/lib/plugins/apache_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 require "zabbix-ruby-client/plugins"
-ZabbixRubyClient::Plugins.load_dirs ["zabbix-ruby-client/plugins"]
+ZabbixRubyClient::Plugins.scan_dirs ["zabbix-ruby-client/plugins"]
 require "zabbix-ruby-client/plugins/apache"
 
 describe ZabbixRubyClient::Plugins::Apache do

data/spec/lib/plugins/cpu_spec.rb

@@ -2,11 +2,10 @@
 
 require 'spec_helper'
 require "zabbix-ruby-client/plugins"
-ZabbixRubyClient::Plugins.load_dirs ["zabbix-ruby-client/plugins"]
 require "zabbix-ruby-client/plugins/cpu"
 
 describe ZabbixRubyClient::Plugins::Cpu do
-  
+
   pending "populate a hash with extracted data"
 
-end
+end

data/spec/lib/plugins/disk_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 require "zabbix-ruby-client/plugins"
-ZabbixRubyClient::Plugins.load_dirs ["zabbix-ruby-client/plugins"]
+ZabbixRubyClient::Plugins.scan_dirs ["zabbix-ruby-client/plugins"]
 require "zabbix-ruby-client/plugins/disk"
 
 describe ZabbixRubyClient::Plugins::Disk do

data/spec/lib/plugins/memory_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 require "zabbix-ruby-client/plugins"
-ZabbixRubyClient::Plugins.load_dirs ["zabbix-ruby-client/plugins"]
+ZabbixRubyClient::Plugins.scan_dirs ["zabbix-ruby-client/plugins"]
 require "zabbix-ruby-client/plugins/memory"
 
 describe ZabbixRubyClient::Plugins::Memory do

data/spec/lib/plugins/network_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 require "zabbix-ruby-client/plugins"
-ZabbixRubyClient::Plugins.load_dirs ["zabbix-ruby-client/plugins"]
+ZabbixRubyClient::Plugins.scan_dirs ["zabbix-ruby-client/plugins"]
 require "zabbix-ruby-client/plugins/network"
 
 describe ZabbixRubyClient::Plugins::Network do

data/spec/lib/plugins_spec.rb

@@ -4,9 +4,40 @@ require 'spec_helper'
 require "zabbix-ruby-client/plugins"
 
 describe ZabbixRubyClient::Plugins do
-  
-  pending "loading dirs works"
-  pending "registering a new plugin loads it"
-  pending "loading a plugin adds plugin in loaded list"
 
-end
+  before :all do
+    @plugindir = File.expand_path("../../files/plugins", __FILE__)
+  end
+
+  before :each do
+    ZabbixRubyClient::Plugins.scan_dirs([@plugindir])
+  end
+
+  after :each do
+    ZabbixRubyClient::Plugins.reset
+  end
+
+  it "loading dirs works" do
+    result = {"sample" => File.join(@plugindir, "sample.rb") }
+    expect(ZabbixRubyClient::Plugins.instance_variable_get(:@available)).to eq result 
+  end
+
+  it "registering a new plugin loads it" do
+    ZabbixRubyClient::Plugins.register("sample",Object)
+    result = { "sample" => Object }
+    expect(ZabbixRubyClient::Plugins.instance_variable_get(:@loaded)).to eq result
+  end
+
+  it "loading a plugin adds plugin in loaded list" do
+    ZabbixRubyClient::Plugins.load("sample")
+    expect(Sample).to be_kind_of Module
+  end
+
+  it "do not load a plugin already loaded" do
+    ZabbixRubyClient::Plugins.load("sample")
+    ZabbixRubyClient::Plugins.load("sample")
+    result = { "sample" => Sample }
+    expect(ZabbixRubyClient::Plugins.instance_variable_get(:@loaded)).to eq result
+  end
+
+end

data/spec/lib/runner_spec.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require "zabbix-ruby-client"
+
+describe ZabbixRubyClient::Runner do
+
+  before :each do
+    @basedir = File.expand_path("../../files", __FILE__)
+    Dir.chdir @basedir
+    config_file = File.join(@basedir, "config.yml")
+    @config = YAML::load_file(config_file)
+    task_file = File.join(@basedir, "task.yml")
+    @tasks = YAML::load_file(task_file)
+  end
+
+  after :each do
+    logfile = File.join("logs", "zrc.log")
+    File.unlink(logfile) if File.exists?(logfile)
+  end
+
+  it "initialize the client object" do
+    @zrc = ZabbixRubyClient::Runner.new(@config, @tasks)
+    expect(@zrc.instance_variable_get(:@config)['host']).to eq 'localhost'
+  end
+
+  it "creates dirs if needed" do
+    @zrc = ZabbixRubyClient::Runner.new(@config, @tasks)
+    expect(Dir.exists? "logs").to be_true
+  end
+
+  pending "loads list of plugins"
+  pending "initialize datafile according to config"
+  pending "stores data in datafile"
+  pending "issues the upload command according to config"
+
+end

data/spec/spec_helper.rb

@@ -2,6 +2,9 @@ $LOAD_PATH << File.expand_path('../../lib', __FILE__)
 require 'rubygems'
 require 'bundler'
 
+require 'coveralls'
+Coveralls.wear!
+
 RSpec.configure do |config|
   config.mock_with :rspec
   config.expect_with :rspec do |c|

data/zabbix-ruby-client.gemspec

@@ -23,4 +23,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "coveralls"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zabbix-ruby-client
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.16
 platform: ruby
 authors:
 - mose
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-22 00:00:00.000000000 Z
+date: 2013-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -66,6 +66,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A zabbix alternative to zabbix-agent using zabbix-sender.
 email:
 - mose@mose.com
@@ -74,7 +88,9 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- .coveralls.yml
 - .gitignore
+- .travis.yml
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -98,14 +114,19 @@ files:
 - lib/zabbix-ruby-client/plugins/redis.rb
 - lib/zabbix-ruby-client/plugins/sysinfo.rb
 - lib/zabbix-ruby-client/plugins/who.rb
+- lib/zabbix-ruby-client/runner.rb
 - lib/zabbix-ruby-client/store.rb
 - lib/zabbix-ruby-client/version.rb
 - spec/files/config.yml
-- spec/files/plugins/apache_status
-- spec/files/plugins/iostat_disk
-- spec/files/plugins/mpstat
-- spec/files/plugins/netstat
-- spec/files/plugins/vmstat
+- spec/files/data/.gitkeep
+- spec/files/logs/.gitkeep
+- spec/files/plugins/sample.rb
+- spec/files/system/apache_status
+- spec/files/system/iostat_disk
+- spec/files/system/mpstat
+- spec/files/system/netstat
+- spec/files/system/vmstat
+- spec/files/task.yml
 - spec/lib/cli_spec.rb
 - spec/lib/data_spec.rb
 - spec/lib/logger_spec.rb
@@ -115,8 +136,8 @@ files:
 - spec/lib/plugins/memory_spec.rb
 - spec/lib/plugins/network_spec.rb
 - spec/lib/plugins_spec.rb
+- spec/lib/runner_spec.rb
 - spec/lib/store_spec.rb
-- spec/lib/zabbix-ruby-client_spec.rb
 - spec/spec_helper.rb
 - templates/client/Gemfile
 - templates/client/config.yml
@@ -165,11 +186,15 @@ summary: This tool is intended to use zabbix sender to propagate monitoring data
   Zabbix server.
 test_files:
 - spec/files/config.yml
-- spec/files/plugins/apache_status
-- spec/files/plugins/iostat_disk
-- spec/files/plugins/mpstat
-- spec/files/plugins/netstat
-- spec/files/plugins/vmstat
+- spec/files/data/.gitkeep
+- spec/files/logs/.gitkeep
+- spec/files/plugins/sample.rb
+- spec/files/system/apache_status
+- spec/files/system/iostat_disk
+- spec/files/system/mpstat
+- spec/files/system/netstat
+- spec/files/system/vmstat
+- spec/files/task.yml
 - spec/lib/cli_spec.rb
 - spec/lib/data_spec.rb
 - spec/lib/logger_spec.rb
@@ -179,6 +204,6 @@ test_files:
 - spec/lib/plugins/memory_spec.rb
 - spec/lib/plugins/network_spec.rb
 - spec/lib/plugins_spec.rb
+- spec/lib/runner_spec.rb
 - spec/lib/store_spec.rb
-- spec/lib/zabbix-ruby-client_spec.rb
 - spec/spec_helper.rb

data/spec/lib/zabbix-ruby-client_spec.rb

@@ -1,16 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-require "zabbix-ruby-client"
-
-describe ZabbixRubyClient do
-
-  pending "initialize the client object"
-  pending "creates dirs if needed"
-  pending "loads list of plugins"
-  pending "initialize datafile according to config"
-  pending "stores data in datafile"
-  pending "runs list of plugins according to config"
-  pending "issues the upload command according to config"
-
-end