zabbix-monitor 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 29fc1e1290fbd5398058280ddc8dc5de4747a920
-  data.tar.gz: 3804953826fb8964598e3bf97322d3b74ba0ed67
+  metadata.gz: d62efd8efb5101a7ee8573dc7703ff1808a99052
+  data.tar.gz: 654a0b6511265333477a3184cb6444f7b9b7d506
 SHA512:
-  metadata.gz: a0845431f03d095103e171fa5cbc0a577c1829ba0654d6089a56251814b5ae15cab3b76a2b70835c3462b180fa888a86bfaa9d264d9b42b4dd6d8c82dbeefd2f
-  data.tar.gz: 874c3de57a94eee7b231e850abc9219c7061bd6689b1df1cb5b604febff5cf1032c794e9d916b1ad5192df55080c4e8eb420e3925eafcc3a29d452cf60ecfe75
+  metadata.gz: a31b40d780051fc453afd55b0c2e4831e906b4f3739b27b2e4dc7a1e3f900417c9c33f44c0966b44ac5507410372fb0eac57cd401c127ea4fbd0662eef29cf14
+  data.tar.gz: 9bc5e2267cf60e84b7c4c3d26e4b6f817425be76952a4e6a99466f0603040c541bbe768a85e3b8e2f4068ac7c83af0f3389141b6bbd0d0e438d8759ca2711cb8

data/.gitignore

@@ -15,3 +15,7 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.ruby-gemset
+.ruby-version
+log/*
+/.rspec

data/.travis.yml

@@ -0,0 +1,15 @@
+language: ruby
+cache: bundler
+rvm:
+  - 1.9.2
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - jruby-19mode
+  - ruby-head
+  - jruby-head
+matrix:
+  allow_failures:
+    - rvm: ruby-head
+    - rvm: jruby-head
+script: "bundle exec rake spec"

data/.yardopts

@@ -0,0 +1,5 @@
+--readme README.md
+--charset utf-8
+--private
+--protected
+'lib/**/*.rb' - '*.md'

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+# Zabbix Monitor Changelog
+
+### TBA
+- 100% code coverage
+- 100% documented
+- Added services:
+  - Travis CI
+  - Rdoc
+
+### v0.0.1 (2014-04-17)
+- Initial release

data/README.md

@@ -1,12 +1,23 @@
-# Monitor
+# Zabbix Monitor
+[![Gem Version](https://badge.fury.io/rb/zabbix-monitor.png)][gemversion]
+[![Build Status](https://secure.travis-ci.org/sping/zabbix-monitor.png?branch=master)][travis]
+[![Code Climate](https://codeclimate.com/github/sping/zabbix-monitor.png)][codeclimate]
 
-TODO: Write a gem description
+[gemversion]: http://badge.fury.io/rb/zabbix-monitor
+[travis]: http://travis-ci.org/sping/zabbix-monitor
+[codeclimate]: https://codeclimate.com/github/sping/zabbix-monitor
+
+Zabbix monitoring for Ruby apps. Works with pushing and polling: push data to the agent server with zabbix_sender or collect data with the Zabbix agent.
+
+Here you can find [Documentation](http://rubydoc.info/github/sping/zabbix-monitor/master/frames)
 
 ## Installation
 
+Requires the Zabbix agent to be installed.
+
 Add this line to your application's Gemfile:
 
-    gem 'zabbix-agent-monitor'
+    gem 'zabbix-monitor'
 
 And then execute:
 
@@ -14,11 +25,52 @@ And then execute:
 
 Or install it yourself as:
 
-    $ gem install zabbix-agent-monitor
+    $ gem install zabbix-monitor
+
+To include the rake tasks in your application, add the following line to your Rakefile (before `App::Application.load_tasks`):
+
+    require 'zabbix/tasks'
 
 ## Usage
 
-TODO: Write usage instructions here
+### For Rails applications:
+
+Place your Zabbix Monitoring configuration in an initializer:
+
+```ruby
+Zabbix.configure do |config|
+  config.config_file_path = '/etc/zabbix/zabbix_agentd.conf'
+  # optional, defaults to ./log/#{RACK_ENV}.log
+  # config.log_file_path = '/var/log/monitor.log'
+  config.host_name = 'servername'
+  config.mode = :push
+  config.rules = [
+    {
+      :command => 'Monitor.new.test',
+      :zabbix_key => 'zabbix.test'
+    }
+  ]
+end
+```
+
+Put the host name as configured in your Zabbix server config in `config.host_name`.
+
+Set the `config.mode` to one of the following options:
+
+- `:push` uses the Zabbix agent to push the data to the Zabbix server
+- `:file` writes the data to tmp/zabbix/monitor
+- `:stdout` writes the data to the stdout
+
+Put your monitoring rules in `config.rules`. Each rule contains a Ruby command to be executed by the Zabbix Monitor and the key as configured on the Zabbix Server.
+
+Start running your monitoring jobs with:
+
+    $ rake zabbix:collect_data
+
+
+## Changelog
+
+A detailed overview can be found in the [CHANGELOG](CHANGELOG.md).
 
 ## Contributing
 

data/Rakefile

@@ -1 +1,11 @@
-require 'bundler/gem_tasks'
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'yard'
+
+RSpec::Core::RakeTask.new(:spec) do |task|
+  task.rspec_opts = ['--color', '--format', 'documentation']
+end
+
+YARD::Rake::YardocTask.new do |t|
+  t.options += ["--title", "Zabbix monitor Documentation"]
+end

data/TODO.md

@@ -0,0 +1,5 @@
+# Todo
+
+- Create :file mode
+- Make ActiveRecord independent
+- Make schedule frequency configurable

data/bin/zabbix_reader

@@ -0,0 +1,5 @@
+#!/usr/bin/env ruby
+
+require 'zabbix'
+
+puts Zabbix::Reader.new.get_value ARGV[0]

data/lib/tasks/zabbix.rb

@@ -1,20 +1,15 @@
 require 'zabbix'
-require 'rufus-scheduler'
 
 namespace :zabbix do
   desc 'Collect data for Zabbix'
   task :collect_once => :environment do
+    Zabbix.logger.info "[Rake] executing #collect_once"
     Zabbix::Monitor.new.collect_data
   end
 
   desc 'Collect data for Zabbix every minute'
   task :collect_data => :environment do
-    Rufus::Scheduler.new.tap do |scheduler|
-      scheduler.every '1m' do
-        ActiveRecord::Base.connection_pool.with_connection do
-          Zabbix::Monitor.new.collect_data
-        end
-      end
-    end.join
+    Zabbix.logger.info "[Rake] executing #collect_data, setting up Rufus"
+    Zabbix::Monitor.new.schedule
   end
-end
+end

data/lib/zabbix.rb

@@ -1,31 +1,48 @@
 require 'zabbix/config'
 require 'zabbix/monitor'
+require 'zabbix/reader'
+require 'yell'
 
+# Zabbix Monitor
 module Zabbix
 
+  class FileNotFoundError < StandardError; end
+
   class << self
 
     # Call this method to modify defaults in your initializers.
     #
-    # example:
+    # @example
+    #   require 'zabbix'
+    #
+    #   Zabbix.configure do |config|
+    #     config.config_file_path = '/etc/zabbix/zabbix_agentd.conf'
+    #     config.log_file_path = '/var/log/monitor.log' #optional
+    #     config.host_name = 'servername'
+    #     config.mode = :push
+    #     config.rules = [
+    #       {
+    #         :command => 'Monitor.new.test',
+    #         :zabbix_key => 'zabbix.test'
+    #       }
+    #     ]
+    #   end
     #
-    # Zabbix.configure do |config|
-    #   config.config_file_path = '/etc/zabbix/zabbix_agentd.conf'
-    #   config.host_name = 'servername'
-    #   config.mode = :push
-    #   config.rules = [
-    #     {
-    #       :command => 'Monitor.new.test',
-    #       :zabbix_key => 'zabbix.test'
-    #     }
-    #   ]
-    # end
+    # @param [Hash] config variables
     def configure
       yield config
     end
 
+    # @return [Zabbix::Config] creates a new or returns the existing the zabbix-monitor config
     def config
       @config ||= Config.new
     end
+
+    # @return [Yell] creates a new or returns the +Yell+ logger instance
+    def logger
+      @logger ||= Yell.new do |l|
+        l.adapter :datefile, :filename => self.config.log_file_path, :symlink => true
+      end
+    end
   end
-end
+end

data/lib/zabbix/config.rb

@@ -1,23 +1,62 @@
 module Zabbix
 
+  # The +Zabbix::Config+ object used for initializing zabbix-monitor
+  #
+  # @example
+  #   Zabbix.configure do |config|
+  #     config.config_file_path = '/etc/zabbix/zabbix_agentd.conf'
+  #     config.log_file_path = '/var/log/monitor.log' #optional
+  #     config.host_name = 'servername'
+  #     config.mode = :push
+  #     config.rules = [
+  #       {
+  #         :command => 'Monitor.new.test',
+  #         :zabbix_key => 'zabbix.test'
+  #       }
+  #     ]
+  #   end
+  #
   class Config
 
-    attr_accessor :config_file_path, :host_name, :rules, :mode
-
-    # Set the mode to one of :push, :file or :stdout
+    # @return [String] the zabbix agentd config file location
+    attr_accessor :config_file_path
+    # @note
+    #   (optional) Defaults to +./log/#{RACK_ENV}.log+
+    # @return [String] The zabbix-monitor log file location (optional)
+    attr_accessor :log_file_path
+    # @return [String] the zabbix hostname
+    attr_accessor :host_name
+    # @return [Array<Symbol>] the set of rules to monitor
+    attr_accessor :rules
+    # @overload mode
+    #   @return [Symbol] the mode zabbix-monitor uses to process the results of the rules
+    # @overload mode=(value)
+    #   Sets the mode type, so zabbix-monitor knows how to process the results of the rules
     #
-    # Options:
+    #   Options:
+    #     :push uses the Zabbix agent to push the data to the Zabbix server
+    #     :file writes the data to tmp/zabbix-stats.yml
+    #     :stdout writes the data to the stdout
     #
-    #   :push uses the Zabbix agent to push the data to the Zabbix server
-    #   :file writes the data to tmp/zabbix/monitor
-    #   :stdout writes the data to the stdout
+    #   @param value [Symbol] the mode
+    #   @return [Symbol] the new mode
+    #   @raise [StandardError] when a unsupported mode is specified
+    attr_accessor :mode
+
     def mode= value
       allowed_modes = [:push, :file, :stdout].freeze
       if allowed_modes.include?(value)
+        Zabbix.logger.info "[Config] setting mode to '#{value}'"
         @mode = value
       else
+        Zabbix.logger.error "[Config] failed setting mode to '#{value}'"
         raise "Unsupported mode: #{value}"
       end
     end
+
+    def log_file_path
+      @log_file_path || nil
+    end
+
   end
-end
+end

data/lib/zabbix/monitor.rb

@@ -1,25 +1,52 @@
 require 'json'
+require 'yaml'
+require 'fileutils'
+require 'rufus-scheduler'
 
 module Zabbix
 
+  # Base class for processing and delivering the results to an endpoint
   class Monitor
 
+    # Schedule the data collector
+    # @return [void]
+    def schedule
+      Rufus::Scheduler.new.tap do |scheduler|
+        scheduler.every '1m' do
+          ActiveRecord::Base.connection_pool.with_connection do
+            collect_data
+          end
+        end
+      end.join
+    end
+
+    # Loops through all rules and process the result
+    # @return [void]
     def collect_data
+      current_zabbix_rule = nil
       config.rules.each do |rule|
+        current_zabbix_rule = rule
         value = eval rule[:command]
         process_data rule[:zabbix_key], value
       end
     rescue Exception => e
-      puts 'NO GOOD'
-      puts e.message
+      message = "#{current_zabbix_rule[:zabbix_key]} command: #{current_zabbix_rule[:command]} with message: #{e.message}"
+      Zabbix.logger.error "[Monitor] failed collecting data for rule: #{message}"
     end
 
     private
 
+    # @return [Zabbix::Config] the zabbix-monitor config
     def config
       Zabbix.config
     end
 
+    # Process the result for a rule based on the mode specified in the config
+    #
+    # @param key [String] zabbix key
+    # @param value [String] the result from the rule's command
+    #
+    # @return [void]
     def process_data key, value
       case config.mode
       when :push
@@ -28,28 +55,52 @@ module Zabbix
         to_file key, value
       when :stdout
         to_stdout key, value
-      else
-        to_stdout key, value
       end
     end
 
-    # Use zabbix_sender command to send each result to the Zabbix server
+    # Use +zabbix_sender+ command to send each result to the Zabbix server
+    #
+    # @param key [String] zabbix key
+    # @param value [String] the result from the rule's command
+    #
+    # @return [void]
     def to_zabbix key, value
       result = `zabbix_sender -c #{config.config_file_path} -s "#{config.host_name}" -k #{key} -o #{value}`
       case $?.to_i
       when 0 # SUCCESS
-        puts 'GREAT'
+        Zabbix.logger.info "[Monitor] successfully sended rule: '#{key}' to zabbix server: '#{config.host_name}'"
       else
-        puts 'BUMMER'
+        Zabbix.logger.error "[Monitor] failed sending rule: '#{key}' with value: '#{value}' to zabbix server: '#{config.host_name}'"
       end
     end
 
+    # Writes the result to a file
+    #
+    # @param key [String] zabbix key
+    # @param value [String] the result from the rule's command
+    #
+    # @return [void]
     def to_file key, value
-      raise 'Write to file is not implemented yet'
+      filename = 'tmp/zabbix-stats.yml'
+      Dir.mkdir 'tmp' unless Dir.exists? 'tmp'
+      if File.exists? filename
+        yml = YAML::load_file(filename)
+      else
+        yml = {'statistics' => {'created_at' => Time.now.to_i}}
+      end
+      yml['statistics'][key] = value
+
+      File.open(filename, 'w') { |file| file.write yml.to_yaml }
     end
 
+    # Prints the result of the monitored rule to stdout
+    #
+    # @param key [String] zabbix key
+    # @param value [String] the result from the rule's command
+    #
+    # @return [void]
     def to_stdout key, value
       puts "#{key}: #{value}"
     end
   end
-end
+end

data/lib/zabbix/reader.rb

@@ -0,0 +1,23 @@
+require 'yaml'
+
+module Zabbix
+
+  # The +Zabbix::Reader+ object used to get values from the monitor file
+  class Reader
+
+    def initialize
+      filename = 'tmp/zabbix-stats.yml'
+      raise FileNotFoundError, 'Monitoring file not found' if !File.exists?(filename)
+      @file = YAML.load_file(filename)
+    end
+
+    # Get a value from the Zabbix monitor file
+    #
+    # @param key [String] zabbix key
+    #
+    # @return [String] The monitoring value
+    def get_value key
+      @file['statistics'][key]
+    end
+  end
+end

data/spec/config_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe Zabbix::Config do
+
+  let(:logger) { Zabbix.logger }
+  let(:config) { Zabbix::Config.new }
+
+  describe '#mode' do
+    it 'allows setting mode to push' do
+      expect(logger).to receive(:info).with(/setting mode to 'push'/)
+      config.mode = :push
+    end
+    it 'allows setting mode to file' do
+      expect(logger).to receive(:info).with(/setting mode to 'file'/)
+      config.mode = :file
+    end
+    it 'allows setting mode to stdout' do
+      expect(logger).to receive(:info).with(/setting mode to 'stdout'/)
+      config.mode = :stdout
+    end
+    it 'raises an unsupported mode for a invalid mode' do
+      expect(logger).to receive(:error).with(/failed setting mode to 'wrong'/)
+      expect { config.mode = :wrong }
+        .to raise_error(StandardError, 'Unsupported mode: wrong')
+    end
+    it 'raises an unsupported mode for a empty mode' do
+      expect(logger).to receive(:error).with(/failed setting mode to ''/)
+      expect { config.mode = '' }
+        .to raise_error(StandardError, 'Unsupported mode: ')
+    end
+  end
+end

data/spec/monitor_spec.rb

@@ -0,0 +1,154 @@
+require 'spec_helper'
+
+describe Zabbix::Monitor do
+  let(:logger)  { Zabbix.logger }
+  let(:monitor) { Zabbix::Monitor.new }
+  let(:config)  { Zabbix::Config.new }
+
+  before :each do
+    Zabbix.stub(:config) { config }
+  end
+
+  describe "#config" do
+    it 'returns the Zabbix monitor instance config' do
+      monitor.send(:config).should eq config
+    end
+  end
+
+  describe '#schedule' do
+    it 'schedule the data collector to run every minute' do
+      pending 'add scheduler test magic here'
+    end
+  end
+
+  describe "#collect_data" do
+    # 'process data'
+    # 'raise exception invalid rule, invalid command, no command'
+    describe "one rule" do
+      before :each do
+        config.stub(:rules) {[
+          { :command => 'cmd', :zabbix_key => 'some.key' }
+        ]}
+      end
+      it 'executes the command once and passes it to process' do
+        expect(monitor).to receive(:eval).once.and_return("result")
+        expect(monitor).to receive(:process_data).once.with('some.key', 'result')
+        monitor.collect_data
+      end
+      it 'catches the exception if command can not be excuted' do
+        exception = Exception.new("some error description")
+        expect(monitor).to receive(:eval).and_raise(exception)
+        expect(monitor).not_to receive(:process_data)
+        expect(logger).to receive(:error).with(/some.key command: cmd with message: some error description/)
+        monitor.collect_data
+      end
+    end
+    describe "two rules" do
+      before :each do
+        config.stub(:rules) {[
+          { :command => 'cmd', :zabbix_key => 'some.key' },
+          { :command => 'cmd', :zabbix_key => 'another.key' }
+        ]}
+      end
+      it 'executes the command once and passes it to process' do
+        expect(monitor).to receive(:eval).twice.and_return("result")
+        expect(monitor).to receive(:process_data).once.with('some.key', 'result')
+        expect(monitor).to receive(:process_data).once.with('another.key', 'result')
+        monitor.collect_data
+      end
+    end
+  end
+
+  describe "#process_data" do
+    it 'triggers the #to_zabbix for :push' do
+      config.mode = :push
+
+      expect(monitor).to receive(:to_zabbix).once.with(1, 2)
+      monitor.send(:process_data, 1, 2)
+    end
+    it 'triggers the #to_file for :file' do
+      config.mode = :file
+
+      expect(monitor).to receive(:to_file).once.with(1, 2)
+      monitor.send(:process_data, 1, 2)
+    end
+    it 'triggers the #stdout for :stdout' do
+      config.mode = :stdout
+
+      expect(monitor).to receive(:to_stdout).once.with(1, 2)
+      monitor.send(:process_data, 1, 2)
+    end
+  end
+
+  describe "#to_zabbix" do
+    before do
+      config.config_file_path = '/zabbix.conf'
+      config.host_name = 'servername'
+    end
+    it 'executes the zabbix_sender command with the correct arguments' do
+      expect(monitor).to receive(:'`').once.with('zabbix_sender -c /zabbix.conf -s "servername" -k key -o value')
+      monitor.stub(:puts) {}
+      monitor.send(:to_zabbix, 'key', 'value')
+    end
+    it 'outputs GREAT if the command is executed without errors' do
+      monitor.stub(:'`') { `(exit 0)` }
+      expect(logger).to receive(:info).with(/successfully sended rule: 'key' to zabbix server: 'servername'/)
+      monitor.send(:to_zabbix, 'key', 'value')
+    end
+    it 'outputs BUMMER if the command is executed with an error' do
+      monitor.stub(:'`') { `(exit -1)` }
+      expect(logger).to receive(:error).with(/failed sending rule: 'key' with value: 'value' to zabbix server: 'servername'/)
+      monitor.send(:to_zabbix, 'key', 'value')
+    end
+  end
+
+  describe "#to_file" do
+    before :each do
+      File.stub(:exists?) { false }
+      File.stub(:open).with('tmp/zabbix-stats.yml', 'w')
+    end
+    it 'creates the tmp folder if it does not exist' do
+      expect(Dir).to receive(:mkdir).once.with('tmp')
+      expect(Dir).to receive(:exists?).once.with('tmp').and_return(false)
+      monitor.send(:to_file, 'key', 'value')
+    end
+    it 'will not create the tmp folder if it already exists' do
+      expect(Dir).not_to receive(:mkdir).with('tmp')
+      expect(Dir).to receive(:exists?).once.with('tmp').and_return(true)
+      monitor.send(:to_file, 'key', 'value')
+    end
+    before :each do
+      Dir.stub(:exists?) { true }
+    end
+    describe 'writeing and reading' do
+      it 'writes the result to "tmp/zabbix-stats.yml"' do
+        File.stub(:exists?) { false }
+        file = double('file')
+        yml = {'statistics' => {'created_at' => Time.now.to_i, 'key' => 'value'}}
+
+        expect(File).to receive(:open).with('tmp/zabbix-stats.yml', 'w').and_yield(file)
+        expect(file).to receive(:write).with(yml.to_yaml)
+        monitor.send(:to_file, 'key', 'value')
+      end
+      it 'adds the key and value to the output file if it already exists' do
+        File.stub(:exists?) { true }
+        file = double('file')
+        yml = {'statistics' => {'created_at' => Time.now.to_i, 'old_key' => 'old_value'}}
+
+        expect(YAML).to receive(:load_file).once.with('tmp/zabbix-stats.yml').and_return(yml)
+        expect(File).to receive(:open).with('tmp/zabbix-stats.yml', 'w').and_yield(file)
+
+        yml['statistics']['key'] = 'value'
+        expect(file).to receive(:write).with(yml.to_yaml)
+        monitor.send(:to_file, 'key', 'value')
+      end
+    end
+  end
+
+  describe "#to_stdout" do
+    it 'receives the key and value as a puts command' do
+      expect(monitor).to receive(:puts).with('key: the value')
+      monitor.send(:to_stdout, 'key', 'the value')
+    end
+  end
+end

data/spec/reader_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe Zabbix::Reader do
+
+  before :each do
+    @filename = 'tmp/zabbix-stats.yml'
+    # File.open(@filename, 'w') { |file| file.write({'statistics' => {'test' => 'OK'}}.to_yaml) } unless File.exists?(@filename)
+  end
+
+  describe 'initialize' do
+    it 'raises an error when the file can\'t be found' do
+      expect(File).to receive(:exists?).with(@filename).and_return(false)
+      expect{ Zabbix::Reader.new }.to raise_error(Zabbix::FileNotFoundError, 'Monitoring file not found')
+    end
+
+    it 'reads the monitoring file from tmp' do
+      expect(File).to receive(:exists?).with(@filename).and_return(true)
+      expect(YAML).to receive(:load_file).with(@filename)
+      Zabbix::Reader.new
+    end
+  end
+
+  describe 'get_value' do
+    before :each do
+      File.stub(:exists?) { true }
+      YAML.stub(:load_file) { {'statistics' => {'test' => 'OK'}} }
+    end
+    let(:reader) { Zabbix::Reader.new }
+
+    it 'returns the requested value' do
+      expect(reader.get_value 'test').to eq('OK')
+    end
+
+    it 'returns nil when the key can\'t be found' do
+      expect(reader.get_value 'missing').to be_nil
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,18 @@
+require 'pry'
+require 'simplecov'
+
+SimpleCov.start do
+  add_filter '/spec/'
+end
+
+require 'zabbix'
+
+RSpec.configure do |config|
+  # configure yell logger's ENV and remove the logs files afterwards
+  ENV['YELL_ENV'] = 'test'
+
+  config.before :each do
+    log_path = File.expand_path("../log", File.dirname(__FILE__))
+    Dir[log_path + "/test*.log" ].each { |f| File.delete f }
+  end
+end

data/spec/zabbix_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe Zabbix do
+  before :each do
+    # reset config
+    Zabbix.send(:config) { nil }
+  end
+
+  describe "#configure" do
+    describe "basic config vars and behaviour" do
+
+      it 'creates a new config for the Zabbix monitor instance' do
+        Zabbix.config.should be_kind_of(Zabbix::Config)
+      end
+      it 'set the correct config values' do
+        Zabbix.configure do |config|
+          config.config_file_path = '/etc/zabbix/zabbix_agentd.conf'
+          config.host_name = 'servername'
+          config.mode = :push
+        end
+
+        Zabbix.config.config_file_path.should eq '/etc/zabbix/zabbix_agentd.conf'
+        Zabbix.config.log_file_path.should be_nil
+        Zabbix.config.host_name.should eq 'servername'
+        Zabbix.config.mode.should eq :push
+        pending 'should rules be initialized as an empty array?'
+        Zabbix.config.rules.count.should eq 0
+      end
+      it 'returns the correct log_file_path if specified' do
+        Zabbix.configure do |config|
+          config.log_file_path = '/var/log/monitor.log'
+        end
+        Zabbix.config.log_file_path.should eq '/var/log/monitor.log'
+      end
+    end
+
+    describe "rules" do
+      it 'has one rule' do
+        rule = { :command => 'a', :zabbix_key => 'a' }
+        Zabbix.configure do |config|
+          config.rules = [rule]
+        end
+        Zabbix.config.rules.should eq [rule]
+      end
+      it 'has two rules' do
+        ruleA = { :command => 'a', :zabbix_key => 'a' }
+        ruleB = { :command => 'b', :zabbix_key => 'b' }
+        Zabbix.configure do |config|
+          config.rules = [ruleA, ruleB]
+        end
+        Zabbix.config.rules.should eq [ruleA, ruleB]
+      end
+      it 'validates if the format of a rule from config is valid' do
+        pending 'todo'
+      end
+    end
+  end
+end

data/zabbix-monitor.gemspec

@@ -4,21 +4,27 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'zabbix-monitor'
-  spec.version       = '0.0.1'
-  spec.authors       = ['Robert Jan de Gelder']
-  spec.email         = ['r.degelder@sping.nl']
+  spec.version       = '0.0.2'
+  spec.authors       = ['Robert Jan de Gelder', 'Manuel van Rijn']
+  spec.email         = ['r.degelder@sping.nl', 'm.vanrijn@sping.nl']
   spec.description   = 'Zabbix application monitoring'
   spec.summary       = 'Let the Zabbix agent read your application monitoring'
   spec.homepage      = 'http://rubygems.org/gems/zabbix-monitor'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
-  # spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  # spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rufus-scheduler'
+  spec.add_dependency 'rufus-scheduler', '~> 3.0'
+  spec.add_dependency 'yell', '~> 2.0'
 
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rspec', '~> 2.14'
+  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'pry-nav'
+  spec.add_development_dependency 'yard'
+  spec.add_development_dependency 'simplecov'
 end

metadata

@@ -1,29 +1,44 @@
 --- !ruby/object:Gem::Specification
 name: zabbix-monitor
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Robert Jan de Gelder
+- Manuel van Rijn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-17 00:00:00.000000000 Z
+date: 2014-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rufus-scheduler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: yell
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -52,23 +67,106 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-nav
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Zabbix application monitoring
 email:
 - r.degelder@sping.nl
-executables: []
+- m.vanrijn@sping.nl
+executables:
+- zabbix_reader
 extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
+- .yardopts
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- TODO.md
+- bin/zabbix_reader
 - lib/tasks/zabbix.rb
 - lib/zabbix.rb
 - lib/zabbix/config.rb
 - lib/zabbix/monitor.rb
-- lib/zabbix/tasks.rb
+- lib/zabbix/reader.rb
+- log/.gitkeep
+- spec/config_spec.rb
+- spec/monitor_spec.rb
+- spec/reader_spec.rb
+- spec/spec_helper.rb
+- spec/zabbix_spec.rb
 - zabbix-monitor.gemspec
 homepage: http://rubygems.org/gems/zabbix-monitor
 licenses:
@@ -94,4 +192,10 @@ rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Let the Zabbix agent read your application monitoring
-test_files: []
+test_files:
+- spec/config_spec.rb
+- spec/monitor_spec.rb
+- spec/reader_spec.rb
+- spec/spec_helper.rb
+- spec/zabbix_spec.rb
+has_rdoc: 

data/lib/zabbix/tasks.rb

@@ -1 +0,0 @@
-require 'tasks/zabbix'