yt 0.5.5 → 0.5.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2c609731e55cd81b71dfbc3f53f47147dac54b51
-  data.tar.gz: 0993daf654fda172520af7d6d01e8620ff66fbf6
+  metadata.gz: 29f2a9daff36933af1c9fafa394009a4660697cd
+  data.tar.gz: b9cb80c044040fc195eac01bad264d1fb65fea69
 SHA512:
-  metadata.gz: 60d5bf311041934ec83bd36cfff50905d04e3ef8444f90e8be39ad3249da24618ef308bdee47688785a5bdc8d8024d91dc2a253a44d3cf204d331e6209eb66cb
-  data.tar.gz: fea7bc7fb323a51c21be93a0108e8d3350f808c8a4bb56cc956d2db5d4cf8c720fe6bdb8e492f39f65337d76d8843edf9898cd2464f9d354adc9ca089d0a834b
+  metadata.gz: 02a7be4f86dd4fe2801edf57ffa79f05a2b16321d3d3e5a7043893b3eb40d81bf4173049de53443bd816fe5cdf177b64f5e9150140a1b25d4f30bb5ee3523f24
+  data.tar.gz: d9a7005315e12337e16d89e19f8112d3b484594d984fdd7315f6fb5a3c34193f21ed1758fd9bf65487a2c849422b0763abc4b5b50406f3e733344b59c6561c5c

data/.travis.yml

@@ -6,13 +6,13 @@ matrix:
   - rvm: 1.9.3
     gemfile: gemfiles/Gemfile.activesupport-3.x
     env:
-    - secure: MRWnEbchfgv+FLXLDzkc5rqqiZ/fE/9zQVYRUlTtwHYWKRacl45RDzv0ns7avz/tGGyL/3CMQabOvRiErhN5FWoaRdQV3kBl+gAgSvV910dC+gb/dEpTxU8KGRFLBOFG5oT2WF9eTDjUOxNRiR0jEw/+wD/FltxHEuoc5EixdSI=
+    - secure: Z93M7+GBYG8A7Dsjwcsgj/8AmdJ5X2KezBk9qelw89/OtAqIp1zMNQehTEg24p/NygkNjnGycb3DQuW++31v4c+mt5/MgDDhd2jXJ4+js+3gAMAIpiMtPJfEOvmKxLbC0uMaQhXLn7dGMnn8ed7hh6Zu/8P+17qZvVeI0thI3Dg=
   - rvm: 2.0.0
     gemfile: gemfiles/Gemfile.activesupport-4.x
     env:
-    - secure: fxPlgZJcWnJZcsQYfLm5EQI4kt9Ohikwi5YugcU+daT43ZacrK0MWAnPhYBXnwNbfsot1udSFnN8DADxbL6/0DxVGVVuQUB4hT59kh8im58Rfim6uCDbgsPLeCzMrWuE2Mj+SBcwVlJ2i0zWqFv6nz4TCi007E/4BOLjjmTsOSo=
+    - secure: eIxGZcTZFVMxn0cxjaknhflAR78L6q+Q2G6jCXnFxqj8ARfgAS1F8v7ErkGaJ9h6dxfsH+5evhj4ZUc/gvHaqs8jcT9CVGUZsC7jpZz3gkfQ9k7Tm3sTnSfv4HbqGM8OkCJkLNOUQypmGr+mkPQskroNPhm6WT9Ml1vGq1RSTow=
 env:
   global:
-  - secure: QEKPYkbA9ejUZTYz4p8xWMKqZ+2KpiKa2c6eu79ISQcGsp3gRvnvAzEVByVxrr+K7Igtj/jeRUE8xXMDh6d6wCcguNkTy9BVNevlo12qESpM8oP0iEmnQJL0TtYWEvqivJMg/FSXOaRj4kifB1sfTQjJLdTKVMM52r5qR9K60bs=
-  - secure: DznIfIfJN5c0lad7FPf8TVqbMDFFajcDyWPDA55KtlDgpMrjgmLh7z1ZEhQMLvu+HAdvnxx7jEiroeMCT724hXS3ex4MsQnn9fohuM4bsjeqxgxCtdL3urFGBwGx3wMmisY3Jn+5WEQkeqrfMgnUGIyXMp8K1VvjJ6r4GrW6yEk=
-  - secure: NeI3iyIAY3ZKAQ+AGo8+uFxdaMmf9zYkVDJMbHsXZLkHxsF1UAMnFic8EEsktfx+zobykQFarwBFeN7LtEvMjpIHeL0caKas0NiUmvnXjCh7CfK9lqY1rjZSYuNSA8uSR1Bl7GOxBjQD8xtRoUdaYAF8MLPVtEs76l0tSVwHQ6Q=
+  - secure: ApPj5c9h6xk+AbHHf4KXL10QnleYCWwcp2+qMFolrS6RWR5vhrnKq1UBo0h59HuvXeOQIgZ/GmocuSEZovS9c1hQP3n0PHSNEnGUNJyn6CS3BiPQSWmC3p2pONo1Xv+hVWfzDoEv80b82GX5P5x/l1BSqhpxLA9geITJprWsoLg=
+  - secure: CkLyqIq/yTV5h/41b0wxIhMN0LvTk51IBht1+l678YSK7zT9emo9DcwnZVQ9f9KluDD8SyUGRORD40eQs8XmqpDCx7gj7i5e3TEVBofM9YnyFMR1lsWRiMr8jf2eksuP10kEkV7S7E1KH4LI2K1ZcOVqfN0G3Vs0C5D8GwpEcQ8=
+  - secure: XzuEz0AV6eDeT3+VaodXRMOh+fDvtG1X/VDfnh3f3gmVsnW1d8gdZY9Gw9rkSixK0SwL58BcSu+SU9BlDAsa0asv2XF8h51Q7s3x0ld9I60ssV/4DXSXqicHYcq13Vd86JMmURUuLiJM3y5lXb0bMGXNOkgYZ19gd5X9No+Tkww=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    yt (0.5.5)
+    yt (0.5.6)
       activesupport
 
 GEM

data/HISTORY.md

@@ -10,6 +10,7 @@ v0.5 - 2014/05/16
 * Move models in Yt::Models but still auto-include them in the main namespace
 * New Authentication model to separate `access_token` and `refresh_token` from Account
 * New types of Errors that render more verbose errors and the failing request in cURL syntax
+* Separate Error class for 500 error, so they can be easily found in app logs
 
 v0.4 - 2014/05/09
 --------------------

data/README.md

@@ -300,7 +300,7 @@ To install on your system, run
 
 To use inside a bundled Ruby project, add this line to the Gemfile:
 
-    gem 'yt', '~> 0.5.5'
+    gem 'yt', '~> 0.5.6'
 
 Since the gem follows [Semantic Versioning](http://semver.org),
 indicating the full version in your Gemfile (~> *major*.*minor*.*patch*)

data/lib/yt/errors/server_error.rb

@@ -0,0 +1,13 @@
+require 'yt/errors/request_error'
+
+module Yt
+  module Errors
+    class ServerError < RequestError
+      private
+
+      def explanation
+        'A request to YouTube API caused an unexpected server error'
+      end
+    end
+  end
+end

data/lib/yt/models/request.rb

@@ -6,6 +6,7 @@ require 'active_support/core_ext' # for Hash.from_xml, Hash.to_param
 require 'yt/config'
 require 'yt/errors/missing_auth'
 require 'yt/errors/request_error'
+require 'yt/errors/server_error'
 
 module Yt
   module Models
@@ -27,10 +28,12 @@ module Yt
         case response
         when @expected_response
           response.tap{|response| response.body = parse_format response.body}
+        when Net::HTTPServerError
+          raise Errors::ServerError, request_error_message
         when Net::HTTPUnauthorized
           raise Errors::MissingAuth, request_error_message
         else
-          raise Yt::Error, request_error_message
+          raise Errors::RequestError, request_error_message
         end
       end
 

data/lib/yt/version.rb

@@ -1,3 +1,3 @@
 module Yt
-  VERSION = '0.5.5'
+  VERSION = '0.5.6'
 end

data/spec/associations/device_auth/subscriptions_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 require 'yt/models/channel'
 
-# NOTE: This test is slow because we *must* wait for some seconds between
-# subscribing and unsubscribing to a channel, otherwise YouTube will show
-# wrong (cached) data, such as a user is subscribed when he is not.
 describe Yt::Associations::Subscriptions, :device_app do
   describe '#subscription' do
+    # NOTE: These tests are slow because we *must* wait some seconds between
+    # subscribing and unsubscribing to a channel, otherwise YouTube will show
+    # wrong (cached) data, such as a user is subscribed when he is not.
     context 'given an existing channel' do
       let(:channel) { Yt::Channel.new id: 'UCxO1tY8h1AhOz0T4ENwmpow', auth: $account }
 
@@ -21,5 +21,15 @@ describe Yt::Associations::Subscriptions, :device_app do
         it { expect(channel.unsubscribe!).to be_true }
       end
     end
+
+    # NOTE: This test is just a reflection of YouTube irrational behavior of
+    # raising a 500 error when you try to subscribe to your own channel, rather
+    # than a more logical 4xx error. Hopefully this will get fixed and this
+    # test removed.
+    context 'given my own channel' do
+      let(:channel) { Yt::Channel.new id: $account.channel.id, auth: $account }
+
+      it { expect{channel.subscribe}.to raise_error Yt::Errors::ServerError }
+    end
   end
 end

data/spec/models/request_spec.rb

@@ -4,19 +4,27 @@ require 'yt/models/request'
 describe Yt::Request do
   subject(:request) { Yt::Request.new attrs }
   let(:attrs) { {host: 'example.com'} }
+  before { Net::HTTP.stub(:start).and_return response }
+  before { response.stub(:body) }
 
   describe '#run' do
+    context 'given a request that returns a 500 code' do
+      let(:response) { Net::HTTPServerError.new nil, nil, nil }
+      it { expect{request.run}.to fail }
+    end
+
+    context 'given a request that returns a 401 code' do
+      let(:response) { Net::HTTPUnauthorized.new nil, nil, nil }
+      it { expect{request.run}.to fail }
+    end
+
     context 'given a request that returns a non-2XX code' do
-      let(:not_found) { Net::HTTPNotFound.new nil, nil, nil }
-      before { Net::HTTP.stub(:start).and_return not_found }
-      before { not_found.stub(:body) }
+      let(:response) { Net::HTTPNotFound.new nil, nil, nil }
       it { expect{request.run}.to fail }
     end
 
     context 'given a request that returns a 2XX code' do
-      let(:ok) { Net::HTTPOK.new nil, nil, nil }
-      before { Net::HTTP.stub(:start).and_return ok }
-      before { ok.stub(:body) }
+      let(:response) { Net::HTTPOK.new nil, nil, nil }
       it { expect{request.run}.not_to fail }
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yt
 version: !ruby/object:Gem::Version
-  version: 0.5.5
+  version: 0.5.6
 platform: ruby
 authors:
 - Claudio Baccigalupo
@@ -153,6 +153,7 @@ files:
 - lib/yt/errors/missing_auth.rb
 - lib/yt/errors/no_items.rb
 - lib/yt/errors/request_error.rb
+- lib/yt/errors/server_error.rb
 - lib/yt/models/account.rb
 - lib/yt/models/annotation.rb
 - lib/yt/models/authentication.rb