yt 0.11.4 → 0.11.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d4252625265d920e49c56abd24211d37be9881ba
-  data.tar.gz: 620dceb9f5722aa8108a06dcc5bc665386a3d1ee
+  metadata.gz: 42014f27313df641d183c3372c321750d4286503
+  data.tar.gz: fdfcb6df1b63ed5943f50292111c43279c3e8cbd
 SHA512:
-  metadata.gz: 529db7f3f2bc51ccbabd6a42c320406b87f1320877fe182b04f86d087febc406d65fcd9baa16def7dcfd49997cf6394f149634b26d8dcd9172cf19f71b45363e
-  data.tar.gz: c6357576d740ca80c940392f6794f739715703a660bdc9a1987ea90a68b8ce7d5ef47013ea63e0d85af5175be69684d88bd28ddb6c90da1bca2a822a197b7868
+  metadata.gz: bb5e31dcea230569c121333be4829eb24c964224c88e60ba506fbbe7aadc2aae4019be292a944135da2b07e0fa89d2e36306adcc5f853685d4d0c83612901163
+  data.tar.gz: 34df50c4d27f24824605e49e8a9305b8efdbe290b94aab35f31ff5f254f979ed5edac78ec266fdae61ebec4a0333226882e6185ec68443f1206c60db0eb41db2

data/CHANGELOG.md

@@ -6,6 +6,10 @@ For more information about changelogs, check
 [Keep a Changelog](http://keepachangelog.com) and
 [Vandamme](http://tech-angels.github.io/vandamme).
 
+## 0.11.5 - 2014-08-27
+
+* [BUGFIX] Make videos.where(id: 'MESycYJytkU').first.id return 'MESycYJytkU'
+
 ## 0.11.4 - 2014-08-27
 
 * [ENHANCEMENT] Add Video search even by id, chart or rating

data/README.md

@@ -41,7 +41,7 @@ To install on your system, run
 
 To use inside a bundled Ruby project, add this line to the Gemfile:
 
-    gem 'yt', '~> 0.11.4'
+    gem 'yt', '~> 0.11.5'
 
 Since the gem follows [Semantic Versioning](http://semver.org),
 indicating the full version in your Gemfile (~> *major*.*minor*.*patch*)

data/lib/yt/collections/videos.rb

@@ -12,8 +12,9 @@ module Yt
     private
 
       def attributes_for_new_item(data)
+        id = use_list_endpoint? ? data['id'] : data['id']['videoId']
         snippet = data.fetch('snippet', {}).merge includes_tags: false
-        {id: data['id']['videoId'], snippet: snippet, auth: @auth}
+        {id: id, snippet: snippet, auth: @auth}
       end
 
       # @return [Hash] the parameters to submit to YouTube to list videos.
@@ -52,17 +53,20 @@ module Yt
         end
       end
 
+      def videos_path
+        use_list_endpoint? ? '/youtube/v3/videos' : '/youtube/v3/search'
+      end
+
       # @private
+      # YouTube API provides two different endpoints to get a list of videos:
+      # /videos should be used when the query specifies video IDs or a chart,
+      # /search otherwise.
+      # @return [Boolean] whether to use the /videos endpoint.
       # @todo: This is one of two places outside of base.rb where @where_params
       #   is accessed; it should be replaced with a filter on params instead.
-      # @see https://developers.google.com/youtube/v3/docs/videos/list
-      def videos_path
+      def use_list_endpoint?
         @where_params ||= {}
-        if @parent.nil? && (@where_params.keys & [:id, :chart]).any?
-          '/youtube/v3/videos'
-        else
-          '/youtube/v3/search'
-        end
+        @parent.nil? && (@where_params.keys & [:id, :chart]).any?
       end
     end
   end

data/lib/yt/models/video.rb

@@ -76,7 +76,9 @@ module Yt
       # @return [Array<Yt::Models::Tag>] the list of keyword tags associated
       #   with the video.
       def tags
-        @snippet = nil unless snippet.includes_tags
+        unless snippet.tags.any? || snippet.includes_tags || @auth.nil?
+          @snippet = nil
+        end
         snippet.tags
       end
 

data/lib/yt/version.rb

@@ -1,3 +1,3 @@
 module Yt
-  VERSION = '0.11.4'
+  VERSION = '0.11.5'
 end

data/spec/requests/as_server_app/videos_spec.rb

@@ -13,8 +13,12 @@ describe Yt::Collections::Videos, :server_app do
     expect(videos.where(q: 'Fullscreen CreatorPlatform', video_duration: :long).size).to be < 100_000
   end
 
-  specify 'with a list of video IDs, only returns the videos matching those IDs' do
-    expect(videos.where(id: 'MESycYJytkU,invalid').size).to be 1
+  context 'with a list of video IDs, only returns the videos matching those IDs' do
+    let(:video_id) { 'MESycYJytkU' }
+    let(:videos_by_id) { videos.where id: "#{video_id},invalid" }
+
+    it { expect(videos_by_id.size).to be 1 }
+    it { expect(videos_by_id.first.id).to eq video_id }
   end
 
   specify 'with a chart parameter, only returns videos of that chart', :ruby2 do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yt
 version: !ruby/object:Gem::Version
-  version: 0.11.4
+  version: 0.11.5
 platform: ruby
 authors:
 - Claudio Baccigalupo