yrb-lite 0.1.0.beta7 → 0.1.0.beta9
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG.md +0 -132
- data/README.md +50 -67
- data/ext/yrb_lite/src/lib.rs +44 -350
- data/ext/yrb_lite/src/protocol.rs +4 -3
- data/lib/yrb_lite/version.rb +1 -1
- metadata +1 -1
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: 8d834b5052572c1d84374702a2c45963522725abf47eaaefd62acc934b75a4fe
|
|
4
|
+
data.tar.gz: 025f4e5ae96c0fd3c9af6e43e2ddd16c4bc22cb34b95b17ad70f8ff74283557b
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: 73e9cd5d0bf9ffbf3c729f54390731376dd443d1f59fa597917c926f3c6326089903ab7b9c67a2dc037de343368d6f1f045f937fae99a2c01d430500fd0f6fe5
|
|
7
|
+
data.tar.gz: 67ad34f34202019617905d035e6cfb91f3693534eebed93d3fbb612b1e410bc75803f4bc2c311bedff076bed15c3718a4100153e3b42ae1de74e9cae0d7f73a5
|
data/CHANGELOG.md
CHANGED
|
@@ -5,135 +5,3 @@ All notable changes to this project are documented here. The format is based on
|
|
|
5
5
|
to follow [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|
6
6
|
|
|
7
7
|
## [Unreleased]
|
|
8
|
-
|
|
9
|
-
## [0.1.0.beta6] - 2026-06-22
|
|
10
|
-
|
|
11
|
-
(yrb-lite core gem. The `yrb-lite-client` npm package ships these client changes as 0.1.2.)
|
|
12
|
-
|
|
13
|
-
### Added
|
|
14
|
-
|
|
15
|
-
- `yrb-lite-client`, the TypeScript client package for the yrb-lite
|
|
16
|
-
ActionCable/AnyCable protocol. It provides `ActionCableProvider`,
|
|
17
|
-
`YProtocolSession`, and the standalone `ReliableSync` delivery core.
|
|
18
|
-
|
|
19
|
-
### Changed
|
|
20
|
-
|
|
21
|
-
- Document delivery is ack-tracked by default in `yrb-lite-client`: document
|
|
22
|
-
frames use `{ update, id }`, acknowledgements use `{ ack }`, and pending
|
|
23
|
-
document updates stay queued until acked.
|
|
24
|
-
- The ActionCable protocol surface uses a single canonical document envelope:
|
|
25
|
-
`{ "update" => "<base64 frame>" }`.
|
|
26
|
-
- AnyCable awareness/presence uses an awareness-only whisper envelope,
|
|
27
|
-
`{ awareness: "<base64 awareness frame>" }`, while document frames stay on
|
|
28
|
-
the server persistence/ack path.
|
|
29
|
-
|
|
30
|
-
### Fixed
|
|
31
|
-
|
|
32
|
-
- Incoming protocol frames are validated before mutating documents or awareness
|
|
33
|
-
state, including trailing-byte rejection on the TypeScript client.
|
|
34
|
-
- Native/Rust protocol entry points reject wire client IDs that are unsafe for
|
|
35
|
-
JavaScript clients.
|
|
36
|
-
- `lib0` is declared as a direct runtime dependency of `yrb-lite-client`.
|
|
37
|
-
|
|
38
|
-
## [0.1.0.beta5] - 2026-06-18
|
|
39
|
-
|
|
40
|
-
### Changed
|
|
41
|
-
|
|
42
|
-
- **Breaking:** the ActionCable integration has been extracted into a separate
|
|
43
|
-
gem, [`yrb-lite-actioncable`](https://rubygems.org/gems/yrb-lite-actioncable).
|
|
44
|
-
`yrb-lite` is now a standalone y-crdt wrapper: CRDT documents, awareness, and
|
|
45
|
-
the y-websocket sync protocol primitives, with no Rails/ActionCable coupling
|
|
46
|
-
(mirrors the `y-rb` / `yrb-actioncable` split). The `base64` runtime
|
|
47
|
-
dependency moved with it.
|
|
48
|
-
|
|
49
|
-
### Migration
|
|
50
|
-
|
|
51
|
-
- Using `YrbLite::Sync`? Add `gem "yrb-lite-actioncable"` and change
|
|
52
|
-
`include YrbLite::Sync` to `include YrbLite::ActionCable::Sync`. The concern's
|
|
53
|
-
API is otherwise unchanged. If you only use `YrbLite::Doc`/`YrbLite::Awareness`,
|
|
54
|
-
nothing changes.
|
|
55
|
-
|
|
56
|
-
## [0.1.0.beta4] - 2026-06-18
|
|
57
|
-
|
|
58
|
-
### Changed
|
|
59
|
-
|
|
60
|
-
- `on_change` block recorders now run in the **channel instance's context**
|
|
61
|
-
(via `instance_exec`), so a recorder can call the channel's own methods --
|
|
62
|
-
`current_user`, `params`, request/connection-scoped accessors -- directly,
|
|
63
|
-
instead of plumbing them in through a thread-local. A non-Proc callable (an
|
|
64
|
-
object responding to `#call`) is still invoked with `#call` and its own
|
|
65
|
-
context. Existing block recorders that use
|
|
66
|
-
only the `(key, update)` arguments and lexically-scoped constants are
|
|
67
|
-
unaffected; the only behavioral change is `self` inside the block.
|
|
68
|
-
|
|
69
|
-
## [0.1.0.beta3] - 2026-06-18
|
|
70
|
-
|
|
71
|
-
### Changed
|
|
72
|
-
|
|
73
|
-
- Upgraded the bundled `yrs` (y-crdt) from 0.21 to 0.27.2. No change to the
|
|
74
|
-
`YrbLite::Doc`, `YrbLite::Awareness`, or `YrbLite::Sync` public API; existing
|
|
75
|
-
code and the wire protocol are unaffected.
|
|
76
|
-
- Thread-safety is preserved across the upgrade. yrs 0.27 dropped `Awareness`'s
|
|
77
|
-
internal locking (its mutating methods now take `&mut self`, and `Awareness`
|
|
78
|
-
is no longer `Sync`), so `YrbLite::Awareness` now serializes access through an
|
|
79
|
-
internal `Mutex`. The lock is taken only while the GVL is released and is
|
|
80
|
-
never held across the GVL boundary, so concurrent access from multiple Ruby
|
|
81
|
-
threads stays safe and deadlock-free, and document reads still run in parallel
|
|
82
|
-
(they operate on a cheaply-cloned, `Arc`-backed `Doc` handle, not under the
|
|
83
|
-
presence lock).
|
|
84
|
-
|
|
85
|
-
### Build
|
|
86
|
-
|
|
87
|
-
- Building the gem from source now requires **Rust 1.94 or newer** (yrs 0.27.2
|
|
88
|
-
uses `let`-chains). The precompiled platform gems are unaffected -- they need
|
|
89
|
-
no Rust toolchain to install.
|
|
90
|
-
|
|
91
|
-
## [0.1.0.beta2] - 2026-06-16
|
|
92
|
-
|
|
93
|
-
### Added
|
|
94
|
-
|
|
95
|
-
- Reliable delivery (opt-in, client-driven). A client may tag a document update
|
|
96
|
-
with an `"id"`; the server replies `{ "ack": <id> }` once the update has been
|
|
97
|
-
durably recorded. This lets an
|
|
98
|
-
ack-aware client retain and retransmit an update until delivery is confirmed,
|
|
99
|
-
so an edit can't be silently lost on a flaky connection. Clients that omit
|
|
100
|
-
`"id"` are still accepted, but their delivery is not ack-tracked.
|
|
101
|
-
- Demo coverage for reliable delivery with "sync-since-last-ack" framing (the
|
|
102
|
-
unacknowledged tail is sent as one merged, causally-complete delta), plus a
|
|
103
|
-
minimal reference client and an intensive message-loss stress test.
|
|
104
|
-
|
|
105
|
-
### Fixed
|
|
106
|
-
|
|
107
|
-
- Causal-gap protection. The authoritative, fast, and store paths now reject a
|
|
108
|
-
document update that isn't causally ready -- one whose dependencies are
|
|
109
|
-
missing because an earlier update was lost in transit or its durable record
|
|
110
|
-
failed -- and ask the client to resync, instead of recording or relaying an
|
|
111
|
-
un-integrable update that would leave the log permanently pending. Adds native
|
|
112
|
-
`Doc#update_ready?`/`#pending?` (cheap, read-only checks) used to gate the
|
|
113
|
-
record-before-distribute path.
|
|
114
|
-
|
|
115
|
-
## [0.1.0.beta1]
|
|
116
|
-
|
|
117
|
-
### Added
|
|
118
|
-
|
|
119
|
-
- Thread-safe `YrbLite::Doc` and `YrbLite::Awareness` over `yrs` (magnus/rb-sys
|
|
120
|
-
native extension). The GVL is released during CRDT work so docs can run in
|
|
121
|
-
parallel on MRI.
|
|
122
|
-
- `YrbLite::Sync` ActionCable channel concern implementing the y-websocket
|
|
123
|
-
protocol (document sync plus awareness/presence).
|
|
124
|
-
- A "record-before-distribute" mode via an `on_change` hook, so every change is
|
|
125
|
-
recorded durably before it's applied or relayed.
|
|
126
|
-
- Presence cleanup on disconnect, and idle-document eviction.
|
|
127
|
-
- Store-backed ActionCable delivery for AnyCable and multi-process use.
|
|
128
|
-
- Hardening against bad input: malformed or multi-message frames are dropped
|
|
129
|
-
before processing or relay, and native panics are contained at the FFI
|
|
130
|
-
boundary.
|
|
131
|
-
- Precompiled native gems for common platforms (no Rust toolchain needed to
|
|
132
|
-
install) via the cross-gem workflow.
|
|
133
|
-
|
|
134
|
-
[Unreleased]: https://github.com/jpcamara/yrb-lite/compare/v0.1.0.beta5...main
|
|
135
|
-
[0.1.0.beta5]: https://github.com/jpcamara/yrb-lite/compare/v0.1.0.beta4...v0.1.0.beta5
|
|
136
|
-
[0.1.0.beta4]: https://github.com/jpcamara/yrb-lite/compare/v0.1.0.beta3...v0.1.0.beta4
|
|
137
|
-
[0.1.0.beta3]: https://github.com/jpcamara/yrb-lite/compare/v0.1.0.beta2...v0.1.0.beta3
|
|
138
|
-
[0.1.0.beta2]: https://github.com/jpcamara/yrb-lite/compare/v0.1.0.beta1...v0.1.0.beta2
|
|
139
|
-
[0.1.0.beta1]: https://github.com/jpcamara/yrb-lite/releases/tag/v0.1.0.beta1
|
data/README.md
CHANGED
|
@@ -19,12 +19,12 @@ end
|
|
|
19
19
|
|
|
20
20
|
On the browser, use the `yrb-lite-client` `ActionCableProvider`. Tiptap,
|
|
21
21
|
ProseMirror, and BlockNote all sync through the `Y.Doc` you pass in and the
|
|
22
|
-
provider's Awareness instance
|
|
22
|
+
provider's Awareness instance.
|
|
23
23
|
|
|
24
24
|
## What you get
|
|
25
25
|
|
|
26
|
-
-
|
|
27
|
-
|
|
26
|
+
- A thread-safe Ruby `Doc` you can share across Puma threads; native CRDT work
|
|
27
|
+
runs with the GVL released.
|
|
28
28
|
- The y-websocket protocol (document sync plus awareness/presence) as a
|
|
29
29
|
one-include ActionCable concern.
|
|
30
30
|
- Store-backed ActionCable/AnyCable delivery for multi-process deployments.
|
|
@@ -86,11 +86,7 @@ require "yrb_lite"
|
|
|
86
86
|
|
|
87
87
|
# Create docs
|
|
88
88
|
doc = YrbLite::Doc.new # random client ID
|
|
89
|
-
doc = YrbLite::Doc.new(12345) # specific client ID
|
|
90
|
-
|
|
91
|
-
# Get document info
|
|
92
|
-
doc.client_id # => unique client identifier
|
|
93
|
-
doc.guid # => document GUID
|
|
89
|
+
doc = YrbLite::Doc.new(12345) # specific client ID (used for CRDT identity)
|
|
94
90
|
|
|
95
91
|
# Encoding
|
|
96
92
|
doc.encode_state_vector # => current state vector
|
|
@@ -100,36 +96,23 @@ doc.encode_state_as_update(sv) # => update diff against state vector
|
|
|
100
96
|
# Applying updates
|
|
101
97
|
doc.apply_update(update_bytes) # apply raw V1 update
|
|
102
98
|
|
|
103
|
-
# Sync protocol
|
|
104
|
-
doc.sync_step1 # => SyncStep1 message (
|
|
105
|
-
doc.
|
|
106
|
-
|
|
107
|
-
doc.encode_update_message(update) # => wrap update as sync Update message
|
|
99
|
+
# Sync protocol
|
|
100
|
+
doc.sync_step1 # => SyncStep1 message (this doc's state vector)
|
|
101
|
+
doc.handle_sync_message(data) # => [msg_type, sync_type, response]; answers a
|
|
102
|
+
# peer's SyncStep1 with a SyncStep2
|
|
108
103
|
```
|
|
109
104
|
|
|
110
|
-
###
|
|
111
|
-
|
|
112
|
-
```ruby
|
|
113
|
-
# Create awareness instances (each contains a Doc)
|
|
114
|
-
awareness = YrbLite::Awareness.new # random client ID
|
|
115
|
-
awareness = YrbLite::Awareness.new(12345) # specific client ID
|
|
116
|
-
|
|
117
|
-
# Get document info
|
|
118
|
-
awareness.client_id # => unique client identifier
|
|
119
|
-
awareness.guid # => document GUID
|
|
120
|
-
```
|
|
105
|
+
### Protocol codec (module functions)
|
|
121
106
|
|
|
122
|
-
|
|
107
|
+
Classifying and unwrapping wire frames is stateless, so it's exposed as
|
|
108
|
+
`YrbLite` module functions rather than a class. The server never holds presence
|
|
109
|
+
or document state to route a frame — presence lives in the browser clients, and
|
|
110
|
+
the server only relays awareness frames opaquely.
|
|
123
111
|
|
|
124
112
|
```ruby
|
|
125
|
-
#
|
|
126
|
-
|
|
127
|
-
#
|
|
128
|
-
|
|
129
|
-
# When receiving messages from peer
|
|
130
|
-
response = awareness.handle(incoming_data)
|
|
131
|
-
# Send response back to peer if not empty
|
|
132
|
-
send_to_peer(response) unless response.empty?
|
|
113
|
+
YrbLite.message_kind(frame) # => 0 drop / 1 step1 / 2 update / 3 awareness / 4 query
|
|
114
|
+
YrbLite.update_from_message(frame) # => the document delta carried by a frame, or nil
|
|
115
|
+
YrbLite.wrap_update(update_bytes) # => wrap a raw doc update as a sync Update frame
|
|
133
116
|
```
|
|
134
117
|
|
|
135
118
|
### ActionCable Integration
|
|
@@ -178,6 +161,34 @@ oversized, or unknown frames are dropped. A bad frame can't crash the process: a
|
|
|
178
161
|
Rust panic is caught at the FFI boundary and re-raised as a Ruby exception. And
|
|
179
162
|
no single client can relay garbage that breaks the others in a room.
|
|
180
163
|
|
|
164
|
+
#### Delivery guarantees
|
|
165
|
+
|
|
166
|
+
The contract is the same at every scale — one process, or hundreds across many
|
|
167
|
+
servers:
|
|
168
|
+
|
|
169
|
+
- **The document always converges.** CRDT updates are commutative and
|
|
170
|
+
idempotent, so out-of-order, duplicate, or concurrent delivery all converge to
|
|
171
|
+
the same correct document. This needs no coordination and holds everywhere.
|
|
172
|
+
- **The durable log never goes gappy.** An update is recorded only once its
|
|
173
|
+
causal dependencies are already in the store (checked against `on_load`); a
|
|
174
|
+
causally-incomplete update triggers a resync instead, so the log always
|
|
175
|
+
rebuilds cleanly.
|
|
176
|
+
- **`on_change` is at-least-once, and the durable guarantee is that replaying the
|
|
177
|
+
log reconstructs the document.** Every change is recorded before it's acked or
|
|
178
|
+
broadcast (record-before-distribute). Entry count is not 1:1 with edits: a
|
|
179
|
+
best-effort check skips most lost-ack retries but isn't cross-process exact (a
|
|
180
|
+
retry on another process can record the same update twice), and a resync can
|
|
181
|
+
coalesce a client's un-acked tail into a single record. So **make `on_change`
|
|
182
|
+
idempotent** if duplicate side effects would matter (a webhook, a counter) — a
|
|
183
|
+
raw append-only delta log is naturally fine, since it replays to the same
|
|
184
|
+
document either way.
|
|
185
|
+
|
|
186
|
+
There is deliberately no in-gem cross-process lock. One that only spanned a
|
|
187
|
+
single process would give exactly-once at small scale and silently degrade as
|
|
188
|
+
you scale out, so the guarantee is uniform instead. If you need exactly-once
|
|
189
|
+
*side effects*, enforce it in your store (a unique key on the update) or with
|
|
190
|
+
your own distributed lock — the gem stays storage-agnostic and assumes neither.
|
|
191
|
+
|
|
181
192
|
#### Multi-process deployments
|
|
182
193
|
|
|
183
194
|
Most Rails apps run several processes (Puma workers, multiple dynos), and any of
|
|
@@ -295,43 +306,15 @@ one `{ ack: id }` cumulatively confirms everything up to it. Because CRDT apply
|
|
|
295
306
|
is idempotent, a resend that already landed is a harmless no-op that just
|
|
296
307
|
re-acks. Awareness stays ephemeral and is not acked.
|
|
297
308
|
|
|
298
|
-
|
|
299
|
-
|
|
300
|
-
|
|
301
|
-
# Set local user state (cursor position, name, etc.)
|
|
302
|
-
awareness.set_local_state('{"user": {"name": "Alice", "color": "#ff0000"}}')
|
|
303
|
-
|
|
304
|
-
# Get local state
|
|
305
|
-
awareness.local_state # => '{"user": {"name": "Alice", "color": "#ff0000"}}'
|
|
306
|
-
|
|
307
|
-
# Clear local state (e.g., when disconnecting)
|
|
308
|
-
awareness.clear_local_state
|
|
309
|
-
|
|
310
|
-
# Encode awareness update for broadcasting
|
|
311
|
-
update = awareness.encode_awareness_update
|
|
312
|
-
```
|
|
313
|
-
|
|
314
|
-
### Low-Level Access
|
|
315
|
-
|
|
316
|
-
```ruby
|
|
317
|
-
# Get state vector for manual sync
|
|
318
|
-
sv = awareness.encode_state_vector
|
|
319
|
-
|
|
320
|
-
# Get update diffed against a state vector
|
|
321
|
-
update = awareness.encode_state_as_update(remote_state_vector)
|
|
322
|
-
|
|
323
|
-
# Apply raw update to the document
|
|
324
|
-
awareness.apply_update(update_bytes)
|
|
325
|
-
|
|
326
|
-
# Wrap raw update data in a sync message
|
|
327
|
-
message = awareness.encode_update(update_bytes)
|
|
328
|
-
```
|
|
309
|
+
Presence (cursors, selections) is owned by the browser clients — the server
|
|
310
|
+
never sets or holds presence state, it only relays awareness frames opaquely.
|
|
311
|
+
See `yrb-lite-client` for the client-side awareness API.
|
|
329
312
|
|
|
330
313
|
## Thread Safety
|
|
331
314
|
|
|
332
|
-
`Doc`
|
|
333
|
-
|
|
334
|
-
|
|
315
|
+
A `Doc` is safe to share across Ruby threads — used concurrently from Puma
|
|
316
|
+
workers, ActionCable connection threads, or background jobs without external
|
|
317
|
+
locking.
|
|
335
318
|
|
|
336
319
|
That comes from how the underlying types work, not from locking on top:
|
|
337
320
|
|
data/ext/yrb_lite/src/lib.rs
CHANGED
|
@@ -1,16 +1,13 @@
|
|
|
1
1
|
use magnus::{
|
|
2
2
|
function, method, prelude::*, Error, ExceptionClass, RString, Ruby, TryConvert, Value,
|
|
3
3
|
};
|
|
4
|
-
use
|
|
5
|
-
use yrs::sync::{Awareness, DefaultProtocol, Message, Protocol, SyncMessage};
|
|
4
|
+
use yrs::sync::{Message, SyncMessage};
|
|
6
5
|
use yrs::updates::decoder::Decode;
|
|
7
|
-
use yrs::updates::encoder::
|
|
6
|
+
use yrs::updates::encoder::Encode;
|
|
8
7
|
use yrs::{Doc, ReadTxn, Transact};
|
|
9
8
|
|
|
10
9
|
mod protocol;
|
|
11
|
-
use protocol::{
|
|
12
|
-
classify_message, doc_has_pending, merged_doc_update, update_advances_doc, update_is_ready,
|
|
13
|
-
};
|
|
10
|
+
use protocol::{classify_message, merged_doc_update, update_advances_doc, update_is_ready};
|
|
14
11
|
|
|
15
12
|
/// Wrapper around yrs Doc.
|
|
16
13
|
///
|
|
@@ -22,37 +19,13 @@ use protocol::{
|
|
|
22
19
|
#[magnus::wrap(class = "YrbLite::Doc", free_immediately, size)]
|
|
23
20
|
struct RbDoc(Doc);
|
|
24
21
|
|
|
25
|
-
///
|
|
26
|
-
///
|
|
27
|
-
///
|
|
28
|
-
/// its mutating methods (`handle`, `set_local_state`, `clean_local_state`,
|
|
29
|
-
/// `remove_state`, `update_with_clients`) take `&mut self`. It is `Send` but no
|
|
30
|
-
/// longer `Sync`, so we serialize all access through a `Mutex`.
|
|
31
|
-
///
|
|
32
|
-
/// CRITICAL: the `Mutex` is ALWAYS locked inside the `nogvl` closure (never with
|
|
33
|
-
/// the GVL held) and the guard is dropped before the closure returns. This obeys
|
|
34
|
-
/// the same rule as the doc's RwLock (see `nogvl`): a thread never waits on this
|
|
35
|
-
/// lock while holding the GVL, and never reacquires the GVL while holding this
|
|
36
|
-
/// lock, so the GVL and this `Mutex` can't deadlock on lock order. Locking with
|
|
37
|
-
/// the GVL held (outside `nogvl`) reintroduces that deadlock -- don't.
|
|
38
|
-
///
|
|
39
|
-
/// For doc-only reads we clone the (Arc-backed) `Doc` out under the brief lock
|
|
40
|
-
/// and operate on the owned clone, so a long encode holds only the doc's own
|
|
41
|
-
/// RwLock, not this `Mutex`, and never blocks presence updates on another
|
|
42
|
-
/// thread. Lock order is always Mutex-then-doc-RwLock (or doc-RwLock alone),
|
|
43
|
-
/// never the reverse.
|
|
44
|
-
#[magnus::wrap(class = "YrbLite::Awareness", free_immediately, size)]
|
|
45
|
-
struct RbAwareness(Mutex<Awareness>);
|
|
46
|
-
|
|
47
|
-
/// Compile-time proof that the wrapped types are thread-safe. If a future
|
|
48
|
-
/// yrs upgrade makes Doc lose Send/Sync, or Awareness lose Send, this fails the
|
|
49
|
-
/// build instead of silently shipping a thread-unsafe gem. (Awareness is no
|
|
50
|
-
/// longer `Sync` as of yrs 0.27, hence the `Mutex` wrapper, which restores it.)
|
|
22
|
+
/// Compile-time proof that the wrapped Doc is thread-safe. If a future yrs
|
|
23
|
+
/// upgrade makes Doc lose Send/Sync, this fails the build instead of silently
|
|
24
|
+
/// shipping a thread-unsafe gem.
|
|
51
25
|
#[allow(dead_code)]
|
|
52
26
|
fn assert_thread_safe() {
|
|
53
27
|
fn is_send_sync<T: Send + Sync>() {}
|
|
54
28
|
is_send_sync::<Doc>();
|
|
55
|
-
is_send_sync::<Mutex<Awareness>>();
|
|
56
29
|
}
|
|
57
30
|
|
|
58
31
|
/// Run `f` with the GVL (Global VM Lock) released, so other Ruby threads,
|
|
@@ -161,14 +134,6 @@ impl RbDoc {
|
|
|
161
134
|
Ok(RbDoc(doc))
|
|
162
135
|
}
|
|
163
136
|
|
|
164
|
-
fn client_id(&self) -> u64 {
|
|
165
|
-
self.0.client_id().get()
|
|
166
|
-
}
|
|
167
|
-
|
|
168
|
-
fn guid(&self) -> String {
|
|
169
|
-
self.0.guid().to_string()
|
|
170
|
-
}
|
|
171
|
-
|
|
172
137
|
fn encode_state_vector(&self) -> RString {
|
|
173
138
|
let doc = &self.0;
|
|
174
139
|
let sv = nogvl(move || {
|
|
@@ -228,13 +193,6 @@ impl RbDoc {
|
|
|
228
193
|
nogvl(move || update_advances_doc(doc, &update_bytes)).map_err(yrb_error)
|
|
229
194
|
}
|
|
230
195
|
|
|
231
|
-
/// True if the document holds pending (un-integrable) structs waiting on a
|
|
232
|
-
/// missing dependency.
|
|
233
|
-
fn pending(&self) -> bool {
|
|
234
|
-
let doc = &self.0;
|
|
235
|
-
nogvl(move || doc_has_pending(doc))
|
|
236
|
-
}
|
|
237
|
-
|
|
238
196
|
/// Sync step 1: Create a sync message with our state vector
|
|
239
197
|
fn sync_step1(&self) -> RString {
|
|
240
198
|
let doc = &self.0;
|
|
@@ -246,20 +204,6 @@ impl RbDoc {
|
|
|
246
204
|
binary_string(&encoded)
|
|
247
205
|
}
|
|
248
206
|
|
|
249
|
-
/// Sync step 2: Create a sync message with updates for the given state vector
|
|
250
|
-
fn sync_step2(&self, sv_bytes: RString) -> Result<RString, Error> {
|
|
251
|
-
let sv_data = copy_bytes(sv_bytes);
|
|
252
|
-
let doc = &self.0;
|
|
253
|
-
let encoded = nogvl(move || -> Result<Vec<u8>, String> {
|
|
254
|
-
let sv = yrs::StateVector::decode_v1(&sv_data).map_err(|e| e.to_string())?;
|
|
255
|
-
let txn = doc.transact();
|
|
256
|
-
let update = txn.encode_state_as_update_v1(&sv);
|
|
257
|
-
Ok(Message::Sync(SyncMessage::SyncStep2(update)).encode_v1())
|
|
258
|
-
})
|
|
259
|
-
.map_err(yrb_error)?;
|
|
260
|
-
Ok(binary_string(&encoded))
|
|
261
|
-
}
|
|
262
|
-
|
|
263
207
|
/// Handle a sync message and return response (if any)
|
|
264
208
|
/// Returns [message_type, sync_type, response_bytes] or nil
|
|
265
209
|
fn handle_sync_message(&self, data: RString) -> Result<Option<(u8, u8, RString)>, Error> {
|
|
@@ -306,255 +250,46 @@ impl RbDoc {
|
|
|
306
250
|
|
|
307
251
|
Ok(Some((msg_type, sync_type, binary_string(&response))))
|
|
308
252
|
}
|
|
309
|
-
|
|
310
|
-
/// Encode raw update bytes as a sync Update message
|
|
311
|
-
fn encode_update_message(&self, update: RString) -> RString {
|
|
312
|
-
let update_bytes = copy_bytes(update);
|
|
313
|
-
let msg = Message::Sync(SyncMessage::Update(update_bytes));
|
|
314
|
-
binary_string(&msg.encode_v1())
|
|
315
|
-
}
|
|
316
253
|
}
|
|
317
254
|
|
|
318
255
|
// ============================================================================
|
|
319
|
-
//
|
|
256
|
+
// Protocol codec (stateless) -- exposed as `YrbLite` module functions
|
|
320
257
|
// ============================================================================
|
|
258
|
+
//
|
|
259
|
+
// The server never holds presence or document state to classify a frame; these
|
|
260
|
+
// are pure functions of their bytes. (Presence lives in the browser clients; the
|
|
261
|
+
// server only relays awareness frames opaquely.)
|
|
262
|
+
|
|
263
|
+
/// Wrap a raw document update in a sync Update message frame, ready to relay.
|
|
264
|
+
fn wrap_update(update: RString) -> RString {
|
|
265
|
+
let update_bytes = copy_bytes(update);
|
|
266
|
+
let msg = Message::Sync(SyncMessage::Update(update_bytes));
|
|
267
|
+
binary_string(&msg.encode_v1())
|
|
268
|
+
}
|
|
321
269
|
|
|
322
|
-
|
|
323
|
-
|
|
324
|
-
|
|
325
|
-
|
|
326
|
-
|
|
327
|
-
|
|
328
|
-
|
|
329
|
-
|
|
330
|
-
|
|
331
|
-
|
|
332
|
-
|
|
333
|
-
|
|
334
|
-
|
|
335
|
-
|
|
336
|
-
nogvl(move || awareness.lock().unwrap().doc().client_id().get())
|
|
337
|
-
}
|
|
338
|
-
|
|
339
|
-
fn guid(&self) -> String {
|
|
340
|
-
let awareness = &self.0;
|
|
341
|
-
nogvl(move || awareness.lock().unwrap().doc().guid().to_string())
|
|
342
|
-
}
|
|
343
|
-
|
|
344
|
-
/// A standalone SyncStep1 message (the server's state vector). Sent as its
|
|
345
|
-
/// own frame in the opening handshake so providers that parse one message
|
|
346
|
-
/// per frame (e.g. @y-rb/actioncable) handle it correctly.
|
|
347
|
-
fn sync_step1(&self) -> RString {
|
|
348
|
-
let awareness = &self.0;
|
|
349
|
-
let encoded = nogvl(move || {
|
|
350
|
-
let doc = awareness.lock().unwrap().doc().clone();
|
|
351
|
-
let txn = doc.transact();
|
|
352
|
-
let sv = txn.state_vector();
|
|
353
|
-
Message::Sync(SyncMessage::SyncStep1(sv)).encode_v1()
|
|
354
|
-
});
|
|
355
|
-
binary_string(&encoded)
|
|
356
|
-
}
|
|
357
|
-
|
|
358
|
-
/// Create initial sync messages to send when connection opens.
|
|
359
|
-
/// Returns binary data containing SyncStep1 + Awareness update.
|
|
360
|
-
fn start(&self) -> Result<RString, Error> {
|
|
361
|
-
let awareness = &self.0;
|
|
362
|
-
let encoded = nogvl(move || -> Result<Vec<u8>, String> {
|
|
363
|
-
let awareness = awareness.lock().unwrap();
|
|
364
|
-
let protocol = DefaultProtocol;
|
|
365
|
-
let mut encoder = EncoderV1::new();
|
|
366
|
-
protocol
|
|
367
|
-
.start(&awareness, &mut encoder)
|
|
368
|
-
.map_err(|e| e.to_string())?;
|
|
369
|
-
Ok(encoder.to_vec())
|
|
370
|
-
})
|
|
371
|
-
.map_err(yrb_error)?;
|
|
372
|
-
Ok(binary_string(&encoded))
|
|
373
|
-
}
|
|
374
|
-
|
|
375
|
-
/// Handle incoming message and return response messages (if any).
|
|
376
|
-
/// Returns binary data containing response messages, or empty if no response needed.
|
|
377
|
-
fn handle(&self, data: RString) -> Result<RString, Error> {
|
|
378
|
-
let data_bytes = copy_bytes(data);
|
|
379
|
-
let awareness = &self.0;
|
|
380
|
-
|
|
381
|
-
let encoded = nogvl(move || -> Result<Vec<u8>, String> {
|
|
382
|
-
let mut awareness = awareness.lock().unwrap();
|
|
383
|
-
let protocol = DefaultProtocol;
|
|
384
|
-
let responses = protocol
|
|
385
|
-
.handle(&mut awareness, &data_bytes)
|
|
386
|
-
.map_err(|e| e.to_string())?;
|
|
387
|
-
|
|
388
|
-
if responses.is_empty() {
|
|
389
|
-
return Ok(Vec::new());
|
|
390
|
-
}
|
|
391
|
-
|
|
392
|
-
let mut encoder = EncoderV1::new();
|
|
393
|
-
for msg in responses {
|
|
394
|
-
msg.encode(&mut encoder);
|
|
395
|
-
}
|
|
396
|
-
Ok(encoder.to_vec())
|
|
397
|
-
})
|
|
398
|
-
.map_err(yrb_error)?;
|
|
399
|
-
Ok(binary_string(&encoded))
|
|
400
|
-
}
|
|
401
|
-
|
|
402
|
-
/// Encode an update message for broadcasting changes to peers.
|
|
403
|
-
fn encode_update(&self, update: RString) -> RString {
|
|
404
|
-
let update_bytes = copy_bytes(update);
|
|
405
|
-
let msg = Message::Sync(SyncMessage::Update(update_bytes));
|
|
406
|
-
binary_string(&msg.encode_v1())
|
|
407
|
-
}
|
|
408
|
-
|
|
409
|
-
fn encode_state_vector(&self) -> RString {
|
|
410
|
-
let awareness = &self.0;
|
|
411
|
-
let sv = nogvl(move || {
|
|
412
|
-
let doc = awareness.lock().unwrap().doc().clone();
|
|
413
|
-
let txn = doc.transact();
|
|
414
|
-
txn.state_vector().encode_v1()
|
|
415
|
-
});
|
|
416
|
-
binary_string(&sv)
|
|
417
|
-
}
|
|
418
|
-
|
|
419
|
-
/// Encode state as update (optionally diffed against a state vector)
|
|
420
|
-
fn encode_state_as_update(&self, args: &[Value]) -> Result<RString, Error> {
|
|
421
|
-
let sv_bytes: Option<Vec<u8>> = if args.is_empty() {
|
|
422
|
-
None
|
|
423
|
-
} else {
|
|
424
|
-
let sv_string: RString = TryConvert::try_convert(args[0])?;
|
|
425
|
-
Some(copy_bytes(sv_string))
|
|
426
|
-
};
|
|
427
|
-
let awareness = &self.0;
|
|
428
|
-
let update = nogvl(move || -> Result<Vec<u8>, String> {
|
|
429
|
-
let sv = match &sv_bytes {
|
|
430
|
-
None => yrs::StateVector::default(),
|
|
431
|
-
Some(bytes) => yrs::StateVector::decode_v1(bytes).map_err(|e| e.to_string())?,
|
|
432
|
-
};
|
|
433
|
-
let doc = awareness.lock().unwrap().doc().clone();
|
|
434
|
-
let txn = doc.transact();
|
|
435
|
-
Ok(txn.encode_state_as_update_v1(&sv))
|
|
436
|
-
})
|
|
437
|
-
.map_err(yrb_error)?;
|
|
438
|
-
Ok(binary_string(&update))
|
|
439
|
-
}
|
|
440
|
-
|
|
441
|
-
/// Set local awareness state (JSON string)
|
|
442
|
-
fn set_local_state(&self, json: String) -> Result<(), Error> {
|
|
443
|
-
let value: serde_json::Value =
|
|
444
|
-
serde_json::from_str(&json).map_err(|e| yrb_error(e.to_string()))?;
|
|
445
|
-
let awareness = &self.0;
|
|
446
|
-
nogvl(move || -> Result<(), String> {
|
|
447
|
-
awareness
|
|
448
|
-
.lock()
|
|
449
|
-
.unwrap()
|
|
450
|
-
.set_local_state(value)
|
|
451
|
-
.map_err(|e| e.to_string())
|
|
452
|
-
})
|
|
453
|
-
.map_err(yrb_error)
|
|
454
|
-
}
|
|
455
|
-
|
|
456
|
-
/// Get local awareness state as JSON string (or nil if not set)
|
|
457
|
-
fn local_state(&self) -> Option<String> {
|
|
458
|
-
let awareness = &self.0;
|
|
459
|
-
nogvl(move || {
|
|
460
|
-
awareness
|
|
461
|
-
.lock()
|
|
462
|
-
.unwrap()
|
|
463
|
-
.local_state::<serde_json::Value>()
|
|
464
|
-
.map(|v| v.to_string())
|
|
465
|
-
})
|
|
466
|
-
}
|
|
467
|
-
|
|
468
|
-
/// Clear local awareness state
|
|
469
|
-
fn clear_local_state(&self) {
|
|
470
|
-
let awareness = &self.0;
|
|
471
|
-
nogvl(move || awareness.lock().unwrap().clean_local_state());
|
|
472
|
-
}
|
|
473
|
-
|
|
474
|
-
/// Get awareness update for broadcasting to peers
|
|
475
|
-
fn encode_awareness_update(&self) -> Result<RString, Error> {
|
|
476
|
-
let awareness = &self.0;
|
|
477
|
-
let encoded = nogvl(move || -> Result<Vec<u8>, String> {
|
|
478
|
-
let awareness = awareness.lock().unwrap();
|
|
479
|
-
let update = awareness.update().map_err(|e| e.to_string())?;
|
|
480
|
-
Ok(Message::Awareness(update).encode_v1())
|
|
481
|
-
})
|
|
482
|
-
.map_err(yrb_error)?;
|
|
483
|
-
Ok(binary_string(&encoded))
|
|
484
|
-
}
|
|
485
|
-
|
|
486
|
-
fn apply_update(&self, update: RString) -> Result<(), Error> {
|
|
487
|
-
let update_bytes = copy_bytes(update);
|
|
488
|
-
let awareness = &self.0;
|
|
489
|
-
nogvl(move || -> Result<(), String> {
|
|
490
|
-
let update = yrs::Update::decode_v1(&update_bytes).map_err(|e| e.to_string())?;
|
|
491
|
-
let doc = awareness.lock().unwrap().doc().clone();
|
|
492
|
-
let mut txn = doc.transact_mut();
|
|
493
|
-
txn.apply_update(update).map_err(|e| e.to_string())
|
|
494
|
-
})
|
|
495
|
-
.map_err(yrb_error)
|
|
496
|
-
}
|
|
497
|
-
|
|
498
|
-
/// True if applying `update` would integrate cleanly (its dependencies are
|
|
499
|
-
/// all present). False means it depends on a missing, causally-prior update.
|
|
500
|
-
/// Pure read; does not mutate.
|
|
501
|
-
fn update_ready(&self, update: RString) -> Result<bool, Error> {
|
|
502
|
-
let update_bytes = copy_bytes(update);
|
|
503
|
-
let awareness = &self.0;
|
|
504
|
-
nogvl(move || {
|
|
505
|
-
let doc = awareness.lock().unwrap().doc().clone();
|
|
506
|
-
update_is_ready(&doc, &update_bytes)
|
|
507
|
-
})
|
|
508
|
-
.map_err(yrb_error)
|
|
509
|
-
}
|
|
510
|
-
|
|
511
|
-
/// True if applying `update` would change the document, false if it's an
|
|
512
|
-
/// already-applied retry. See `update_advances_doc`. Pure read.
|
|
513
|
-
fn update_advances(&self, update: RString) -> Result<bool, Error> {
|
|
514
|
-
let update_bytes = copy_bytes(update);
|
|
515
|
-
let awareness = &self.0;
|
|
516
|
-
nogvl(move || {
|
|
517
|
-
let doc = awareness.lock().unwrap().doc().clone();
|
|
518
|
-
update_advances_doc(&doc, &update_bytes)
|
|
519
|
-
})
|
|
520
|
-
.map_err(yrb_error)
|
|
521
|
-
}
|
|
522
|
-
|
|
523
|
-
/// True if the document holds pending (un-integrable) structs waiting on a
|
|
524
|
-
/// missing dependency.
|
|
525
|
-
fn pending(&self) -> bool {
|
|
526
|
-
let awareness = &self.0;
|
|
527
|
-
nogvl(move || {
|
|
528
|
-
let doc = awareness.lock().unwrap().doc().clone();
|
|
529
|
-
doc_has_pending(&doc)
|
|
530
|
-
})
|
|
531
|
-
}
|
|
532
|
-
|
|
533
|
-
/// Classify a frame for safe routing and relay. Returns a code only when
|
|
534
|
-
/// the frame is exactly one well-formed message that consumes the whole
|
|
535
|
-
/// buffer, so a malformed, truncated, multi-message, or trailing-garbage
|
|
536
|
-
/// frame (which a malicious client could craft to disrupt others if
|
|
537
|
-
/// relayed) is rejected up front:
|
|
538
|
-
/// 0 = drop (malformed, multiple, unknown, or empty)
|
|
539
|
-
/// 1 = sync step1 (a request: respond, do not relay)
|
|
540
|
-
/// 2 = sync step2/update (a document change: record/apply/relay)
|
|
541
|
-
/// 3 = awareness (presence: relay)
|
|
542
|
-
/// 4 = awareness query (a request: respond, do not relay)
|
|
543
|
-
fn message_kind(&self, data: RString) -> u8 {
|
|
544
|
-
let data_bytes = copy_bytes(data);
|
|
545
|
-
nogvl(move || classify_message(&data_bytes))
|
|
546
|
-
}
|
|
270
|
+
/// Classify a frame for safe routing and relay. Returns a code only when the
|
|
271
|
+
/// frame is exactly one well-formed message that consumes the whole buffer, so
|
|
272
|
+
/// a malformed, truncated, multi-message, or trailing-garbage frame (which a
|
|
273
|
+
/// malicious client could craft to disrupt others if relayed) is rejected up
|
|
274
|
+
/// front:
|
|
275
|
+
/// 0 = drop (malformed, multiple, unknown, or empty)
|
|
276
|
+
/// 1 = sync step1 (a request: respond, do not relay)
|
|
277
|
+
/// 2 = sync step2/update (a document change: record/apply/relay)
|
|
278
|
+
/// 3 = awareness (presence: relay)
|
|
279
|
+
/// 4 = awareness query (a request: respond, do not relay)
|
|
280
|
+
fn message_kind(data: RString) -> u8 {
|
|
281
|
+
let data_bytes = copy_bytes(data);
|
|
282
|
+
nogvl(move || classify_message(&data_bytes))
|
|
283
|
+
}
|
|
547
284
|
|
|
548
|
-
|
|
549
|
-
|
|
550
|
-
|
|
551
|
-
|
|
552
|
-
|
|
553
|
-
|
|
554
|
-
|
|
555
|
-
|
|
556
|
-
Ok(merged.map(|b| binary_string(&b)))
|
|
557
|
-
}
|
|
285
|
+
/// Extract the document-update delta carried by a protocol message: the payloads
|
|
286
|
+
/// of any Update or SyncStep2 sub-messages, merged into a single update. Returns
|
|
287
|
+
/// nil if the message carries no document change (a SyncStep1 request or an
|
|
288
|
+
/// awareness update). The store-backed path records this exact delta before relay.
|
|
289
|
+
fn update_from_message(data: RString) -> Result<Option<RString>, Error> {
|
|
290
|
+
let data_bytes = copy_bytes(data);
|
|
291
|
+
let merged = nogvl(move || merged_doc_update(&data_bytes)).map_err(yrb_error)?;
|
|
292
|
+
Ok(merged.map(|b| binary_string(&b)))
|
|
558
293
|
}
|
|
559
294
|
|
|
560
295
|
// ============================================================================
|
|
@@ -572,8 +307,6 @@ fn init(ruby: &Ruby) -> Result<(), Error> {
|
|
|
572
307
|
// Define Doc class
|
|
573
308
|
let doc_class = module.define_class("Doc", ruby.class_object())?;
|
|
574
309
|
doc_class.define_singleton_method("new", function!(RbDoc::new, -1))?;
|
|
575
|
-
doc_class.define_method("client_id", method!(RbDoc::client_id, 0))?;
|
|
576
|
-
doc_class.define_method("guid", method!(RbDoc::guid, 0))?;
|
|
577
310
|
doc_class.define_method(
|
|
578
311
|
"encode_state_vector",
|
|
579
312
|
method!(RbDoc::encode_state_vector, 0),
|
|
@@ -585,54 +318,15 @@ fn init(ruby: &Ruby) -> Result<(), Error> {
|
|
|
585
318
|
doc_class.define_method("apply_update", method!(RbDoc::apply_update, 1))?;
|
|
586
319
|
doc_class.define_method("update_ready?", method!(RbDoc::update_ready, 1))?;
|
|
587
320
|
doc_class.define_method("update_advances?", method!(RbDoc::update_advances, 1))?;
|
|
588
|
-
doc_class.define_method("pending?", method!(RbDoc::pending, 0))?;
|
|
589
321
|
doc_class.define_method("sync_step1", method!(RbDoc::sync_step1, 0))?;
|
|
590
|
-
doc_class.define_method("sync_step2", method!(RbDoc::sync_step2, 1))?;
|
|
591
322
|
doc_class.define_method(
|
|
592
323
|
"handle_sync_message",
|
|
593
324
|
method!(RbDoc::handle_sync_message, 1),
|
|
594
325
|
)?;
|
|
595
|
-
|
|
596
|
-
|
|
597
|
-
|
|
598
|
-
)?;
|
|
599
|
-
|
|
600
|
-
// Define Awareness class
|
|
601
|
-
let awareness_class = module.define_class("Awareness", ruby.class_object())?;
|
|
602
|
-
awareness_class.define_singleton_method("new", function!(RbAwareness::new, -1))?;
|
|
603
|
-
awareness_class.define_method("client_id", method!(RbAwareness::client_id, 0))?;
|
|
604
|
-
awareness_class.define_method("guid", method!(RbAwareness::guid, 0))?;
|
|
605
|
-
awareness_class.define_method("start", method!(RbAwareness::start, 0))?;
|
|
606
|
-
awareness_class.define_method("sync_step1", method!(RbAwareness::sync_step1, 0))?;
|
|
607
|
-
awareness_class.define_method("handle", method!(RbAwareness::handle, 1))?;
|
|
608
|
-
awareness_class.define_method("encode_update", method!(RbAwareness::encode_update, 1))?;
|
|
609
|
-
awareness_class.define_method(
|
|
610
|
-
"encode_state_vector",
|
|
611
|
-
method!(RbAwareness::encode_state_vector, 0),
|
|
612
|
-
)?;
|
|
613
|
-
awareness_class.define_method(
|
|
614
|
-
"encode_state_as_update",
|
|
615
|
-
method!(RbAwareness::encode_state_as_update, -1),
|
|
616
|
-
)?;
|
|
617
|
-
awareness_class.define_method("apply_update", method!(RbAwareness::apply_update, 1))?;
|
|
618
|
-
awareness_class.define_method("update_ready?", method!(RbAwareness::update_ready, 1))?;
|
|
619
|
-
awareness_class.define_method("update_advances?", method!(RbAwareness::update_advances, 1))?;
|
|
620
|
-
awareness_class.define_method("pending?", method!(RbAwareness::pending, 0))?;
|
|
621
|
-
awareness_class.define_method("set_local_state", method!(RbAwareness::set_local_state, 1))?;
|
|
622
|
-
awareness_class.define_method("local_state", method!(RbAwareness::local_state, 0))?;
|
|
623
|
-
awareness_class.define_method(
|
|
624
|
-
"clear_local_state",
|
|
625
|
-
method!(RbAwareness::clear_local_state, 0),
|
|
626
|
-
)?;
|
|
627
|
-
awareness_class.define_method(
|
|
628
|
-
"encode_awareness_update",
|
|
629
|
-
method!(RbAwareness::encode_awareness_update, 0),
|
|
630
|
-
)?;
|
|
631
|
-
awareness_class.define_method(
|
|
632
|
-
"update_from_message",
|
|
633
|
-
method!(RbAwareness::update_from_message, 1),
|
|
634
|
-
)?;
|
|
635
|
-
awareness_class.define_method("message_kind", method!(RbAwareness::message_kind, 1))?;
|
|
326
|
+
// Stateless protocol codec, as YrbLite module functions.
|
|
327
|
+
module.define_module_function("wrap_update", function!(wrap_update, 1))?;
|
|
328
|
+
module.define_module_function("message_kind", function!(message_kind, 1))?;
|
|
329
|
+
module.define_module_function("update_from_message", function!(update_from_message, 1))?;
|
|
636
330
|
|
|
637
331
|
// Define message type constants
|
|
638
332
|
module.const_set("MSG_SYNC", 0u8)?;
|
|
@@ -53,7 +53,7 @@ pub(crate) fn merged_doc_update(bytes: &[u8]) -> Result<Option<Vec<u8>>, String>
|
|
|
53
53
|
let update = yrs::Update::decode_v1(&merged).map_err(|e| e.to_string())?;
|
|
54
54
|
// A genuine no-op (e.g. the empty SyncStep2 in an opening handshake) carries
|
|
55
55
|
// no structs, no deletes, and no dependencies. We must NOT treat a causally-
|
|
56
|
-
// pending update as a no-op:
|
|
56
|
+
// pending update as a no-op: such an update reports an empty
|
|
57
57
|
// state_vector (its structs can't integrate yet), but it still carries
|
|
58
58
|
// content and a non-empty lower bound (the deps it's waiting on). Dropping it
|
|
59
59
|
// here would silently swallow a gappy update instead of rejecting + resyncing.
|
|
@@ -115,8 +115,9 @@ pub(crate) fn update_advances_doc(doc: &Doc, update_bytes: &[u8]) -> Result<bool
|
|
|
115
115
|
}
|
|
116
116
|
|
|
117
117
|
/// True if the doc holds pending structs or a pending delete set -- blocks that
|
|
118
|
-
/// couldn't integrate because a dependency is missing.
|
|
119
|
-
///
|
|
118
|
+
/// couldn't integrate because a dependency is missing. Test-only: asserts the
|
|
119
|
+
/// causal-chain parking behavior in the unit tests below.
|
|
120
|
+
#[cfg(test)]
|
|
120
121
|
pub(crate) fn doc_has_pending(doc: &Doc) -> bool {
|
|
121
122
|
let txn = doc.transact();
|
|
122
123
|
txn.store().pending_update().is_some() || txn.store().pending_ds().is_some()
|
data/lib/yrb_lite/version.rb
CHANGED