youroom_api 0.0.10 → 0.0.11

data/lib/youroom_api/request.rb

@@ -20,8 +20,8 @@ module Youroom
       ShowAttachment.new(access_token, room_id, mutter_id, url).get
     end
 
-    def get_all_timeline
-      HomeTimeline.new(access_token, url).get
+    def get_all_timeline(params={ })
+      HomeTimeline.new(access_token, params, url).get
     end
 
     def get_unread_timeline

data/lib/youroom_api/request/timeline.rb

@@ -1,8 +1,21 @@
 module Youroom
   class HomeTimeline < Request
-    # TODO: Request parameter feel bad
+    attr_reader :room_id, :since, :page, :flat, :read_state
+    QUERY_KEYS = %w[since page flat read_state]
+
+    def initialize(access_token, params={}, url=BASE_URL)
+      required_structure(params, Hash)
+      params.each { |k,v| self.instance_variable_set("@#{k}", v)}
+      super(access_token, url)
+    end
+
     def path
-      File.join(url, '?format=json')
+      query_str = "&"
+      QUERY_KEYS.each do |query_key|
+        val = self.instance_variable_get("@#{query_key}")
+        query_str += "#{query_key}=#{val}&" if !val.nil?
+      end
+      File.join(url, '?format=json'+"#{query_str.chop}")
     end
   end
 end

data/spec/youroom_api/timeline_spec.rb

@@ -1,3 +1,4 @@
+# coding: utf-8
 require File.expand_path("../spec_helper", File.dirname(__FILE__))
 
 describe Youroom::HomeTimeline do
@@ -14,17 +15,79 @@ describe Youroom::HomeTimeline do
 
     describe "when url is not original" do
       before do
-        @client = Youroom::HomeTimeline.new(access_token, WW_URL)
+        @client = Youroom::HomeTimeline.new(access_token, { }, WW_URL)
       end
 
       subject { @client.path }
       it { should == File.join(@client.url, '?format=json')}
     end
+
+    describe "パラメータを設定する場合" do
+      context "sinceを設定する場合" do
+        before do
+          @client = Youroom::HomeTimeline.new(access_token, { :since => "hogehoge" })
+        end
+
+        subject { @client.path }
+
+        it "Queryパラメータにsinceが設定されていること" do
+          should == File.join(@client.url, '?format=json&since=hogehoge')
+        end
+      end
+
+      context "flatを設定する場合" do
+        before do
+          @client = Youroom::HomeTimeline.new(access_token, { :flat => "true" })
+        end
+
+        subject { @client.path }
+
+        it "Queryパラメータにflatが設定されていること" do
+          should == File.join(@client.url, '?format=json&flat=true')
+        end
+      end
+
+      context "pageを設定する場合" do
+        before do
+          @client = Youroom::HomeTimeline.new(access_token, { :page => 3 })
+        end
+
+        subject { @client.path }
+
+        it "Queryパラメータにpageが設定されていること" do
+          should == File.join(@client.url, '?format=json&page=3')
+        end
+      end
+
+      context "read_stateを設定する場合" do
+        before do
+          @client = Youroom::HomeTimeline.new(access_token, { :read_state => "unread" })
+        end
+
+        subject { @client.path }
+
+        it "Queryパラメータにread_stateが設定されていること" do
+          should == File.join(@client.url, '?format=json&read_state=unread')
+        end
+      end
+
+      context "複合オプションを設定した場合" do
+        before do
+          @client = Youroom::HomeTimeline.new(access_token, { :read_state => "unread", :page => 3, :flat => "true" })
+        end
+
+        subject { @client.path }
+
+        it "Queryパラメータに複合パラメータが設定されていること" do
+          should == File.join(@client.url, '?format=json&page=3&flat=true&read_state=unread')
+        end
+      end
+    end
   end
 
   describe "#call" do
     before do
-      @client = Youroom::HomeTimeline.new(access_token, WW_URL)
+      @client = Youroom::HomeTimeline.new(access_token, { }, WW_URL)
       # dammy ww url
       @client.should_receive(:path).at_least(1).and_return("http://localhost:8083/all?format=json")
 

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 0
-  - 10
-  version: 0.0.10
+  - 11
+  version: 0.0.11
 platform: ruby
 authors: 
 - pochi