RubyGems - your_membership - Versions diffs - 1.1.3 → 1.1.4 - Mend

your_membership 1.1.3 → 1.1.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (11) hide show

checksums.yaml +4 -4
data/CHANGELOG.md +4 -0
data/README.md +5 -0
data/lib/httparty/patch.rb +1 -1
data/lib/your_membership/version.rb +1 -1
data/spec/fixtures/vcr_cassettes/no_body_response.yml +49 -0
data/spec/fixtures/vcr_cassettes/sa_members_cdata.yml +51 -0
data/spec/fixtures/vcr_cassettes/sa_members_no_body.yml +43 -0
data/spec/lib/httparty/patch_spec.rb +32 -0
data/spec/spec_helper.rb +1 -1
metadata +11 -2

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7dca31de77c1f07ea870f32e160e2791b5fea1fc
-  data.tar.gz: a30728a8cea27ed96e36db41f8757226bd6cff6d
+  metadata.gz: eae6af7093fcd10224ba255ebddf1c6cb39cd7d8
+  data.tar.gz: fc90a242e95061cdf01d83602015664b0673cea6
 SHA512:
-  metadata.gz: 0b230561fc1a29dcd04fe2ea5e558fa714a9b60f7df3abfe8e710a2c5cbf091f3001cf13d4658727ab1e6d0d5cc91dbb8e7a2ff7c3d3e8deb04cc0601b9ec11c
-  data.tar.gz: 2a60452add253f288c85893c251e8975da116c5afc89eebd2f8ecdc9b3ca4032d5b0c444890796f34f78d683f97ab65dc1cce352cd7b298b61183999e4ebc573
+  metadata.gz: ea5a1efd9eeea94fd8863e2b5d1d6abea4e2e404832703a0567f9efd300020ae6a7ad650ba4e9959ba3f87a51f5a7da4ee28d62beb71a2fdf8ff223c6e89dea3
+  data.tar.gz: 6f07520885bfcae69f67c8f071414f483031f7884faa9749f0a89d603b62cb0d2865c1d8a8868c927a79a11ee51282b82b21a1166ac3d6cd0a479f06e9827649

data/CHANGELOG.md CHANGED Viewed

@@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ## [Unreleased]
+## [1.1.4] - 2017-08-18
+### Fixed
+- HTTParty monkey patch now handles nils properly.
 ## [1.1.3] - 2017-03-13
 ### Fixed
 - Allow YourMembership::Sa::Members.profile_create to pass along

data/README.md CHANGED Viewed

@@ -252,6 +252,11 @@ Thanks to grants and donations from people like you, ECHO is able to connect tra
 To find out more about ECHO, or to help with the work that is being done worldwide please visit http://www.echonet.org
+## Contributors
+npflood
+sbleon
+mmccarthy15
 ## Contributing
 If you find a problem with this library or would like to contribute an improvement please fork and submit a pull request.

data/lib/httparty/patch.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module HTTParty
     def fix_cdata(body)
       # <![CDATA[ = &lt;![CDATA[
       # ]]> =  ]]&gt;
-      if body.include? '&lt;![CDATA['
+      if !body.nil? && body.include?('&lt;![CDATA[')
         body.gsub! '&lt;![CDATA[', '<![CDATA['
         body.gsub! ']]&gt', ']]>'
       end

data/lib/your_membership/version.rb CHANGED Viewed

@@ -1,3 +1,3 @@
 module YourMembership
-  VERSION = "1.1.3"
+  VERSION = "1.1.4"
 end

data/spec/fixtures/vcr_cassettes/no_body_response.yml ADDED Viewed

@@ -0,0 +1,49 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.yourmembership.com/
+    body:
+      encoding: UTF-8
+      string: |
+        <?xml version="1.0" encoding="UTF-8"?>
+        <YourMembership>
+          <Version>2.00</Version>
+          <ApiKey><PRIVATE_KEY></ApiKey>
+          <SaPasscode><SA_PASSCODE></SaPasscode>
+          <CallID>10000</CallID>
+          <Call Method="Sa.Members.All.GetIDs">
+            <Timestamp>2015-12-02 15:54:11</Timestamp>
+          </Call>
+        </YourMembership>
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - private
+      Content-Length:
+      - '24051'
+      Content-Type:
+      - text/xml; Charset=utf-8
+      Set-Cookie:
+      - "<ASP_SESSION_ID>"
+      X-Powered-By:
+      - ASP.NET
+      Date:
+      - Wed, 16 Dec 2015 20:54:12 GMT
+      Connection:
+      - Keep-alive
+    body:
+      string: null
+    http_version:
+  recorded_at: Wed, 16 Dec 2015 20:54:12 GMT
+recorded_with: VCR 3.0.0

data/spec/fixtures/vcr_cassettes/sa_members_cdata.yml ADDED Viewed

@@ -0,0 +1,51 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.yourmembership.com/
+    body:
+      encoding: UTF-8
+      string: |
+        <?xml version="1.0" encoding="UTF-8"?>
+        <YourMembership>
+          <Version>2.00</Version>
+          <ApiKey><PRIVATE_KEY></ApiKey>
+          <SaPasscode><SA_PASSCODE></SaPasscode>
+          <CallID>10000</CallID>
+          <Call Method="Sa.Members.All.GetIDs">
+            <Timestamp>2015-12-02 15:54:11</Timestamp>
+          </Call>
+        </YourMembership>
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - private
+      Content-Length:
+      - '24051'
+      Content-Type:
+      - text/xml; Charset=utf-8
+      Set-Cookie:
+      - "<ASP_SESSION_ID>"
+      X-Powered-By:
+      - ASP.NET
+      Date:
+      - Wed, 16 Dec 2015 20:54:12 GMT
+      Connection:
+      - Keep-alive
+    body:
+      encoding: UTF-8
+      string: "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\r\n\r\n<YourMembership_Response>\r\n<ErrCode>0</ErrCode>\r\n<ExtendedErrorInfo>&lt;![CDATA[Text information here]]&gt;</ExtendedErrorInfo>\r\n<Sa.Members.All.GetIDs>\r\n<ServerGmtBias>-5</ServerGmtBias>\r\n<ServerTime>2015-12-16
+        15:54:12</ServerTime>\r\n<Members>\r\n<ID>57EEB598-CB44-4D85-B0D6-377F393AF5B4</ID>\r\n<ID>1C0CE647-FAA5-4EB0-ADF0-5B669B36378E</ID>\r\n</Members>\r\n</Sa.Members.All.GetIDs>\r\n</YourMembership_Response>\r\n"
+    http_version:
+  recorded_at: Wed, 16 Dec 2015 20:54:12 GMT
+recorded_with: VCR 3.0.0

data/spec/fixtures/vcr_cassettes/sa_members_no_body.yml ADDED Viewed

@@ -0,0 +1,43 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.yourmembership.com/
+    body:
+      encoding: UTF-8
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - private
+      Content-Type:
+      - text/xml; Charset=utf-8
+      Vary:
+      - Accept-Encoding
+      Server:
+      - Microsoft-IIS/8.5
+      Set-Cookie:
+      - "<ASP_SESSION_ID>"
+      X-Powered-By:
+      - ASP.NET
+      Date:
+      - Thu, 17 Aug 2017 20:18:09 GMT
+      Content-Length:
+      - '301'
+    body:
+      encoding: ASCII-8BIT
+      string: "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\r\n\r\n<YourMembership_Response>\r\n<ErrCode>902</ErrCode>\r\n<ExtendedErrorInfo></ExtendedErrorInfo>\r\n<ErrDesc>XML
+        packet is malformed or otherwise unreadable.</ErrDesc>\r\n<XmlRequest>\r\n<unnamed></unnamed>\r\n</XmlRequest>\r\n</YourMembership_Response>\r\n"
+    http_version:
+  recorded_at: Thu, 17 Aug 2017 20:18:09 GMT
+recorded_with: VCR 3.0.3

data/spec/lib/httparty/patch_spec.rb ADDED Viewed

@@ -0,0 +1,32 @@
+require 'spec_helper'
+describe 'FixCdata' do
+  it 'string returned' do
+    VCR.use_cassette 'sa_members_all_getids_timestamp_single' do
+      response = HTTParty.post("https://api.yourmembership.com/")
+      expect(response.body).to be_a(String)
+    end
+  end
+  it 'replace &lt;![CDATA' do
+    VCR.use_cassette 'sa_members_cdata' do
+      response = HTTParty.post("https://api.yourmembership.com/")
+      expect(response.body).to include("<![CDATA[")
+    end
+  end
+  it 'replace ]]&gt' do
+    VCR.use_cassette 'sa_members_cdata' do
+      response = HTTParty.post("https://api.yourmembership.com/")
+      expect(response.body).to include("]]>")
+    end
+  end
+  it 'handle blank body response' do
+    VCR.use_cassette 'no_body_response' do
+      # Note that a nil body is unlikely (never) to occur within YM, but other non-YM tools may respond with a nil body
+      response = HTTParty.post("https://api.yourmembership.com/")
+      expect(response.body).to be nil
+    end
+  end
+end

data/spec/spec_helper.rb CHANGED Viewed

@@ -2,6 +2,7 @@ require 'dotenv'
 require 'pry'
 require 'vcr'
 require 'your_membership'
+require 'webmock/rspec'
 Dotenv.load(
   File.expand_path('../../.env.local', __FILE__),
@@ -98,4 +99,3 @@ YourMembership.configure(
   privateKey: ENV.fetch('YM_API_PRIVATE_KEY'),
   saPasscode: ENV.fetch('YM_API_SA_PASSCODE')
 )

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: your_membership
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.4
 platform: ruby
 authors:
 - Nate Flood
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-03-13 00:00:00.000000000 Z
+date: 2017-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -187,9 +187,13 @@ files:
 - lib/your_membership/sa_people.rb
 - lib/your_membership/session.rb
 - lib/your_membership/version.rb
+- spec/fixtures/vcr_cassettes/no_body_response.yml
 - spec/fixtures/vcr_cassettes/sa_members_all_getids_timestamp_multiple.yml
 - spec/fixtures/vcr_cassettes/sa_members_all_getids_timestamp_none.yml
 - spec/fixtures/vcr_cassettes/sa_members_all_getids_timestamp_single.yml
+- spec/fixtures/vcr_cassettes/sa_members_cdata.yml
+- spec/fixtures/vcr_cassettes/sa_members_no_body.yml
+- spec/lib/httparty/patch_spec.rb
 - spec/lib/your_membership/profile_spec.rb
 - spec/lib/your_membership/sa_members_spec.rb
 - spec/spec_helper.rb
@@ -219,9 +223,14 @@ signing_key:
 specification_version: 4
 summary: Ruby SDK for interfacing with the YourMembership.com XML API
 test_files:
+- spec/fixtures/vcr_cassettes/no_body_response.yml
 - spec/fixtures/vcr_cassettes/sa_members_all_getids_timestamp_multiple.yml
 - spec/fixtures/vcr_cassettes/sa_members_all_getids_timestamp_none.yml
 - spec/fixtures/vcr_cassettes/sa_members_all_getids_timestamp_single.yml
+- spec/fixtures/vcr_cassettes/sa_members_cdata.yml
+- spec/fixtures/vcr_cassettes/sa_members_no_body.yml
+- spec/lib/httparty/patch_spec.rb
 - spec/lib/your_membership/profile_spec.rb
 - spec/lib/your_membership/sa_members_spec.rb
 - spec/spec_helper.rb
+has_rdoc: