you_shall_not_pass 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a79fae216fadbeb00fde315821f821aa02d74b7
-  data.tar.gz: d0ab7c087b94a4aadda386632355083703c376fc
+  metadata.gz: aebfe45a21e352593dba3c1d5cc1baae6e1f9b66
+  data.tar.gz: 8c6f55da43443b50d645136e4350013195c32e32
 SHA512:
-  metadata.gz: f9156130df570722857fc64a371fd79773192663149c1cd067e0524bfb7bd4705be9ad3fde7684c3a1ede19f736e27f17efe0ebaaaf05464e1743de8e8ed6c3c
-  data.tar.gz: 3b7e2881fca8cc9552391b7b30cf62d8af1b640eaafe6e692e6a5978858c963735c72ff3477b6796f204f4126bf7db9a5e260643cc061ee3ee326575432bbd06
+  metadata.gz: 36fa32a3062e4b639f3e0c753335b4258e14d7c08e60ab00b26d824da38b40d00916ce6a2cd080a81ddcc94bf99cb619c51ae0a3b07bcb6e6253382103390b74
+  data.tar.gz: c90158efd3dd6010b86fb9177f3093f2f7d5865b8aff219bc121a1815a5bd3f4db0b1b4487f217354835f1e5ba361f2f119121f14fa2bb996b64a8cf58efd61a

data/lib/you_shall_not_pass.rb

@@ -1,7 +1,7 @@
 require "you_shall_not_pass/version"
 require "you_shall_not_pass/authorizator"
 require "you_shall_not_pass/policy"
-require "you_shall_not_pass/callable"
+require "callable"
 
 module YouShallNotPass
 end

data/lib/you_shall_not_pass/authorizator.rb

@@ -1,39 +1,31 @@
-require "you_shall_not_pass/callable"
+require "callable"
+require "fattr"
+
 module YouShallNotPass
   class Authorizator
-    include Callable
-
-    attr_reader :user
-
-    def initialize(user)
-      @user = user
+    def initialize(**attrs)
+      attrs.each do |attr, value|
+        send attr, value
+      end
     end
-
-    def can_all?(action, **options, &block)
-      available_policies = Array(policies[action.to_sym])
-      can = available_policies.any? && available_policies.all? do |policy|
-        Callable(policy).call(**options)
+    
+    def can?(permission, **args)
+      Array(policies.fetch(permission)).all? do |policy|
+        Callable(policy).call(**args) == true
       end
-
-      if block_given?
-        yield if can
+    rescue KeyError => e
+      if permission =~ /_and_/
+        permission.to_s.split("_and_").all? { |policy| can?(policy.to_sym, **args)}
+      elsif permission =~ /_or_/
+        permission.to_s.split("_or_").any? { |policy| can?(policy.to_sym, **args)}
       else
-        can
+        raise e
       end
-    end
-    alias :can? :can_all?
 
-    def can_any?(action, **options, &block)
-      available_policies = Array(policies[action.to_sym])
-      can = available_policies.any? && available_policies.any? do |policy|
-        Callable(policy).call(**options)
-      end
+    end
 
-      if block_given?
-        yield if can
-      else
-        can
-      end
+    def perform_for(permission, **args)
+      yield if can?(permission, **args)
     end
 
     def policies
@@ -44,31 +36,8 @@ module YouShallNotPass
 
     private
 
-    def get_policies
-      if policies_dir
-        entries  = Dir.new(policies_dir).entries
-        policy_files = entries.grep(/_policy.rb/)
-          .map { |p|
-          p["_policy.rb"] = ""
-          policy_class = "#{p.camelize}Policy".constantize
-          [p.to_sym, policy_class.new(self)]
-        }.to_h
-      else
-        Hash.new
-      end
-    end
-
-    def self.set_policies_dir(dir)
-      @policies_dir = dir
-    end
-
-    def self.policies_dir
-      @policies_dir
-    end
-
-    def policies_dir
-      self.class.policies_dir
+    def self.attribute(attr)
+      fattr attr
     end
   end
-
 end

data/lib/you_shall_not_pass/version.rb

@@ -1,3 +1,3 @@
 module YouShallNotPass
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/you_shall_not_pass/authorizator_spec.rb

@@ -2,7 +2,299 @@ require "spec_helper"
 require "you_shall_not_pass/authorizator"
 
 scope YouShallNotPass::Authorizator do
-  spec do
-    true
+  scope "#can?" do
+    scope "no policies" do
+      spec "no policies defined" do
+        @ex = capture_exception(KeyError) do
+          YouShallNotPass::Authorizator.new.can?(:whatever)
+        end
+
+        @ex.class == KeyError
+      end
+    end
+
+    scope "lambdas, procs and other callables" do
+      class Action
+        def initialize(val)
+          @val = val
+        end
+
+        def call(*)
+          @val
+        end
+      end
+
+      class MyAuthenticator < YouShallNotPass::Authorizator
+        def policies
+          {
+            can_lambda:  -> (*) { true },
+            cant_lambda: -> (*) { false },
+
+            can_proc:    proc { true },
+            cant_proc:   proc { false },
+
+            can_action:  Action.new(true),
+            cant_action: Action.new(false),
+
+            can_true:    true,
+            cant_false:  false,
+
+            can_array:   [ true, proc { true }, true ],
+            cant_array:  [ true, false,         true ],
+          }
+        end
+      end
+
+      let(:authorizator) { MyAuthenticator.new }
+
+      spec "allow lambda" do
+        authorizator.can?(:can_lambda)
+      end
+
+      spec "reject lambda" do
+        ! authorizator.can?(:cant_lambda)
+      end
+
+      spec "allow proc" do
+        authorizator.can?(:can_proc)
+      end
+
+      spec "reject proc" do
+        ! authorizator.can?(:cant_proc)
+      end
+
+      spec "allow action" do
+        authorizator.can?(:can_action)
+      end
+
+      spec "reject action" do
+        ! authorizator.can?(:cant_action)
+      end
+
+      spec "allow true" do
+        authorizator.can?(:can_true)
+      end
+
+      spec "reject false" do
+        ! authorizator.can?(:cant_false)
+      end
+
+      spec "allow array" do
+        authorizator.can?(:can_array)
+      end
+
+      spec "reject array" do
+        ! authorizator.can?(:cant_array)
+      end
+    end
+  end
+
+  scope "arguments" do
+    class MyAuthenticatorWithArgs < YouShallNotPass::Authorizator
+      def policies
+        {
+          lambda: -> (a:, b:) { a == b },
+          proc:   proc { |a:, b:| a == b },
+
+          splat:  -> (**args) { args.all? { |k, v| k == v} },
+        }
+      end
+    end
+
+    let(:authorizator) { MyAuthenticatorWithArgs.new }
+
+    spec "allow lambda" do
+      authorizator.can?(:lambda, a: 1, b: 1)
+    end
+
+    spec "reject lambda" do
+      ! authorizator.can?(:lambda, a: 1, b: 2)
+    end
+
+    spec "allow proc" do
+      authorizator.can?(:proc, a: 1, b: 1)
+    end
+
+    spec "reject proc" do
+      ! authorizator.can?(:proc, a: 1, b: 2)
+    end
+
+    spec "allow splat" do
+      authorizator.can?(:splat, a: :a , b: :b , c: :c )
+    end
+
+    spec "reject splat" do
+      ! authorizator.can?(:splat, a: :a, b: :b, c: :a)
+    end
+  end
+
+  scope "#perform_for" do
+    class BasicAuthorizator < YouShallNotPass::Authorizator
+      def policies
+        {
+          can:  true,
+          cant: false,
+
+          use_args: -> (**args) { args.all? { |k, v| k == v }  }
+        }
+      end
+    end
+
+    let(:authorizator) { BasicAuthorizator.new }
+
+    spec "executes the block if it is allowed" do
+      authorizator.perform_for(:can) do
+        @i_can = true
+      end
+
+      !! defined? @i_can
+    end
+
+    spec "doesn't execute the block if it isn't allowed" do
+      authorizator.perform_for(:cant) do
+        @i_can = true
+      end
+
+      ! defined? @i_can
+    end
+
+    spec "passes the arguments" do
+      authorizator.perform_for(:use_args, a: :a, b: :b) do
+        @i_can = true
+      end
+
+      !! defined? @i_can
+    end
+  end
+
+  scope "conditional policies" do
+    class NumberAuthenticator < YouShallNotPass::Authorizator
+      def policies
+        {
+          one:   true,
+          two:   true,
+          three: false,
+          four:  false,
+        }
+      end
+    end
+
+    let(:authorizator) { NumberAuthenticator.new }
+
+    spec "allow _and_" do
+      authorizator.can?(:one_and_two)
+    end
+
+    spec "reject _and_" do
+      ! authorizator.can?(:one_and_three)
+    end
+
+    spec "allow _or_" do
+      authorizator.can?(:one_or_two)
+    end
+
+    spec "reject _or_" do
+      ! authorizator.can?(:three_or_four)
+    end
+
+    spec "allow _and_or_" do
+      authorizator.can?(:one_and_two_or_three)
+    end
+
+    spec "reject _and_or_" do
+      ! authorizator.can?(:one_and_three_or_four)
+    end
+
+    scope "regular policies vs conditional policies" do
+      class ConditionalAuthorizator < YouShallNotPass::Authorizator
+        def policies
+          {
+            one: true,
+            two: true,
+            one_and_two: false,
+            one_or_two: false
+          }
+        end
+      end
+
+      let(:authorizator) { ConditionalAuthorizator.new }
+
+      spec "_and_" do
+        ! authorizator.can?(:one_and_two)
+      end
+
+      spec "_or_" do
+        ! authorizator.can?(:one_or_two)
+      end
+    end
+  end
+
+  scope "#polices" do
+    class MergePolicies < YouShallNotPass::Authorizator
+      def action_policies
+        {
+          create_user: true,
+          update_user: true,
+        }
+      end
+
+      def role_policies
+        {
+          admin: true,
+          editor: true,
+        }
+      end
+
+      def feature_policies
+        {
+          avatars: true,
+          random_player: true,
+        }
+      end
+    end
+
+    spec do
+      YouShallNotPass::Authorizator.new.policies == {}
+    end
+
+    let(:authorizator) { MergePolicies.new }
+
+    spec "merges all the policies" do
+      @expected = {
+        create_user: true,
+        update_user: true,
+        admin: true,
+        editor: true,
+        avatars: true,
+        random_player: true,
+      }
+
+      authorizator.policies == @expected
+    end
+  end
+
+  scope ".attribute" do
+    class UserAuthorizator < YouShallNotPass::Authorizator
+      attribute :user
+      attribute :role
+
+      def policies
+        {
+          something: proc { user == "Me" && role == :admin }
+        }
+      end
+    end
+
+    spec "can initialize with attributes" do
+      authorizator = UserAuthorizator.new(user: "Me", role: :admin)
+
+      authorizator.can?(:something)
+    end
+
+    spec "can initialize with attributes" do
+      authorizator = UserAuthorizator.new(user: "Me", role: :user)
+
+      ! authorizator.can?(:something)
+    end
   end
 end

data/you_shall_not_pass.gemspec

@@ -21,4 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "matest", "~> 1.5"
+  
+  spec.add_dependency "callable", "~> 0.0.3"
+  spec.add_dependency "fattr", "~> 2.2.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: you_shall_not_pass
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Federico Iachetti
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-30 00:00:00.000000000 Z
+date: 2015-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
+- !ruby/object:Gem::Dependency
+  name: callable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+- !ruby/object:Gem::Dependency
+  name: fattr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.2.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.2.2
 description: Embrace authorization with this simple library.
 email:
 - iachetti.federico@gmail.com
@@ -66,7 +94,6 @@ files:
 - Rakefile
 - lib/you_shall_not_pass.rb
 - lib/you_shall_not_pass/authorizator.rb
-- lib/you_shall_not_pass/callable.rb
 - lib/you_shall_not_pass/policy.rb
 - lib/you_shall_not_pass/version.rb
 - spec/spec_helper.rb

data/lib/you_shall_not_pass/callable.rb

@@ -1,16 +0,0 @@
-module YouShallNotPass
-
-  module Callable
-    def Callable( callable_or_not )
-      callable_or_not.respond_to?(:call) ? callable_or_not : proc { |*args| callable_or_not }
-    end
-
-    def callable
-      Callable( self )
-    end
-
-    def callable?
-      self.respond_to? :call
-    end
-  end
-end