ynab 3.5.0 → 3.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc994f9a63594e32cb1b9c8b13306f18f2733eb431053f8dcfef284f7895403b
-  data.tar.gz: 9c28e134e2a37ee05170523094f73f92cb4ee1c66bb031b9fa87720211fb8e2c
+  metadata.gz: 4e7cc95c27139444ec433935a9fc17e06f771ae4a4d021f4fbecade36387cb18
+  data.tar.gz: e7c5352cfdc082da9f48a8a2f66a1b0c174eab6337c6be50e3a16360a4ba1527
 SHA512:
-  metadata.gz: dc6b6d5d897605e05ab6b3ecbbf980dabee50e595fb37b2daba30cf4c0374a1b5ab5dfe7292bfd33dcb031f9ff70728201c7de3f49e024dfe3e4a3a93f0adb6e
-  data.tar.gz: 8fb3ed8420ca14192b5fc275762c28ffce341f611a5010f2f7cc3eb41f4249631c0ec24000877e8e8cf2bf0f45e306061ef93d6191f829456feba5b3125d4bb1
+  metadata.gz: ca7f1029e4c876b0d4e877ec7c26de5ed44bf3af089a57171ba299e9de169ad5e5ec53619d667cdb65c41be338654fea9b1529365220ec8e5af353dc758c3193
+  data.tar.gz: 51f288bf18cc87fe4ac2994b409eac0396afdc7dcea6e802fed6c3bff3f69a8e16962dd7a04df4eb36bb58940a722382bf9e6382fd5ceb0a74e685adb57d7d53

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ynab (3.4.0)
+    ynab (3.5.0)
       typhoeus (~> 1.0, >= 1.0.1)
 
 GEM

data/lib/ynab/models/account_type.rb

@@ -41,8 +41,12 @@ module YNAB
     # @param [String] The enum value in the form of the string
     # @return [String] The enum value
     def build_from_hash(value)
-      return value if AccountType.all_vars.include?(value)
-      raise "Invalid ENUM value #{value} for class #AccountType"
+      if AccountType.all_vars.include?(value)
+        return value
+      else
+        return nil
+      end
     end
   end
+
 end

data/lib/ynab/models/scheduled_transaction_frequency.rb

@@ -41,8 +41,12 @@ module YNAB
     # @param [String] The enum value in the form of the string
     # @return [String] The enum value
     def build_from_hash(value)
-      return value if ScheduledTransactionFrequency.all_vars.include?(value)
-      raise "Invalid ENUM value #{value} for class #ScheduledTransactionFrequency"
+      if ScheduledTransactionFrequency.all_vars.include?(value)
+        return value
+      else
+        return nil
+      end
     end
   end
+
 end

data/lib/ynab/models/transaction_cleared_status.rb

@@ -31,8 +31,12 @@ module YNAB
     # @param [String] The enum value in the form of the string
     # @return [String] The enum value
     def build_from_hash(value)
-      return value if TransactionClearedStatus.all_vars.include?(value)
-      raise "Invalid ENUM value #{value} for class #TransactionClearedStatus"
+      if TransactionClearedStatus.all_vars.include?(value)
+        return value
+      else
+        return nil
+      end
     end
   end
+
 end

data/lib/ynab/models/transaction_flag_color.rb

@@ -35,8 +35,12 @@ module YNAB
     # @param [String] The enum value in the form of the string
     # @return [String] The enum value
     def build_from_hash(value)
-      return value if TransactionFlagColor.all_vars.include?(value)
-      raise "Invalid ENUM value #{value} for class #TransactionFlagColor"
+      if TransactionFlagColor.all_vars.include?(value)
+        return value
+      else
+        return nil
+      end
     end
   end
+
 end

data/lib/ynab/version.rb

@@ -1,3 +1,3 @@
 module YNAB
-  VERSION = '3.5.0'
+  VERSION = '3.6.0'
 end

data/spec/api/transactions_spec.rb

@@ -44,6 +44,18 @@ describe 'transactions' do
         expect(response.data.transactions.length).to be 2
       end
     end
+
+    it 'gracefully handles invalid flag_color values' do
+      # transactions_invalid_flags contains transactions with invalid/unsupported flag_color values
+      VCR.use_cassette("transactions_invalid_flags") do
+        response = instance.get_transactions(budget_id)
+        expect(client.last_request.response.options[:code]).to be 200
+        expect(response.data.transactions.length).to be 2
+        # We expect the flag_color to have been converted to nil for these transactions
+        expect(response.data.transactions[0].flag_color).to be_nil
+        expect(response.data.transactions[1].flag_color).to be_nil
+      end
+    end
   end
 
   describe 'GET /budgets/{budget_id}/category/{category_id}/transactions' do

data/spec/fixtures/vcr_cassettes/transactions_invalid_flags.yml

@@ -0,0 +1,46 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.localhost:3000/v1/budgets/f419ac25-6217-4175-88dc-c3136ff5f6fd/transactions
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - api_client/ruby/0.1.0
+      Content-Type:
+      - application/json
+      Accept:
+      - application/json
+      Authorization:
+      - Bearer 9f1a2c4842b614a771aaae9220fc54ae835e298c4654dc2c9205fc1d7bd1a045
+      Expect:
+      - ''
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - application/json; charset=utf-8
+      Vary:
+      - Accept-Encoding, Origin
+      ETag:
+      - W/"faa32c94f0e94eebee572fe3def08d83"
+      Cache-Control:
+      - max-age=0, private, must-revalidate
+      X-Request-Id:
+      - d290c58c-2261-4564-a267-5ea1ec878fdf
+      X-Runtime:
+      - '0.197369'
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: UTF-8
+      string: '{"data":{"transactions":[{"id":"1f9d45f6-8ba5-476b-8cff-209b3791bd83","date":"2018-02-15","amount":1000000,"memo":null,"cleared":"cleared","approved":true,"flag_color":"","account_id":"5982e895-98e5-41ca-9681-0b6de1036a1c","payee_id":"2141b5d8-5b9b-4a17-be45-3f4a9ac397ec","category_id":"26513650-523e-4e7a-ac0d-f6e78d0a8a03","transfer_account_id":null,"import_id":null,"subtransactions":[]},{"id":"81c374ff-74ab-4d6d-8d5a-ba3ad3fa68e4","date":"2018-02-15","amount":-2000,"memo":"","cleared":"uncleared","approved":true,"flag_color":"invalid","account_id":"5982e895-98e5-41ca-9681-0b6de1036a1c","payee_id":"200e6eb1-02fc-4af6-be26-27c5740bb949","category_id":null,"transfer_account_id":null,"import_id":null,"subtransactions":[]}]}}'
+    http_version: '1.1'
+    adapter_metadata:
+      effective_url: http://api.localhost:3000/v1/budgets/f419ac25-6217-4175-88dc-c3136ff5f6fd/transactions
+  recorded_at: Thu, 15 Feb 2018 19:00:01 GMT
+recorded_with: VCR 3.0.3

data/templates/partial_model_enum_class.mustache

@@ -0,0 +1,26 @@
+  class {{classname}}{{#allowableValues}}{{#enumVars}}
+    {{{name}}} = {{{value}}}.freeze{{/enumVars}}
+
+{{/allowableValues}}
+    def self.all_vars
+      @all_vars ||= [{{#allowableValues}}{{#enumVars}}{{{name}}}{{^-last}}, {{/-last}}{{/enumVars}}{{/allowableValues}}].freeze
+    end
+
+    # Builds the enum from string
+    # @param [String] The enum value in the form of the string
+    # @return [String] The enum value
+    def self.build_from_hash(value)
+      new.build_from_hash(value)
+    end
+
+    # Builds the enum from string
+    # @param [String] The enum value in the form of the string
+    # @return [String] The enum value
+    def build_from_hash(value)
+      if {{classname}}.all_vars.include?(value)
+        return value
+      else
+        return nil
+      end
+    end
+  end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ynab
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.6.0
 platform: ruby
 authors:
 - YNAB
@@ -65,7 +65,6 @@ files:
 - LICENSE.md
 - README.md
 - Rakefile
-- config.json
 - config.yaml
 - docs/Account.md
 - docs/AccountResponse.md
@@ -333,6 +332,7 @@ files:
 - spec/fixtures/vcr_cassettes/scheduled_transactions_unauthorized.yml
 - spec/fixtures/vcr_cassettes/transaction.yml
 - spec/fixtures/vcr_cassettes/transactions.yml
+- spec/fixtures/vcr_cassettes/transactions_invalid_flags.yml
 - spec/fixtures/vcr_cassettes/transactions_unauthorized.yml
 - spec/fixtures/vcr_cassettes/update_transaction.yml
 - spec/fixtures/vcr_cassettes/update_transactions.yml
@@ -345,6 +345,7 @@ files:
 - templates/api_info.mustache
 - templates/gem.mustache
 - templates/gemspec.mustache
+- templates/partial_model_enum_class.mustache
 - templates/partial_model_generic.mustache
 - templates/partial_model_generic_doc.mustache
 - ynab.gemspec
@@ -401,6 +402,7 @@ test_files:
 - spec/fixtures/vcr_cassettes/patch_month_category.yml
 - spec/fixtures/vcr_cassettes/payee_locations_unauthorized.yml
 - spec/fixtures/vcr_cassettes/payee_location.yml
+- spec/fixtures/vcr_cassettes/transactions_invalid_flags.yml
 - spec/fixtures/vcr_cassettes/payee_transactions.yml
 - spec/fixtures/vcr_cassettes/accounts.yml
 - spec/fixtures/vcr_cassettes/categories_unauthorized.yml

data/config.json

@@ -1,9 +0,0 @@
-{
-  "gemName": "ynab",
-  "moduleName": "YNAB",
-  "gemDescription": "Ruby gem wrapper for the YNAB API. Read the documentation at https://api.ynab.com",
-  "gemHomepage": "https://github.com/ynab/ynab-sdk-ruby",
-  "gemLicense": "Apache-2.0",
-  "gemAuthor": "YNAB",
-  "gemAuthorEmail": "api@ynab.com"
-}