yinum 1.7.1 → 1.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 46b4c4c4f5f5cce627f88c4c19607cc77bd23095
-  data.tar.gz: db4d64a617533347040e9b0176fc968b95486f64
+  metadata.gz: 2d50d2731f00aceba47464bf8cbe73d4a91a01f1
+  data.tar.gz: 26bc3ed9869a9c39065ae635627232e5a1aadb19
 SHA512:
-  metadata.gz: 46d4bd89347488975200454f7000cdd61459acf21ede9f1c1ee07858fb4437fdd9cfd032db08f9bc8680f0edb858f97b225b926b48acafccb0ee63289c5bcd25
-  data.tar.gz: e8c496f34c5b983a5cea385eb1ad162e2b0ebf719540de12ffd481d24a10030c493c06aca5ee00e15176e0fd13992ed8c9bc15676c2aba526fbbfb68d8f99848
+  metadata.gz: 857019820b29df357921fe69c2cc006d77af3969f2f9deabee50c9347bc9263680e8fac84cbda800c04a647a8feb779d9807343bafc2f4bd1406ff875fcd78d4
+  data.tar.gz: ba7a24c3960486e6d7766da19fa4434acd8005792db599bb883afa843372b96cee4205e07c8ac6b466a1f03a81d3832b90274508a398f256d2071787a69139b7

data/CHANGELOG.md

@@ -5,5 +5,10 @@
 
 **1.7.1**
 * Remove usage of `reverse_merge`, apparently doesn't exist in Ruby core.
-* `attr_enum`'s writer does not pass an EnumValue to the super.
-* Fix `EnumValue#t` specs (mocking `I18n`).
+* `attr_enum`'s writer does not pass an `EnumValue` to the super.
+* Fix `EnumValue#t` specs (mocking `I18n`).
+
+**1.7.2**
+* Added `Object#enum_value?` to fix `attr_enum`'s writer, `BasicObject` does
+  not have `respond_to?`.
+* Fix specs that didn't catch above bug.

data/Gemfile.lock

@@ -6,15 +6,15 @@ PATH
 GEM
   remote: http://rubygems.org/
   specs:
-    diff-lcs (1.1.3)
-    rspec (2.12.0)
-      rspec-core (~> 2.12.0)
-      rspec-expectations (~> 2.12.0)
-      rspec-mocks (~> 2.12.0)
-    rspec-core (2.12.1)
-    rspec-expectations (2.12.0)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.12.0)
+    diff-lcs (1.2.5)
+    rspec (2.14.1)
+      rspec-core (~> 2.14.0)
+      rspec-expectations (~> 2.14.0)
+      rspec-mocks (~> 2.14.0)
+    rspec-core (2.14.8)
+    rspec-expectations (2.14.5)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.14.6)
 
 PLATFORMS
   ruby

data/lib/enum/enum_value.rb

@@ -1,3 +1,9 @@
+class Object
+  def enum_value?
+    false
+  end
+end
+
 class Enum::EnumValue < BasicObject
   attr_reader :enum, :name, :value
 
@@ -70,10 +76,6 @@ class Enum::EnumValue < BasicObject
     end
   end
 
-  def methods
-    super + @value.methods
-  end
-
   def method_missing(method, *args, &block)
     match = method.to_s.match(/^(.+)\?$/)
     enum_name = match[1].to_sym if match

data/lib/enum/helpers/enum_attribute.rb

@@ -22,7 +22,7 @@ module Enum::Helpers::EnumAttribute
     define_method(attr) { v = super(); (v.nil? or not e.values.include?(v)) ? Enum::EnumValue.new(e, v) : e[v] }
     # attribute writer
     define_method("#{attr}=") do |v|
-      if v.respond_to?(:enum_value?) and v.enum_value?
+      if v.enum_value?
         super(v.value)
       elsif v.nil?
         super(v)

data/lib/enum/version.rb

@@ -1,3 +1,3 @@
 class Enum
-  VERSION = '1.7.1'
+  VERSION = '1.7.2'
 end

data/spec/lib/enum/helpers/enum_attribute_spec.rb

@@ -51,19 +51,19 @@ def enum_attribute_specs
       specify "nil" do
         @record.color = nil
         @record[:color].should be_nil
-        @record[:color].should_not respond_to(:enum_value?)
+        @record[:color].should_not be_enum_value
       end
 
       specify "name" do
         @record.color = :red
-        @record[:color] == 1
-        @record[:color].should_not respond_to(:enum_value?)
+        @record[:color].should == 1
+        @record[:color].should_not be_enum_value
       end
 
       specify "value" do
         @record.color = 2
-        @record[:color] == 2
-        @record[:color].should_not respond_to(:enum_value?)
+        @record[:color].should == 2
+        @record[:color].should_not be_enum_value
       end
 
       specify "invalid" do
@@ -75,16 +75,19 @@ def enum_attribute_specs
       specify "nil" do
         @record[:color] = nil
         @record.color.should be_nil
+        @record.color.should be_enum_value
       end
 
       specify "value" do
         @record[:color] = 2
-        @record.color.should be_enum_value and @record.color.should be_blue
+        @record.color.should be_blue
+        @record.color.should be_enum_value
       end
 
       specify "invalid" do
         @record[:color] = 3
-        @record.color.should_not respond_to(:enum_value?) and @record.color.should == 3
+        @record.color.should == 3
+        @record.color.should be_enum_value
       end
     end # context "getter"
   end # context "attribute"

data/spec/lib/enum/helpers/enum_column_spec.rb

@@ -71,18 +71,19 @@ def enum_columns_attribute_specs
       specify "nil" do
         @record.color = nil
         @record[:color].should be_nil
+        @record[:color].should_not be_enum_value
       end
 
       specify "name" do
         @record.color = :red
         @record[:color].should == 1
-        @record[:color].should_not respond_to(:enum_value?)
+        @record[:color].should_not be_enum_value
       end
 
       specify "value" do
         @record.color = 2
         @record[:color].should == 2
-        @record[:color].should_not respond_to(:enum_value?)
+        @record[:color].should_not be_enum_value
       end
 
       specify "invalid" do
@@ -94,16 +95,19 @@ def enum_columns_attribute_specs
       specify "nil" do
         @record[:color] = nil
         @record.color.should be_nil
+        @record.color.should be_enum_value
       end
 
       specify "value" do
         @record[:color] = 2
-        @record.color.should be_enum_value and @record.color.should be_blue
+        @record.color.should be_blue
+        @record.color.should be_enum_value
       end
 
       specify "invalid" do
         @record[:color] = 3
-        @record.color.should_not respond_to(:enum_value?) and @record.color.should == 3
+        @record.color.should == 3
+        @record.color.should be_enum_value
       end
     end # context "getter"
   end # context "attribute"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yinum
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 1.7.2
 platform: ruby
 authors:
 - Oded Niv