yieldmanager 0.9.10 → 0.9.11

data/.travis.yml

@@ -2,6 +2,7 @@ language: ruby
 rvm:
 - 1.9.3
 - 2.0
+- 2.1
 - jruby-19mode
 env:
   global:
@@ -9,3 +10,4 @@ env:
   - secure: ZFxeI+npRXNbhQNIWNu1/MOl6fbNt84kD7AJF62E/LfjEVQZKohm6Zfm2pUrfAF7UWGnpb/ZYDusj3EnzazyUvfkd8Gj40XWXwjv0jvfnV3p8yUkAIbHKlEQqKWnbppMM7i0z+uAyJW1VFU/H50ZiuaPXTdB4LzJXH2crJQXnaQ=
   - secure: A8iYjMBh3OPznTKD/rPztz3tWGBrdJzmlakf3JrTLLWfHHxCE+lHip/Z/EVvTb3ec37owNjh0W8Z8yTPkz54FM++tM/t/W/eR8c71y2V4SI6ln+0wv5Uh5WNqVYpCsAn1DiZ3W4j1LpMGKbnw5ShyV89wfefC2JV55jQorQbth8=
   - secure: TE+/zUZh6brUT4q/oIKqgQH8P4mMPdeav+gUiRvkh5mtwX0HCPMW1Eq7+AoaxsTvksQfUbQLaObGGuQ3xn6ZkiE98lG6y1rk/3Q7keZLQ7zHDP2ucxAtRS/YBTKlcY5yVaj3oRoG4J0XGvN18YNXKB7jRb95HsIRIpSVmvbDjKA=
+  - secure: T0AM8anAGrZom/gGoOQPwsDkpP0yQWw5MMs0+GCHJTut0GURMJdbPy7S7UA8YE6PwRhvKRA7Jp//QUnWWq21152u+b25RwvOIXXeGqfDGHgp9Y8n0MMB8yL6GM3+c7gKTbAf544mkzjTWEQZOrTmeqtN91LstVz5W5RjqN5xkRU=

data/README.md

@@ -21,7 +21,7 @@ Yieldmanager is available as a gem for easy installation.
 sudo gem install yieldmanager
 ```
 
-or if you're using [RVM](https://rvm.beginrescueend.com/) (and why on earth wouldn't you?)
+or if you're using [RVM](https://rvm.io/) (and why on earth wouldn't you?)
 
 ```
 gem install yieldmanager
@@ -100,6 +100,28 @@ SOAP parser will interpret the returned SOAP object as
 an AR Creative object, resulting in bizarre errors. Uniquely
 re-name your AR object to eliminate the conflict.
 
+### WSDL validation checks
+
+**NOTE** this feature is not thread-safe!
+
+Due to an unknown bug, soap4r occasionally reports that a field is required when it really isn't. If you get an error along the lines of
+
+```
+XSD::ValueSpaceError: {https://api.yieldmanager.com/types}enum_ad_tag_type: cannot accept ''
+```
+
+...you can disable this checking temporarily by calling
+
+```
+@ym.disable_check_restriction
+```
+
+When you're done with the call, re-enable it using
+
+```
+@ym.enable_check_restriction
+```
+
 ### Pagination
 
 Some calls return datasets too large to retrieve all at once.

data/lib/yieldmanager/client.rb

@@ -45,9 +45,11 @@ end
 
 
 # Monkey-patch to eliminate bogus "cannot be null" errors from YM wsdl
+# "SKIP" is controlled via (enable|disable)_check_restriction methods
 class WSDL::XMLSchema::SimpleType
   private
   def check_restriction(value)
+    return value if ENV["YIELDMANAGER_CHECK_RESTRICTION"] == "SKIP"
     unless @restriction.valid?(value) || @name.to_s =~ /(enum_creative_third_party_types|enum_ym_numbers_difference)/
       raise XSD::ValueSpaceError.new("#{@name}: cannot accept '#{value}'")
     end
@@ -177,6 +179,19 @@ module Yieldmanager
       report
     end
 
+    # Disable WSDL restriction checking until re-enabled
+    # Some services complain incorrectly about nillable fields requiring values
+    # Disabling this checking allows them to pass properly
+    def disable_check_restriction
+      ENV["YIELDMANAGER_CHECK_RESTRICTION"] = "SKIP"
+    end
+
+    # Enable WSDL restriction checking (it's on by default)
+    # This is only needed when you've explicitly disabled the behavior previously
+    def enable_check_restriction
+      ENV["YIELDMANAGER_CHECK_RESTRICTION"] = nil
+    end
+
     def self.api_version
       version_file = "API_VERSION"
       path = File.join(File.dirname(__FILE__), '..', '..', version_file)

data/lib/yieldmanager/version.rb

@@ -1,3 +1,3 @@
 module Yieldmanager
-  VERSION = "0.9.10"
+  VERSION = "0.9.11"
 end

data/spec/yieldmanager/client_spec.rb

@@ -139,6 +139,26 @@ describe "A new Yieldmanager client" do
       expect(e.message).not_to match(/enum_ym_numbers_difference: cannot accept ''/)
     end
   end
+
+  it "skips check_restriction when necessary" do
+    @ym.session do |t|
+      expect{ get_pub_tags(t) }.to raise_error(/enum_ad_tag_type: cannot accept ''/)
+
+      begin
+        @ym.disable_check_restriction
+        get_pub_tags(t)
+      ensure
+        @ym.enable_check_restriction
+      end
+
+      expect{ get_pub_tags(t) }.to raise_error(/enum_ad_tag_type: cannot accept ''/)
+    end
+  end
+
+  def get_pub_tags t
+    id = ENV["YIELDMANAGER_PUBLISHER_SECTION_ID"].to_i
+    @ym.entity.getPubAdTags(t, [id], { banners_size_ids: [2,6,10] })
+  end
   
   describe "A Yieldmanager report" do
 

metadata

@@ -1,18 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: yieldmanager
 version: !ruby/object:Gem::Version
-  version: 0.9.10
+  version: 0.9.11
+  prerelease: 
 platform: ruby
 authors:
 - Bill Gathen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-17 00:00:00.000000000 Z
+date: 2014-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -20,6 +22,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -27,6 +30,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -34,6 +38,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -41,6 +46,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -48,6 +54,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -55,6 +62,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -62,6 +70,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -69,6 +78,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: mini_portile
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -76,6 +86,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -83,6 +94,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: soap4r
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -90,6 +102,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -137,26 +150,27 @@ files:
 homepage: http://github.com/billgathen/yieldmanager
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.10
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: YieldManager API Tool
 test_files:
 - spec/patch_detector_spec.rb
@@ -165,3 +179,4 @@ test_files:
 - spec/spec_helper.rb
 - spec/yieldmanager/client_spec.rb
 - spec/yieldmanager/report_spec.rb
+has_rdoc: 

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZjcwYTg3N2NkMTEzOWJkMjRiNzRjMDljNjIyZjE4ZWVjNzg3YmFjOA==
-  data.tar.gz: !binary |-
-    YzEzZGViZDU5OGM1MGQ5NDJjNzc3YzVlMDAzNGZjYzAwZDhmN2JlYw==
-SHA512:
-  metadata.gz: !binary |-
-    ZjJhNTkxOWZmNjRhMWI3NzU2NWMzY2I4MzMxMTdkNzhkNDE4YzgzNjcxYmZm
-    YzhhYTllN2E2OTkxODlhYWU1ZTIzZGUxYzc0MjUxZGQzZTlmZDgzMTY1ZWM2
-    ZTA5YWNlMThhZDhhNzExOWE3MWMzNzNkZWRmNjk4ODI0OGYyM2Q=
-  data.tar.gz: !binary |-
-    MDYxMmFkOWY2NTcyNDlhNjUyYzk3MjI1NDdkNDU1YjBhMTA5N2QxMjMwOGJh
-    MzQ2NzNkNTU2YmM2Y2ViM2UwN2I5MjhmZDkzMjIzOGIxNWNjNWQ3ZDliMzI1
-    MGJmNzEzNzhkMzI2ZDJkZWY5NjBmYjdlMmY5NTgzYmE2ZDg0ZDE=