yfinance 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 98f8be13814463fc01eae9f18f585ab71febae8e
-  data.tar.gz: 95aa6ed0c2d29dc538cd4addb4a4b428e70c4301
+  metadata.gz: f4c8f8cb69a0ec6b3be6d435fef5f4c7aefd2e0b
+  data.tar.gz: 21b6e341cb7eba6c30bc57450dc8263ae9bde03c
 SHA512:
-  metadata.gz: c8388c6431bebbb5192d4cecfe0f279d7129d14027678ed61b6cfd25ca622f28f900ebdc591c53ae644d433fc3dfd493ecbe5df2976680d573ae0d58a9f44fdf
-  data.tar.gz: e42b7224a6e838df45632c841f7eb628ceab86c3ad425749ff1f03c47ed88b66438211d1b3f93552a936a0d59daef29ae13582960931576858514c23ac5126de
+  metadata.gz: d168726e7cde571255d627c427cdda5dcdb4d50321092ff847a4d4df032061836aff8f62d51b87fdaad81899f78586ce0066df4eb33296229991a4337013528f
+  data.tar.gz: 3bea5eca2dabdb125dae0841526b07cb4f155057ace29128268dc16d088e760fed7470cc06a12a390e170f9268f1efacd95e521b8e2a63fb4102258248f9a15a

data/lib/yfinance.rb

@@ -151,9 +151,13 @@ class Yfinance
     url = "http://download.finance.yahoo.com/d/quotes.csv?s=#{URI.escape(symb_str)}&f=#{columns}"
     request = Typhoeus::Request.new(url, method: :get)
     request.on_complete do |response|
-      result = CSV.parse(response.body, headers: columns_array)
-      result.each do |row|
-        ret << OpenStruct.new(row.to_hash) 
+      begin
+        result = CSV.parse(response.body, headers: columns_array)
+        result.each do |row|
+          ret << row.to_hash#OpenStruct.new(row.to_hash) 
+        end
+      rescue
+        ret = {name: "unknown symbol"}#OpenStruct.new(name: "unknown symbol")
       end
       return ret
     end
@@ -181,7 +185,7 @@ class Yfinance
         if response.body[0..40] != "Date,Open,High,Low,Close,Volume,Adj Close"
           raise YahooFinanceException.new(" * Error: Unknown response body from Yahoo - #{ response.body[0..40] } ...")
         else
-          result = CSV.parse(response.body, headers: cols)
+          result = CSV.parse(response.body, headers: cols).to_a
           result.delete(0)
           callback.call(result)
         end

data/test/yfinance_test.rb

@@ -16,7 +16,19 @@ class YfinanceTest < Minitest::Test
   def test_it_works_requesting_all_data_for_valid_symbols
     yf = Yfinance.new
     res = yf.quotes_all_info(["AAPL", "TWTR", "TEP.L"])
-    assert_equal res.length, 2
+    assert_equal res.length, 3
+  end
+
+  def test_it_works_requesting_all_data_for_one_invalid_symbol
+    yf = Yfinance.new
+    res = yf.quotes_all_info(["asdfasdfiajsodfi"])
+    assert_equal res.name, "unknown symbol"
+  end
+  
+  def test_it_works_requesting_all_data_for_a_mix_of_valid_and_invalid__symbols
+    yf = Yfinance.new
+    res = yf.quotes_all_info(["AAPL", "asdfasdfiajsodfi", "MSFT"])
+    assert_equal res, "unknown symbol"
   end
 
 end

data/yfinance.gemspec

@@ -5,7 +5,7 @@ require 'yfinance'
 
 Gem::Specification.new do |spec|
   spec.name          = "yfinance"
-  spec.version       = "1.0.3"
+  spec.version       = "1.0.4"
   spec.authors       = ["Alexander Potrykus"]
   spec.email         = ["alexander@risklog.io"]
   spec.summary       = %q{Fetches Yahoo! Finance data using parallel HTTP requests.}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yfinance
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Alexander Potrykus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-26 00:00:00.000000000 Z
+date: 2014-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -102,7 +102,8 @@ licenses:
 metadata: {}
 post_install_message: 
 rdoc_options: []
-require_paths: lib
+require_paths:
+- lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -115,7 +116,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.1
 signing_key: 
 specification_version: 4
 summary: Fetches Yahoo! Finance data using parallel HTTP requests.