yfinance 1.0.10 → 1.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec8af8ce71dfa3e2005b7dc2463e9fed6bd74d0b
-  data.tar.gz: 6a7a22cf66e59f1a1bcc021f318a64d4287a480d
+  metadata.gz: 246dc6eddd72d55071b137e94a5adc17850be66c
+  data.tar.gz: 13f32b0307fa2bdfd2404c9e2db65bb15afd01d2
 SHA512:
-  metadata.gz: b644597c8b49388e83fa5b6bef8d1d288717da78972325cca955af5d702c0e6df7dadbb711547414674131bb5929bf15570a714490550ef28a155c7d862cb271
-  data.tar.gz: 7fae35e0492dc94a19fc0be530046377c4d9190a53a9a939623a2d7e22d55a628a22e7ce4cf6735b317defb65a9c20f5cde517a3aeb397f1d3b9bcc393d7d59a
+  metadata.gz: f7e3ed3d417f8b921f8d71945533d73d31b0d6b02d4ced8b5ef24856d5cb147dbfcba4cc662627b3aaa9ffa6023931730dc998be97f44b8b9b9c02ffb450aa28
+  data.tar.gz: 367305c56a9a76add28e559bcfe0dc4869b3e0dea91501bd9ab43afeb3591cbb7d9b6e5317004ab13b48b2be1923f3d7b2e3b69ad507ff059ca37d944ba90cf4

data/lib/yfinance.rb

@@ -101,6 +101,9 @@ class Yfinance
      :stock_exchange => "x",
      :dividend_yield => "y"
   }
+
+  # these options do not mess up the CSV parser by including ',' in the data fields
+  SAVE_OPTIONS = [:symbol, :name, :average_daily_volume, :dividend_per_share, :earnings_per_share, :eps_estimate_current_year, :eps_estimate_next_year, :eps_estimate_next_quarter, :low_52_weeks, :high_52_weeks, :market_capitalization, :ebitda, :moving_average_50_day, :moving_average_200_day, :ex_dividend_date, :peg_ratio, :price_eps_estimate_current_year, :shares_owned, :volume, :stock_exchange, :dividend_yield, :change, :previous_close, :last_trade_trade]
   
   HISTORICAL_MODES = {
     :daily => "d",
@@ -126,7 +129,7 @@ class Yfinance
      options[:raw] ||= true
      options[:period] ||= :daily
      symbols_array.each do |symbol|
-       symbol = symbol.rstrip
+       symbol = symbol.rstrip.upcase
        url = "http://ichart.finance.yahoo.com/table.csv?s=#{URI.escape(symbol)}&d=#{end_date.month-1}&e=#{end_date.day}&f=#{end_date.year}&g=#{HISTORICAL_MODES[options[:period]]}&a=#{start_date.month-1}&b=#{start_date.day}&c=#{start_date.year}&ignore=.csv"
       @hydra.queue(make_request(url, symbol, options, callback))
     end
@@ -147,6 +150,7 @@ class Yfinance
 
   def quotes(symbols_array, columns_array = [:symbol, :last_trade_price, :last_trade_date, :change, :previous_close], options = {})
     options[:raw] ||= true
+    symbols_array = symbols_array.map(&:upcase)
     ret = Hash[symbols_array.each_slice(1).to_a]
     symb_str = symbols_array.join("+")
     columns_array.unshift(:symbol)
@@ -158,9 +162,13 @@ class Yfinance
         result = CSV.parse(response.body, headers: columns_array)
         result.each do |row|
           h = row.to_hash
-          ret[h[:symbol]] = h
-          return ret
+          if h[:name] == h[:symbol]
+            ret[h[:symbol]] = nil 
+          else 
+            ret[h[:symbol]] = h
+          end
         end
+        return ret
       rescue
         return {error: @error_message}
       end
@@ -170,8 +178,7 @@ class Yfinance
   end
 
   def quotes_all_info(symbols_array)
-    columns_array = COLUMNS.keys
-    quotes(symbols_array, columns_array)
+    quotes(symbols_array, SAVE_OPTIONS)
   end
 
   private

data/test/yfinance_test.rb

@@ -21,28 +21,30 @@ class YfinanceTest < Minitest::Test
 
   def test_it_work_for_an_invalid_symbol
     yf = Yfinance.new
-    res = yf.quotes(["TWTR", "MADASDFASD", "AAPL"])
+    res = yf.quotes_all_info(["TWTR", "MADASDFASD", "AAPL"])
     assert_equal res.length, 3
   end
-  #
+
   def test_it_works_requesting_all_data_for_valid_symbols
     yf = Yfinance.new
     res = yf.quotes_all_info(["MSFT", "TWTR", "TEP.L"])
-    # p res
-    assert_equal res.length, 3 
+    assert_equal 3, res.length
     assert_equal "MSFT", res["MSFT"][:symbol]
+    assert_equal "TWTR", res["TWTR"][:symbol]
+    assert_equal "TEP.L", res["TEP.L"][:symbol]
   end
-  #
+
   def test_it_works_requesting_all_data_for_one_invalid_symbol
     yf = Yfinance.new
     res = yf.quotes_all_info(["asdf"])
-    assert_equal yf.error_message, res[:error] 
+    assert_nil res["ASDF"] 
   end
 
   def test_it_returns_an_error_for_a_mix_of_valid_and_invalid__symbols
     yf = Yfinance.new
     res = yf.quotes_all_info(["AAPL", "bcxza", "MSFT"])
-    assert_equal yf.error_message, res[:error]
+    assert_equal 3, res.length
+    assert_nil res["BCXZA"]
   end
   #
   def test_historical_data_works

data/yfinance.gemspec

@@ -5,7 +5,7 @@ require 'yfinance'
 
 Gem::Specification.new do |spec|
   spec.name          = "yfinance"
-  spec.version       = "1.0.10"
+  spec.version       = "1.0.11"
   spec.authors       = ["Alexander Potrykus"]
   spec.email         = ["alexander@risklog.io"]
   spec.summary       = %q{Fetches Yahoo! Finance data using parallel HTTP requests.}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yfinance
 version: !ruby/object:Gem::Version
-  version: 1.0.10
+  version: 1.0.11
 platform: ruby
 authors:
 - Alexander Potrykus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-17 00:00:00.000000000 Z
+date: 2014-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler