yfinance 1.0.9 → 1.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 81e27766934f17e64ea6fbc03920e4376b84e3fd
-  data.tar.gz: ea7b06fa093fba8e361e3b27136af24a23a939f5
+  metadata.gz: ec8af8ce71dfa3e2005b7dc2463e9fed6bd74d0b
+  data.tar.gz: 6a7a22cf66e59f1a1bcc021f318a64d4287a480d
 SHA512:
-  metadata.gz: ca7256197fe68faf2d97d826d4f3abe28ba96e62e9c2c73bab27877579e199864eeb0f0b4b4882d152e1a5203547db784757fcc9e36f0217f5f7d2c43ae57ee4
-  data.tar.gz: b265f3edac262e1bc13b65c03c825d6cdd33f852d17188d2327e1dbe24cb1680ecc7fcbb43435646198d152e7e96041ff40ea4b23510feec439a3ebcd7950890
+  metadata.gz: b644597c8b49388e83fa5b6bef8d1d288717da78972325cca955af5d702c0e6df7dadbb711547414674131bb5929bf15570a714490550ef28a155c7d862cb271
+  data.tar.gz: 7fae35e0492dc94a19fc0be530046377c4d9190a53a9a939623a2d7e22d55a628a22e7ce4cf6735b317defb65a9c20f5cde517a3aeb397f1d3b9bcc393d7d59a

data/lib/yfinance.rb

@@ -5,6 +5,8 @@ require 'json'
 
 class Yfinance
 
+  attr_reader :error_message
+
   class YahooFinanceException < Exception
   end
 
@@ -110,6 +112,7 @@ class Yfinance
   def initialize(max_concurrency: 20, memoize: false)
     @hydra = Typhoeus::Hydra.new(max_concurrency: max_concurrency)
     Typhoeus::Config.memoize = memoize
+    @error_message = "Symbol not found"
   end
 
   def run
@@ -144,8 +147,9 @@ class Yfinance
 
   def quotes(symbols_array, columns_array = [:symbol, :last_trade_price, :last_trade_date, :change, :previous_close], options = {})
     options[:raw] ||= true
-    ret = []
+    ret = Hash[symbols_array.each_slice(1).to_a]
     symb_str = symbols_array.join("+")
+    columns_array.unshift(:symbol)
     columns = "#{columns_array.map {|col| COLUMNS[col] }.join('')}"
     url = "http://download.finance.yahoo.com/d/quotes.csv?s=#{URI.escape(symb_str)}&f=#{columns}"
     request = Typhoeus::Request.new(url, method: :get)
@@ -153,12 +157,13 @@ class Yfinance
       begin
         result = CSV.parse(response.body, headers: columns_array)
         result.each do |row|
-          ret << row.to_hash#OpenStruct.new(row.to_hash) 
+          h = row.to_hash
+          ret[h[:symbol]] = h
+          return ret
         end
       rescue
-        ret = {name: "unknown symbol"}#OpenStruct.new(name: "unknown symbol")
+        return {error: @error_message}
       end
-      return ret
     end
     @hydra.queue(request)
     @hydra.run

data/test/yfinance_test.rb

@@ -3,37 +3,51 @@ require 'test_helper.rb'
 class YfinanceTest < Minitest::Test
   def test_it_receives_quotes_for_valid_symbols
     yf = Yfinance.new
-    res = yf.quotes(["AAPL", "TWTR"])
+    res = yf.quotes(["AAPL"])
     refute_empty res
   end
 
+  def test_it_returns_a_hash
+    yf = Yfinance.new
+    res = yf.quotes(["MSFT", "TEP.L"])
+    assert res.kind_of?(Hash), "It does NOT return a hash"
+  end
+
+  def test_it_always_adds_the_symbol_to_the_resulting_hash
+    yf = Yfinance.new
+    res = yf.quotes(["TWTR", "BARC.L"], [:last_trade_date, :close])
+    assert_equal res["TWTR"][:symbol], "TWTR"
+  end
+
   def test_it_work_for_an_invalid_symbol
     yf = Yfinance.new
     res = yf.quotes(["TWTR", "MADASDFASD", "AAPL"])
     assert_equal res.length, 3
   end
-
+  #
   def test_it_works_requesting_all_data_for_valid_symbols
     yf = Yfinance.new
     res = yf.quotes_all_info(["MSFT", "TWTR", "TEP.L"])
-    assert_equal res.length, 3
+    # p res
+    assert_equal res.length, 3 
+    assert_equal "MSFT", res["MSFT"][:symbol]
   end
-
+  #
   def test_it_works_requesting_all_data_for_one_invalid_symbol
     yf = Yfinance.new
-    res = yf.quotes_all_info(["asdfasdfiajsodfi"])
-    assert_equal res[:name], "unknown symbol"
+    res = yf.quotes_all_info(["asdf"])
+    assert_equal yf.error_message, res[:error] 
   end
 
-  def test_it_works_requesting_all_data_for_a_mix_of_valid_and_invalid__symbols
+  def test_it_returns_an_error_for_a_mix_of_valid_and_invalid__symbols
     yf = Yfinance.new
-    res = yf.quotes_all_info(["AAPL", "asdfasdfiajsodfi", "MSFT"])
-    assert_equal res[:name], "unknown symbol"
+    res = yf.quotes_all_info(["AAPL", "bcxza", "MSFT"])
+    assert_equal yf.error_message, res[:error]
   end
-
+  #
   def test_historical_data_works
     yf = Yfinance.new
-    res = Proc.new { |resp| p resp }
+    res = Proc.new { |resp| assert resp["MSFT"].kind_of?(Array)}
     yf.add_historical_data_query(['MSFT'], '2013-01-01', Date.today, {period: :daily}, &res)
     yf.run
   end

data/yfinance.gemspec

@@ -5,7 +5,7 @@ require 'yfinance'
 
 Gem::Specification.new do |spec|
   spec.name          = "yfinance"
-  spec.version       = "1.0.9"
+  spec.version       = "1.0.10"
   spec.authors       = ["Alexander Potrykus"]
   spec.email         = ["alexander@risklog.io"]
   spec.summary       = %q{Fetches Yahoo! Finance data using parallel HTTP requests.}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yfinance
 version: !ruby/object:Gem::Version
-  version: 1.0.9
+  version: 1.0.10
 platform: ruby
 authors:
 - Alexander Potrykus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-16 00:00:00.000000000 Z
+date: 2014-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler