yeller_ruby 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d42737cc1ec35e99dd72cd70479e087239f970d8
-  data.tar.gz: 782addb9a7232e15533ad8a7e01efaa177fadea3
+  metadata.gz: 1bc4dfe4cdd8c6603b2d69c726871777fd36f993
+  data.tar.gz: d20de3a957643e0104836a088b06114db1bcbfaf
 SHA512:
-  metadata.gz: e2b049ad4ce727a49e41dc493a110af32abfba5a65057d7e105d159d7802db8fd328d0ac3e3a23e8641a04c4e748d57ae91df8b88ab760d1289bf4c86ba493bc
-  data.tar.gz: e5b740b66434058f15241845ded775030713ad15553da74c33634fa91751d8f410c00917fec9ca810bb4de6292752563d1424cafcecf6482856ed7a6c77d624d
+  metadata.gz: 4b2a330661919869d5aea4b0087623972efb09d0633fa614e835b60edcb54c2a5cfd5770d019b248afa916481b9ce4ad4727509be2c5d3cd80788979852d9863
+  data.tar.gz: e1c9d17782072e4e273b89614ae130e60ea28c8b8f373b99c891fb02ea4d9bcfb5ae1c5c7c8acb730763559ece461f05052892ac3387bdeaafb0fade10aa9537

data/lib/yeller.rb

@@ -10,6 +10,7 @@ require_relative 'yeller/server'
 require_relative 'yeller/version'
 require_relative 'yeller/startup_params'
 require_relative 'yeller/log_error_handler'
+require_relative 'yeller/verify_log'
 
 if defined?(::Rails)
   require 'yeller/rails'

data/lib/yeller/client.rb

@@ -19,12 +19,18 @@ module Yeller
     end
 
     def report_with_roundtrip(serialized, error_count)
-      next_server.client.post("/#{@token}", serialized, {"Content-Type" => "application/json"})
-      @reported_error ||= true
+      response = next_server.client.post("/#{@token}", serialized, {"Content-Type" => "application/json"})
+      if response.code.to_i >= 200 && response.code.to_i <= 300
+        Yeller::VerifyLog.reported_to_api!
+        @reported_error ||= true
+      else
+        Yeller::VerifyLog.error_code_from_api!(response)
+      end
     rescue StandardError => e
       if error_count <= (@servers.size * 2)
         report_with_roundtrip(serialized, error_count + 1)
       else
+        Yeller::VerifyLog.exception_from_api!(e)
         @error_handler.handle(e)
       end
     end

data/lib/yeller/rack.rb

@@ -10,6 +10,7 @@ module Yeller
     end
 
     def self.report(exception, options={})
+      Yeller::VerifyLog.reporting_to_yeller_rack!
       @client.report(exception, options)
     end
 

data/lib/yeller/rails.rb

@@ -50,15 +50,29 @@ module Yeller
 
       protected
       def render_exception_with_yeller(env, exception)
-        controller = env['action_controller.instance']
-        params = controller.send(:params)
-        request = ::Rack::Request.new(env)
-        Yeller::Rack.report(
-          exception,
-          :url => request.url,
-          :location => "#{controller.class.to_s}##{params[:action]}",
-          :custom_data => controller._yeller_custom_data
-        )
+        Yeller::VerifyLog.render_exception_with_yeller!
+        begin
+          request = ::Rack::Request.new(env)
+          controller = env['action_controller.instance']
+
+          if controller
+            params = controller.send(:params)
+            Yeller::Rack.report(
+              exception,
+              :url => request.url,
+              :location => "#{controller.class.to_s}##{params[:action]}",
+              :custom_data => controller._yeller_custom_data
+            )
+          else
+            Yeller::VerifyLog.action_controller_instance_not_in_env!
+            Yeller::Rack.report(
+              exception,
+              :url => request.url
+            )
+          end
+        rescue => e
+          Yeller::VerifyLog.error_reporting_rails_error!(e)
+        end
 
         render_exception_without_yeller(env, exception)
       end
@@ -71,8 +85,11 @@ module Yeller
 
       config.after_initialize do
         if defined?(::ActionDispatch::DebugExceptions)
+          Yeller::VerifyLog.monkey_patching_rails!("ActionDispatch::DebugExceptions")
           ::ActionDispatch::DebugExceptions.send(:include, Yeller::Rails::ActionControllerCatchingHooks)
-        elsif defined(::ActionDispatch::ShowExceptions)
+        end
+        if defined?(::ActionDispatch::ShowExceptions)
+          Yeller::VerifyLog.monkey_patching_rails!("ActionDispatch::ShowExceptions")
           ::ActionDispatch::ShowExceptions.send(:include, Yeller::Rails::ActionControllerCatchingHooks)
         end
         ActionController::Base.send(:include, Yeller::Rails::ControllerMethods)

data/lib/yeller/rails/tasks.rb

@@ -1,7 +1,11 @@
 require 'action_controller/test_case'
 namespace :yeller do
+  task :enable_verify_log => [] do
+    Yeller::VerifyLog.enable!
+  end
+
   desc "verify your yeller gem installation by sending a test exception to yeller's servers"
-  task :verify => [:environment] do
+  task :verify => [:enable_verify_log, :environment] do
     Dir["app/controllers/application*.rb"].each { |file| require(File.expand_path(file)) }
 
     catcher = Yeller::Rails::ActionControllerCatchingHooks
@@ -29,6 +33,7 @@ namespace :yeller do
       prepend_before_filter :verify_yeller
 
       def verify_yeller
+        Yeller::VerifyLog.about_to_raise_exception_in_controller!
         raise YellerVerifyException.new("verifying that yeller works")
       end
 
@@ -62,6 +67,7 @@ namespace :yeller do
         Kernel.puts "ERROR: CLIENT NOT ENABLED yeller-verification-failed enabled=#{client.enabled?} token=\"#{client.token}\""
         Kernel.puts "Yeller rails client not enabled, check development_environments setting"
       else
+        Yeller::StdoutVerifyLog.print_log!
         Kernel.puts "ERROR yeller-verification-failed enabled=#{client.enabled?} token=\"#{client.token}\""
       end
       exit 126

data/lib/yeller/verify_log.rb

@@ -0,0 +1,143 @@
+module Yeller
+  class NoopLog
+    def self.monkey_patching_rails!(rails_class)
+    end
+
+    def self.render_exception_with_yeller!
+    end
+
+    def self.error_reporting_rails_error!(e)
+    end
+
+    def self.action_controller_instance_not_in_env!
+    end
+
+    def self.reported_to_api!
+    end
+
+    def self.error_code_from_api!(response)
+    end
+
+    def self.exception_from_api!(e)
+    end
+
+    def self.about_to_raise_exception_in_controller!
+    end
+
+    def self.reporting_to_yeller_rack!
+    end
+  end
+
+  class VerifyLog
+    @logger = NoopLog
+
+    def self.enable!
+      @logger = StdoutVerifyLog
+    end
+
+    def self.monkey_patching_rails!(rails_class)
+      @logger.monkey_patching_rails!(rails_class)
+    end
+
+    def self.render_exception_with_yeller!
+      @logger.render_exception_with_yeller!
+    end
+
+    def self.error_reporting_rails_error!(e)
+      @logger.error_reporting_rails_error!(e)
+    end
+
+    def self.action_controller_instance_not_in_env!
+      @logger.action_controller_instance_not_in_env!
+    end
+
+    def self.reported_to_api!
+      @logger.reported_to_api!
+    end
+
+    def self.error_code_from_api!(response)
+      @logger.error_code_from_api!(response)
+    end
+
+    def self.exception_from_api!(e)
+      @logger.exception_from_api!(e)
+    end
+
+    def self.about_to_raise_exception_in_controller!
+      @logger.about_to_raise_exception_in_controller!
+    end
+
+    def self.reporting_to_yeller_rack!
+      @logger.reporting_to_yeller_rack!
+    end
+  end
+
+  class StdoutVerifyLog
+    def self.print_log!
+      @log ||= []
+      @log.each do |line|
+        puts line
+      end
+    end
+
+    def self.monkey_patching_rails!(rails_class)
+      info("monkeypatching rails #{rails_class}")
+    end
+
+    def self.render_exception_with_yeller!
+      info("rendering exception with yeller")
+    end
+
+    def self.error_reporting_rails_error!(e)
+      error("error reporting rails error, please contact rails@yellerapp.com with this message:\n" +
+           e.inspect + "\n" + e.backtrace.join("\n"))
+    end
+
+    def self.action_controller_instance_not_in_env!
+      warn("rack env didn't contain 'action_controller.instance', which should be set from rails.\n" +
+           "Errors will still be logged, but they'll be missing a lot of useful information\n" +
+           "check that your middleware doesn't mess with that key, and please contact rails@yellerapp.com for more assistance")
+    end
+
+    def self.reported_to_api!
+      info("reported to api successfully!")
+    end
+
+    def self.error_code_from_api!(response)
+      error("got a non successful response from yeller's api!: #{response.code} #{response.body}" +
+           "\ncheck the api token is correct, and if you're still getting this error, contact rails@yellerapp.com")
+    end
+
+    def self.exception_from_api!(e)
+      error("got an exception whilst sending the test error to yeller's api servers. Please contact rails@yellerapp.com with this message for help debugging.\n" +
+           e.inspect + "\n" + e.backtrace.join("\n"))
+    end
+
+    def self.about_to_raise_exception_in_controller!
+      info("about to raise exception in fake controller")
+    end
+
+    def self.reporting_to_yeller_rack!
+      info("reporting via Yeller::Rack")
+    end
+
+    def self.info(message)
+      @log ||= []
+      @log << "yeller: #{message}"
+    end
+
+    def self.warn(message)
+      info(red("WARNING:"))
+      info(red(message))
+    end
+
+    def self.error(message)
+      info(red("ERROR DETECTED:"))
+      info(red(message))
+    end
+
+    def self.red(message)
+      "\033[31m#{message}\033[0m"
+    end
+  end
+end

data/lib/yeller/version.rb

@@ -1,3 +1,3 @@
 module Yeller
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yeller_ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Tom Crayford
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-10 00:00:00.000000000 Z
+date: 2014-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -71,6 +71,7 @@ files:
 - lib/yeller/rails/tasks.rb
 - lib/yeller/server.rb
 - lib/yeller/startup_params.rb
+- lib/yeller/verify_log.rb
 - lib/yeller/version.rb
 - lib/yeller_ruby.rb
 homepage: https://github.com/tcrayford/yeller_rubby