yard-doctest 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4023ce3acc9d083c21073b13aa9e38aa70106ed0
-  data.tar.gz: 4e839b3a471e0639ca5e217557e176abe5a6d2ff
+  metadata.gz: 0cd1fc903edfa86337db79cf3b40f762fbf2cadc
+  data.tar.gz: 408b814a356c164e4d894f1c9320ce422ffb8706
 SHA512:
-  metadata.gz: 9ca5d6326dfab02d4bc4d2c391f23aeb7f8d92f56d29d26269a3784ebdfc123b33edfd1b1ab68a1d64da0e84cad1b42be90353c09cff9bdc9117d8330b2350ff
-  data.tar.gz: 6c62c7630f36fb14dd7b834fec7a75cde72b0c13131c6c9702aabb679e2058e1f4585310dfa2ed554d5c6bc216b349a4a7c171807bd4eb17c4bf706332bca068
+  metadata.gz: 0fba50d53837f55aef654d3e675ff8b3bca2128668f2599db051c0f4e0c1d11c4c9a1bb1b6d1b7fa697eff0c930675aea6f0e885336a70dc6db3cfc6db64e508
+  data.tar.gz: c1b06e9a0119434cc69a5212a7d06982e69adfa2d1e025513299fc50646c5158a81d209341237ec3945c774386616c0a88089ab0d2d90dee2bd4d07c6c0b8744

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.8
+
+* Fixed a bug when test was passing even though exception was raised in example
+
 ## 0.1.7
 
 * Fix a bug when only one of global and test-name hooks is executed for matching test

data/features/yard-doctest.feature

@@ -108,6 +108,28 @@ Feature: yard doctest
     And the output should contain "B.multiply"
     And the output should contain "B#div"
 
+  Scenario: fails if exception is raised
+    Given a file named "doctest_helper.rb" with:
+      """
+      require 'app/app'
+      """
+    And a file named "app/app.rb" with:
+      """
+      # @example
+      #   foo
+      def foo
+        raise 'Fails with exception'
+      end
+      """
+    When I run `bundle exec yard doctest`
+    Then the exit status should be 1
+    And the output should contain:
+      """
+      1) Error:
+      #foo#test_0001_:
+      RuntimeError: Fails with exception
+      """
+
   Scenario: asserts using equality
     Given a file named "doctest_helper.rb" with:
       """

data/lib/yard/doctest/example.rb

@@ -39,13 +39,10 @@ module YARD
             it this.name do
               this.asserts.each do |assert|
                 expected, actual = assert[:expected], assert[:actual]
-                next if expected.empty?
-
-                begin
-                  assert_equal evaluate(expected), evaluate(actual)
-                rescue Minitest::Assertion => error
-                  add_filepath_to_backtrace(error, this.filepath)
-                  raise error
+                if expected.empty?
+                  evaluate_example(this, actual)
+                else
+                  assert_example(this, expected, actual)
                 end
               end
             end
@@ -55,6 +52,20 @@ module YARD
 
       protected
 
+      def evaluate_example(example, actual)
+        context.eval(actual)
+      rescue StandardError => error
+        add_filepath_to_backtrace(error, example.filepath)
+        raise error
+      end
+
+      def assert_example(example, expected, actual)
+        assert_equal evaluate(expected), evaluate(actual)
+      rescue Minitest::Assertion => error
+        add_filepath_to_backtrace(error, example.filepath)
+        raise error
+      end
+
       def evaluate(code)
         context.eval(code)
       rescue StandardError => error
@@ -69,7 +80,7 @@ module YARD
         backtrace = exception.backtrace
         line = backtrace.find { |l| l =~ %r{lib/yard/doctest/example} }
         index = backtrace.index(line)
-        backtrace = backtrace.insert(index, filepath)
+        backtrace = backtrace.insert(index + 1, filepath)
         exception.set_backtrace backtrace
       end
 

data/lib/yard/doctest/version.rb

@@ -1,5 +1,5 @@
 module YARD
   module Doctest
-    VERSION = '0.1.7'
+    VERSION = '0.1.8'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yard-doctest
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Alex Rodionov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-04 00:00:00.000000000 Z
+date: 2016-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yard