yandex_direct 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dee574dff6487e3ee0a4b8bf331573c95c2ffdf9d169ba83b768eebd5306d9c4
-  data.tar.gz: 8f1398e376e0d4d2659ee5695ea5bd0439ee940eb50c205441c381a7e50a61a3
+  metadata.gz: 14b05d58fb32619a11756ddac6466ba4bafff4d35cb6fe3d451f62737829cbcc
+  data.tar.gz: 7fbfed575a3fb120c1997c7959f34442f504a21f2dc5e08f16e11acf693a47e4
 SHA512:
-  metadata.gz: 817a556108c46e85385e116e38e41ff509b7f44affeb345a4eb0f51b067cd7f65d6ad95e5e3c05825dc3c6d093fc5f3770e6e2c9c78f464e6b7bd75b1265a3ce
-  data.tar.gz: 0752b067ba1cdec46b5ab8dcc7811bcdff3943c263a1fcda3d5de3a1e4267a9cfc42d5e6419d37c80ce285a240b181db56ec49bf07fed5b7fee19c3aa8b8a48b
+  metadata.gz: b946381b1e6e8b6210635e810d4fbcb59aa85cd5254e1dd32856dd2b8655d3f1b8a843a55ba8ed0c3f82b9892b1fb760508d78f41c1b42444fc9b1eee2af6b3b
+  data.tar.gz: e004ee719582415003dd9b6c6afc00d16bea3c0259706c9e75f14adeb090a559f14957b32a71b192395399cdc557c326b98acd6c5dff9094afdd83b88fe23cba

data/.rubocop.yml

@@ -4,6 +4,10 @@ AllCops:
 Metrics/AbcSize:
   Max: 23
 
+Metrics/BlockLength:
+  Exclude:
+    - "**/*_spec.rb"
+
 Metrics/LineLength:
   Max: 195
 

data/.travis.yml

@@ -3,3 +3,9 @@ language: ruby
 rvm:
   - 2.5.0
 before_install: gem install bundler -v 1.16.1
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+after_script:
+    - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/Gemfile

@@ -8,5 +8,8 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 gemspec
 
 group :test do
-  gem 'rubocop', '~> 0.54.0', require: false
+  gem 'rspec', '~> 3.7'
+  gem 'rubocop', '~> 0.54.0'
+  gem 'simplecov', '~> 0.16.1'
+  gem 'webmock', '~> 3.3'
 end

data/README.md

@@ -1,4 +1,9 @@
-# YandexDirect
+# The Yandex.Direct Ruby Gem
+
+[![Gem Version](https://badge.fury.io/rb/yandex_direct.svg)](https://badge.fury.io/rb/yandex_direct)
+[![Build Status](https://travis-ci.org/radanisk/yandex_direct.svg?branch=master)](https://travis-ci.org/radanisk/yandex_direct)
+[![Maintainability](https://api.codeclimate.com/v1/badges/4cdc27846467bc400f5a/maintainability)](https://codeclimate.com/github/radanisk/yandex_direct/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/4cdc27846467bc400f5a/test_coverage)](https://codeclimate.com/github/radanisk/yandex_direct/test_coverage)
 
 A Ruby interface to the Yandex Direct API.
 

data/lib/yandex_direct.rb

@@ -5,27 +5,13 @@ require 'yandex_direct/authorization_error'
 require 'yandex_direct/error'
 require 'yandex_direct/not_enough_units_error'
 require 'yandex_direct/blank_data_error'
+require 'yandex_direct/v5/api'
 require 'yandex_direct/v5/request'
-require 'yandex_direct/v5/ads'
-require 'yandex_direct/v5/ad_groups'
-require 'yandex_direct/v5/ad_images'
-require 'yandex_direct/v5/campaigns'
-require 'yandex_direct/v5/dictionaries'
-require 'yandex_direct/v5/keywords'
-require 'yandex_direct/v5/sitelinks'
-require 'yandex_direct/v5/v_cards'
 require 'yandex_direct/version'
 
 module YandexDirect
   class Client
-    include YandexDirect::V5::Ads
-    include YandexDirect::V5::AdGroups
-    include YandexDirect::V5::AdImages
-    include YandexDirect::V5::Campaigns
-    include YandexDirect::V5::Dictionaries
-    include YandexDirect::V5::Keywords
-    include YandexDirect::V5::Sitelinks
-    include YandexDirect::V5::VCards
+    include YandexDirect::V5::API
 
     attr_accessor :token, :login, :test, :app_id
     attr_reader :available_units
@@ -77,12 +63,6 @@ module YandexDirect
       request_live('GetBannersTags', param)
     end
 
-    def regions
-      request('GetRegions')['data'].map do |region_data|
-        YandexDirect::RegionInfo.new(region_data)
-      end
-    end
-
     def ping_api
       request('PingAPI')
     end
@@ -111,14 +91,4 @@ module YandexDirect
       request_v4(@url_live, method, param)
     end
   end
-
-  class RegionInfo
-    attr_reader :region_id, :parent_id, :region_name
-
-    def initialize(attrs)
-      @region_id   = attrs['RegionID']
-      @parent_id   = attrs['ParentID']
-      @region_name = attrs['RegionName']
-    end
-  end
 end

data/lib/yandex_direct/geo_regions_item.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module YandexDirect
+  class GeoRegionsItem
+    attr_reader :geo_region_id, :parent_id, :geo_region_name
+
+    def initialize(attrs)
+      @geo_region_id = attrs['GeoRegionId']
+      @parent_id = attrs['ParentId']
+      @geo_region_name = attrs['GeoRegionName']
+    end
+  end
+end

data/lib/yandex_direct/v5/api.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'yandex_direct/v5/ads'
+require 'yandex_direct/v5/ad_groups'
+require 'yandex_direct/v5/ad_images'
+require 'yandex_direct/v5/campaigns'
+require 'yandex_direct/v5/dictionaries'
+require 'yandex_direct/v5/keywords'
+require 'yandex_direct/v5/sitelinks'
+require 'yandex_direct/v5/v_cards'
+
+module YandexDirect
+  module V5
+    module API
+      include YandexDirect::V5::Ads
+      include YandexDirect::V5::AdGroups
+      include YandexDirect::V5::AdImages
+      include YandexDirect::V5::Campaigns
+      include YandexDirect::V5::Dictionaries
+      include YandexDirect::V5::Keywords
+      include YandexDirect::V5::Sitelinks
+      include YandexDirect::V5::VCards
+    end
+  end
+end

data/lib/yandex_direct/v5/dictionaries.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'yandex_direct/v5/geo_regions_item'
+require 'yandex_direct/geo_regions_item'
 
 module YandexDirect
   module V5
@@ -13,7 +13,7 @@ module YandexDirect
         response = YandexDirect::V5::Request.new(self, @token, 'dictionaries', 'get', params).perform
         if response[:result]['GeoRegions'].any?
           response[:result]['GeoRegions'].map! do |region_data|
-            GeoRegionsItem.new(region_data)
+            YandexDirect::GeoRegionsItem.new(region_data)
           end
         end
         response[:result]

data/lib/yandex_direct/v5/request.rb

@@ -3,9 +3,12 @@
 module YandexDirect
   module V5
     class Request
+      BASE_URL = 'https://api.direct.yandex.com/json/v5/'
+      SANDBOX_BASE_URL = 'https://api-sandbox.direct.yandex.com/json/v5/'
+
       def initialize(client, token, service_name, method, params)
         @payload = { method: method, params: params }
-        api_url = client.test ? 'https://api-sandbox.direct.yandex.com/json/v5/' : 'https://api.direct.yandex.com/json/v5/'
+        api_url = client.test ? SANDBOX_BASE_URL : BASE_URL
         @url = "#{api_url}#{service_name}"
         @token = token
       end

data/lib/yandex_direct/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module YandexDirect
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/yandex_direct.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'yandex_direct/version'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yandex_direct
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Aleksandr B. Ivanov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-25 00:00:00.000000000 Z
+date: 2018-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -87,13 +87,14 @@ files:
 - lib/yandex_direct/authorization_error.rb
 - lib/yandex_direct/blank_data_error.rb
 - lib/yandex_direct/error.rb
+- lib/yandex_direct/geo_regions_item.rb
 - lib/yandex_direct/not_enough_units_error.rb
 - lib/yandex_direct/v5/ad_groups.rb
 - lib/yandex_direct/v5/ad_images.rb
 - lib/yandex_direct/v5/ads.rb
+- lib/yandex_direct/v5/api.rb
 - lib/yandex_direct/v5/campaigns.rb
 - lib/yandex_direct/v5/dictionaries.rb
-- lib/yandex_direct/v5/geo_regions_item.rb
 - lib/yandex_direct/v5/keywords.rb
 - lib/yandex_direct/v5/request.rb
 - lib/yandex_direct/v5/sitelinks.rb
@@ -120,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A Ruby interface to the Yandex Direct API

data/lib/yandex_direct/v5/geo_regions_item.rb

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-class GeoRegionsItem
-  attr_reader :geo_region_id, :parent_id, :geo_region_name
-
-  def initialize(attrs)
-    @geo_region_id = attrs['GeoRegionId']
-    @parent_id = attrs['ParentId']
-    @geo_region_name = attrs['GeoRegionName']
-  end
-end