yaml-validator 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1e8456ef2611d6bf089a626ad29353e035ec5064
-  data.tar.gz: da9122a2e4a22c9f88db778b5c0e3736fe8b9165
+  metadata.gz: 77d97bf3baf6728ffb9da7c658caa53775fbd621
+  data.tar.gz: e8b5e202a428c260fe0978bf9ef1353cd39c677a
 SHA512:
-  metadata.gz: 4f40e01f2e5edbb98aedeba67008c5cb549cf558b102789ad664d8149e6f8d27524578b2969f968c1b1791edfdfea0d9e95650d5d14c916e5bf3aea126a510c8
-  data.tar.gz: 5f5f42e97a15a02487227322986559d2096b9b1ba7ec73d3c91e76885bfb1b727a41e4501e00e0b1316ac91a38bfb7610e4aaa0724a057aea4e38b4378323776
+  metadata.gz: d19beeb8c9657d58c7c279e52d3b5e4c247a0a6639e789aa69851c9622cfce25eba4b72c6a1a2143801b30c47432bac2e7a9f72ba89b8fbf9e1fa9f38202ea8d
+  data.tar.gz: 3ae273ea3a8a7b98f6a4a3a50b284038fb3adec9e115789a17161babba4427b8ea48bc57c046a8d663fd124e653c0f71a2deb02a3de03ac211f4d84ed6aea7ed

data/.ruby-version

@@ -0,0 +1 @@
+2.0.0-p247

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    yaml-validator (0.1.5)
+    yaml-validator (0.1.7)
       colorize
       rake
       rspec

data/lib/yaml-validator.rb

@@ -53,12 +53,12 @@ class YamlValidator
     yaml_object = yaml_object[yaml_object.keys[0]]
     yaml_object = Helpers.normalize_yaml(yaml_object)
     errors += validate_yaml_object('', yaml_object)
-    if @options.missing?
+    if @options[:missing]
       errors.concat find_missing_translations(yaml_object)
       errors.concat find_missing_pluralizations(filename, yaml_object)
     end
 
-    if @options.sanitize?
+    if @options[:sanitize]
       errors.concat find_unsanitized_html(filename, yaml_object)
     end
     
@@ -133,6 +133,28 @@ class YamlValidator
   end
   
   def validate_item(full_key, value, is_pluralization = false)
+    errors = validate_item_vars(full_key, value, is_pluralization)
+    errors.concat validate_item_characters(full_key, value)
+    errors
+  end
+
+  def validate_item_characters(full_key, value)
+    bad_chars = '⏎'
+    bad_chars_found = []
+    bad_chars.each_char do |ch|
+      if value.include? ch
+        bad_chars_found << ch
+      end
+    end
+
+    if bad_chars_found.any?
+      return ["#{full_key}: bad characters (#{bad_chars_found.join(', ')} ) in '#{value}'"]
+    else
+      return []
+    end
+  end
+
+  def validate_item_vars(full_key, value, is_pluralization = false)
     real_vars = get_key_en_vars(full_key)
     if real_vars.nil?
       if is_pluralization

data/lib/yaml-validator/version.rb

@@ -1,3 +1,3 @@
 class YamlValidator
-  VERSION = "0.1.6"
+  VERSION = "0.1.7"
 end

data/spec/fixtures/bad_chars/en.yml

@@ -0,0 +1,4 @@
+en:
+  key1: |-
+    line1
+    line2

data/spec/fixtures/bad_chars/he.yml

@@ -0,0 +1,2 @@
+he:
+  key1: line1 ⏎ line2

data/spec/yaml-validator_spec.rb

@@ -34,10 +34,20 @@ describe YamlValidator do
         ]
       end
     end
+
+    describe "bad_chars scenario" do
+      it "returns two errors" do
+        validator = YamlValidator.new('spec/fixtures/bad_chars')
+        errors = validator.validate()
+        errors.should == [
+          "he.yml: key1: bad characters (⏎ ) in 'line1 ⏎ line2'",
+        ]
+      end
+    end
     
     describe "inconsistent_types scenario" do
       it "returns inconsistent type error" do
-        validator = YamlValidator.new('spec/fixtures/inconsistent_types')
+        validator = YamlValidator.new('spec/fixtures/inconsistent_types', missing: true)
         errors = validator.validate()
         errors.should == [
           "he.yml: parent1.key1.subkey1 doesn't exist in en.yml",
@@ -63,7 +73,7 @@ describe YamlValidator do
     
     describe "missing translations" do
       it "returns invalid yaml error" do
-        validator = YamlValidator.new('spec/fixtures/missing_translations')
+        validator = YamlValidator.new('spec/fixtures/missing_translations', missing: true)
         errors = validator.validate()
         errors.should == [
           "he.yml: missing translation for key2 ('value2')",
@@ -76,7 +86,7 @@ describe YamlValidator do
 
     describe "weird pluralizations" do
       it "returns missing pluralizations error" do
-        validator = YamlValidator.new('spec/fixtures/weird_pluralizations')
+        validator = YamlValidator.new('spec/fixtures/weird_pluralizations', missing: true)
         errors = validator.validate()
         errors.should == [
           "ru.yml: missing 'few' pluralization for 'dogs'",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yaml-validator
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - David Elentok
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-15 00:00:00.000000000 Z
+date: 2013-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -89,6 +89,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .rspec
+- .ruby-version
 - .travis.yml
 - Gemfile
 - Gemfile.lock
@@ -102,6 +103,8 @@ files:
 - lib/yaml-validator/version.rb
 - pkg/yaml-validator-0.0.1.gem
 - scripts/get-rails-i18n-rules.rb
+- spec/fixtures/bad_chars/en.yml
+- spec/fixtures/bad_chars/he.yml
 - spec/fixtures/inconsistent_types/en.yml
 - spec/fixtures/inconsistent_types/he.yml
 - spec/fixtures/invalid_yml/en.yml
@@ -144,6 +147,8 @@ signing_key:
 specification_version: 4
 summary: Validates .yml locale files for Ruby on Rails projects
 test_files:
+- spec/fixtures/bad_chars/en.yml
+- spec/fixtures/bad_chars/he.yml
 - spec/fixtures/inconsistent_types/en.yml
 - spec/fixtures/inconsistent_types/he.yml
 - spec/fixtures/invalid_yml/en.yml