yahoofx 0.0.1 → 0.0.2

data/README.md

@@ -8,3 +8,5 @@ Includes shell command that returns the rate. Usage: yahoofx
 [currency pair]
 
 E.g. `yahoofx eurusd` outputs 1.2925 if the price of 1 EUR is 1.2925 USD
+
+To use this in your ruby code, this would return the rate as a Float: `Yahoofx::Pair.new(:eur, :usd).bid`

data/lib/yahoofx/pair.rb

@@ -5,14 +5,21 @@ module Yahoofx
     # First and second currency code. The parameters could be "USD" and "EUR" for instance
     def initialize(first, second)
       @first, @second = first.to_s, second.to_s
-      raise "Invalid currency code provided" unless @first.length==3 && @second.length==3
+      raise "Invalid currency code provided" unless valid_currency_code?(@first) && 
+                                                    valid_currency_code?(@second)  
     end
 
     def bid
       request_feed.scan(bid_regexp).each { |results| return results.first.to_f }
+      nil
     end
 
     protected
+      def valid_currency_code?(currency_code)
+        return true if currency_code =~ /^[a-zA-Z]{3}$/
+        false
+      end
+
       def url_for_currency_pair
         URI("http://finance.yahoo.com/q?s=#{@first}#{@second}%3Dx&ql=1")
       end

data/test/unit/yahoofx_test.rb

@@ -1,5 +1,4 @@
 require_relative "../test_helper"
-#p YahooFx::Pair.new(:eur, :usd).bid
 
 describe Yahoofx do
   before do
@@ -13,4 +12,10 @@ describe Yahoofx do
     assert_equal 1.2967, Yahoofx::Pair.new(:eur, :usd).bid
   end
 
+  describe "when providing a currency code that's not 3 letters" do
+    it "should raise an exception" do
+      proc {Yahoofx::Pair.new(:usd, :foooo)}.must_raise(RuntimeError)
+      proc {Yahoofx::Pair.new(:us1, :eur)}.must_raise(RuntimeError)
+    end
+  end
 end

data/yahoofx.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'yahoofx'
-  s.version     = '0.0.1'
+  s.version     = '0.0.2'
   s.executables << 'yahoofx'
   s.summary     = "Gets currency rates from Yahoo Finance"
   s.description = "The gem scrapes Yahoo Finance and returns foreign exchange rates. Also comes with a shell command."

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yahoofx
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-07 00:00:00.000000000 Z
+date: 2012-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock