yahoo_finance_client 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e431bef79d59f2f41862b78bae97b9b0935d764c2772dd34d64185c55a1bfac
-  data.tar.gz: 244e81d428f6db8662943c978fca0bc8849657cb6272f5cf9d6e86703bc9586d
+  metadata.gz: c3279a92de28429f202ecb5b00115c837826fe910fe7bf27b60d7e2f1772e40c
+  data.tar.gz: 28bd09c8d5f228f069ed75a57b786e250737f554dab0d7c59b7a7b1e69ee1c5c
 SHA512:
-  metadata.gz: e5515556391d51378e7a483efa7dbc01bbfe899c4040cf25c2b0f51ec15c2c506e61cdb91add0297e2746681dd073fb29e199c9c0c6ef54bc1083326e62940e8
-  data.tar.gz: 1b42eaaeaa692b2449710cbd291bf432b8ba4e8b82f1754319da81a441bb18bb1a2cd4149f5a5e4e3ac0774b8e7af23d800b5b114e79a7b5e355fa927527e286
+  metadata.gz: 6fdcf90496cd4efff95fa6a1ec7ab9729152e17341b24a45d15e299ac356dba96214272033fa3295aaaa69fd59caaa7f60ab416cecc034b02a6ce986f173c822
+  data.tar.gz: 39bfe49e50f2ef5ac851459ee4e07634a19b184ed4ed2774b4975fd15cd6fb7c274da1190590e4ab4b0c5b7f0afe7d36b37930daf9291d35861a373c5b4434f4

data/.rubocop.yml

@@ -10,6 +10,9 @@ Lint/EmptyClass:
 Metrics/AbcSize:
   Max: 25
 
+Metrics/ClassLength:
+  Max: 150
+
 Metrics/MethodLength:
   Max: 11
 

data/lib/yahoo_finance_client/stock.rb

@@ -9,6 +9,7 @@ module YahooFinanceClient
     QUOTE_PATH = "/v7/finance/quote"
     CACHE_TTL = 300
     MAX_RETRIES = 2
+    BATCH_SIZE = 50
     AUTH_ERROR_PATTERNS = [/invalid cookie/i, /invalid crumb/i, /unauthorized/i].freeze
 
     @cache = {}
@@ -19,8 +20,35 @@ module YahooFinanceClient
         fetch_from_cache(cache_key) || fetch_and_cache(cache_key, symbol)
       end
 
+      def get_quotes(symbols)
+        return {} if symbols.nil? || symbols.empty?
+
+        results, uncached = partition_cached(symbols)
+        fetch_uncached_quotes(uncached, results)
+        results
+      end
+
       private
 
+      def partition_cached(symbols)
+        results = {}
+        uncached = []
+        symbols.each do |symbol|
+          cached = fetch_from_cache("quote_#{symbol}")
+          cached ? results[symbol] = cached : uncached << symbol
+        end
+        [results, uncached]
+      end
+
+      def fetch_uncached_quotes(uncached, results)
+        uncached.each_slice(BATCH_SIZE) do |batch|
+          fetch_quotes_data(batch).each do |sym, data|
+            store_in_cache("quote_#{sym}", data)
+            results[sym] = data
+          end
+        end
+      end
+
       def fetch_and_cache(cache_key, symbol)
         data = fetch_quote_data(symbol)
         store_in_cache(cache_key, data) if data[:error].nil?
@@ -39,6 +67,19 @@ module YahooFinanceClient
         end
       end
 
+      def fetch_quotes_data(symbols)
+        retries = 0
+        symbols_param = symbols.join(",")
+        begin
+          response = make_authenticated_request(symbols_param)
+          handle_batch_response(response, symbols)
+        rescue AuthenticationError
+          retries += 1
+          retry if retries <= MAX_RETRIES
+          symbols.each_with_object({}) { |s, h| h[s] = { error: "Authentication failed after #{MAX_RETRIES} retries" } }
+        end
+      end
+
       def make_authenticated_request(symbol)
         session = Session.instance
         session.ensure_authenticated
@@ -54,6 +95,20 @@ module YahooFinanceClient
         response.success? ? parse_response(response.body, symbol) : { error: "Yahoo Finance connection failed" }
       end
 
+      def handle_batch_response(response, symbols)
+        if auth_error?(response)
+          Session.instance.invalidate!
+          raise AuthenticationError, "Authentication failed"
+        end
+        unless response.success?
+          return symbols.each_with_object({}) do |s, h|
+            h[s] = { error: "Yahoo Finance connection failed" }
+          end
+        end
+
+        parse_batch_response(response.body, symbols)
+      end
+
       def auth_error?(response)
         response.code == 401 || AUTH_ERROR_PATTERNS.any? { |p| response.body.to_s.match?(p) }
       end
@@ -63,6 +118,18 @@ module YahooFinanceClient
         quote ? format_quote(quote) : { error: "No data was found for #{symbol}" }
       end
 
+      def parse_batch_response(body, symbols)
+        results = JSON.parse(body).dig("quoteResponse", "result") || []
+        found = results.each_with_object({}) do |quote, hash|
+          formatted = format_quote(quote)
+          hash[formatted[:symbol]] = formatted
+        end
+
+        symbols.each_with_object(found) do |symbol, hash|
+          hash[symbol] ||= { error: "No data was found for #{symbol}" }
+        end
+      end
+
       def format_quote(quote)
         price = quote["regularMarketPrice"]
         dividend = quote["dividendRate"]

data/lib/yahoo_finance_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module YahooFinanceClient
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yahoo_finance_client
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Francesc Leveque