yahoo-group-data 1.0.0 → 1.1.0

data/README.md

@@ -17,6 +17,8 @@ p = g.post_email
 s = g.subscribe_email
 u = g.unsubscribe_email
 o = g.unsubscribe_email
+
+json = g.to_json
 ```
 
 ### Available instance methods
@@ -28,6 +30,7 @@ These should be relatively self-explanatory. Where the data is unnavailable (for
 - not_found?
 - private?
 - age_restricted?
+- no_data? (true if any of the above are true, othersise false. Here for convenience)
 
 #### String values
 
@@ -39,6 +42,7 @@ These should be relatively self-explanatory. Where the data is unnavailable (for
 - unsubscribe_email
 - language
 - category
+- to_json
 
 #### Other values
 

data/lib/yahoo-group-data/version.rb

@@ -1,3 +1,3 @@
 class YahooGroupData
-	VERSION = "1.0.0"
+	VERSION = "1.1.0"
 end

data/lib/yahoo-group-data.rb

@@ -106,6 +106,10 @@ class YahooGroupData
 		Yajl::Encoder.encode(data_hash)
 	end
 
+	def no_data?
+		private? or age_restricted? or not_found?
+	end
+
 	private
 
 	def matches_private?
@@ -119,10 +123,6 @@ class YahooGroupData
 		@matches_age_restricted ||= (doc.xpath('/html/body/div[3]/div/div/div/h4').size > 0 and doc.xpath('/html/body/div[3]/div/div/div/h4').first.inner_html.strip.match(/You've reached an Age-Restricted Area/i)) ? true : false
 	end
 
-	def no_data?
-		private? or age_restricted? or not_found?
-	end
-
 	# French:     jan,fév,mar,avr,mai,jun,jul,aoû,sep,oct,nov,déc
 	# German:     jan,feb,mrz,apr,mai,jun,jul,aug,sep,okt,nov,dez
 	# Portuguese: jan,fev,mar,abr,mai,jun,jul,ago,set,out,nov,dez

data/test/test_yahoo_group_data.rb

@@ -13,7 +13,6 @@ class YahooGroupDataTest < Test::Unit::TestCase
 				to_return(:status => 200, :body => File.read("test/yahoo_pages/#{original_group['id']}.html"), :headers => {})
 
 			g = YahooGroupData.new(original_group["url"])
-			puts original_group["url"]
 			data = Yajl::Parser.parse(g.to_json)
 
 			assert_equal original_group['private'], data['private']
@@ -32,6 +31,16 @@ class YahooGroupDataTest < Test::Unit::TestCase
 		end
 	end
 
+	def test_no_data
+		YAML.load_file('test/groups.yml')["groups"].each do |original_group|
+			stub_request(:get, original_group["url"]).
+				to_return(:status => 200, :body => File.read("test/yahoo_pages/#{original_group['id']}.html"), :headers => {})
+
+			g = YahooGroupData.new(original_group["url"])
+			assert_equal g.no_data?, (original_group['private'] || original_group['not_found'] || original_group['age_restricted'])
+		end
+	end
+
 	def test_initialize_with_invalid_params
 		assert_raise(ArgumentError)  { YahooGroupData.new }
 	end
@@ -65,7 +74,6 @@ class YahooGroupDataTest < Test::Unit::TestCase
 	# then runs the assertions on each one.
 	def test_data_extraction
 		YAML.load_file('test/groups.yml')["groups"].each do |g_data|
-			puts "fetching #{g_data["url"]}"
 			stub_request(:get, g_data["url"]).
 			to_return(:status => 200, :body => File.read("test/yahoo_pages/#{g_data['id']}.html"), :headers => {})
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yahoo-group-data
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70311668310240 !ruby/object:Gem::Requirement
+  requirement: &70321718153700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '1.5'
   type: :runtime
   prerelease: false
-  version_requirements: *70311668310240
+  version_requirements: *70321718153700
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70311668309540 !ruby/object:Gem::Requirement
+  requirement: &70321718153000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '1.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70311668309540
+  version_requirements: *70321718153000
 - !ruby/object:Gem::Dependency
   name: curb
-  requirement: &70311668308520 !ruby/object:Gem::Requirement
+  requirement: &70321718151980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '0.8'
   type: :runtime
   prerelease: false
-  version_requirements: *70311668308520
+  version_requirements: *70321718151980
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70311668308100 !ruby/object:Gem::Requirement
+  requirement: &70321718151560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70311668308100
+  version_requirements: *70321718151560
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70311668307600 !ruby/object:Gem::Requirement
+  requirement: &70321718151060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70311668307600
+  version_requirements: *70321718151060
 description: A lib to fetch public Yahoo group data
 email:
 - will@willj.net