xml-kit 0.1.11 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 925e83f414bc42a59834de793c7a37d174ebb0a787524c2188701f6851150a79
-  data.tar.gz: 4b1fd806847050b19df10455f3fd21cffa6835c6298b160ef56aa00acd90a879
+  metadata.gz: 3a3ce34db33309cbe5b6afe5bd7ed352bfca890ba176151136ab9c8223b27090
+  data.tar.gz: f4c89d59e1329584df15437a7b39210a7bff471c0a59edfb1cd07b4bde1a7a53
 SHA512:
-  metadata.gz: c7426c0584ed0487fed5012a7ed794c3b22de1841af005224c4286feb6f8fa78117f3ae5fa1570d93479c867254aa9ce3c6ae26e44d821bfc08286020e1e1cc0
-  data.tar.gz: 952246a69a2ac54a07075fa72f9c8b3769a1cb73fe5dceb60c0c7f50a22fbc1ed2a93d5c6e1afff2a4af9388b597f1a2d95de08ed604c2a1b5dc58685b935767
+  metadata.gz: 3866cc2e2bbc1fe2349a1d3cd8c7a2977029d46f0afa67f7f8113439a2031ad38dc409fdf22ba0a8e2093dcc07f625c0bd9dcb3e018eaaeaad159c82d5540732
+  data.tar.gz: 594bae158f8ac34f12629b4feb9e38c7a890ec515c6211663d94b9adb2ee532cedd6dd79a0b1084628730da6b89465353582551281b6074835e0a5d62136151c

data/.gitlab-ci.yml

@@ -5,11 +5,11 @@ before_script:
   - echo "en_US.UTF-8 UTF-8" > /etc/locale.gen
   - locale-gen
   - export LC_ALL=en_US.UTF-8
-  - ruby -v
-  - which ruby
-  - gem install bundler --no-ri --no-rdoc
-  - bundle install --jobs $(nproc) "${FLAGS[@]}"
 
 rspec:
   script:
-    - bundle exec rspec
+    - bin/cibuild
+
+lint:
+  script:
+    - bin/lint

data/.rubocop.yml

@@ -0,0 +1,94 @@
+inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop/cop/internal_affairs
+  - rubocop-rspec
+
+AllCops:
+  Exclude:
+    - 'coverage/**/*'
+    - 'pkg/**/*'
+    - 'spec/fixtures/**/*'
+    - 'tmp/**/*'
+    - 'vendor/**/*'
+  TargetRubyVersion: 2.2
+
+Layout/ClassStructure:
+  Enabled: true
+  Categories:
+    module_inclusion:
+      - include
+      - prepend
+      - extend
+  ExpectedOrder:
+      - module_inclusion
+      - constants
+      - public_class_methods
+      - initializer
+      - instance_methods
+      - protected_methods
+      - private_methods
+
+Layout/EndOfLine:
+  EnforcedStyle: lf
+
+Layout/IndentArray:
+  EnforcedStyle: consistent
+
+Layout/IndentHeredoc:
+  EnforcedStyle: active_support
+
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - 'spec/**/*.rb'
+
+Lint/InterpolationCheck:
+  Exclude:
+    - 'spec/**/*.rb'
+
+Metrics/BlockLength:
+  Exclude:
+    - '**/**/*.builder'
+    - '**/*.rake'
+    - '*.gemspec'
+    - 'Rakefile'
+    - 'spec/**/*.rb'
+
+Metrics/ModuleLength:
+  Exclude:
+    - 'spec/**/*.rb'
+
+Metrics/LineLength:
+  Exclude:
+    - 'spec/**/*.rb'
+
+Naming/FileName:
+  Exclude:
+    - 'lib/xml-kit.rb'
+
+Style/Documentation:
+  Enabled: false
+
+Style/EachWithObject:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: 'single_quotes'
+
+Style/TrailingCommaInLiteral:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Max: 80
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/NamedSubject:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 7
+
+RSpec/SubjectStub:
+  Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,22 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-03-03 11:50:08 -0700 using RuboCop version 0.52.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+Metrics/AbcSize:
+  Max: 18
+
+# Offense count: 1
+Style/DoubleNegation:
+  Exclude:
+    - 'lib/xml/kit/certificate.rb'
+
+# Offense count: 29
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 141

data/.travis.yml

@@ -5,5 +5,6 @@ rvm:
   - 2.3.6
   - 2.4.3
   - 2.5.0
-before_install: gem install bundler -v 1.16.0
-script: bundle exec rspec
+script:
+  - bin/cibuild
+  - bin/lint

data/Gemfile

@@ -1,6 +1,8 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+source 'https://rubygems.org'
+
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in xml-kit.gemspec
 gemspec

data/Rakefile

@@ -1,6 +1,13 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/audit/task'
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new(:rubocop)
+Bundler::Audit::Task.new
 
-task :default => :spec
+task default: :spec
+task lint: [:rubocop, 'bundle:audit']

data/bin/cibuild

@@ -0,0 +1,21 @@
+#!/bin/sh
+
+# script/cibuild: Setup environment for CI to run tests. This is primarily
+#                 designed to run on the continuous integration server.
+
+set -e
+
+cd "$(dirname "$0")/.."
+
+echo [$(date "+%H:%M:%S")] "==> Started at…"
+
+# GC customizations
+export RUBY_GC_MALLOC_LIMIT=79000000
+export RUBY_GC_HEAP_INIT_SLOTS=800000
+export RUBY_HEAP_FREE_MIN=100000
+export RUBY_HEAP_SLOTS_INCREMENT=400000
+export RUBY_HEAP_SLOTS_GROWTH_FACTOR=1
+
+ruby -v
+gem install bundler --no-ri --no-rdoc --conservative
+bin/test

data/bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "xml/kit"
+require 'bundler/setup'
+require 'xml/kit'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "xml/kit"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/bin/lint

@@ -0,0 +1,11 @@
+#!/bin/sh
+
+set -e
+
+[ -z "$DEBUG" ] || set -x
+
+echo [$(date "+%H:%M:%S")] "==> Running setup…"
+bin/setup
+
+echo [$(date "+%H:%M:%S")] "==> Running linters…"
+bundle exec rake lint

data/bin/setup

@@ -4,5 +4,3 @@ IFS=$'\n\t'
 set -vx
 
 bundle install
-
-# Do any other automated setup that you need to do here

data/bin/test

@@ -0,0 +1,17 @@
+#!/bin/sh
+
+# script/test: Run test suite for application. Optionally pass in a path to an
+#              individual test file to run a single test.
+
+
+set -e
+
+cd "$(dirname "$0")/.."
+
+[ -z "$DEBUG" ] || set -x
+
+echo [$(date "+%H:%M:%S")] "==> Running setup…"
+bin/setup
+
+echo [$(date "+%H:%M:%S")] "==> Running tests…"
+bundle exec rake spec

data/lib/xml-kit.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require 'xml/kit'

data/lib/xml/kit.rb

@@ -1,32 +1,34 @@
-require "active_model"
-require "active_support/core_ext/numeric/time"
-require "active_support/deprecation"
-require "base64"
-require "builder"
-require "logger"
-require "nokogiri"
-require "openssl"
-require "pathname"
-require "tilt"
-require "xmldsig"
+# frozen_string_literal: true
 
-require "xml/kit/namespaces"
+require 'active_model'
+require 'active_support/core_ext/numeric/time'
+require 'active_support/deprecation'
+require 'base64'
+require 'builder'
+require 'logger'
+require 'nokogiri'
+require 'openssl'
+require 'pathname'
+require 'tilt'
+require 'xmldsig'
 
-require "xml/kit/certificate"
-require "xml/kit/crypto"
-require "xml/kit/decryption"
-require "xml/kit/decryption_error"
-require "xml/kit/document"
-require "xml/kit/encryption"
-require "xml/kit/fingerprint"
-require "xml/kit/id"
-require "xml/kit/key_pair"
-require "xml/kit/self_signed_certificate"
-require "xml/kit/signature"
-require "xml/kit/signatures"
-require "xml/kit/templatable"
-require "xml/kit/template"
-require "xml/kit/version"
+require 'xml/kit/namespaces'
+
+require 'xml/kit/certificate'
+require 'xml/kit/crypto'
+require 'xml/kit/decryption'
+require 'xml/kit/decryption_error'
+require 'xml/kit/document'
+require 'xml/kit/encryption'
+require 'xml/kit/fingerprint'
+require 'xml/kit/id'
+require 'xml/kit/key_pair'
+require 'xml/kit/self_signed_certificate'
+require 'xml/kit/signature'
+require 'xml/kit/signatures'
+require 'xml/kit/templatable'
+require 'xml/kit/template'
+require 'xml/kit/version'
 
 module Xml
   module Kit
@@ -35,9 +37,7 @@ module Xml
         @logger ||= Logger.new(STDOUT)
       end
 
-      def logger=(logger)
-        @logger = logger
-      end
+      attr_writer :logger
 
       def deprecate(message)
         @deprecation ||= ActiveSupport::Deprecation.new('1.0.0', 'xml-kit')

data/lib/xml/kit/certificate.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     # {include:file:spec/xml/certificate_spec.rb}
     class Certificate
       BASE64_FORMAT = %r(\A([A-Za-z0-9+/]{4})*([A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?\Z)
-      BEGIN_CERT=/-----BEGIN CERTIFICATE-----/
-      END_CERT=/-----END CERTIFICATE-----/
+      BEGIN_CERT = /-----BEGIN CERTIFICATE-----/
+      END_CERT = /-----END CERTIFICATE-----/
       # The use can be `:signing` or `:encryption`. Use `nil` for both.
       attr_reader :use
 
@@ -59,7 +61,7 @@ module Xml
       end
 
       def ==(other)
-        self.fingerprint == other.fingerprint
+        fingerprint == other.fingerprint
       end
 
       def eql?(other)
@@ -106,6 +108,11 @@ module Xml
         x509.not_before
       end
 
+      def to_xml(pretty: false, xml: ::Builder::XmlMarkup.new)
+        xml = ::Xml::Kit::Template.new(self).to_xml(xml: xml)
+        pretty ? Nokogiri::XML(xml).to_xml(indent: 2) : xml
+      end
+
       class << self
         def to_x509(value)
           return value if value.is_a?(OpenSSL::X509::Certificate)
@@ -122,10 +129,10 @@ module Xml
         end
 
         def strip(value)
-          value.
-            gsub(BEGIN_CERT, '').
-            gsub(END_CERT, '').
-            gsub(/[\r\n]|\\r|\\n|\s/, "")
+          value
+            .gsub(BEGIN_CERT, '')
+            .gsub(END_CERT, '')
+            .gsub(/[\r\n]|\\r|\\n|\s/, '')
         end
       end
     end

data/lib/xml/kit/crypto.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'xml/kit/crypto/oaep_cipher'
 require 'xml/kit/crypto/rsa_cipher'
 require 'xml/kit/crypto/symmetric_cipher'
@@ -6,7 +8,7 @@ require 'xml/kit/crypto/unknown_cipher'
 module Xml
   module Kit
     module Crypto
-      CIPHERS = [ SymmetricCipher, RsaCipher, OaepCipher, UnknownCipher ]
+      CIPHERS = [SymmetricCipher, RsaCipher, OaepCipher, UnknownCipher].freeze
 
       # @!visibility private
       def self.cipher_for(algorithm, key)

data/lib/xml/kit/crypto/oaep_cipher.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     module Crypto
       class OaepCipher
         ALGORITHMS = {
           'http://www.w3.org/2001/04/xmlenc#rsa-oaep-mgf1p' => true,
-        }
-        def initialize(algorithm, key)
+        }.freeze
+        def initialize(_algorithm, key)
           @key = key
         end
 

data/lib/xml/kit/crypto/rsa_cipher.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     module Crypto
       class RsaCipher
-        ALGORITHM = "#{::Xml::Kit::Namespaces::XMLENC}rsa-1_5"
+        ALGORITHM = "#{::Xml::Kit::Namespaces::XMLENC}rsa-1_5".freeze
 
-        def initialize(algorithm, key)
+        def initialize(_algorithm, key)
           @key = key
         end
 

data/lib/xml/kit/crypto/symmetric_cipher.rb

@@ -1,14 +1,16 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     module Crypto
       class SymmetricCipher
-        DEFAULT_ALGORITHM="#{::Xml::Kit::Namespaces::XMLENC}aes256-cbc"
+        DEFAULT_ALGORITHM = "#{::Xml::Kit::Namespaces::XMLENC}aes256-cbc".freeze
         ALGORITHMS = {
-          "#{::Xml::Kit::Namespaces::XMLENC}tripledes-cbc" => "DES-EDE3-CBC",
-          "#{::Xml::Kit::Namespaces::XMLENC}aes128-cbc" => "AES-128-CBC",
-          "#{::Xml::Kit::Namespaces::XMLENC}aes192-cbc" => "AES-192-CBC",
-          "#{::Xml::Kit::Namespaces::XMLENC}aes256-cbc" => "AES-256-CBC",
-        }
+          "#{::Xml::Kit::Namespaces::XMLENC}tripledes-cbc" => 'DES-EDE3-CBC',
+          "#{::Xml::Kit::Namespaces::XMLENC}aes128-cbc" => 'AES-128-CBC',
+          "#{::Xml::Kit::Namespaces::XMLENC}aes192-cbc" => 'AES-192-CBC',
+          "#{::Xml::Kit::Namespaces::XMLENC}aes256-cbc" => 'AES-256-CBC',
+        }.freeze
 
         attr_reader :key
 
@@ -29,9 +31,9 @@ module Xml
 
         def decrypt(cipher_text)
           cipher.decrypt
-          iv = cipher_text[0..cipher.iv_len-1]
+          iv = cipher_text[0..cipher.iv_len - 1]
           data = cipher_text[cipher.iv_len..-1]
-          #cipher.padding = 0
+          # cipher.padding = 0
           cipher.key = @key
           cipher.iv = iv
           cipher.update(data) + cipher.final

data/lib/xml/kit/crypto/unknown_cipher.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     module Crypto
       class UnknownCipher
-        def initialize(algorithm, key)
-        end
+        def initialize(algorithm, key); end
 
-        def self.matches?(algorithm)
+        def self.matches?(_algorithm)
           true
         end
 

data/lib/xml/kit/decryption.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     # {include:file:spec/saml/xml_decryption_spec.rb}
@@ -13,7 +15,7 @@ module Xml
       #
       # @param data [Hash] the XML document converted to a [Hash] using Hash.from_xml.
       def decrypt(data)
-        ::Xml::Kit.deprecate("decrypt is deprecated. Use decrypt_xml or decrypt_hash instead.")
+        ::Xml::Kit.deprecate('decrypt is deprecated. Use decrypt_xml or decrypt_hash instead.')
         decrypt_hash(data)
       end
 
@@ -30,34 +32,34 @@ module Xml
       def decrypt_hash(hash)
         encrypted_data = hash['EncryptedData']
         symmetric_key = symmetric_key_from(encrypted_data)
-        cipher_text = Base64.decode64(encrypted_data["CipherData"]["CipherValue"])
-        to_plaintext(cipher_text, symmetric_key, encrypted_data["EncryptionMethod"]['Algorithm'])
+        cipher_value = encrypted_data['CipherData']['CipherValue']
+        cipher_text = Base64.decode64(cipher_value)
+        algorithm = encrypted_data['EncryptionMethod']['Algorithm']
+        to_plaintext(cipher_text, symmetric_key, algorithm)
       end
 
       # Decrypts an EncryptedData Nokogiri::XML::Element.
       #
       # @param node [Nokogiri::XML::Element.] the XML node to decrypt.
       def decrypt_node(node)
-        return node unless !node.nil? && "EncryptedData" == node.name
+        return node unless !node.nil? && node.name == 'EncryptedData'
 
         node.parent.replace(decrypt_xml(node.to_s))[0]
       end
 
       private
 
-      def symmetric_key_from(encrypted_data)
-        encrypted_key = encrypted_data['KeyInfo']['EncryptedKey']
-        cipher_text = Base64.decode64(encrypted_key['CipherData']['CipherValue'])
-        attempts = private_keys.count
+      def symmetric_key_from(encrypted_data, attempts = private_keys.count)
+        cipher_text = Base64.decode64(encrypted_data['KeyInfo']['EncryptedKey']['CipherData']['CipherValue'])
         private_keys.each do |private_key|
           begin
             attempts -= 1
-            return to_plaintext(cipher_text, private_key, encrypted_key["EncryptionMethod"]['Algorithm'])
+            return to_plaintext(cipher_text, private_key, encrypted_data['KeyInfo']['EncryptedKey']['EncryptionMethod']['Algorithm'])
           rescue OpenSSL::PKey::RSAError
             raise if attempts.zero?
           end
         end
-        raise DecryptionError.new(private_keys)
+        raise DecryptionError, private_keys
       end
 
       def to_plaintext(cipher_text, symmetric_key, algorithm)

data/lib/xml/kit/decryption_error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     class DecryptionError < StandardError
@@ -5,7 +7,7 @@ module Xml
 
       def initialize(private_keys)
         @private_keys = private_keys
-        super("Cannot decrypt document with the provided private keys")
+        super('Cannot decrypt document with the provided private keys')
       end
     end
   end

data/lib/xml/kit/document.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     # {include:file:spec/saml/xml_spec.rb}
@@ -41,7 +43,7 @@ module Xml
 
       def validate_signatures
         invalid_signatures.flat_map(&:errors).uniq.each do |error|
-          errors.add(error, "is invalid")
+          errors.add(error, 'is invalid')
         end
       end
 
@@ -58,22 +60,14 @@ module Xml
         return if find_by('//ds:Signature').nil?
 
         x509_certificates.each do |certificate|
-          inactive = now < certificate.not_before
-          if inactive
-            error_message = "Not valid before #{certificate.not_before}"
-            errors.add(:certificate, error_message)
-          end
+          errors.add(:certificate, "Not valid before #{certificate.not_before}") if now < certificate.not_before
 
-          expired = now > certificate.not_after
-          if expired
-            error_message = "Not valid after #{certificate.not_after}"
-            errors.add(:certificate, error_message)
-          end
+          errors.add(:certificate, "Not valid after #{certificate.not_after}") if now > certificate.not_after
         end
       end
 
       def x509_certificates
-        find_all("//ds:KeyInfo/ds:X509Data/ds:X509Certificate").map do |item|
+        find_all('//ds:KeyInfo/ds:X509Data/ds:X509Certificate').map do |item|
           Certificate.to_x509(item.text)
         end
       end

data/lib/xml/kit/encryption.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     class Encryption
@@ -13,10 +15,10 @@ module Xml
         asymmetric_algorithm: ::Xml::Kit::Crypto::RsaCipher::ALGORITHM
       )
         @symmetric_algorithm = symmetric_algorithm
-        @symmetric_cipher_value = Base64.encode64(symmetric_cipher.encrypt(raw_xml)).gsub(/\n/, '')
+        @symmetric_cipher_value = Base64.encode64(symmetric_cipher.encrypt(raw_xml)).delete("\n")
 
         @asymmetric_algorithm = asymmetric_algorithm
-        @asymmetric_cipher_value = Base64.encode64(public_key.public_encrypt(symmetric_cipher.key)).gsub(/\n/, '')
+        @asymmetric_cipher_value = Base64.encode64(public_key.public_encrypt(symmetric_cipher.key)).delete("\n")
       end
 
       def to_xml(xml: ::Builder::XmlMarkup.new)

data/lib/xml/kit/fingerprint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     # This generates a fingerprint for an X509 Certificate.
@@ -25,7 +27,7 @@ module Xml
       end
 
       def ==(other)
-        self.to_s == other.to_s
+        to_s == other.to_s
       end
 
       def eql?(other)
@@ -43,7 +45,7 @@ module Xml
       private
 
       def pretty_fingerprint(fingerprint)
-        fingerprint.upcase.scan(/../).join(":")
+        fingerprint.upcase.scan(/../).join(':')
       end
     end
   end

data/lib/xml/kit/id.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     # This class is used primary for generating ID.

data/lib/xml/kit/key_pair.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     class KeyPair # :nodoc:

data/lib/xml/kit/namespaces.rb

@@ -1,18 +1,20 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     module Namespaces
-      CANONICALIZATION = "http://www.w3.org/2001/10/xml-exc-c14n#"
-      ENVELOPED_SIG = "http://www.w3.org/2000/09/xmldsig#enveloped-signature"
-      RSA_SHA1 = "http://www.w3.org/2000/09/xmldsig#rsa-sha1"
-      RSA_SHA256 = "http://www.w3.org/2001/04/xmldsig-more#rsa-sha256"
-      RSA_SHA384 = "http://www.w3.org/2001/04/xmldsig-more#rsa-sha384"
-      RSA_SHA512 = "http://www.w3.org/2001/04/xmldsig-more#rsa-sha512"
-      SHA1 = "http://www.w3.org/2000/09/xmldsig#sha1"
-      SHA256 = 'http://www.w3.org/2001/04/xmlenc#sha256'
-      SHA384 = "http://www.w3.org/2001/04/xmldsig-more#sha384"
-      SHA512 = 'http://www.w3.org/2001/04/xmlenc#sha512'
-      XMLDSIG = "http://www.w3.org/2000/09/xmldsig#"
-      XMLENC = "http://www.w3.org/2001/04/xmlenc#"
+      CANONICALIZATION = 'http://www.w3.org/2001/10/xml-exc-c14n#'.freeze
+      ENVELOPED_SIG = 'http://www.w3.org/2000/09/xmldsig#enveloped-signature'.freeze
+      RSA_SHA1 = 'http://www.w3.org/2000/09/xmldsig#rsa-sha1'.freeze
+      RSA_SHA256 = 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha256'.freeze
+      RSA_SHA384 = 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha384'.freeze
+      RSA_SHA512 = 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha512'.freeze
+      SHA1 = 'http://www.w3.org/2000/09/xmldsig#sha1'.freeze
+      SHA256 = 'http://www.w3.org/2001/04/xmlenc#sha256'.freeze
+      SHA384 = 'http://www.w3.org/2001/04/xmldsig-more#sha384'.freeze
+      SHA512 = 'http://www.w3.org/2001/04/xmlenc#sha512'.freeze
+      XMLDSIG = 'http://www.w3.org/2000/09/xmldsig#'.freeze
+      XMLENC = 'http://www.w3.org/2001/04/xmlenc#'.freeze
     end
   end
 end

data/lib/xml/kit/self_signed_certificate.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     class SelfSignedCertificate
-      SUBJECT="/C=CA/ST=AB/L=Calgary/O=XmlKit/OU=XmlKit/CN=XmlKit"
+      SUBJECT = '/C=CA/ST=AB/L=Calgary/O=XmlKit/OU=XmlKit/CN=XmlKit'.freeze
 
       def create(algorithm: 'AES-256-CBC', passphrase: nil, key_pair: OpenSSL::PKey::RSA.new(2048))
         certificate = certificate_for(key_pair.public_key)
         certificate.sign(key_pair, OpenSSL::Digest::SHA256.new)
-        [ certificate.to_pem, export(key_pair, algorithm, passphrase) ]
+        [certificate.to_pem, export(key_pair, algorithm, passphrase)]
       end
 
       private

data/lib/xml/kit/signature.rb

@@ -1,19 +1,21 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     class Signature
       SIGNATURE_METHODS = {
-        SHA1: "http://www.w3.org/2000/09/xmldsig#rsa-sha1",
-        SHA224: "http://www.w3.org/2001/04/xmldsig-more#rsa-sha224",
-        SHA256: "http://www.w3.org/2001/04/xmldsig-more#rsa-sha256",
-        SHA384: "http://www.w3.org/2001/04/xmldsig-more#rsa-sha384",
-        SHA512: "http://www.w3.org/2001/04/xmldsig-more#rsa-sha512",
+        SHA1: 'http://www.w3.org/2000/09/xmldsig#rsa-sha1',
+        SHA224: 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha224',
+        SHA256: 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha256',
+        SHA384: 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha384',
+        SHA512: 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha512',
       }.freeze
       DIGEST_METHODS = {
-        SHA1: "http://www.w3.org/2000/09/xmldsig#SHA1",
-        SHA224: "http://www.w3.org/2001/04/xmldsig-more#sha224",
-        SHA256: "http://www.w3.org/2001/04/xmlenc#sha256",
-        SHA384: "http://www.w3.org/2001/04/xmldsig-more#sha384",
-        SHA512: "http://www.w3.org/2001/04/xmlenc#sha512",
+        SHA1: 'http://www.w3.org/2000/09/xmldsig#SHA1',
+        SHA224: 'http://www.w3.org/2001/04/xmldsig-more#sha224',
+        SHA256: 'http://www.w3.org/2001/04/xmlenc#sha256',
+        SHA384: 'http://www.w3.org/2001/04/xmldsig-more#sha384',
+        SHA512: 'http://www.w3.org/2001/04/xmlenc#sha512',
       }.freeze
 
       attr_reader :certificate

data/lib/xml/kit/signatures.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     # @!visibility private
@@ -41,7 +43,7 @@ module Xml
         signatures = new(
           key_pair: key_pair,
           signature_method: signature_method,
-          digest_method: digest_method,
+          digest_method: digest_method
         )
         yield xml, XmlSignatureTemplate.new(xml, signatures)
         signatures.complete(xml.target!)

data/lib/xml/kit/templatable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     module Templatable
@@ -51,6 +53,14 @@ module Xml
         signatures.sign_with(key_pair)
       end
 
+      # Allows you to specify which public key to use for generating an XML encrypted element.
+      #
+      # @param certificate [Xml::Kit::Certificate] the certificate containing the public key to use for encryption.
+      def encrypt_with(certificate)
+        self.encrypt = true
+        self.encryption_certificate = certificate
+      end
+
       private
 
       def sign?
@@ -62,7 +72,7 @@ module Xml
         @signatures ||= ::Xml::Kit::Signatures.new(
           key_pair: signing_key_pair,
           digest_method: digest_method,
-          signature_method: signature_method,
+          signature_method: signature_method
         )
       end
 

data/lib/xml/kit/template.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     class Template
-      TEMPLATES_DIR=Pathname.new(File.join(__dir__, "templates/" ))
+      TEMPLATES_DIR = Pathname.new(File.join(__dir__, 'templates/'))
 
       attr_reader :target
 
@@ -24,7 +26,7 @@ module Xml
       end
 
       def template_name
-        "#{target.class.name.split("::").last.underscore}.builder"
+        "#{target.class.name.split('::').last.underscore}.builder"
       end
 
       def template

data/lib/xml/kit/templates/certificate.builder

@@ -1,4 +1,6 @@
-xml.KeyDescriptor use: use do
+# frozen_string_literal: true
+
+xml.KeyDescriptor use ? { use: use } : {} do
   xml.KeyInfo "xmlns": ::Xml::Kit::Namespaces::XMLDSIG do
     xml.X509Data do
       xml.X509Certificate stripped

data/lib/xml/kit/templates/encryption.builder

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 xml.EncryptedData xmlns: ::Xml::Kit::Namespaces::XMLENC do
   xml.EncryptionMethod Algorithm: symmetric_algorithm
   xml.KeyInfo xmlns: ::Xml::Kit::Namespaces::XMLDSIG do

data/lib/xml/kit/templates/signature.builder

@@ -1,4 +1,6 @@
-xml.Signature "xmlns" => ::Xml::Kit::Namespaces::XMLDSIG do
+# frozen_string_literal: true
+
+xml.Signature 'xmlns' => ::Xml::Kit::Namespaces::XMLDSIG do
   xml.SignedInfo do
     xml.CanonicalizationMethod Algorithm: ::Xml::Kit::Namespaces::CANONICALIZATION
     xml.SignatureMethod Algorithm: signature_method
@@ -8,10 +10,10 @@ xml.Signature "xmlns" => ::Xml::Kit::Namespaces::XMLDSIG do
         xml.Transform Algorithm: ::Xml::Kit::Namespaces::CANONICALIZATION
       end
       xml.DigestMethod Algorithm: digest_method
-      xml.DigestValue ""
+      xml.DigestValue ''
     end
   end
-  xml.SignatureValue ""
+  xml.SignatureValue ''
   xml.KeyInfo do
     xml.X509Data do
       xml.X509Certificate certificate.stripped

data/lib/xml/kit/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
-    VERSION = "0.1.11"
+    VERSION = '0.1.12'.freeze
   end
 end

data/xml-kit.gemspec

@@ -1,36 +1,41 @@
-# coding: utf-8
-lib = File.expand_path("../lib", __FILE__)
+
+# frozen_string_literal: true
+
+lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "xml/kit/version"
+require 'xml/kit/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "xml-kit"
+  spec.name          = 'xml-kit'
   spec.version       = Xml::Kit::VERSION
-  spec.authors       = ["mo khan"]
-  spec.email         = ["mo@mokhan.ca"]
+  spec.authors       = ['mo khan']
+  spec.email         = ['mo@mokhan.ca']
 
-  spec.summary       = %q{A simple toolkit for working with XML.}
-  spec.description   = %q{A simple toolkit for working with XML.}
-  spec.homepage      = "https://github.com/saml-kit/xml-kit"
-  spec.license       = "MIT"
+  spec.summary       = 'A simple toolkit for working with XML.'
+  spec.description   = 'A simple toolkit for working with XML.'
+  spec.homepage      = 'https://github.com/saml-kit/xml-kit'
+  spec.license       = 'MIT'
   spec.required_ruby_version = '>= 2.2.0'
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.metadata["yard.run"] = "yri"
-  spec.bindir        = "exe"
+  spec.metadata['yard.run'] = 'yri'
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "activemodel", ">= 4.2.0"
-  spec.add_dependency "builder", "~> 3.2"
-  spec.add_dependency "nokogiri", ">= 1.8.1"
-  spec.add_dependency "tilt", ">= 1.4.1"
-  spec.add_dependency "xmldsig", "~> 0.6"
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "ffaker", "~> 2.7"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "simplecov", "~> 0.15.1"
+  spec.add_dependency 'activemodel', '>= 4.2.0'
+  spec.add_dependency 'builder', '~> 3.2'
+  spec.add_dependency 'nokogiri', '>= 1.8.2'
+  spec.add_dependency 'tilt', '>= 1.4.1'
+  spec.add_dependency 'xmldsig', '~> 0.6'
+  spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'bundler-audit', '~> 0.6'
+  spec.add_development_dependency 'ffaker', '~> 2.7'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rubocop', '~> 0.52'
+  spec.add_development_dependency 'rubocop-rspec', '~> 1.22'
+  spec.add_development_dependency 'simplecov', '~> 0.15.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: xml-kit
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.12
 platform: ruby
 authors:
 - mo khan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-01 00:00:00.000000000 Z
+date: 2018-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.8.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.8.2
 - !ruby/object:Gem::Dependency
   name: tilt
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +94,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.16'
+- !ruby/object:Gem::Dependency
+  name: bundler-audit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: ffaker
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +150,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.52'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.52'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.22'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.22'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -160,13 +202,19 @@ files:
 - ".gitignore"
 - ".gitlab-ci.yml"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/cibuild
 - bin/console
+- bin/lint
 - bin/setup
+- bin/test
+- lib/xml-kit.rb
 - lib/xml/kit.rb
 - lib/xml/kit/certificate.rb
 - lib/xml/kit/crypto.rb
@@ -214,7 +262,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A simple toolkit for working with XML.