xlint 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bcfee8fd2980a89cb729e4d32a8e6983c38a2d56
-  data.tar.gz: 74967a5b0109001208b35cbeffe82165af6cda96
+  metadata.gz: 44ff74fe99426f97c888147083f625d0a5cc9d60
+  data.tar.gz: 4a5537b2eafb5d7d5e071b1e1e0654be3807810f
 SHA512:
-  metadata.gz: 69fbb304de54c93cecc8fcec72bc72b5c331e46077879711898e75d9bf959c5af137c9da3931ee36d65d4ec38162956f1840dbbc33c1a642ddd6aa9e673cb500
-  data.tar.gz: 6fe7769a80dead24dc1fdc4978ad6bf0c1c0800c3bc49dc6bfabb3dd147c883c6e0ccbdc5deeae26a217e7700dfc33fe57e83907fbe0bd4a1749ba6fa93413af
+  metadata.gz: e2fb76abcce5b30a6aec4c498049c775fb0462299e18fd08452e6b5be3f1cb1d6449773c099298eff13a5cad12c1d16d35674768636452c66c6820b33a0bbad1
+  data.tar.gz: 5918d137e4bf58c957b68d2aab5eba3a46bddea6f551d4416fbfeef6890ab6811d60e3ab9431e93c8490024353a38a841f791ec0520f5ac2d6706e4db1a97ab8

data/README.md

@@ -3,7 +3,7 @@
 [![Gem Version](https://badge.fury.io/rb/xlint.svg)](https://rubygems.org/gems/xlint)
 [![Build Status](https://travis-ci.org/instructure/xlint.svg?branch=master)](https://travis-ci.org/instructure/xlint)
 [![Code Climate](https://codeclimate.com/github/instructure/xlint/badges/gpa.svg)](https://codeclimate.com/github/instructure/xlint)
-[![Coverage Status](https://coveralls.io/repos/github/instructure/xlint/badge.svg?branch=master)](https://coveralls.io/github/instructure/xlint?branch=master)
+[![Coverage Status](https://coveralls.io/repos/github/instructure/xlint/badge.svg?branch=HEAD)](https://coveralls.io/github/instructure/xlint?branch=HEAD)
 [![Dependency Status](https://gemnasium.com/badges/github.com/instructure/xlint.svg)](https://gemnasium.com/github.com/instructure/xlint)
 
 Xlint is command-line tool for linting XCode project files and posting

data/lib/xlint.rb

@@ -7,10 +7,11 @@ require 'gergich'
 
 class Xlint
   class << self
-    attr_accessor :diff_file, :comments
+    attr_accessor :diff_file, :draft, :comments
 
     def clear
       @diff_file = nil
+      @draft.reset! if draft
       @comments = []
     end
 
@@ -28,7 +29,11 @@ class Xlint
 
     def build_draft
       @comments = []
-      diff = Xlint.parse_git(File.read(diff_file))
+      # GitDiffParser::Patches.parse(cp932 text) raises ArgumentError: invalid byte sequence in UTF-8
+      # https://github.com/packsaddle/ruby-git_diff_parser/issues/91
+      diff_data = File.read(diff_file)
+      diff_data.encode!('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: '')
+      diff = Xlint.parse_git(diff_data)
       diff.files.each do |file|
         patch = diff.find_patch_by_file(file)
         changes = Xlint.patch_body_changes(patch.body, file)
@@ -37,15 +42,21 @@ class Xlint
     end
 
     def save_draft
-      return if comments.empty?
-      draft = Gergich::Draft.new
+      @draft = Gergich::Draft.new
       comments.each do |comment|
         draft.add_comment(comment[:path], comment[:position], comment[:message], comment[:severity])
       end
     end
 
+    def build_label
+      return unless ENV['GERGICH_REVIEW_LABEL']
+      score = comments.empty? ? 1 : -1
+      message = comments.empty? ? 'Xlint didn\'t find anything to complain about' : 'Xlint is worried about your commit'
+      draft.add_message(message)
+      draft.add_label(ENV['GERGICH_REVIEW_LABEL'], score)
+    end
+
     def publish_draft
-      return if comments.empty?
       Gergich::Review.new.publish!
     end
 
@@ -54,6 +65,7 @@ class Xlint
       check_env
       build_draft
       save_draft
+      build_label
       publish_draft
     end
 
@@ -65,7 +77,7 @@ class Xlint
       result = []
       line_number = 0
       body.split("\n").each do |line|
-        if line.start_with?('@@')
+        if valid_git_header?(line)
           line_number = starting_line_number(line)
           next
         end
@@ -107,5 +119,9 @@ class Xlint
       end
       offenses
     end
+
+    def valid_git_header?(line)
+      line =~ /^(@{2})\s([-]{1}[0-9]*(,[0-9]*)?)\s([+][0-9]*(,[0-9]*)?)\s(@{2})$/
+    end
   end
 end

data/lib/xlint/version.rb

@@ -1,3 +1,3 @@
 class Xlint
-  VERSION = '0.0.4'.freeze unless defined? ::Xlint::VERSION
+  VERSION = '0.0.5'.freeze unless defined? ::Xlint::VERSION
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: xlint
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Taylor Wilson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-13 00:00:00.000000000 Z
+date: 2016-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git