xirr 0.2.7 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2944764274ca9f0acb15890cfd6540f62f074ff9
-  data.tar.gz: dc62255a7a04825f670208c439ce0adb9437f3a9
+  metadata.gz: dcb7b25e26618e39ecb5c1e8b38ad211be4edc73
+  data.tar.gz: 0c845e053436159125d5b8bedf2dd08e8243cdbc
 SHA512:
-  metadata.gz: 0d8cbf1bcb0d9b47148e748b5db9748061fb4c7ddcae2b2c52b7a046a1d036e80cc0789085e988ef02d8709f0093c7fd158f05283db49855abad729cf31281cf
-  data.tar.gz: d4ee0b6b68097528fd5a28b4d5095fcf73524c8919b4b4cae614c12725fee20f5c0182c88533fce6cdb0421703cb7a74aeef13df7203b86256cd2e4ccea4b611
+  metadata.gz: ec7a9821be4721669be0d656864b1d7db88f5d0fc1ec4306b0f190d5b2d2143f0b98ebe338589f3de60af6f07f9077a9a19b9022ee3d64f0aeec81f94b1885b7
+  data.tar.gz: dcf0c3570dbc34e6595cfd3f0e1976ec4f2bd876e1a9ad11dfebdc52b75494199a55f3b4dabb12185b07d36abe79c1a987453a2ebe3889fd4bc756bc00bc2253

data/CHANGE_LOG.md

@@ -1,3 +1,8 @@
+## Version 0.2.8
+
+* Added missing tests
+* Fixed Fallback method
+
 ## Version 0.2.7
 
 * Bisection will now retry XIRR in Newton Method if right limit is reached

data/lib/xirr/bisection.rb

@@ -13,6 +13,7 @@ module Xirr
       # Initial values
       left = [BigDecimal.new(-0.99, Xirr::PRECISION), cf.irr_guess].min
       right = [BigDecimal.new(9.99, Xirr::PRECISION), cf.irr_guess + 1].max
+      @original_right = right
       midpoint ||= cf.irr_guess
       runs = 0
 
@@ -29,7 +30,7 @@ module Xirr
       end
 
       # If enabled, will retry XIRR with NewtonMethod
-      if Xirr::FALLBACK && right_limit_reached?(right, midpoint)
+      if Xirr::FALLBACK && right_limit_reached?(midpoint)
         return NewtonMethod.new(cf).xirr
       end
 
@@ -43,8 +44,8 @@ module Xirr
     # @param midpoint [BigDecimal]
     # @return [Boolean]
     # Checks if result is the right limit.
-    def right_limit_reached?(right, midpoint)
-      (right - midpoint).abs < Xirr::EPS
+    def right_limit_reached?(midpoint)
+      (@original_right - midpoint).abs < Xirr::EPS
     end
 
     # @param left [BigDecimal]

data/lib/xirr/version.rb

@@ -1,4 +1,4 @@
 module Xirr
   # Version of the Gem
-  VERSION = "0.2.7"
+  VERSION = "0.2.8"
 end

data/test/test_cashflow.rb

@@ -23,7 +23,7 @@ describe 'Cashflows' do
     end
 
     it 'has an Internal Rate of Return on Bisection Method using a Guess' do
-      assert_equal '0.225683'.to_f, @cf.xirr(0.15)
+      assert_in_delta 0.225683, @cf.xirr(0.15).to_f, 0.000002
     end
 
     it 'has an Internal Rate of Return on Newton Method' do
@@ -44,12 +44,16 @@ describe 'Cashflows' do
       @cf << Transaction.new(6000, date: '1995-01-01'.to_date)
     end
 
+    it 'has a sum of its transactions' do
+      assert_equal '5600'.to_f, @cf.sum
+    end
+
     it 'has an Internal Rate of Return on Bisection Method' do
       assert_equal '0.225683'.to_f, @cf.xirr
     end
 
     it 'has an Internal Rate of Return on Bisection Method using a Guess' do
-      assert_equal '0.225683'.to_f, @cf.xirr(0.15)
+      assert_in_delta 0.225683, @cf.xirr(0.15).to_f, 0.000002
     end
 
     it 'has an Internal Rate of Return on Newton Method' do
@@ -73,6 +77,10 @@ describe 'Cashflows' do
       assert_equal '22.352206  '.to_f, @cf.xirr
     end
 
+    it 'has a sum of its transactions' do
+      assert_equal '-2000000'.to_f, @cf.sum
+    end
+
     it 'has an Internal Rate of Return on Newton Method' do
       assert_equal '22.352206 '.to_f, @cf.xirr(nil, :newton_method)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: xirr
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.8
 platform: ruby
 authors:
 - tubedude
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-10 00:00:00.000000000 Z
+date: 2014-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler