xirr 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 66b347b5dff9686099a5cc4c5edf591f69bfdb80
-  data.tar.gz: cb80f9aba97b06a467e7155f9d787b8de172745d
+  metadata.gz: 893aa205c2c9ff4d6608cb61a9360638bb335974
+  data.tar.gz: ea5fc078f408285564152271f95faf34326cf6b8
 SHA512:
-  metadata.gz: 098443d1b4836a96cd65544cd932f7dacfecc60632e0dfc5d2db08289948eea691113adaa73a3da21d8508dc3f6272fd62f222e7de4306d66e5c6bb4f2c7cdba
-  data.tar.gz: f1cd69d853329c9efcab026153906c887ccdf565028300fd52d96a24eb5f10f408801e030cd3cb36fad9531f5763ad5bcf55c5cc3dc0242125b7630227ba4664
+  metadata.gz: 3b0d7975ce89e61ad8df222ab66564f3b005f73cd6da3c1c7d0db9a3012376e9af7fe12b882f465558c52716748616bec135b52473e55e7abe3fb67acb1e9b62
+  data.tar.gz: a01d888ce35bef52506235ed2b1734d52e46c55615a58a59e260519d5f894f8fe3c55f228654b66efb65e08df11937bf34941dc54fc020a7c571c1ee13e7b182

data/CHANGE_LOG.md

@@ -1,3 +1,8 @@
+## Version 0.2.5
+
+* Default XIRR does not raise an Exception if cashflow is invalid
+
+
 ## Version 0.2.4
 
 * Cashflow Invalid Messages are now public.

data/lib/xirr/cashflow.rb

@@ -16,7 +16,7 @@ module Xirr
       self.flatten!
     end
 
-    # Check if Cashflow is invalid and raises ArgumentError
+    # Check if Cashflow is invalid
     # @return [Boolean]
     def invalid?
       positives.empty? || negatives.empty?
@@ -50,7 +50,7 @@ module Xirr
     # @param method [Symbol]
     # @return [Float]
     # Finds the XIRR according to the method provided. Default to Bisection
-    def xirr(guess = nil, method = Xirr.config.default_method)
+    def xirr_with_exception(guess = nil, method = Xirr.config.default_method)
       if valid?
         choose_(method).send :xirr, guess
       else
@@ -62,11 +62,11 @@ module Xirr
     # @param guess [Float]
     # @param method [Symbol]
     # @return [Float]
-    def xirr_no_exception(guess = nil, method = Xirr.config.default_method)
+    def xirr(guess = nil, method = Xirr.config.default_method)
       if invalid?
         BigDecimal.new(0, Xirr::PRECISION)
       else
-        xirr(guess, method)
+        xirr_with_exception(guess, method)
       end
     end
 

data/lib/xirr/version.rb

@@ -1,4 +1,4 @@
 module Xirr
   # Version of the Gem
-  VERSION = "0.2.4"
+  VERSION = "0.2.5"
 end

data/test/test_cashflow.rb

@@ -14,10 +14,14 @@ describe 'Cashflows' do
       assert_raises(ArgumentError) { @cf.xirr(nil, :no_method) }
     end
 
-    it 'has an Internal Rate of Return on Bisection Method' do
+    it 'has an Internal Rate of Return on default Method' do
       assert_equal '0.225683'.to_f, @cf.xirr
     end
 
+    it 'has an Internal Rate of Return on default Method' do
+      assert_equal '0.225683'.to_f, @cf.xirr(nil, :bisection)
+    end
+
     it 'has an Internal Rate of Return on Bisection Method using a Guess' do
       assert_equal '0.225683'.to_f, @cf.xirr(0.15)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: xirr
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - tubedude