xeroizer 2.17.1 → 2.18.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0b4149d832f1cb36887a460f7f8258d049fdd991
-  data.tar.gz: c8ea7a95afb25ee8f41f7a1f15f9f6ce4ae3914e
+  metadata.gz: ea62d6d6a33c98a88703fe9f1c6b675fcfa6731e
+  data.tar.gz: cf3504a3fafc2b1a8d65e274b03373a7dd466d75
 SHA512:
-  metadata.gz: bbaef5a37d2b986f9e81f7b2cd229f501d711563f5634f2cc50125f541cca510386e5110dae6a483fd4782db4213641cc827ab6a6cab43b33bc43deaeb68c6ea
-  data.tar.gz: e37566c54ffddbc031712a08ff0c3179ea26f8def7f75c709d9430ed01a185f70f639976741599bef4307ac9846034c533c060e982129311f23f7f0aaf60b884
+  metadata.gz: 74c217092e28ee42009e40461d99e4b542a09531cba94cfe22f07544dfc5cf7fe35c10d95691a91ffbc152738d67a07470c043b061aa963688b970095db0011e
+  data.tar.gz: 35af4e22733df6241464e95b2a33b7020fbe5590df8e84292ceabdc3f2b0f830174f69d59693af9e09c77cd318c4132767ac2dbd542f7c8c09e9219a45f72cc3

data/README.md

@@ -225,7 +225,7 @@ access_secret = client.access_token.secret
 Two other interesting attributes of the PartnerApplication client are:
 
 > **`#expires_at`**:								Time this AccessToken will expire (usually 30 minutes into the future).		
-> **`#authorization_expires_at`**:	How long this organisation has authorised you to access their data (usually 365 days into the future).		
+> **`#authorization_expires_at`**:	How long this organisation has authorised you to access their data (usually 10 years into the future).		
 
 #### AccessToken Renewal
 
@@ -269,7 +269,7 @@ Retrieves list of all records with matching options.
 **Note:** Some records (Invoice, CreditNote) only return summary information for the contact and no line items
 when returning them this list operation. This library takes care of automatically retrieving the 
 contact and line items from Xero on first access however, this first access has a large performance penalty
-and will count as an extra query towards your 1,000/day and 60/minute request per organisation limit.
+and will count as an extra query towards your 5,000/day and 60/minute request per organisation limit.
 
 Valid options are:
 
@@ -460,7 +460,7 @@ minimum validation requirements for each of the record types.
 
 ### Bulk Creates & Updates
 
-Xero has a hard daily limit on the number of API requests you can make (currently 1,000 requests
+Xero has a hard daily limit on the number of API requests you can make (currently 5,000 requests
 per account per day). To save on requests, you can batch creates and updates into a single PUT or
 POST call, like so:
 
@@ -512,6 +512,43 @@ contact.errors_for(:name) # will contain ["can't be blank"]
 If something goes really wrong and the particular validation isn't handled by the internal
 validators then the library may raise a `Xeroizer::ApiException`.
 
+Example Use Cases
+-------
+
+Creating & Paying an invoice:
+
+```ruby
+contact = xero.Contact.first
+
+# Build the Invoice, add a LineItem and save it
+invoice = xero.Invoice.build(:type => "ACCREC", :contact => contact, :date => DateTime.new(2017,10,19), :due_date => DateTime.new(2017,11,19))
+
+invoice.add_line_item(:description => 'test', :unit_amount => '200.00', :quantity => '1', :account_code => '200')
+
+invoice.save
+
+# An invoice created without a status will default to 'DRAFT'
+invoice.approved?
+
+# Payments can only be created against 'AUTHROISED' invoices
+invoice.approve!
+
+# Find the first bank account
+bank_account = xero.Account.first(:where => {:type => 'BANK'})
+
+# Create & save the payment
+payment = xero.Payment.build(:invoice => invoice, :account => bank_account, :amount => '220.00')
+payment.save
+
+# Reload the invoice from the Xero API
+invoice = xero.Invoice.find(invoice.id)
+
+# Invoice status is now "PAID" & Payment details have been returned as well
+invoice.status
+invoice.payments.first
+invoice.payments.first.date
+```
+
 Reports
 -------
 
@@ -646,6 +683,26 @@ client = Xeroizer::PublicApplication.new(YOUR_OAUTH_CONSUMER_KEY,
 
 This option adds the unitdp=4 query string parameter to all requests for models with line items - invoices, credit notes, bank transactions and receipts.
 
+Tests
+-----
+
+The tests within the repository can be run by setting up a [Private App](https://developer.xero.com/documentation/auth-and-limits/private-applications).  You can create a Private App in the [developer portal](https://developer.xero.com/myapps/), it's suggested that you create it against the [Demo Company](https://developer.xero.com/documentation/getting-started/development-accounts) (note: the Demo Company expires after 28 days, so you will need to reset it and create a new Private App if you Demo Company has expired).
+
+Once you have created your Private App, set these environment variables:
+```
+EXPORT CONSUMER_KEY="your private app's consumer key"
+EXPORT CONSUMER_SECRET="your private app's consumer secret"
+EXPORT PRIVATE_KEY_PATH="the path to your private app's private key"
+```
+
+PRIVATE_KEY_PATH is the path to the private key for your Private App (you uploaded the Public Key when you created the Private App)
+
+Then run the tests
+```
+rake test
+```
+
+
 ### Contributors
 Xeroizer was inspired by the https://github.com/tlconnor/xero_gateway gem created by Tim Connor 
 and Nik Wakelin and portions of the networking and authentication code are based completely off 

data/lib/xeroizer.rb

@@ -44,6 +44,7 @@ require 'xeroizer/models/employee'
 require 'xeroizer/models/expense_claim'
 require 'xeroizer/models/invoice'
 require 'xeroizer/models/invoice_reminder'
+require 'xeroizer/models/online_invoice'
 require 'xeroizer/models/item'
 require 'xeroizer/models/item_purchase_details'
 require 'xeroizer/models/item_sales_details'

data/lib/xeroizer/exceptions.rb

@@ -97,6 +97,8 @@ module Xeroizer
     
   end
 
+  class RecordInvalid < XeroizerError; end
+
   class SettingTotalDirectlyNotSupported < XeroizerError
     
     def initialize(attribute_name)

data/lib/xeroizer/generic_application.rb

@@ -25,6 +25,7 @@ module Xeroizer
     record :ExpenseClaim
     record :Invoice
     record :InvoiceReminder
+    record :OnlineInvoice
     record :Item
     record :Journal
     record :LineItem

data/lib/xeroizer/http.rb

@@ -223,9 +223,9 @@ module Xeroizer
 
     # unitdp query string parameter to be added to request params
     # when the application option has been set and the model has line items
-    # http://developer.xero.com/documentation/advanced-docs/rounding-in-xero/#unitamount
+    # https://developer.xero.com/documentation/api-guides/rounding-in-xero#unitamount
     def unitdp_param(request_url)
-      models = [/Invoices/, /CreditNotes/, /BankTransactions/, /Receipts/]
+      models = [/Invoices/, /CreditNotes/, /BankTransactions/, /Receipts/, /Items/, /Overpayments/, /Prepayments/]
       self.unitdp == 4 && models.any?{ |m| request_url =~ m } ? {:unitdp => 4} : {}
     end
 

data/lib/xeroizer/models/contact.rb

@@ -53,7 +53,7 @@ module Xeroizer
 
       has_many  :addresses, :list_complete => true
       has_many  :phones, :list_complete => true
-      has_many  :contact_groups
+      has_many  :contact_groups, :list_complete => true
       has_many  :contact_persons, :internal_name => :contact_people
 
       has_many :sales_tracking_categories, :model_name => 'ContactSalesTrackingCategory'
@@ -63,7 +63,7 @@ module Xeroizer
       has_one :batch_payments, :model_name => 'BatchPayments', :list_complete => true
       has_one :payment_terms, :model_name => 'PaymentTerms', :list_complete => true
 
-      validates_presence_of :name, :unless => Proc.new { | contact | contact.contact_id.present?}
+      validates_presence_of :name, :unless => Proc.new { | contact | contact.contact_id.present? || contact.contact_number.present? }
       validates_inclusion_of :contact_status, :in => CONTACT_STATUS.keys, :allow_blanks => true
       validates_associated :addresses, allow_blanks: true
 

data/lib/xeroizer/models/credit_note.rb

@@ -51,6 +51,7 @@ module Xeroizer
       guid          :credit_note_id
       string        :credit_note_number
       string        :reference
+      guid          :branding_theme_id
       string        :type
       date          :date
       date          :due_date

data/lib/xeroizer/models/currency.rb

@@ -3,14 +3,26 @@ module Xeroizer
     
     class CurrencyModel < BaseModel
         
-      set_permissions :read
+      set_permissions :read, :write
+
+      # Currencies can only be created (added), no update or delete is possible
+      def create_method
+        :http_put
+      end
       
     end
     
     class Currency < Base
+
+      # Currency does not have an ID
+      # This method overrides the base model to always treat a Currency as new (so it can be saved)
+      # Attempting to update a currency will result in a validation error.	
+      def new_record?
+      	true
+      end
       
       string  :code
-      string  :description
+      string  :description # read only
       
     end
     

data/lib/xeroizer/models/invoice.rb

@@ -1,4 +1,5 @@
 require "xeroizer/models/attachment"
+require "xeroizer/models/online_invoice"
 
 module Xeroizer
   module Record
@@ -14,6 +15,7 @@ module Xeroizer
       set_permissions :read, :write, :update
 
       include AttachmentModel::Extensions
+      include OnlineInvoiceModel::Extensions
 
       public
 
@@ -51,6 +53,7 @@ module Xeroizer
       INVOICE_STATUSES = INVOICE_STATUS.keys.sort
 
       include Attachment::Extensions
+      include OnlineInvoice::Extensions
 
       set_primary_key :invoice_id
       set_possible_primary_keys :invoice_id, :invoice_number

data/lib/xeroizer/models/item.rb

@@ -18,7 +18,6 @@ module Xeroizer
       string  :purchase_description
       string  :name
 
-      decimal :unit_price
       decimal :total_cost_pool # read only
       decimal :quantity_on_hand # read only
 
@@ -27,6 +26,8 @@ module Xeroizer
       boolean :is_tracked_as_inventory # read only, infered from inventory_asset_account_code, cogs_account_code, is_sold and is_purchased
       string  :inventory_asset_account_code
 
+      datetime_utc :updated_date_utc, api_name: 'UpdatedDateUTC'
+      
       belongs_to :purchase_details, :model_name => 'ItemPurchaseDetails'
       belongs_to :sales_details, :model_name => 'ItemSalesDetails'
       

data/lib/xeroizer/models/item_purchase_details.rb

@@ -12,7 +12,7 @@ module Xeroizer
       decimal :unit_price
       string  :account_code
       string  :tax_type
-      decimal :cogs_account_code
+      string  :cogs_account_code, api_name: 'COGSAccountCode'
 
     end
     

data/lib/xeroizer/models/online_invoice.rb

@@ -0,0 +1,37 @@
+module Xeroizer
+  module Record
+    
+    class OnlineInvoiceModel < BaseModel
+
+      module Extensions
+        def online_invoice(id)
+          application.OnlineInvoice.online_invoice(url, id)
+        end
+      end
+    
+      set_permissions :read
+
+      def online_invoice(url, id)
+        response_xml = @application.http_get(@application.client, "#{url}/#{CGI.escape(id)}/OnlineInvoice")
+    
+        response = parse_response(response_xml)
+
+        response.response_items.first
+      end
+    
+    end
+    
+    class OnlineInvoice < Base
+
+      module Extensions
+        def online_invoice
+          parent.online_invoice(id)
+        end
+      end
+
+      string :online_invoice_url
+
+    end
+    
+  end
+end

data/lib/xeroizer/record/base.rb

@@ -105,12 +105,21 @@ module Xeroizer
         end
 
         def save
-          return false unless valid?
+          save!
+          true
+        rescue XeroizerError => e
+          log "[ERROR SAVING] (#{__FILE__}:#{__LINE__}) - #{e.message}"
+          false
+        end
+
+        def save!
+          raise RecordInvalid unless valid?
           if new_record?
             create
           else
             update
           end
+
           saved!
         end
 

data/lib/xeroizer/record/base_model_http_proxy.rb

@@ -1,28 +1,34 @@
-require 'xeroizer/application_http_proxy' 
+require 'xeroizer/application_http_proxy'
 
 module Xeroizer
   module Record
     module BaseModelHttpProxy
-      
+
       def self.included(base)
         base.send :include, Xeroizer::ApplicationHttpProxy
         base.send :include, InstanceMethods
       end
-      
+
       module InstanceMethods
-        
+
         protected
-        
+
           # Parse parameters for GET requests.
           def parse_params(options)
             params = {}
             params[:ModifiedAfter]  = options[:modified_since] if options[:modified_since]
             params[:includeArchived]  = options[:include_archived] if options[:include_archived]
             params[:order]        = options[:order] if options[:order]
+            params[:createdByMyApp] = options[:createdByMyApp] if options[:createdByMyApp]
+
+            params[:IDs]            = filterize(options[:IDs]) if options[:IDs]
+            params[:InvoiceNumbers] = filterize(options[:InvoiceNumbers]) if options[:InvoiceNumbers]
+            params[:ContactIDs]     = filterize(options[:ContactIDs]) if options[:ContactIDs]
+            params[:Statuses]       = filterize(options[:Statuses]) if options[:Statuses]
 
             if options[:where]
               params[:where] =  case options[:where]
-                                  when String   then options[:where] 
+                                  when String   then options[:where]
                                   when Hash     then parse_where_hash(options[:where])
                                 end
             end
@@ -30,7 +36,7 @@ module Xeroizer
             params[:page] = options[:page] if options[:page]
             params
           end
-        
+
           # Parse the :where part of the options for GET parameters and construct a valid
           # .Net version of the criteria to pass to Xero.
           #
@@ -46,14 +52,14 @@ module Xeroizer
               (attribute_name, expression) = extract_expression_from_attribute_name(key)
               (_, field) = model_class.fields.find { | k, v | v[:internal_name] == attribute_name }
               if field
-                conditions << where_condition_part(field, expression, value)                
+                conditions << where_condition_part(field, expression, value)
               else
                 raise InvalidAttributeInWhere.new(model_name, attribute_name)
               end
             end
             conditions.map { | (attr, expression, value) | "#{attr}#{expression}#{value}"}.join('&&')
           end
-        
+
           # Extract the attribute name and expression from the attribute.
           #
           # @return [Array] containing [actual_attribute_name, expression]
@@ -64,37 +70,37 @@ module Xeroizer
                   key.to_s.gsub(/(_is_not|\<\>)$/, '').to_sym,
                   '<>'
                 ]
-              
+
               when /(_is_greater_than|\>)$/
                 [
                   key.to_s.gsub(/(_is_greater_than|\>)$/, '').to_sym,
                   '>'
                 ]
-              
+
               when /(_is_greater_than_or_equal_to|\>\=)$/
                 [
                   key.to_s.gsub(/(_is_greater_than_or_equal_to|\>\=)$/, '').to_sym,
                   '>='
                 ]
-              
+
               when /(_is_less_than|\<)$/
                 [
                   key.to_s.gsub(/(_is_less_than|\<)$/, '').to_sym,
                   '<'
                 ]
-              
+
               when /(_is_less_than_or_equal_to|\<\=)$/
                 [
                   key.to_s.gsub(/(_is_less_than_or_equal_to|\<\=)$/, '').to_sym,
                   '<='
                 ]
-                              
+
               else
                 [key, '==']
-              
+
             end
           end
-        
+
           # Creates a condition part array containing the:
           #   * Field's API name
           #   * Expression
@@ -114,8 +120,18 @@ module Xeroizer
             end
           end
 
+        private
+
+          # Filtering params expect a comma separated list of strings 
+          def filterize(values)
+            case values
+              when String then values
+              when Array  then values.join(',')
+            end
+          end
+
       end
-    
+
     end
   end
 end

data/lib/xeroizer/version.rb

@@ -1,3 +1,3 @@
 module Xeroizer
-  VERSION = "2.17.1".freeze
+  VERSION = "2.18.1".freeze
 end

data/test/acceptance/about_creating_bank_transactions_test.rb

@@ -149,14 +149,24 @@ class AboutCreatingBankTransactions < Test::Unit::TestCase
     }]
   end
 
-  it "fails with ApiException when you try and create a new bank account with missing account type" do
+  it "fails with ApiException when you try and create a new bank account with missing account type with save! method" do
     new_account = client.Account.build(
       :name => "Example bank account",
       :code => "ACC-001"
     )
 
     assert_raise Xeroizer::ApiException do
-      new_account.save
+      new_account.save!
     end
   end
+
+  it "returns false when you try and create a new bank account with a missing account type with save method" do
+    new_account = client.Account.build(
+      :name => "Example bank account",
+      :code => "ACC-001"
+    )
+
+    assert new_account.save == false, "Account save method expected to return false"
+
+  end
 end

data/test/acceptance/about_online_invoice_test.rb

@@ -0,0 +1,29 @@
+require "test_helper"
+require "acceptance_test"
+
+class AboutGetOnlineInvoiceUrl < Test::Unit::TestCase
+  include AcceptanceTest
+
+  let :client do
+    Xeroizer::PrivateApplication.new(@consumer_key, @consumer_secret, @key_file)
+  end
+
+  def setup
+    super
+    @invoice = client.Invoice.all(:where => 'Type=="ACCREC"').first
+    @invoice_acc_pay = client.Invoice.all(:where => 'Type=="ACCPAY"').first
+  end
+
+  can "Request OnlineInvoice of an AccRec invoice" do 
+    @online_invoice = @invoice.online_invoice
+
+    assert @online_invoice.online_invoice_url, "online_invoice_url not found"
+    assert @online_invoice.online_invoice_url.start_with?('https://in.xero.com/'), "online_invoice_url returned in unexpected format"
+  end
+
+  can "Not request OnlineInvoice of an AccPay invoice" do
+    assert_raise do
+      @online_invoice_acc_pay = @invoice_acc_pay.online_invoice
+    end
+  end
+end

data/test/test_helper.rb

@@ -26,7 +26,7 @@ module TestHelper
   
   CONSUMER_KEY      = ENV["CONSUMER_KEY"]     || "fake_key"     unless defined?(CONSUMER_KEY)
   CONSUMER_SECRET   = ENV["CONSUMER_SECRET"]  || "fake_secret"  unless defined?(CONSUMER_SECRET)
-  KEY_FILE          = ENV["KEY_FILE"]         || "fake_key"     unless defined?(KEY_FILE)
+  PRIVATE_KEY_PATH  = ENV["PRIVATE_KEY_PATH"] || "fake_key"     unless defined?(PRIVATE_KEY_PATH)
   
   # Helper constant for checking regex
   GUID_REGEX = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/ unless defined?(GUID_REGEX)

data/test/unit/http_tsl_12_upgrade_test.rb

@@ -0,0 +1,31 @@
+require 'test_helper'
+require 'json'
+
+class HttpTest < Test::Unit::TestCase
+  include TestHelper
+
+  def setup
+    @application = Xeroizer::PrivateApplication.new(CONSUMER_KEY, CONSUMER_SECRET, PRIVATE_KEY_PATH, {:xero_url => 'https://api-tls.xero.com/', :site => 'https://api-tls.xero.com/'})
+    @applicationExternal = Xeroizer::PrivateApplication.new(CONSUMER_KEY, CONSUMER_SECRET, PRIVATE_KEY_PATH, {:xero_url => 'https://www.howsmyssl.com', :site => 'https://www.howsmyssl.com'})
+  end
+
+  context "Connect to Xero TLS 1.2 Test endpoint" do
+    should "receive a 301 response (endpoint redirects on success)" do
+      begin
+        @application.http_get(@application.client, "https://api-tls.xero.com/")
+      rescue Xeroizer::Http::BadResponse => e
+        assert_equal "Unknown response code: 301", e.message, "Unexpected Response Code (Xero): Check TLS 1.2 is set"
+      end
+      
+    end
+  end
+
+  context "Connect to external TLS 1.2 Test endpoint" do
+    should "respond with tls version 1.2" do
+      response = @applicationExternal.http_get(@applicationExternal.client, "https://www.howsmyssl.com/a/check")
+      jsonResponse = JSON.parse(response)
+      assert_equal "TLS 1.2", jsonResponse['tls_version'], "Unexpected Response (External): Check TLS 1.2 is set"
+    end
+  end
+end
+

data/test/unit/models/contact_test.rb

@@ -21,6 +21,24 @@ class ContactTest < Test::Unit::TestCase
       assert_equal(0, contact.errors.size)
     end
 
+    should "be able to have no name if it has a contact_id" do
+      contact = @client.Contact.build
+
+      assert_equal(false, contact.valid?)
+      contact.contact_id = "1-2-3"
+      assert_equal(true, contact.valid?)
+      assert_equal(0, contact.errors.size)
+    end
+
+    should "be able to have no name if it has a contact_number" do
+      contact = @client.Contact.build
+
+      assert_equal(false, contact.valid?)
+      contact.contact_number = "abc123"
+      assert_equal(true, contact.valid?)
+      assert_equal(0, contact.errors.size)
+    end
+
     should "not allow invalid addresses" do
       contact = @client.Contact.build(name: "SOMETHING")
       address = contact.add_address(:type => "INVALID_TYPE")
@@ -66,15 +84,6 @@ class ContactTest < Test::Unit::TestCase
       assert_equal(contact.attributes.keys, keys)
     end
 
-    should "be able to have no name if has a contact_id" do
-      contact = @client.Contact.build
-
-      assert_equal(false, contact.valid?)
-      contact.contact_id = "1-2-3"
-      assert_equal(true, contact.valid?)
-      assert_equal(0, contact.errors.size)
-    end
-
     it "parses extra attributes when present" do
       @instance = Xeroizer::Record::ContactModel.new(nil, "Contact")
       some_xml = get_record_xml("contact_with_details")

data/test/unit/models/line_item_test.rb

@@ -24,11 +24,8 @@ class LineItemTest < Test::Unit::TestCase
 
     line_item.quantity = 1
     line_item.unit_amount = BigDecimal("1337.00")
-    line_item.tax_amount = BigDecimal("0.15")
 
-    expected = BigDecimal((line_item.quantity * (line_item.unit_amount)).to_s).round(2)
-
-    assert_equal expected.to_s, line_item.line_amount.to_s,
+    assert_equal "1337.0", line_item.line_amount.to_s,
       "expected line_amount to equal unit_amount times quantity"
   end
 
@@ -36,12 +33,9 @@ class LineItemTest < Test::Unit::TestCase
     line_item = LineItem.new(nil)
     line_item.quantity = 1
     line_item.unit_amount = BigDecimal("1337.00")
-    line_item.tax_amount = BigDecimal("0.15")
-    line_item.discount_rate = BigDecimal("10.0")
+    line_item.discount_rate = BigDecimal("12.34")
 
-    discount = (100 - line_item.discount_rate) / 100
-    expected = BigDecimal(((line_item.quantity * line_item.unit_amount) * discount).to_s).round(2)
-    assert_equal expected.to_s, line_item.line_amount.to_s,
+    assert_equal "1172.01", line_item.line_amount.to_s,
       "expected line_amount to equal unit_amount times quantity minus the discount"
   end
 
@@ -50,20 +44,19 @@ class LineItemTest < Test::Unit::TestCase
 
     line_item.quantity = nil
     line_item.unit_amount = BigDecimal("1.00")
-    line_item.tax_amount = BigDecimal("0.15")
 
-    assert_equal "0.0", line_item.line_amount.to_s, "expected line amount zero when quantity is nil"
+    assert_equal "0.0", line_item.line_amount.to_s,
+      "expected line amount to be zero when quantity is nil"
 
     line_item.quantity = 0
-    assert_equal "0.0", line_item.line_amount.to_s, "expected line amount zero when quantity is zero"
+    assert_equal "0.0", line_item.line_amount.to_s,
+      "expected line amount to be zero when quantity is zero"
   end
 
   it "is not possible to set unit_amount to zero" do
     line_item = LineItem.new(nil)
 
-    line_item.quantity = 1
     line_item.unit_amount = nil
-    line_item.tax_amount = BigDecimal("0.15")
 
     assert_equal 0.0, line_item.unit_amount,
       "Expected setting unit_amount to nil to be ignored, i.e., it should remain zero"
@@ -74,11 +67,12 @@ class LineItemTest < Test::Unit::TestCase
 
     line_item.quantity = 1
     line_item.unit_amount = nil
-    line_item.tax_amount = BigDecimal("0.15")
 
-    assert_equal "0.0", line_item.line_amount.to_s, "expected line amount zero when unit_amount is nil"
+    assert_equal "0.0", line_item.line_amount.to_s,
+      "expected line amount to be zero when unit_amount is nil"
 
     line_item.unit_amount = BigDecimal("0.00")
-    assert_equal "0.0", line_item.line_amount.to_s, "expected line amount zero when unit_amount is zero"
+    assert_equal "0.0", line_item.line_amount.to_s,
+      "expected line amount to be zero when unit_amount is zero"
   end
 end

data/test/unit/oauth_test.rb

@@ -99,7 +99,7 @@ class OAuthTest < Test::Unit::TestCase
       
       assert_raises Xeroizer::ApiException do
         contact = @client.Contact.build(:name => 'Test Contact')
-        contact.save
+        contact.save!
       end
     end
     
@@ -109,7 +109,7 @@ class OAuthTest < Test::Unit::TestCase
       
       assert_raises Xeroizer::UnparseableResponse do
         contact = @client.Contact.build(:name => 'Test Contact')
-        contact.save
+        contact.save!
       end      
     end
     

data/test/unit/record/base_test.rb

@@ -103,4 +103,62 @@ class RecordBaseTest < Test::Unit::TestCase
       an_example_instance.save
     end
   end
+
+  context 'saving' do
+    context 'invalid record' do
+      setup do
+        @contact.stubs(:valid?).returns(false)
+      end
+
+      must 'raise an exception saving with #save!' do
+        assert_raise(Xeroizer::RecordInvalid) do
+          @contact.save!
+        end
+      end
+
+      must 'return false saving with #save' do
+        assert_equal(false, @contact.save)
+      end
+    end
+
+    context 'api error received' do
+      setup do
+        response = get_file_as_string('api_exception.xml')
+        doc = Nokogiri::XML(response)
+        exception = Xeroizer::ApiException.new(doc.root.xpath("Type").text,
+                                               doc.root.xpath("Message").text,
+                                               response,
+                                               doc,
+                                               '<FakeRequest />')
+
+        @contact.stubs(:valid?).returns(true)
+        @contact.stubs(:create).raises(exception)
+        @contact.stubs(:update).raises(exception)
+      end
+
+      must 'raise an exception creating records with #save!' do
+        @contact.stubs(:new_record?).returns(true)
+        assert_raise(Xeroizer::ApiException) do
+          @contact.save!
+        end
+      end
+
+      must 'raise an exception updating records with #save!' do
+        @contact.stubs(:new_record?).returns(false)
+        assert_raise(Xeroizer::ApiException) do
+          @contact.save!
+        end
+      end
+
+      must 'return false creating records with #save' do
+        @contact.stubs(:new_record?).returns(true)
+        assert_equal(false, @contact.save)
+      end
+
+      must 'return false updating records with #save' do
+        @contact.stubs(:new_record?).returns(false)
+        assert_equal(false, @contact.save)
+      end
+    end
+  end
 end

data/test/unit/record/parse_params_test.rb

@@ -0,0 +1,59 @@
+require 'test_helper'
+
+module Xeroizer
+  module Record
+
+    class ParseParamTestModel < BaseModel
+    end
+
+    class ParseParamTest < Base
+
+      set_primary_key :primary_key_id
+
+      guid      :primary_key_id
+      string    :string1
+      boolean   :boolean1
+      integer   :integer1
+      decimal   :decimal1
+      date      :date1
+      datetime  :datetime1
+
+    end
+
+  end
+end
+
+class ParseParamsTest < Test::Unit::TestCase
+  include TestHelper
+
+  def setup
+    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)
+    @model = Xeroizer::Record::ParseParamTestModel.new(@client, "ParseParamTest")
+  end
+
+  context "should return valid and filtered params" do
+    should "filter unsupported keys" do
+      params = @model.send(:parse_params, {
+        :should_be_filtered_out => 'should be filtered',
+        :modified_since => Date.parse("2010-01-05"),
+        :include_archived => true,
+        :order => :order,
+        :where => 'where string',
+        :IDs => ['29ed7958-0466-486d-bf57-3fd966ea37d7', 'd561892a-9023-498c-a28d-c626ed3940d8'],
+        :InvoiceNumbers => 'INV-0034,INV-0035,INV-0036,INV-0037',
+        :ContactIDs => 'b919a496-1a1c-4fc6-b6ef-8c561e0dd8c2,8289cca4-90a9-466b-95f3-f0adf351b2ac',
+        :Statuses => ['DRAFT', nil, 'SUBMITTED'],
+        :offset => 100,
+        :page => 2
+      })
+
+      params.assert_valid_keys(:ModifiedAfter, :includeArchived, :order, :where,
+                               :IDs, :InvoiceNumbers, :ContactIDs, :Statuses,
+                               :offset, :page)
+      assert_equal(params[:IDs], '29ed7958-0466-486d-bf57-3fd966ea37d7,d561892a-9023-498c-a28d-c626ed3940d8')
+      assert_equal(params[:InvoiceNumbers], 'INV-0034,INV-0035,INV-0036,INV-0037')
+      assert_equal(params[:ContactIDs], 'b919a496-1a1c-4fc6-b6ef-8c561e0dd8c2,8289cca4-90a9-466b-95f3-f0adf351b2ac')
+      assert_equal(params[:Statuses], 'DRAFT,,SUBMITTED')
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: xeroizer
 version: !ruby/object:Gem::Version
-  version: 2.17.1
+  version: 2.18.1
 platform: ruby
 authors:
 - Wayne Robinson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-19 00:00:00.000000000 Z
+date: 2018-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -234,8 +234,11 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Ruby library for the Xero accounting system API.
-email: wayne.robinson@gmail.com
+description: Ruby library for the Xero accounting API.  Originally developed by Wayne
+  Robinson, now maintained by the Xero API Team & Xero/Ruby developer community.
+email:
+- wayne.robinson@gmail.com
+- api@xero.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -289,6 +292,7 @@ files:
 - lib/xeroizer/models/line_item_sum.rb
 - lib/xeroizer/models/manual_journal.rb
 - lib/xeroizer/models/manual_journal_line.rb
+- lib/xeroizer/models/online_invoice.rb
 - lib/xeroizer/models/option.rb
 - lib/xeroizer/models/organisation.rb
 - lib/xeroizer/models/overpayment.rb
@@ -347,6 +351,7 @@ files:
 - test/acceptance/about_creating_bank_transactions_test.rb
 - test/acceptance/about_creating_prepayment_test.rb
 - test/acceptance/about_fetching_bank_transactions_test.rb
+- test/acceptance/about_online_invoice_test.rb
 - test/acceptance/acceptance_test.rb
 - test/acceptance/bank_transaction_reference_data.rb
 - test/acceptance/bank_transfer_test.rb
@@ -591,6 +596,7 @@ files:
 - test/test_helper.rb
 - test/unit/generic_application_test.rb
 - test/unit/http_test.rb
+- test/unit/http_tsl_12_upgrade_test.rb
 - test/unit/models/address_test.rb
 - test/unit/models/bank_transaction_model_parsing_test.rb
 - test/unit/models/bank_transaction_test.rb
@@ -616,6 +622,7 @@ files:
 - test/unit/record/base_test.rb
 - test/unit/record/block_validator_test.rb
 - test/unit/record/model_definition_test.rb
+- test/unit/record/parse_params_test.rb
 - test/unit/record/parse_where_hash_test.rb
 - test/unit/record/record_association_test.rb
 - test/unit/record/validators_test.rb
@@ -625,7 +632,12 @@ files:
 homepage: http://github.com/waynerobinson/xeroizer
 licenses:
 - MIT
-metadata: {}
+metadata:
+  bug_tracker_uri: https://github.com/waynerobinson/xeroizer/issues
+  changelog_uri: https://github.com/waynerobinson/xeroizer/releases
+  source_code_uri: https://github.com/waynerobinson/xeroizer
+  documentation_uri: https://developer.xero.com/documentation/
+  mailing_list_uri: https://developer.xero.com/subscribe-to-the-xero-api-developer-mailing-list
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -642,14 +654,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
-summary: Xero library
+summary: Ruby Library for Xero accounting API
 test_files:
 - test/acceptance/about_creating_bank_transactions_test.rb
 - test/acceptance/about_creating_prepayment_test.rb
 - test/acceptance/about_fetching_bank_transactions_test.rb
+- test/acceptance/about_online_invoice_test.rb
 - test/acceptance/acceptance_test.rb
 - test/acceptance/bank_transaction_reference_data.rb
 - test/acceptance/bank_transfer_test.rb
@@ -894,6 +907,7 @@ test_files:
 - test/test_helper.rb
 - test/unit/generic_application_test.rb
 - test/unit/http_test.rb
+- test/unit/http_tsl_12_upgrade_test.rb
 - test/unit/models/address_test.rb
 - test/unit/models/bank_transaction_model_parsing_test.rb
 - test/unit/models/bank_transaction_test.rb
@@ -919,6 +933,7 @@ test_files:
 - test/unit/record/base_test.rb
 - test/unit/record/block_validator_test.rb
 - test/unit/record/model_definition_test.rb
+- test/unit/record/parse_params_test.rb
 - test/unit/record/parse_where_hash_test.rb
 - test/unit/record/record_association_test.rb
 - test/unit/record/validators_test.rb