xero 0.0.6 → 0.0.7

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 3a6709590e45fb8983ef2f6ecaa194745c52f495
+  data.tar.gz: 934906f3430f1ce438e5e8d38886ff691ad59d16
+SHA512:
+  metadata.gz: 1582a31370715524cfe8cd62bcefa74fdef67d17936118f644f57dc6c5010a566ee149b8695af439253638c294a684172664f1b0b7bcbe8da30d5a6b7cf068f5
+  data.tar.gz: bfb845ce8ce89f101e436c1d0b6c6e2739595a5b014a76fe8e8b0ebe6b7fe52d0dd11119a2d90438678353453411893afd430fb6a108ba2b698ee42dd87e0690

data/lib/xero.rb

@@ -12,6 +12,7 @@ require 'xero/clients/partner_application'
 require 'xero/clients/private_application'
 require 'xero/configuration'
 require 'xero/connection'
+require 'xero/errors/bad_request'
 require 'xero/models/base_model'
 require 'xero/models/account'
 require 'xero/models/address'

data/lib/xero/connection.rb

@@ -60,11 +60,22 @@ module Xero
         "XERO::Connection RESPONSE code: #{response} body: #{response.body}"
       )
 
-      handle_response(response)
+      handle_response(params, response)
     end
 
-    def handle_response(response)
-      response
+    def handle_response(request, response)
+      if response.code.to_i == 200
+        response
+      else
+        handle_error(request, response)
+      end
+    end
+
+    def handle_error(request, response)
+      case response.code.to_i
+      when 400
+        raise Xero::Errors::BadRequest.new(request, response.body)
+      end
     end
   end
 end

data/lib/xero/errors/bad_request.rb

@@ -0,0 +1,23 @@
+module Xero
+  module Errors
+    class BadRequest < StandardError
+
+      attr_reader :request_xml, :response_xml, :type, :message
+
+      def initialize(request_xml, response_xml)
+        @request_xml = request_xml
+        @response_xml = response_xml
+        Hash.from_xml(response_xml).tap do |data|
+          @type = data['ApiException']['Type']
+          @message = data['ApiException']['Message']
+          @error_number = data['ApiException']['ErrorNumber']
+        end
+        self
+      end
+
+      def message
+        "#{@type}: #{@message}"
+      end
+    end
+  end
+end

data/lib/xero/version.rb

@@ -1,3 +1,3 @@
 module Xero
-  VERSION = "0.0.6"
+  VERSION = '0.0.7'
 end

data/spec/lib/xero/clients/private_application_spec.rb

@@ -210,6 +210,20 @@ describe Xero::Clients::PrivateApplication do
     end
   end
 
+  context 'when saving an invalid invoice' do
+    before { configure }
+
+    let(:invoice) { Xero::Models::Invoice.new }
+
+    let(:response) do
+      VCR.use_cassette('save_invalid_invoice') { client.save(invoice) }
+    end
+
+    it 'should raise a BadRequest exception' do
+      expect { response }.to raise_error(Xero::Errors::BadRequest)
+    end
+  end
+
   describe '#get_item' do
 
     before { configure }

data/spec/vcr_cassettes/save_invalid_invoice.yml

@@ -0,0 +1,76 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.xero.com/api.xro/2.0/Invoices
+    body:
+      encoding: US-ASCII
+      string: xml=%3C%3Fxml%20version%3D%221.0%22%20encoding%3D%22UTF-8%22%3F%3E%0A%3CInvoice%3E%0A%20%20%3CDueDate%3E2012-12-12%3C%2FDueDate%3E%0A%3C%2FInvoice%3E%0A
+    headers:
+      charset:
+      - utf-8
+      accept:
+      - ! '*/*'
+      user-agent:
+      - OAuth gem v0.4.7
+      content-length:
+      - '0'
+      content-type:
+      - application/x-www-form-urlencoded
+      authorization:
+      - OAuth oauth_consumer_key="TYMATGTPO5QEAWP8I307AOMBHSOJI2", oauth_nonce="knfwvngQrAeAmKXDXHWBeRzQnNbYvrk3IF2i5SmPCqY",
+        oauth_signature="uUJ1Ni0IiEz42VbQ7A1g6HwrNbA2gjir8l9gbikJju%2BOiBmPJz7d2DUTHMiFc5l%2B7gKT6NwXVWOsETu8FN1vzGC5e9InIYPJMU27Cf5Yw1T1jirSo7R595wrb%2Ffcyi6BytVL4Q0xeZOFFj2LcxbpzJhN4IKaCGRE%2BwKae4w5H%2Fg%3D",
+        oauth_signature_method="RSA-SHA1", oauth_timestamp="1352748950", oauth_token="TYMATGTPO5QEAWP8I307AOMBHSOJI2",
+        oauth_version="1.0"
+  response:
+    status:
+      code: 400
+      message: Bad Request
+    headers:
+      cache-control:
+      - private
+      content-type:
+      - text/xml; charset=utf-8
+      server:
+      - Microsoft-IIS/7.0
+      x-aspnetmvc-version:
+      - '2.0'
+      www-authenticate:
+      - OAuth Realm="api.xero.com"
+      x-aspnet-version:
+      - 4.0.30319
+      x-s:
+      - api2
+      x-powered-by:
+      - ASP.NET
+      date:
+      - Mon, 12 Nov 2012 19:35:56 GMT
+      connection:
+      - close
+      content-length:
+      - '1666'
+    body:
+      encoding: US-ASCII
+      string: ! "<ApiException xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\">\r\n
+        \ <ErrorNumber>10</ErrorNumber>\r\n  <Type>ValidationException</Type>\r\n
+        \ <Message>A validation exception occurred</Message>\r\n  <Elements>\r\n    <DataContractBase
+        xsi:type=\"Invoice\">\r\n      <ValidationErrors>\r\n        <ValidationError>\r\n
+        \         <Message>One or more line items must be specified</Message>\r\n
+        \       </ValidationError>\r\n        <ValidationError>\r\n          <Message>Invoice
+        Type must be specified</Message>\r\n        </ValidationError>\r\n        <ValidationError>\r\n
+        \         <Message>A Contact must be specified for this type of transaction</Message>\r\n
+        \       </ValidationError>\r\n      </ValidationErrors>\r\n      <Warnings
+        />\r\n      <Date>2012-11-12T00:00:00</Date>\r\n      <DueDate>2012-12-12T00:00:00</DueDate>\r\n
+        \     <BrandingThemeID xsi:nil=\"true\" />\r\n      <Status>DRAFT</Status>\r\n
+        \     <LineAmountTypes>Exclusive</LineAmountTypes>\r\n      <LineItems />\r\n
+        \     <SubTotal>0.00</SubTotal>\r\n      <TotalTax>0.00</TotalTax>\r\n      <Total>0.00</Total>\r\n
+        \     <UpdatedDateUTC xsi:nil=\"true\" />\r\n      <CurrencyCode>EUR</CurrencyCode>\r\n
+        \     <FullyPaidOnDate xsi:nil=\"true\" />\r\n      <InvoiceID>00000000-0000-0000-0000-000000000000</InvoiceID>\r\n
+        \     <Payments />\r\n      <CreditNotes />\r\n      <AmountDue xsi:nil=\"true\"
+        />\r\n      <AmountPaid xsi:nil=\"true\" />\r\n      <AmountCredited xsi:nil=\"true\"
+        />\r\n      <SentToContact xsi:nil=\"true\" />\r\n      <CurrencyRate xsi:nil=\"true\"
+        />\r\n      <TotalDiscount xsi:nil=\"true\" />\r\n      <HasAttachments>false</HasAttachments>\r\n
+        \     <Attachments />\r\n    </DataContractBase>\r\n  </Elements>\r\n</ApiException>"
+    http_version: '1.1'
+  recorded_at: Mon, 12 Nov 2012 19:35:53 GMT
+recorded_with: VCR 2.2.5

data/xero.gemspec

@@ -27,6 +27,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency('guard-rspec')
   gem.add_development_dependency('rb-fsevent')
   gem.add_development_dependency('rspec')
+  gem.add_development_dependency('rspec-spies')
   gem.add_development_dependency('shoulda-matchers')
   gem.add_development_dependency('vcr')
 end

metadata

@@ -1,190 +1,181 @@
 --- !ruby/object:Gem::Specification
 name: xero
 version: !ruby/object:Gem::Version
-  version: 0.0.6
-  prerelease: 
+  version: 0.0.7
 platform: ruby
 authors:
 - Matt Beedle
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-06 00:00:00.000000000 Z
+date: 2013-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_attr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: oauth
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rb-fsevent
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-spies
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Library for communicating with the xero API
@@ -213,6 +204,7 @@ files:
 - lib/xero/clients/private_application.rb
 - lib/xero/configuration.rb
 - lib/xero/connection.rb
+- lib/xero/errors/bad_request.rb
 - lib/xero/models/account.rb
 - lib/xero/models/address.rb
 - lib/xero/models/base_model.rb
@@ -251,31 +243,31 @@ files:
 - spec/vcr_cassettes/get_item.yml
 - spec/vcr_cassettes/get_items.yml
 - spec/vcr_cassettes/invoices.yml
+- spec/vcr_cassettes/save_invalid_invoice.yml
 - spec/vcr_cassettes/save_invoice.yml
 - xero.gemspec
 homepage: https://github.com/mattbeedle/xero
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Library for communicating with the xero API
 test_files:
 - spec/lib/xero/client_spec.rb
@@ -303,4 +295,5 @@ test_files:
 - spec/vcr_cassettes/get_item.yml
 - spec/vcr_cassettes/get_items.yml
 - spec/vcr_cassettes/invoices.yml
+- spec/vcr_cassettes/save_invalid_invoice.yml
 - spec/vcr_cassettes/save_invoice.yml