xcpretty 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 15e5b2c06fdab978445beef93dcd79340a31e754
-  data.tar.gz: f86212f6533fab98da537943c3a4464685471d8b
+  metadata.gz: b78a4012d3b1df36cbd26eee764159f4a2ee5e14
+  data.tar.gz: 8744a4e46db1e1983611a445b733208c4d12f177
 SHA512:
-  metadata.gz: bfe0f34e95a6cea49c50c1249844abff6ddc447bae786bdfface21384bdad95c7ca48848045970545f95b8fae11fffccb7def9f612d43f827eab1209407dfd1b
-  data.tar.gz: d54e782c2bec5f3dd894348a28b235936189addfccee72fcb4cf054f016360816f3d14456dafc5553ff276b70dedbfddc6b638ccb4877308d8ceba59ea0e407e
+  metadata.gz: 9e7ff5c8ce55088cd935aa120aec5bbe154f876201211d193345349372a5e3100a0f38c2d55c460e2c380ddebfee1f9f9d1e0eee1f0fc930d95a512e27fe1339
+  data.tar.gz: b54c6a0c5d506252a6ae6eb07ee0ddbb40d468757f104decf4219b357527f40eb33f8ac8664a3b221de88d083c613b30f0c4534925489e85452f8443cc1d5daf

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 0.1.2
+
+###### Enhancements
+
+* More consistent error output (add some spacing before and after)
+* Parsed clang errors
+* Parsed ld: errors
+
+
 ## 0.1.1
 
 ###### Enhancements

data/README.md

@@ -17,9 +17,8 @@ XCPretty is designed to be piped with `xcodebuild` and thus keeping 100% compati
 This means, when `xcodebuild` works, `xcpretty` works.
 It's even a bit faster than `xcodebuild` only, since it saves your terminal some prints.
 
-__Important:__ exiting status code is still experimental, and could potentially
-be removed from `xcpretty`. If you want to ensure the exit status code from
-`xcodebuild`, add this to the end of pipe:
+__Important:__ lots of CIs are using exit status for determining if build has
+failed. You probably want to exit with the same status code as `xcodebuild`.
 
 ```
 xcodebuild ... | xcpretty -c; exit ${PIPESTATUS[0]}

data/lib/xcpretty/formatters/formatter.rb

@@ -85,15 +85,15 @@ module XCPretty
     ASCII_ERROR = "[!]"
 
     def format_error(message)
-      red((use_unicode? ? ERROR : ASCII_ERROR) + " " + message)
+      "\n#{red(error_symbol + " " + message)}\n\n"
     end
 
     def format_compile_error(file, file_path, reason, line, cursor)
-      "\n#{file_path}: #{red(reason)}\n\n#{line}\n#{cyan(cursor)}\n\n"
+      "\n#{red(error_symbol + " ")}#{file_path}: #{red(reason)}\n\n#{line}\n#{cyan(cursor)}\n\n"
     end
 
     def format_linker_failure(message, symbol, reference)
-      "\n#{red("⌦ " + message)}\n> Symbol: #{symbol}\n> Referenced from: #{reference}\n\n"
+      "\n#{red(error_symbol + " " + message)}\n> Symbol: #{symbol}\n> Referenced from: #{reference}\n\n"
     end
 
 
@@ -109,5 +109,9 @@ module XCPretty
       end.join("\n")
     end
 
+    def error_symbol
+      use_unicode? ? ERROR : ASCII_ERROR
+    end
+
   end
 end

data/lib/xcpretty/parser.rb

@@ -16,6 +16,10 @@ module XCPretty
     # @regex Nothing returned here for now
     CHECK_DEPENDENCIES_MATCHER = /^Check dependencies/
 
+    # @regex Captured groups
+    # $1 = whole error
+    CLANG_ERROR_MATCHER = /^(clang: error:.*)$/
+
     # @regex Nothing returned here for now
     CLEAN_REMOVE_MATCHER = /^Clean.Remove/
 
@@ -89,6 +93,10 @@ module XCPretty
     # $1 = library
     LIBTOOL_MATCHER = /^Libtool.*\/(.*\.a)/
 
+    # @regex Captured groups
+    # $1 = whole error
+    LD_ERROR_MATCHER = /^(ld:.*not found for.*)/
+
     # @regex Captured groups
     # $1 reason
     LINKER_FAILURE_MATCHER = /^(Undefined symbols for architecture .*):$/
@@ -191,6 +199,8 @@ module XCPretty
         formatter.format_copy_strings_file($1)
       when CHECK_DEPENDENCIES_MATCHER
         formatter.format_check_dependencies
+      when CLANG_ERROR_MATCHER
+        formatter.format_error($1)
       when CODESIGN_FRAMEWORK_MATCHER
         formatter.format_codesign($1)
       when CODESIGN_MATCHER
@@ -211,6 +221,8 @@ module XCPretty
         formatter.format_error($1)
       when GENERATE_DSYM_MATCHER
         formatter.format_generate_dsym($1)
+      when LD_ERROR_MATCHER
+        formatter.format_error($1)
       when LIBTOOL_MATCHER
         formatter.format_libtool($1)
       when LINKING_MATCHER

data/lib/xcpretty/version.rb

@@ -1,3 +1,3 @@
 module XCPretty
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/fixtures/constants.rb

@@ -523,5 +523,10 @@ Undefined symbols for architecture x86_64:
   "_OBJC_CLASS_$_CABasicAnimation", referenced from:
       objc-class-ref in ATZRadialProgressControl.o
 ld: symbol(s) not found for architecture x86_64
-clang: error: linker command failed with exit code 1 (use -v to see invocation)
 )
+
+SAMPLE_LD_SYMBOLS_ERROR = 'ld: symbol(s) not found for architecture x86_64'
+SAMPLE_LD_LIBRARY_ERROR = 'ld: library not found for -lPods-Yammer'
+
+SAMPLE_CLANG_ERROR = 'clang: error: linker command failed with exit code 1 (use -v to see invocation)'
+

data/spec/xcpretty/formatters/formatter_spec.rb

@@ -24,7 +24,7 @@ module XCPretty
 
     it "formats cocoapods errors" do
       @formatter.format_error("The sandbox is not in sync...").should ==
-      "#{@formatter.red("⌦ The sandbox is not in sync...")}"
+      "\n#{@formatter.red("⌦ The sandbox is not in sync...")}\n\n"
     end
 
     it "formats compiling errors" do
@@ -32,7 +32,7 @@ module XCPretty
                                       "[a should",
                                       "         ^").should ==
 %Q(
-path/to/file: #{@formatter.red("expected valid syntax")}
+#{@formatter.red('⌦ ')}path/to/file: #{@formatter.red("expected valid syntax")}
 
 [a should
 #{@formatter.cyan("         ^")}

data/spec/xcpretty/parser_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'xcpretty'
 require 'xcpretty/parser'
 require 'fixtures/constants'
@@ -182,6 +184,11 @@ module XCPretty
 
     context "errors" do
 
+      it "parses clang errors" do
+        @formatter.should receive(:format_error).with(SAMPLE_CLANG_ERROR)
+        @parser.parse(SAMPLE_CLANG_ERROR)
+      end
+
       it "parses cocoapods errors" do
         @formatter.should receive(:format_error).with("The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.")
         @parser.parse(SAMPLE_PODS_ERROR)
@@ -259,6 +266,20 @@ module XCPretty
         @parser.parse(SAMPLE_CODESIGN_ERROR_NO_SPACES)
       end
 
+      it "parses ld library errors" do
+        @formatter.should receive(:format_error).with(
+          SAMPLE_LD_LIBRARY_ERROR
+        )
+        @parser.parse(SAMPLE_LD_LIBRARY_ERROR)
+      end
+
+      it 'parses ld symbols errors' do
+        @formatter.should receive(:format_error).with(
+          SAMPLE_LD_SYMBOLS_ERROR
+        )
+        @parser.parse(SAMPLE_LD_SYMBOLS_ERROR)
+      end
+
       it "doesn't print the same error over and over" do
         SAMPLE_COMPILE_ERROR.each_line do |line|
           @parser.parse(line)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: xcpretty
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Marin Usalj
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-19 00:00:00.000000000 Z
+date: 2014-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler