x 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b97ab44334b647867e9fdd400531d6e925a10533fb51be399c669c28d441c67
-  data.tar.gz: 03e6b5b78f62cdef778dea21128e8ea1b56955a1077c5ea040b6640694e7577a
+  metadata.gz: 81a5b12497937f06eb22779e6c78ef9dc18d5e9c5b049c96b4da461b058c6998
+  data.tar.gz: 96f4e02f93df2e39589095f12d5a1e790f17159f932cc1ab72330e301815bda4
 SHA512:
-  metadata.gz: 47b47a9e6f98e6a61933d7f8f53d2477b2e921206894b2907171f04c2d94da05ebdbb25b501824240997d07c935cc0d2ea1269c6082e7488800c6c7d141f9c0e
-  data.tar.gz: a642eb6fa5e9b61b3cbcf7fff91506e7f44c6b5b5e7a7f16c4cc5ce7ed57d8d19191583fad4bd2bc174c8e9f010546c34d8c83a1b46444de3685805a4b6471dc
+  metadata.gz: f8540864206f44e6863653ec538d076d4f1c696dab4fff2b8eeb33b587603301d2d62faedb163c59cc9366439b28a29acff4068876b4013a05bf88090c61042f
+  data.tar.gz: ef425363ab320f922e9f05f28f4d21a8090b763ef0d2468dfcd0ff7b9d0c456efa7f0a21b034fc750e5d927aafd5c4ae1b9407696d242512a44c7114e4efda4a

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.8.1] - 2023-09-20
+
+- Fix bug where setting Connection#base_uri= doesn't update the HTTP client (d5a89db)
+
 ## [0.8.0] - 2023-09-14
 
 - Add (back) bearer token authentication (62e141d)

data/README.md

@@ -74,6 +74,20 @@ The tests for the previous version of this library executed in about 2 seconds.
 
 This code is not littered with comments that are intended to generate documentation. Rather, this code is intended to be simple enough to serve as its own documentation. If you want to understand how something works, don’t read the documentation—it might be wrong—read the code. The code is always right.
 
+## Sponsorship
+
+The X gem is free to use, but with X API pricing tiers, it actually costs money to develop and maintain. By contributing to the project, you help us:
+
+1. Maintain the library: Keeping it up-to-date and secure.
+2. Add new features: Enhancements that make your life easier.
+3. Provide support: Faster responses to issues and feature requests.
+
+⭐️ Bonus: Sponsors will get priority support and influence over the project roadmap. We will also list your name or your company's logo on our GitHub page.
+
+Building and maintaining an open-source project like this takes a considerable amount of time and effort. Your sponsorship can help sustain this project. Even a small monthly donation makes a huge difference!
+
+[Click here to sponsor this project.](https://github.com/sponsors/sferik)
+
 ## Development
 
 1. Checkout and repo:

data/lib/x/connection.rb

@@ -9,6 +9,8 @@ module X
     extend Forwardable
 
     DEFAULT_BASE_URL = "https://api.twitter.com/2/".freeze
+    DEFAULT_HOST = "https://api.twitter.com".freeze
+    DEFAULT_PORT = 443
     DEFAULT_OPEN_TIMEOUT = 60 # seconds
     DEFAULT_READ_TIMEOUT = 60 # seconds
     DEFAULT_WRITE_TIMEOUT = 60 # seconds
@@ -18,7 +20,7 @@ module X
       Net::ReadTimeout
     ].freeze
 
-    attr_reader :base_uri
+    attr_reader :base_uri, :http_client
 
     def_delegators :@http_client, :open_timeout, :read_timeout, :write_timeout
     def_delegators :@http_client, :open_timeout=, :read_timeout=, :write_timeout=
@@ -27,12 +29,12 @@ module X
     def initialize(base_url: DEFAULT_BASE_URL, open_timeout: DEFAULT_OPEN_TIMEOUT,
       read_timeout: DEFAULT_READ_TIMEOUT, write_timeout: DEFAULT_WRITE_TIMEOUT, debug_output: nil)
       self.base_uri = base_url
-      @http_client = Net::HTTP.new(base_uri.host, base_uri.port) if base_uri.host
-      @http_client.use_ssl = base_uri.scheme == "https"
-      @http_client.open_timeout = open_timeout
-      @http_client.read_timeout = read_timeout
-      @http_client.write_timeout = write_timeout
-      @http_client.set_debug_output(debug_output) if debug_output
+      apply_http_client_settings(
+        open_timeout: open_timeout,
+        read_timeout: read_timeout,
+        write_timeout: write_timeout,
+        debug_output: debug_output
+      )
     end
 
     def send_request(request)
@@ -46,10 +48,48 @@ module X
       raise ArgumentError, "Invalid base URL" unless base_uri.is_a?(URI::HTTPS) || base_uri.is_a?(URI::HTTP)
 
       @base_uri = base_uri
+      update_http_client_settings
     end
 
     def debug_output
       @http_client.instance_variable_get(:@debug_output)
     end
+
+    private
+
+    def apply_http_client_settings(open_timeout:, read_timeout:, write_timeout:, debug_output:)
+      @http_client.open_timeout = open_timeout
+      @http_client.read_timeout = read_timeout
+      @http_client.write_timeout = write_timeout
+      @http_client.set_debug_output(debug_output) if debug_output
+    end
+
+    def current_http_client_settings
+      {
+        open_timeout: @http_client.open_timeout,
+        read_timeout: @http_client.read_timeout,
+        write_timeout: @http_client.write_timeout,
+        debug_output: debug_output
+      }
+    end
+
+    def update_http_client_settings
+      conditionally_apply_http_client_settings do
+        host = @base_uri.host || DEFAULT_HOST
+        port = @base_uri.port || DEFAULT_PORT
+        @http_client = Net::HTTP.new(host, port)
+        @http_client.use_ssl = @base_uri.scheme == "https"
+      end
+    end
+
+    def conditionally_apply_http_client_settings
+      if @http_client
+        settings = current_http_client_settings
+        yield
+        apply_http_client_settings(**settings)
+      else
+        yield
+      end
+    end
   end
 end

data/lib/x/version.rb

@@ -1,5 +1,5 @@
 require "rubygems/version"
 
 module X
-  VERSION = Gem::Version.create("0.8.0")
+  VERSION = Gem::Version.create("0.8.1")
 end

data/sig/x.rbs

@@ -82,23 +82,30 @@ module X
   end
 
   class Connection
-    extend Forwardable
-
     DEFAULT_BASE_URL: String
+    DEFAULT_HOST: String
+    DEFAULT_PORT: Integer
     DEFAULT_OPEN_TIMEOUT: Integer
     DEFAULT_READ_TIMEOUT: Integer
     DEFAULT_WRITE_TIMEOUT: Integer
     NETWORK_ERRORS: Array[(singleton(::Errno::ECONNREFUSED) | singleton(::Net::OpenTimeout) | singleton(::Net::ReadTimeout))]
+    extend Forwardable
     @http_client: Net::HTTP
 
     attr_reader base_uri: URI::Generic
-    attr_reader open_timeout: Float | Integer 
-    attr_reader read_timeout: Float | Integer 
-    attr_reader write_timeout: Float | Integer 
+    attr_reader open_timeout : Float | Integer
+    attr_reader read_timeout : Float | Integer
+    attr_reader write_timeout : Float | Integer
     def initialize: (?base_url: URI::Generic | String, ?open_timeout: Float | Integer, ?read_timeout: Float | Integer, ?write_timeout: Float | Integer, ?debug_output: IO?) -> void
     def send_request: (Net::HTTPRequest request) -> Net::HTTPResponse
-    def base_uri=: (URI::Generic | String base_url) -> URI::Generic
+    def base_uri=: (URI::Generic | String base_url) -> void
     def debug_output: -> IO?
+
+    private
+    def apply_http_client_settings: (open_timeout: Float | Integer, read_timeout: Float | Integer, write_timeout: Float | Integer, debug_output: IO?) -> untyped
+    def current_http_client_settings: -> {open_timeout: Float | Integer, read_timeout: Float | Integer, write_timeout: Float | Integer, debug_output: IO?}
+    def update_http_client_settings: -> untyped
+    def conditionally_apply_http_client_settings: { -> untyped } -> untyped
   end
 
   class RequestBuilder

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: x
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Erik Berlin
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-09-14 00:00:00.000000000 Z
+date: 2023-09-20 00:00:00.000000000 Z
 dependencies: []
 description:
 email:
@@ -69,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.18
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: A Ruby interface to the X API.