wsdsl 0.1.4 → 0.1.5

data/VERSION

@@ -1 +1 @@
-0.1.4
+0.1.5

data/lib/params_verification.rb

@@ -23,7 +23,8 @@ module ParamsVerification
                             :float    => /^-?(\d*\.\d+|\d+)$/,
                             :decimal  => /^-?(\d*\.\d+|\d+)$/,
                             :datetime => /^[-\d:T\s]+$/,  # "T" is for ISO date format
-                            :boolean  => /^(1|true|TRUE|T|Y|0|false|FALSE|F|N)$/
+                            :boolean  => /^(1|true|TRUE|T|Y|0|false|FALSE|F|N)$/,
+                            :array    => /,/
                           }
   end
   
@@ -232,6 +233,9 @@ module ParamsVerification
           raise InvalidParamValue, "Could not typecast boolean to appropriate value"
         end
       end
+    # An array type is a comma delimited string, we need to cast the passed strings.
+    when :array
+      value.respond_to?(:split) ? value.split(',') : value
     when :binary, :array, :file
       value
     else
@@ -248,6 +252,9 @@ module ParamsVerification
   #
   # @return [Nil]
   # @api public
+  # TODO raising an exception really isn't a good idea since it forces the stack to unwind.
+  # More than likely developers are using exceptions to control the code flow and a different approach should be used.
+  # Catch/throw is a bit more efficient but is still the wrong approach for this specific problem.
   def self.verify_cast(name, value, expected_type)
     validation = ParamsVerification.type_validations[expected_type.to_sym]
     unless validation.nil? || value.to_s =~ validation

data/spec/params_verification_spec.rb

@@ -39,6 +39,20 @@ describe ParamsVerification do
     params.delete('framework')
     lambda{ ParamsVerification.validate!(params, @service.defined_params) }.should raise_exception(ParamsVerification::MissingParam)
   end
+
+  it "should cast a comma delimited string into an array when param marked as an array" do
+    service = WSList.all.find{|s| s.url == "services/array_param.xml"}
+    service.should_not be_nil
+    params = {'seq' => "a,b,c,d,e,g"}
+    validated = ParamsVerification.validate!(params, service.defined_params)
+    validated['seq'].should == %W{a b c d e g}
+  end
+
+  it "should raise an exception if a req array param doesn't contain a comma" do
+    service = WSList.all.find{|s| s.url == "services/array_param.xml"}
+    params = {'seq' => "a b c d e g"}
+    lambda{ ParamsVerification.validate!(params, service.defined_params) }.should raise_exception(ParamsVerification::InvalidParamType)
+  end
   
   it "should raise an exception when a param is of the wrong type" do
     params = @valid_params.dup

data/spec/test_services.rb

@@ -71,3 +71,13 @@ describe_service "services.xml" do |service|
   service.http_verb :put
   
 end
+
+describe_service "services/array_param.xml" do |s|
+  s.formats :xml
+  s.http_verb :post
+
+  s.params do |p|
+    p.array :seq, :required => true
+  end
+
+end

data/wsdsl.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{wsdsl}
-  s.version = "0.1.4"
+  s.version = "0.1.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Matt Aimonetti"]
-  s.date = %q{2011-03-15}
+  s.date = %q{2011-05-13}
   s.description = %q{A Ruby DSL describing Web Services without implementation details.}
   s.email = %q{mattaimonetti@gmail.com}
   s.extra_rdoc_files = [
@@ -43,7 +43,7 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/mattetti/wsdsl}
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.7}
+  s.rubygems_version = %q{1.7.2}
   s.summary = %q{Web Service DSL}
   s.test_files = [
     "spec/hello_world_controller.rb",
@@ -57,7 +57,6 @@ Gem::Specification.new do |s|
   ]
 
   if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then

metadata

@@ -1,12 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: wsdsl
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 4
-  version: 0.1.4
+  prerelease: 
+  version: 0.1.5
 platform: ruby
 authors: 
 - Matt Aimonetti
@@ -14,8 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-15 00:00:00 -07:00
-default_executable: 
+date: 2011-05-13 00:00:00 Z
 dependencies: []
 
 description: A Ruby DSL describing Web Services without implementation details.
@@ -50,7 +45,6 @@ files:
 - spec/wsdsl_sinatra_ext_spec.rb
 - spec/wsdsl_spec.rb
 - wsdsl.gemspec
-has_rdoc: true
 homepage: http://github.com/mattetti/wsdsl
 licenses: 
 - MIT
@@ -64,21 +58,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.7.2
 signing_key: 
 specification_version: 3
 summary: Web Service DSL