wp-hmac 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7890c63aaa7a52e55fae583b772d0fdd4ed2f09e
-  data.tar.gz: 9de22c8167a45b4a20f45edc6daeb69e1a1fb53e
+  metadata.gz: 0b1fee8fa88eb3443cba2874b60dff707e07604e
+  data.tar.gz: 8d90cec9afaa7e183bab2bff42c645373368d8fa
 SHA512:
-  metadata.gz: 4d2230ec01a97d7b2e18595ff3d6f4e16564c907c4f720c8a81d5042b629351366e649514cc38f4bfe27d5638dc12d7a85f5c055537cd98e666e7942443efff0
-  data.tar.gz: 50f840e23e5aa29b9a3e71d45e9ef0728cdc2b5f56b83454a6b7a2d312e9d4db3d0d1cd924e077162534f6ca165995f9a333e4c1290ee4ca76b15da385e43eeb
+  metadata.gz: b0cde112d23e27ac62ed9269b3047506002c2fd8c4e16fc1ee75005282ca15de773f5271087ed6610336b66fb534fe125869ababfc9ec1e844fb57768d7cd498
+  data.tar.gz: 6d149a01edfa78c6ab700ab8e2c60eca946acb712702d5e49256749660c27aec353a3de7b39a912e4a4c78c3d5b19f58e876d459cac09d4fc101af167fcb0b32

data/lib/wp/hmac/client.rb

@@ -21,21 +21,28 @@ module WP
         @client
       end
 
-      def method_missing(method_missing, *args, &block)
-        @client.send(method_missing, *args, &block)
-      end
-
       def key_cabinet
         @key_cabinet ||= HMAC::KeyCabinet.find_by_auth_id(HMAC.auth_id)
       end
 
+      # Supports:
+      # client = WP::HMAC::Client.new('https://www.example.com')
+      # client.get('api/staff')
+      %i(delete get head options post put patch).each do |method|
+        define_method(method) do |*args|
+          response = @client.send(method, *args)
+          raise UnsuccessfulResponse unless /2\d\d/.match("#{response.status}")
+          response
+        end
+      end
+
+      # Supports:
+      # WP::HMAC::Client.get('https://www.example.com/api/staff')
       class << self
-        %i(delete get head options post put).each do |method|
+        %i(delete get head options post put patch).each do |method|
           define_method(method) do |*args|
             client = Client.new
             client.send(method, *args)
-
-            raise UnsuccessfulResponse unless /2\d\d/.match("#{client.status}")
           end
         end
       end

data/lib/wp/hmac/version.rb

@@ -1,5 +1,5 @@
 module Wp
   module Hmac
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

data/spec/hmac_spec.rb

@@ -11,6 +11,10 @@ class DummyController < ActionController::Base
   def show
     render inline: 'Hello, world!'
   end
+
+  def create
+    head :bad_request
+  end
 end
 
 RSpec.describe WP::HMAC, type: :request do
@@ -31,7 +35,7 @@ RSpec.describe WP::HMAC, type: :request do
 
   before do
     Rails.application.routes.draw do
-      resources :dummy, only: %i(show)
+      resources :dummy
     end
   end
 
@@ -78,6 +82,25 @@ RSpec.describe WP::HMAC, type: :request do
       rack_response = hmac_client.get 'http://esso.example.org/dummy/1'
       expect(rack_response.body).to include('Hello, world!')
     end
+
+    it 'succeeds when the request is correctly signed (alt syntax)' do
+      pending 'Need to work out how to test this'
+      rack_response = WP::HMAC::Client.get('http://esso.example.org/dummy/1')
+      expect(rack_response.body).to include('Hello, world!')
+    end
+
+    it 'raises UnsuccessfulResponse when server reponds 400' do
+      expect {
+        hmac_client.post('http://esso.example.org/dummy')
+      }.to raise_error(WP::HMAC::Client::UnsuccessfulResponse)
+    end
+
+    it 'raises UnsuccessfulResponse when server reponds 400 (alt syntax)' do
+      pending 'Need to work out how to test this'
+      expect {
+        WP::HMAC::Client.post('http://esso.example.org/dummy')
+      }.to raise_error(WP::HMAC::Client::UnsuccessfulResponse)
+    end
   end
 
   context 'with a key configured via a block' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wp-hmac
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Andrew Nagi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-10 00:00:00.000000000 Z
+date: 2015-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ey_api_hmac