worldpay_iadmin 1.0.1 → 1.0.2

data/CHANGELOG

@@ -1,3 +1,8 @@
+worldpay_iadmin (1.0.2)
+
+  * Fixed a serious bug in iadmin_url method. Was returning test url in production mode
+    and production url in test mode. Added tests to prevent future mistake [Steven Cummings]
+
 worldpay_iadmin (1.0.1)
 
   * Fixed a bug in worldpay_iadmin_test.rb [Steven Cummings]

data/lib/worldpay_iadmin.rb

@@ -77,8 +77,8 @@ class WorldpayIadmin
     @worldpay_id = worldpay_id
     @password = password
     @test_mode = test_mode
-    @production_url = "https://secure-test.wp3.rbsworldpay.com/wcc/iadmin"
-    @test_url = "https://secure.wp3.rbsworldpay.com/wcc/iadmin"
+    @production_url = "https://secure.wp3.rbsworldpay.com/wcc/iadmin"
+    @test_url = "https://secure-test.wp3.rbsworldpay.com/wcc/iadmin"
   end
   
   # Returns the url that the command will be sent to

data/test/worldpay_iadmin_test.rb

@@ -9,17 +9,17 @@ require 'fakeweb'
 class WorldpayIadminTest < Test::Unit::TestCase
   
   def create_worldpay_iadmin(response)
-    @worldpay_iadmin = WorldpayIadmin.new("123434", "password")
-    FakeWeb.register_uri(:any, @worldpay_iadmin.iadmin_url, :body => response)
-    @worldpay_iadmin
+    worldpay_iadmin = WorldpayIadmin.new("123434", "password")
+    FakeWeb.register_uri(:any, worldpay_iadmin.iadmin_url, :body => response)
+    worldpay_iadmin
   end
   
   def test_initialize
-    @worldpay_iadmin = WorldpayIadmin.new("123434", "password", true)
+    worldpay_iadmin = WorldpayIadmin.new("123434", "password", true)
     
-    assert_equal "123434", @worldpay_iadmin.worldpay_id
-    assert_equal "password", @worldpay_iadmin.password
-    assert_equal true, @worldpay_iadmin.test_mode
+    assert_equal "123434", worldpay_iadmin.worldpay_id
+    assert_equal "password", worldpay_iadmin.password
+    assert_equal true, worldpay_iadmin.test_mode
   end
   
   def test_cancel_agreement
@@ -53,5 +53,15 @@ class WorldpayIadminTest < Test::Unit::TestCase
   def test_debit_fail
     assert !create_worldpay_iadmin("E,Agreement already finished").debit("232323", 9.99)
   end
+  
+  def test_iadmin_url_production
+    worldpay_iadmin = WorldpayIadmin.new("123434", "password")
+    assert_equal "https://secure.wp3.rbsworldpay.com/wcc/iadmin", worldpay_iadmin.iadmin_url
+  end
+  
+  def test_iadmin_url_test
+    worldpay_iadmin = WorldpayIadmin.new("123434", "password", true)
+    assert_equal "https://secure-test.wp3.rbsworldpay.com/wcc/iadmin", worldpay_iadmin.iadmin_url
+  end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: worldpay_iadmin
 version: !ruby/object:Gem::Version 
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors: 
 - Steven Cummings