world_wrap 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dc747a45c346b26d2c2b01b3923be985fb9b86f6
-  data.tar.gz: b287bcdc976c8301901b57813e914a104e620b0e
+  metadata.gz: b4744cef9fcdeafba9b922c41595350b20b3a948
+  data.tar.gz: 5d229574c1b305562c595a70bd87898e01aba21c
 SHA512:
-  metadata.gz: 649f56dfc14df7a0b2a2e8cbab35dbcddad3f9b6b7a218f8063ba3d6862a26fe37f9fc5fa47d2087c57f7dca82e9577e58316410082bcca50d99d0f304708b46
-  data.tar.gz: 91aa3510270d3ec1576ddb439ac583de3c3146bd23276f61bcbe1fd6bfdae607f495a338442c0d00762296addf26bc03b33ed4ec676fe74ff01f4c0cda4b3e25
+  metadata.gz: e6d70e0a71cf984f19178e21fd6a88572eba00d418239b419a9bed295d70a7f60e513d4a71a062e736a4d2f48529dfda4b0885fb8a14aecbddba457ef14302c8
+  data.tar.gz: 0ab867da10e1ca9e037f85a6755383cfd1aacd1b5abf5da408b9329a2e23a4885fd3c405d46458713de7940b6f8f6542c8aa4b0b6dee646e9694b708b678619c

data/lib/world_wrap.rb

@@ -1,5 +1,5 @@
 require 'country'
-require 'states'
+require 'state'
 require 'city'
 module WorldWrap
   def countries options = {}
@@ -9,12 +9,21 @@ module WorldWrap
   def states options = {}
     return "Please pass a country name or code" if options[:country].nil? || options[:country].empty?
     country = options[:country].downcase
+    return "not a valid key" if is_invalid_key?(COUNTRIES, country)
+    return "Need to save data for #{country}" unless STATES.has_key?(country)
     STATES[country]
   end
 
   def cities options = {}
     return "Please pass a state name or code" if options[:state].nil? || options[:state].empty?
     state = options[:state].downcase
+#    return "not a valid key" if is_invalid_key?(STATES, state) TODO
+    return "Need to store data for #{state} Or its not a state in the given list" unless CITIES.has_key?(state)
     CITIES[state]
   end
+
+  def is_invalid_key?(objects, value)
+    is_valid = objects.select{|object| object if [object[:name].downcase, object[:code].downcase].include?(value)}
+    is_valid.empty?
+  end
 end

data/spec/world_wrap_spec.rb

@@ -26,6 +26,11 @@ describe WorldWrap do
       actual = states({country: 'INDIA'})
       expected.should == actual
     end
+    it 'should return TODO message' do
+      expected = "Need to save data for af"
+      actual = states({country: 'AF'})
+      expected.should == actual
+    end
   end
 
   describe '#cities' do
@@ -41,4 +46,17 @@ describe WorldWrap do
       expected.should == actual
     end
   end
+
+  describe '#is_valid_key?' do
+    it 'should return false when code or name not matched' do
+      expected = true
+      actual = is_invalid_key?(COUNTRIES, 'dilkhush')
+      expected.should == actual
+    end
+    it 'should return true when code or name matched' do
+      expected = false
+      actual = is_invalid_key?(COUNTRIES, 'in')
+      expected.should == actual
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: world_wrap
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Dilkhush Soni