workers_loader 0.0.3 → 0.0.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzM2NTBjNDBlOGZhZTVhMjI5MDUzMDJkYTA5MTNkYmY4ZjcxZjBhMA==
+    YzQ0ZjM0ZmJhYWNjZmYwNDhkOWU0YzgwZTVkY2NlMGY5MWNmZjBjNg==
   data.tar.gz: !binary |-
-    NmQ0YzNmMTc5ZWJiZDZmYTYwNTlmMmM1OWQwZGExY2E0NjU0MWQwZA==
+    MDYyZjhiMTZiOWU1ZTgxYzBiY2ExMzQ0MTY3MzhhM2NhNGRmMjlmZg==
 SHA512:
   metadata.gz: !binary |-
-    N2ViMDA2YjliNzUwMjEzYTViODFjNmMyOWRjODQwNjkyYjg5YjM3NTQwNDg0
-    YjkxZWY1ZjY2NjA0NmU4OWJkOGYxMTRhYzkwNDlkYmNiZWIwZWQ2NGM1ZWNj
-    NmUyNmE4MDU3ZGNkNGFlNWE0ZDk3ZDlkMDkyMjk3NWYwZjk2ZGI=
+    ODIxZDMyMGVlMzQ2NTIzN2JmOGFmNjllOGY0YWQ2NmJlZDc4N2UxNzFiZWNi
+    YTk2N2Q1ODA0ZjQ2ZWIyOThlMzczZDY1ZGE5NDM1ZWIxMGRiMmMwZDdhNzNm
+    NWM4ZWY3MjU0YmVkYWM3YmExM2YwNGE2Y2Y1NDczNmZjMTcxMjg=
   data.tar.gz: !binary |-
-    MGMyNzU4N2RjZWY5ZWE2OTczMTMzNDYwOWU5MWU0MjVhNjE1NGQwMjE4MDU5
-    YTI0MTQ2OWEzN2RmYjBlMGZiMGVhZjQ4NjlhNzM3N2M1NDQ5NjYwMDU5Mjc2
-    ZTA4ZGJlYWY5NzM1ZTE3MGFjMTAzZTdmZDEyNmZkYTc3NGU2Nzg=
+    ZTkzMDI3OTM3MGFhYjFhNDJhMjU4ZmY1MTU5OWMwZDIzMzY0MTliMDY4MGNl
+    Mjc0NjgwYzEwODNlYTA1M2E0NzIyYmI5NGJlMzc3MzAwNGRkY2EzYjBkZWY3
+    YTk0MWRkMDZiMWQxNWUzZWUwMTEzZTg3Y2NhY2M1MjYwZTg2NjA=

data/README

@@ -1,6 +1,5 @@
 This library is intended to let workers modularization.
 
-
 It lets you load workers queue names from a given directory.
 
 Let's say you have some engines with workers in folder /my_engine/app/workers
@@ -12,7 +11,9 @@ You can place an initializer like follow in your engine so then the container ap
 module MyApp
   class Engine < ::Rails::Engine
     initializer 'my_app.wokers_path' do |app|
-      WorkersLoader.add_path(MyApp::Engine.root.join('app', workers))
+      WorkersLoader.resque_mailer!
+      workers_path = MyApp::Engine.root.join('app', 'workers', 'my_app')
+      WorkersLoader.add_path(workers_path)
     end
   end
 end
@@ -24,3 +25,4 @@ You can get the complete list of queues by doing the following:
 WorkersLoader.load_workers!
 WorkersLoader.workers
 
+With this list you can tell resque what queues to listen to.

data/lib/workers_loader/path.rb

@@ -18,6 +18,11 @@ module WorkersLoader
         .map { |file| /#{base}\/(.*).rb/.match(file)[1] }
     end
 
+    def find
+      files.map { |file| queue_for(file) }
+        .reject(&:blank?)
+    end
+
     def class_for(relative_path)
       relative_path.split('/').map(&:camelize).join('::').constantize
     rescue NameError

data/lib/workers_loader/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module WorkersLoader
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/lib/workers_loader.rb

@@ -10,31 +10,42 @@ module WorkersLoader
   mattr_accessor :workers
   @@workers = []
 
+  mattr_accessor :resque_mailer
+  @@resque_mailer = false
+
   class << self
-    def add_path(path)
+    def add_path(path, parent = true)
       fail "Directory not found: `#{path}`" unless Dir.exist?(path)
-      @@workers_paths << path
-    end
-
-    def find(path)
-      path = Path.new(path)
-      path.files.map { |file| path.queue_for(file) }
-        .reject(&:blank?)
+      @@workers_paths << Path.new(path, parent)
     end
 
     def load_workers!
       workers_paths.each do |path|
-        workers_in_path = find(path)
+        workers_in_path = path.find
         next if workers_in_path.empty?
 
         duplacates = workers_in_path
           .select { |worker| workers.include?(worker) }
-        if duplacates.any?
-          fail("Workers already present! #{duplacates.sort.join(', ')}")
-        end
+          .sort.join(', ')
+        fail("Workers already present! #{duplacates}") unless duplacates.blank?
 
         self.workers += workers_in_path
       end
+
+      resque_mailer_install
+    end
+
+    def resque_mailer_install
+      return if !resque_mailer? || self.workers.include?(:mailer)
+      self.workers << :mailer
+    end
+
+    def resque_mailer!
+      @@resque_mailer = true
+    end
+
+    def resque_mailer?
+      @@resque_mailer
     end
   end
 

data/spec/lib/workers_loader/path_spec.rb

@@ -23,19 +23,25 @@ describe WorkersLoader::Path do
     end
 
     describe '#files' do
-      let(:files) { %w(user reports/usage).sort }
+      let(:files) { %w(not_a_worker user reports/usage).sort }
       it { expect(subject.files.sort).to eq(files) }
     end
 
     describe '#class_for' do
+      it { expect(subject.class_for('not_a_worker')).to eq(NotAWorker) }
       it { expect(subject.class_for('user')).to eq(User) }
       it { expect(subject.class_for('reports/usage')).to eq(Reports::Usage) }
     end
 
     describe '#queue_for' do
+      it { expect(subject.queue_for('not_a_worker')).to be(false) }
       it { expect(subject.queue_for('user')).to eq(:user_queue) }
       it { expect(subject.queue_for('reports/usage')).to eq(:usage_queue) }
     end
+
+    describe '::find' do
+      it { expect(subject.find.sort).to eq([:user_queue, :usage_queue].sort) }
+    end
   end
 
   context 'with parent' do
@@ -70,5 +76,9 @@ describe WorkersLoader::Path do
       it { expect(subject.queue_for('dummy/foo')).to eq(:dummy_foo) }
       it { expect(subject.queue_for('dummy/bar/baz')).to eq(:baz_queue) }
     end
+
+    describe '::find' do
+      it { expect(subject.find.sort).to eq([:dummy_foo, :baz_queue].sort) }
+    end
   end
 end

data/spec/lib/workers_loader_spec.rb

@@ -15,8 +15,8 @@ describe WorkersLoader do
 
   describe '::add_path' do
     before { described_class.add_path(workers_path) }
-
-    it { expect(described_class.workers_paths).to eq([workers_path]) }
+    subject { described_class.workers_paths.first }
+    it { expect(subject).to be_a(WorkersLoader::Path) }
 
     context 'dubplicate worker' do
       let(:message) { 'Directory not found: `foo`' }
@@ -24,21 +24,33 @@ describe WorkersLoader do
     end
   end
 
-  describe '::find' do
-    subject { described_class.find(workers_path) }
+  describe '::load_workers!' do
+    let(:workers) { [:baz_queue, :dummy_foo].sort }
 
-    it { expect(subject.sort).to eq([:dummy_foo, :baz_queue].sort) }
-  end
+    context 'load workers' do
+      before do
+        described_class.add_path(workers_path)
+        described_class.load_workers!
+      end
 
-  describe '::load_workers!' do
-    before do
-      described_class.add_path(workers_path)
-      described_class.load_workers!
+      it { expect(described_class.workers.sort).to eq(workers) }
+    end
+
+    context 'load mailer' do
+      before do
+        described_class.resque_mailer!
+        described_class.load_workers!
+      end
+
+      it { expect(described_class.workers.sort).to include(:mailer) }
     end
-    let(:workers) { [:baz_queue, :dummy_foo].sort }
-    it { expect(described_class.workers.sort).to eq(workers) }
 
     context 'prevent duplicates' do
+      before do
+        described_class.add_path(workers_path)
+        described_class.load_workers!
+      end
+
       let(:message) { "Workers already present! #{workers.join(', ')}" }
       it { expect { described_class.load_workers! }.to raise_error(message) }
     end

data/spec/spec_helper.rb

@@ -13,4 +13,9 @@ RSpec.configure do |config|
   config.mock_with :rspec
 
   config.order = 'random'
+
+  config.before(:each) do
+    WorkersLoader.workers = []
+    WorkersLoader.resque_mailer = false
+  end
 end

data/spec/support/data/not_a_worker.rb

@@ -0,0 +1,4 @@
+# encoding: utf-8
+
+class NotAWorker
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: workers_loader
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ricard Forniol
@@ -96,6 +96,7 @@ files:
 - spec/lib/workers_loader/path_spec.rb
 - spec/lib/workers_loader_spec.rb
 - spec/spec_helper.rb
+- spec/support/data/not_a_worker.rb
 - spec/support/data/reports/usage.rb
 - spec/support/data/user.rb
 - spec/support/dummy/bar/base.rb
@@ -128,6 +129,7 @@ test_files:
 - spec/lib/workers_loader/path_spec.rb
 - spec/lib/workers_loader_spec.rb
 - spec/spec_helper.rb
+- spec/support/data/not_a_worker.rb
 - spec/support/data/reports/usage.rb
 - spec/support/data/user.rb
 - spec/support/dummy/bar/base.rb