workarea-reviews 3.1.1 → 3.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b0b2d9372daaeb9ee3c57719b48614dd6d7669fb4565ef41c27b42d6fe62be8
-  data.tar.gz: 8c96afdcc3148cd43dc0abff152e827eda68884338a0d6b6c825ef01dca2e579
+  metadata.gz: a07fba40d273a1fd46dfa4575601eefe0eb742fafe6da2be58c2ca07fba3b51f
+  data.tar.gz: 9a5f40859ec940937ac073bfc976ea1e899d05864f3cdf2e2b261b25a2963410
 SHA512:
-  metadata.gz: 19b6581073824b8c0c095c82a5e9c00cc24245ce3835e3cf182bcbf7ed862ad67c4bd152dc290fb6c7c79a37c2bf0cb4056198dee55d5cdb06c143ab0d467e56
-  data.tar.gz: 4c6513727fe2685630ab37f9468de14c267a7d3695b955e6188835920874d053e2e17c184d06810ca443d12a9a6919d129dfa6b872884bfa01beb165bdee4f7d
+  metadata.gz: 49005ddc4805c46ff4bcb725a1c6b30d53f616b912880c6c64404c57334e31281824ea1fe3109204981fbec7db255bc327be890d2fd536ef17a9a80e42e9efb6
+  data.tar.gz: 27fc7ae007ceb0b676576a8a93e270869aa8c362d76054e15faa0863911be3872eed903604132d15382fdd52cdc5f251f21ed514b6a515a4b93c24187d2290ee

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+Workarea Reviews 3.1.2 (2020-10-30)
+--------------------------------------------------------------------------------
+
+*   Handle reviews with user_ids that do not match a user
+
+    REVIEWS-6
+
+    Matt Duffy
+
+
+
 Workarea Reviews 3.1.1 (2020-01-07)
 --------------------------------------------------------------------------------
 

data/app/view_models/workarea/storefront/review_view_model.rb

@@ -2,12 +2,18 @@ module Workarea
   module Storefront
     class ReviewViewModel < ApplicationViewModel
       def requires_public_info?
-        anonymous? || user.public_info.blank?
+        anonymous? || user&.public_info.blank?
+      end
+
+      def anonymous?
+        model.anonymous? || user.nil?
       end
 
       def user
-        return if anonymous?
-        @user ||= User.find(user_id)
+        return if model.anonymous?
+        return @user if defined?(@user)
+
+        @user = User.find(user_id) rescue nil
       end
     end
   end

data/lib/workarea/reviews/version.rb

@@ -1,5 +1,5 @@
 module Workarea
   module Reviews
-    VERSION = '3.1.1'.freeze
+    VERSION = '3.1.2'.freeze
   end
 end

data/test/view_models/workarea/storefront/review_view_model_test.rb

@@ -0,0 +1,46 @@
+require 'test_helper'
+
+module Workarea
+  module Storefront
+    class ReviewViewModelTest < TestCase
+      def test_requires_public_info?
+        review = Review.new
+        assert(ReviewViewModel.wrap(review).requires_public_info?)
+
+        user = create_user(first_name: nil, last_name: nil)
+        review.user_id = user.id
+        assert(ReviewViewModel.wrap(review).requires_public_info?)
+
+        user.update!(first_name: 'Bob', last_name: 'Clams')
+        refute(ReviewViewModel.wrap(review).requires_public_info?)
+
+        user.destroy!
+        assert(ReviewViewModel.wrap(review).requires_public_info?)
+      end
+
+      def test_anonymous?
+        review = Review.new
+        assert(ReviewViewModel.wrap(review).anonymous?)
+
+        user = create_user
+        review.user_id = user.id
+        refute(ReviewViewModel.wrap(review).anonymous?)
+
+        user.destroy!
+        assert(ReviewViewModel.wrap(review).anonymous?)
+      end
+
+      def test_user
+        review = Review.new
+        assert_nil(ReviewViewModel.wrap(review).user)
+
+        user = create_user
+        review.user_id = user.id
+        assert_equal(user, ReviewViewModel.wrap(review).user)
+
+        user.destroy!
+        assert_nil(ReviewViewModel.wrap(review).user)
+      end
+    end
+  end
+end

data/yarn.lock

@@ -184,9 +184,9 @@ acorn-jsx@^5.0.0:
   integrity sha512-tiNTrP1MP0QrChmD2DdupCr6HWSFeKVw5d/dHTu4Y7rkAkRhU/Dt7dphAfIUyxtHpl/eBVip5uTNSpQJHylpAw==
 
 acorn@^6.0.7:
-  version "6.3.0"
-  resolved "https://registry.yarnpkg.com/acorn/-/acorn-6.3.0.tgz#0087509119ffa4fc0a0041d1e93a417e68cb856e"
-  integrity sha512-/czfa8BwS88b9gWQVhc8eknunSA2DoJpJyTQkhheIf5E48u1N0R4q/YxxsAeqRrmK9TQ/uYfgLDfZo91UlANIA==
+  version "6.4.1"
+  resolved "https://registry.yarnpkg.com/acorn/-/acorn-6.4.1.tgz#531e58ba3f51b9dacb9a6646ca4debf5b14ca474"
+  integrity sha512-ZVA9k326Nwrj3Cj9jlh3wGFutC2ZornPNARZwsNYqQYgN0EsV2d53w5RN/co65Ohn4sUAUtb1rSUAOD6XN9idA==
 
 ajv@^6.10.2, ajv@^6.9.1:
   version "6.10.2"
@@ -1773,9 +1773,9 @@ locate-path@^2.0.0:
     path-exists "^3.0.0"
 
 lodash@^4.17.11, lodash@^4.17.12, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.15:
-  version "4.17.15"
-  resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.15.tgz#b447f6670a0455bbfeedd11392eff330ea097548"
-  integrity sha512-8xOcRHvCjnocdS5cpwXQXVzmmh5e5+saE2QGoeQmbKmRS6J3VQppPOIt0MnmE+4xlZoumy0GPG0D0MVIQbNA1A==
+  version "4.17.19"
+  resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.19.tgz#e48ddedbe30b3321783c5b4301fbd353bc1e4a4b"
+  integrity sha512-JNvd8XER9GQX0v2qJgsaN/mzFCNA5BRe/j8JN9d+tWyGLSodKQHKFicdwNYzWwI3wjRnaKPsGj1XkBjx/F96DQ==
 
 log-symbols@^2.2.0:
   version "2.2.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workarea-reviews
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.1.2
 platform: ruby
 authors:
 - Ben Crouse
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-08 00:00:00.000000000 Z
+date: 2020-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: workarea
@@ -234,6 +234,7 @@ files:
 - test/system/workarea/storefront/review_system_test.rb
 - test/teaspoon_env.rb
 - test/test_helper.rb
+- test/view_models/workarea/storefront/review_view_model_test.rb
 - test/workers/workarea/create_review_requests_test.rb
 - test/workers/workarea/schedule_review_requests_test.rb
 - test/workers/workarea/send_review_requests_test.rb
@@ -258,7 +259,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Reviews plugin for the Workarea ecommerce platform