workarea-gift_cards 3.4.11 → 4.0.0.beta.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fa8b21256ede5c3dcf4015777bf183d35652185cca9580d6e505bc38d95523a
-  data.tar.gz: 3aecca4a5c02a9d74c3dfd5be8de7e4cd74fa0f38f69258d2ba5c8f6402841cc
+  metadata.gz: ef5e635f5ce1f7cb61c1940ca2d804489894e452dbcd644b6cf3c92cc88f8e00
+  data.tar.gz: 409df19432f8b11ba9ad0fc806ad32b7e2ca04d1d4eb7fda6cb72ce6d8f50964
 SHA512:
-  metadata.gz: b4e7276cabf21febb88b8412e17b323af86efc97c86c8fd4c50f95544edcf329f11c53b21801078d182d7725170adc6853437f2afea56d795ea2d2e4f2caa7a0
-  data.tar.gz: 369dec138960d08588977551ac20719c2872182ffddfca3948daed033b430fea58fdc0f16fa66932da8e186ced735913f0e59bc34e81ea4499a6ec44384c222e
+  metadata.gz: 05c1a4918fd065cd9f697146c9558c844e6673d19df6458a86eeb7ad06d22a43cd71fa1a04f49f91e82b2f60daff801880935f0b44efabefae008399cf708f0a
+  data.tar.gz: 825eff9a470dcf32a45e14777027f86079b76de157f21b298e898e40fc6fdbfcd3d461483df6841c7b7689cef56d1014e5262b05652e2848573dca67024fee0c

data/{.eslintrc → .eslintrc.json}

@@ -1,7 +1,8 @@
 {
     "extends": "eslint:recommended",
     "rules": {
-      "semi": [1, "always"]
+      "semi": ["error", "always"],
+      "eqeqeq": ["error", "always"]
     },
     "globals": {
       "window": true,
@@ -20,5 +21,15 @@
       "Waypoint": true,
       "wysihtml": true,
       "LocalTime": true,
+      "describe": true,
+      "after": true,
+      "afterEach": true,
+      "before": true,
+      "beforeEach": true,
+      "it": true,
+      "expect": true,
+      "sinon": true,
+      "fixture": true,
+      "chai": true
     }
 }

data/.github/workflows/ci.yml

@@ -1,14 +1,16 @@
 name: CI
 on: [push]
-env:
-  BUNDLE_GEMS__WEBLINC__COM: ${{ secrets.BUNDLE_GEMS__WEBLINC__COM }}
+
 jobs:
   static_analysis:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v1
-    - uses: workarea-commerce/ci/bundler-audit@ruby-2.4
-    - uses: workarea-commerce/ci/rubocop@ruby-2.4
+    - uses: workarea-commerce/ci/bundler-audit@v1
+    - uses: workarea-commerce/ci/rubocop@v1
+    - uses: workarea-commerce/ci/eslint@v1
+      with:
+        args: '**/*.js'
 
   admin_tests:
     runs-on: ubuntu-latest
@@ -16,7 +18,7 @@ jobs:
     - uses: actions/checkout@v1
     - uses: actions/setup-ruby@v1
       with:
-        ruby-version: 2.4.x
+        ruby-version: 2.6.x
     - uses: workarea-commerce/ci/test@v1
       with:
         command: bin/rails app:workarea:test:admin
@@ -27,7 +29,7 @@ jobs:
     - uses: actions/checkout@v1
     - uses: actions/setup-ruby@v1
       with:
-        ruby-version: 2.4.x
+        ruby-version: 2.6.x
     - uses: workarea-commerce/ci/test@v1
       with:
         command: bin/rails app:workarea:test:core
@@ -38,7 +40,7 @@ jobs:
     - uses: actions/checkout@v1
     - uses: actions/setup-ruby@v1
       with:
-        ruby-version: 2.4.x
+        ruby-version: 2.6.x
     - uses: workarea-commerce/ci/test@v1
       with:
         command: bin/rails app:workarea:test:storefront
@@ -49,7 +51,7 @@ jobs:
     - uses: actions/checkout@v1
     - uses: actions/setup-ruby@v1
       with:
-        ruby-version: 2.4.x
+        ruby-version: 2.6.x
     - uses: workarea-commerce/ci/test@v1
       with:
         command: bin/rails app:workarea:test:plugins

data/.rubocop.yml

@@ -1,197 +1,2 @@
-AllCops:
-  TargetRubyVersion: 2.4
-  # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
-  # to ignore them, so only the ones explicitly set in this file are enabled.
-  DisabledByDefault: true
-
-# Prefer &&/|| over and/or.
-Style/AndOr:
-  Enabled: true
-  Exclude:
-    - 'testing/lib/workarea/performance_test.rb'
-    - 'admin/app/controllers/workarea/admin/help_authorization.rb'
-    - 'admin/app/controllers/workarea/admin/users_controller.rb'
-    - 'core/app/controllers/workarea/authorization.rb'
-    - 'core/app/models/workarea/analytics/time_series.rb'
-    - 'core/app/models/workarea/payment/operation.rb'
-    - 'core/lib/workarea/validators/ip_address_validator.rb'
-    - 'script/rename'
-    - 'storefront/app/controllers/workarea/storefront/checkout/place_order_controller.rb'
-    - 'storefront/app/controllers/workarea/storefront/current_checkout.rb'
-    - 'storefront/app/controllers/workarea/storefront/searches_controller.rb'
-    - 'storefront/app/controllers/workarea/storefront/users/orders_controller.rb'
-    - 'storefront/app/controllers/workarea/storefront/users/passwords_controller.rb'
-
-# Align `when` with `case`.
-Layout/CaseIndentation:
-  Enabled: true
-  Exclude:
-    - 'admin/app/helpers/workarea/admin/dashboard_helper.rb'
-
-# Align comments with method definitions.
-Layout/CommentIndentation:
-  Enabled: true
-
-Layout/EmptyLineAfterMagicComment:
-  Enabled: true
-
-# In a regular class definition, no empty lines around the body.
-Layout/EmptyLinesAroundClassBody:
-  Enabled: true
-  Exclude:
-    - 'admin/app/controllers/workarea/admin/release_sessions_controller.rb'
-    - 'admin/app/view_models/workarea/admin/release_calendar_view_model.rb'
-    - 'admin/lib/workarea/mailer_previews/admin/comment_mailer_preview.rb'
-    - 'admin/test/integration/workarea/admin/content_blocks_integration_test.rb'
-    - 'admin/test/view_models/workarea/admin/content_view_model_test.rb'
-    - 'core/app/models/workarea/checkout/steps/addresses.rb'
-    - 'core/app/models/workarea/pricing/discount/buy_some_get_some/product_application.rb'
-    - 'core/app/queries/workarea/metadata/catalog_category.rb'
-    - 'core/app/queries/workarea/metadata/content_page.rb'
-    - 'core/app/queries/workarea/search/facet.rb'
-    - 'core/app/queries/workarea/search/range_filter.rb'
-    - 'core/config/initializers/13_rack_attack.rb'
-    - 'core/lib/generators/workarea/override/override_generator.rb'
-    - 'core/lib/workarea/elasticsearch/query_cache.rb'
-    - 'core/lib/workarea/monitoring/elasticsearch_check.rb'
-    - 'core/lib/workarea/monitoring/mongoid_check.rb'
-    - 'core/lib/workarea/monitoring/sidekiq_queue_size_check.rb'
-    - 'core/lib/workarea/validators/email_validator.rb'
-    - 'core/test/lib/workarea/mail_interceptor_test.rb'
-    - 'core/test/models/workarea/commentable_test.rb'
-    - 'core/test/models/workarea/search/settings_test.rb'
-    - 'core/test/models/workarea/shipping/rate_lookup_test.rb'
-    - 'core/test/queries/workarea/find_pipeline_asset_test.rb'
-    - 'core/test/queries/workarea/product_primary_image_url_test.rb'
-    - 'core/test/queries/workarea/search/filter_test.rb'
-    - 'core/test/workers/workarea/bulk_index_admin_test.rb'
-    - 'core/test/workers/workarea/bulk_index_products_test.rb'
-    - 'core/vendor/active_shipping/lib/active_shipping/carriers/australia_post.rb'
-    - 'core/vendor/active_shipping/lib/active_shipping/carriers/canada_post_pws.rb'
-    - 'core/vendor/active_shipping/lib/active_shipping/carriers/usps_returns.rb'
-    - 'core/vendor/active_shipping/lib/active_shipping/delivery_date_estimates_response.rb'
-    - 'core/vendor/active_shipping/lib/active_shipping/rate_response.rb'
-    - 'core/vendor/active_shipping/test/remote/australia_post_test.rb'
-    - 'core/vendor/active_shipping/test/remote/usps_returns_test.rb'
-    - 'core/vendor/active_shipping/test/unit/carriers/australia_post_test.rb'
-    - 'core/vendor/active_shipping/test/unit/carriers/canada_post_pws_test.rb'
-    - 'core/vendor/active_shipping/test/unit/carriers/usps_returns_test.rb'
-    - 'storefront/app/view_models/workarea/storefront/content_blocks/product_list_view_model.rb'
-    - 'storefront/app/view_models/workarea/storefront/product_view_model.rb'
-    - 'storefront/lib/workarea/mailer_previews/storefront/order_mailer_preview.rb'
-    - 'storefront/test/performance/workarea/storefront/categories_performance_test.rb'
-    - 'storefront/test/performance/workarea/storefront/search_performance_test.rb'
-    - 'storefront/test/view_models/workarea/storefront/user_activity_view_model_test.rb'
-
-# In a regular method definition, no empty lines around the body.
-Layout/EmptyLinesAroundMethodBody:
-  Enabled: true
-
-# In a regular module definition, no empty lines around the body.
-Layout/EmptyLinesAroundModuleBody:
-  Enabled: true
-  Exclude:
-    - 'core/lib/workarea/ext/mongoid/timestamps_timeless.rb'
-    - 'storefront/app/view_models/workarea/storefront/search_customization_content.rb'
-    - 'testing/lib/workarea/testing/warning_suppressor.rb'
-
-# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
-Style/HashSyntax:
-  Enabled: true
-
-Layout/SpaceAfterColon:
-  Enabled: true
-  Exclude:
-    - 'testing/lib/workarea/testing/factories/content.rb'
-    - 'testing/lib/workarea/testing/factories/pricing.rb'
-
-Layout/SpaceAfterComma:
-  Enabled: true
-  Exclude:
-    - 'admin/app/controllers/workarea/admin/shipping_services_controller.rb'
-    - 'admin/test/helpers/workarea/admin/application_helper_test.rb'
-    - 'core/app/models/workarea/payment/credit_card.rb'
-    - 'core/app/models/workarea/pricing/request.rb'
-    - 'core/spec/lib/workarea/swappable_list_spec.rb'
-    - 'core/test/models/workarea/inventory_test.rb'
-    - 'core/test/queries/workarea/search/range_facet_test.rb'
-    - 'storefront/test/view_models/workarea/storefront/package_view_model_test.rb'
-
-Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: true
-  Exclude:
-    - 'admin/app/helpers/workarea/admin/content_block_icon_helper.rb'
-    - 'core/app/helpers/workarea/content_assets_helper.rb'
-    - 'core/lib/workarea/elasticsearch/query_cache.rb'
-    - 'testing/lib/workarea/system_test.rb'
-    - 'testing/lib/workarea/testing/locale_routing_fixes.rb'
-
-
-Layout/SpaceAroundKeyword:
-  Enabled: true
-
-Layout/SpaceAroundOperators:
-  Enabled: true
-  Exclude:
-    - 'admin/app/controllers/workarea/admin/content_emails_controller.rb'
-    - 'admin/app/controllers/workarea/admin/users_controller.rb'
-    - 'core/app/helpers/workarea/content_assets_helper.rb'
-    - 'core/vendor/active_shipping/lib/active_shipping/carriers/canada_post_pws.rb'
-    - 'core/vendor/active_shipping/lib/active_shipping/carriers/fedex.rb'
-    - 'core/vendor/active_shipping/lib/active_shipping/carriers/stamps.rb'
-
-Layout/SpaceBeforeFirstArg:
-    Enabled: true
-
-# Defining a method with parameters needs parentheses.
-Style/MethodDefParentheses:
-  Enabled: true
-
-# Use `foo {}` not `foo{}`.
-Layout/SpaceBeforeBlockBraces:
-  Enabled: true
-  Exclude:
-    - 'admin/app/view_models/workarea/admin/release_calendar_view_model.rb'
-
-# Use `foo { bar }` not `foo {bar}`.
-Layout/SpaceInsideBlockBraces:
-  Enabled: true
-
-# Use `{ a: 1 }` not `{a:1}`.
-Layout/SpaceInsideHashLiteralBraces:
-  Enabled: true
-  Exclude:
-    - 'admin/test/integration/workarea/admin/pricing_sku_prices_integration_test.rb'
-    - 'admin/test/integration/workarea/admin/shipping_service_integration_test.rb'
-    - 'admin/test/integration/workarea/admin/tax_categories_integration_test.rb'
-    - 'admin/test/view_models/workarea/admin/changeset_view_model_test.rb'
-    - 'core/app/models/workarea/release/changeset.rb'
-    - 'core/app/queries/workarea/search/product_rules.rb'
-    - 'core/app/queries/workarea/search/term_filter.rb'
-    - 'core/lib/workarea/configuration.rb'
-    - 'core/spec/models/workarea/order_spec.rb'
-    - 'core/test/models/workarea/application_document_test.rb'
-    - 'core/test/models/workarea/fulfillment_test.rb'
-    - 'core/test/queries/workarea/search/product_rules_test.rb'
-    - 'core/test/workers/workarea/generate_content_metadata_test.rb'
-
-Layout/SpaceInsideParens:
-  Enabled: true
-  Exclude:
-    - 'core/app/models/workarea/inventory/collection.rb'
-    - 'core/app/models/workarea/pricing/calculators/item_calculator.rb'
-    - 'core/spec/models/workarea/order/queries_spec.rb'
-
-# Detect hard tabs, no hard tabs.
-Layout/Tab:
-  Enabled: true
-  Exclude:
-    - 'core/vendor/active_shipping/lib/active_shipping/carriers/canada_post.rb'
-
-# No trailing whitespace.
-Layout/TrailingWhitespace:
-  Enabled: true
-
-# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
-Lint/RequireParentheses:
-  Enabled: true
+inherit_from:
+  - https://raw.githubusercontent.com/workarea-commerce/workarea/master/.rubocop.yml

data/.stylelintrc.json

@@ -0,0 +1,8 @@
+{
+  "extends": "stylelint-config-recommended-scss",
+  "rules": {
+    "block-no-empty": null,
+    "no-descending-specificity": null,
+    "property-no-unknown": [true, { "ignoreProperties": ["mso-hide"] }]
+  }
+}

data/CHANGELOG.md

@@ -1,74 +1,3 @@
-Workarea Gift Cards 3.4.11 (2020-12-02)
---------------------------------------------------------------------------------
-
-*   Allow v3.4 use with this gem
-
-
-    Ben Crouse
-
-
-
-Workarea Gift Cards 3.4.10 (2020-02-04)
---------------------------------------------------------------------------------
-
-*   Fix the Gemfile
-
-    Tom Scott
-
-*   Remove ESLint from Gift Cards build
-
-    Tom Scott
-
-*   Fix rubocop config for 2.4
-
-    Tom Scott
-
-*   Use the same ruby version on static analysis as we use in tests
-
-    Tom Scott
-
-*   Use the same env var everywhere
-
-    Tom Scott
-
-*   Backport Missing `:via` Param
-
-    The `:via` param was not included on the gift card template, causing a
-    test in base to fail and subsequently block other plugin development
-    that depends on this gem. This change is from a later version of
-    Workarea, but was not backported to earlier versions. Additionally, this
-    commit adds the test workflow and ensures the correct version of
-    Workarea is being loaded to ensure accurate testing.
-
-    GIFTCARDS-7
-    Tom Scott
-
-
-
-Workarea Gift Cards 3.4.9 (2020-01-21)
---------------------------------------------------------------------------------
-
-*   Fix Tests for 2020
-
-    Update all tests so that they no longer depend on the year 2020 as an
-    expiration year. Instead, use the  method provided by Workarea.
-
-    GIFTCARDS-6
-    Tom Scott
-
-
-
-Workarea Gift Cards 3.4.7 (2019-09-04)
---------------------------------------------------------------------------------
-
-*   Always Use Configured Currency For Default Values (#1)
-
-    When specifying a `default:` for a Mongoid `Money` field, use an Integer
-    type like `0` instead of converting it to a Money type, as this will get
-    evaluated at compile-time rather than at runtime. Doing so preserves
-    the currency configuration specified by the application at runtime.
-
-
 Workarea Gift Cards 3.4.6 (2019-08-21)
 --------------------------------------------------------------------------------
 

data/Gemfile

@@ -1,9 +1,7 @@
 source 'https://rubygems.org'
-git_source(:github) { |repo| "git@github.com:#{repo}.git" }
+git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 gemspec
 
-source 'https://gems.weblinc.com' do
-  gem 'workarea', '~> 3.4.0'
-  gem 'workarea-api', '~> 4.3.0'
-end
+gem 'workarea-api', github: 'workarea-commerce/workarea-api'
+gem 'workarea', github: 'workarea-commerce/workarea'

data/Rakefile

@@ -38,12 +38,13 @@ desc "Release version #{Workarea::GiftCards::VERSION} of the gem"
 task :release do
   host = "https://#{ENV['BUNDLE_GEMS__WEBLINC__COM']}@gems.weblinc.com"
 
-  Rake::Task['workarea:changelog'].execute
-  system 'git add CHANGELOG.md'
-  system 'git commit -m "Update CHANGELOG"'
+  #Rake::Task['workarea:changelog'].execute
+  #system 'git add CHANGELOG.md'
+  #system 'git commit -m "Update CHANGELOG"'
+  #system 'git push origin HEAD'
 
   system "git tag -a v#{Workarea::GiftCards::VERSION} -m 'Tagging #{Workarea::GiftCards::VERSION}'"
-  system 'git push origin HEAD --follow-tags'
+  system 'git push --tags'
 
   system 'gem build workarea-gift_cards.gemspec'
   system "gem push workarea-gift_cards-#{Workarea::GiftCards::VERSION}.gem"