workarea-forter 1.2.4 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e6c4f679107573bc38a3e4a2ec421d83e53a85907082c678ff47553c4b3f9785
-  data.tar.gz: 1aa0edd84330d5b6fee488117362f134f38b2e2763951585cfc36ce1de1c810d
+  metadata.gz: c5b05cf277bf2f9053f124dcf7c7cb83096aa2aaf4def84bc5a600f50364ae6e
+  data.tar.gz: 626cdd36a1900d1372572f04be318ae2e57b4be60a8627427d6b0f02a047d97c
 SHA512:
-  metadata.gz: 2813c8e8aad7976352238666d8aeccb569e443f946f726ae0d2281c3346602940449613ac1b311da9fd3d8ac86e2420eaaf488c67fdee5ffecfcdc376ad88835
-  data.tar.gz: 877214170590717f90ac8ada8d3db7f57c84be2a62842f156cdfcbb2d7fcc26a6ca1e767a6adddaf72e85f2872c8cff9b5afa799923cc8b9b853d501628fa377
+  metadata.gz: 88d605bb65ff10b3764ffd4ab113c066c1534fc968bd3d57fbdd9469d31fcb1f2a92c62fdd0d6f57c86a55c383b2717ce3abb031bd2e4ae309b71ce3c4605ef2
+  data.tar.gz: bd6607c5a93f02a6cd60de6bc36f8000c948c59237e6acfbbf30a739e8f58b05896eeeb5b59be07efc295db3c55a6a0511b582952bfe23b3ec5de4f9832ffb78

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+Workarea Forter 1.3.0 (2019-11-26)
+--------------------------------------------------------------------------------
+
+*   V3.5 compatability updates
+
+    Update to make the plugin compatible with the 3.5 fraud
+    framework. Moves the decision to post auth.
+    Jeff Yucis
+
+
+
 Workarea Forter 1.2.4 (2019-10-16)
 --------------------------------------------------------------------------------
 

data/Gemfile

@@ -3,7 +3,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 gemspec
 
-gem 'workarea', github: 'workarea-commerce/workarea', branch: 'v3.4-stable'
+gem 'workarea', github: 'workarea-commerce/workarea'
 
 gem 'byebug'
 group :test do

data/app/models/search/admin/order.decorator

@@ -1,7 +1,7 @@
 module Workarea
   decorate Search::Admin::Order, with: :forter do
     def should_be_indexed?
-      model.placed? || model.flagged_for_fraud?
+      model.placed? || model.fraud_suspected?
     end
   end
 end

data/app/models/workarea/checkout.decorator

@@ -0,0 +1,24 @@
+module Workarea
+  decorate Checkout, with: :forter do
+
+    # Forter has a post auth model of fraud analysis
+    # This decorator removes the check for fraud.
+    def place_order
+      return false unless complete?
+      return false unless shippable?
+      return false unless payable?
+
+      inventory.purchase
+      return false unless inventory.captured?
+
+      unless payment_collection.purchase
+        inventory.rollback
+        return false
+      end
+
+      result = order.place
+      place_order_side_effects if result
+      result
+    end
+  end
+end

data/app/models/workarea/checkout/collect_payment.decorator

@@ -4,23 +4,20 @@ module Workarea
       collect_result = super
 
       begin
-        decision = Forter::Decision.find_or_create_by(id: @order.id)
-        order_hash = Forter::Order.new(@order).to_h
-
-        response = get_decision(@order_id, order_hash, decision)
+        fraud_analyzer.decide!
 
         # Rollback all transactions if the original collection
         # was successful but the forter decision was a decline.
-        if collect_result && response.suspected_fraud?
+        if collect_result && @order.fraud_suspected?
           payment.rollback!
-          payment.flagged_for_fraud = true
+          payment.fraud_suspected = true
 
           payment.save!
           false
         else
           # need to re-add errors indicating the payment operation failed
           error_messages = payment.errors.messages.clone
-          payment.update_attribute(:flagged_for_fraud, false)
+          payment.update_attribute(:fraud_suspected, false)
           error_messages.each do |attribute, message|
             payment.errors.add(attribute, message)
           end
@@ -30,46 +27,13 @@ module Workarea
       rescue => e
         Forter.log_error(e)
         return collect_result
-      ensure
-        decision.save!
       end
     end
 
     private
 
-      ERROR_STATUSES = 500..599
-      MAX_RETRIES = 2
-
-      # Gets forter decision and builds decision responses on the Forter Decision
-      # model
-      #
-      # @raises Error
-      #
-      # @return [Workarea::Forter::DecisionResponse] response
-      #
-      def get_decision(order_id, order_hash, decision)
-        count = 1
-        begin
-          fraud_response = Forter.gateway.create_decision(@order.id, order_hash)
-          body = JSON.parse(fraud_response.body)
-          response = Forter::DecisionResponse.new(body)
-
-          decision.responses.build(decision_response: response)
-          raise if ERROR_STATUSES.include? fraud_response.status
-
-          response
-        rescue => error
-          decision.responses.build(
-            timed_out: error.is_a?(Faraday::Error::TimeoutError),
-            error: error.message
-          )
-          if count < MAX_RETRIES
-            count += 1
-            retry
-          else
-            raise error
-          end
-        end
-      end
+    def fraud_analyzer
+      @fraud_analyzer ||= Workarea.config.fraud_analyzer.constantize.new(@checkout)
+    end
   end
 end

data/app/models/workarea/checkout/fraud/forter_analyzer.rb

@@ -0,0 +1,57 @@
+module Workarea
+  class Checkout
+    module Fraud
+      class ForterAnalyzer < Analyzer
+        ERROR_STATUSES = 500..599
+        MAX_RETRIES = 2
+
+        def make_decision
+          decision = Workarea::Order::FraudDecision.new
+          order_hash = Forter::Order.new(order).to_h
+          count = 1
+
+          begin
+            fraud_response = Forter.gateway.create_decision(order.id, order_hash)
+            body = JSON.parse(fraud_response.body)
+
+            forter_decision_action = if body["action"] == "decline"
+              :declined
+            else
+              body["action"].optionize.to_sym
+            end
+
+            raise if ERROR_STATUSES.include? fraud_response.status
+
+            decision.message = body["message"]
+            decision.decision = forter_decision_action
+            decision.response = body
+
+            response = Forter::DecisionResponse.new(body)
+            decision.responses.build(decision_response: response)
+            decision
+
+          rescue => error
+            forter_error_decision.responses.build(
+              timed_out: error.is_a?(Faraday::Error::TimeoutError),
+              error: error.message
+            )
+            forter_error_decision
+
+            if count < MAX_RETRIES
+              count += 1
+              retry
+            else
+              raise error
+            end
+          end
+        end
+
+        private
+
+        def forter_error_decision
+          @forter_error_decision ||= error_decision(nil)
+        end
+      end
+    end
+  end
+end

data/app/models/workarea/order.decorator

@@ -3,12 +3,5 @@ module Workarea
     decorated do
       field :forter_tracking_code, type: String
     end
-
-    def flagged_for_fraud?
-      decision = Workarea::Forter::Decision.find(id) rescue nil
-      return false unless decision.present? && decision.response.present?
-
-      decision.response.action == 'decline'
-    end
   end
 end

data/app/models/workarea/order/fraud_decision.decorator

@@ -0,0 +1,13 @@
+module Workarea
+  decorate Order::FraudDecision, with: :forter do
+    decorated do
+      embeds_many :responses, class_name: 'Workarea::Forter::Response'
+      field :external_order_status, type: String, default: "PROCESSING"
+    end
+
+    def response
+      return if responses.empty?
+      responses.sort_by { |r| r.created_at.to_i }.last.decision_response
+    end
+  end
+end

data/app/models/workarea/order/status/suspected_fraud.rb

@@ -1,13 +1,7 @@
 module Workarea
-  class Order
-    module Status
-      class SuspectedFraud
-        include StatusCalculator::Status
-
-        def in_status?
-          !order.placed? && order.flagged_for_fraud? && !order.canceled?
-        end
-      end
+  decorate Order::Status::SuspectedFraud, with: :forter do
+    def in_status?
+      super && !order.placed? && !order.canceled?
     end
   end
 end

data/app/models/workarea/payment.decorator

@@ -1,7 +1,7 @@
 module Workarea
   decorate Payment, with: :forter do
     decorated do
-      field :flagged_for_fraud, type: Boolean, default: false
+      field :fraud_suspected, type: Boolean, default: false
     end
 
     def rollback!(options = {})

data/app/models/workarea/payment/status/suspected_fraud.rb

@@ -5,7 +5,7 @@ module Workarea
         include Workarea::StatusCalculator::Status
 
         def in_status?
-          order.flagged_for_fraud?
+          order.fraud_suspected?
         end
       end
     end

data/app/services/workarea/forter/order.rb

@@ -57,8 +57,8 @@ module Workarea
         end
 
         def delivery_type
-          return "DIGITAL" if order.items.all? { |oi| oi.digital? }
-          return "HYBRID" if order.items.any? { |oi| oi.digital? }
+          return "DIGITAL" if order.items.none?(&:shipping?)
+          return "HYBRID" if order.items.any?(&:shipping?)
           "PHYSICAL"
         end
 
@@ -74,7 +74,7 @@ module Workarea
               basicItemData: {
                 name: item.product.name,
                 quantity: item.quantity,
-                type: item.digital? ? "NON_TANGIBLE" : "TANGIBLE",
+                type: item.shipping? ? "TANGIBLE" : "NON_TANGIBLE",
                 price: { amountUSD: item.total_value.to_s },
                 productId: item.product.id
               }

data/app/views/workarea/admin/orders/{forter.html.haml → fraud.html.haml}

@@ -1,4 +1,4 @@
-- @page_title = t('workarea.admin.orders.forter.page_title', id: @order.id)
+- @page_title = t('workarea.admin.orders.fraud.title', id: @order.id)
 
 .view
   .view__header
@@ -11,7 +11,7 @@
         = render_aux_navigation_for(@order)
 
   .view__container
-    = render_cards_for(@order, :forter)
+    = render_cards_for(@order, :fraud)
 
   .view__container.view__container--narrow
     .grid
@@ -21,7 +21,7 @@
 
         %li
           %strong= t('workarea.admin.orders.forter.status')
-          = @order.decision.external_order_status
+          = @order.fraud_decision.external_order_status
         %li
           %br
           %strong= link_to t('workarea.admin.orders.forter.console'), "https://portal.forter.com/dashboard/#{@order.id}"
@@ -41,7 +41,7 @@
               %th= t('workarea.admin.orders.forter.error')
 
           %tbody
-            - @order.decision.responses.each do |response|
+            - @order.fraud_decision.responses.each do |response|
               %tr
                 %td= response.fraud_decision_action
                 %td= response.decision_response&.body_message
@@ -52,6 +52,3 @@
                       %li= e["message"]
                 %td= response.error
 
-
-
-

data/app/workers/forter/update_status.rb

@@ -4,7 +4,7 @@ module Workarea
       include Sidekiq::Worker
 
       def perform(id, status_hash)
-        decision = Workarea::Forter::Decision.find(id) rescue nil
+        decision = Workarea::Order.find(id).fraud_decision rescue nil
 
         if decision.blank?
           Rails.logger.warn "No decision record found for #{id} during update status"

data/config/initializers/appends.rb

@@ -2,8 +2,3 @@ Workarea.append_partials(
   'storefront.javascript',
   'workarea/storefront/forter_tracking'
 )
-
-Workarea.append_partials(
-  'admin.order_cards',
-  'workarea/admin/orders/forter'
-)

data/config/initializers/workarea.rb

@@ -2,6 +2,8 @@ Workarea.configure do |config|
   config.order_status_calculators.insert(0, 'Workarea::Order::Status::SuspectedFraud')
   config.payment_status_calculators.insert(0, 'Workarea::Payment::Status::SuspectedFraud')
 
+  config.fraud_analyzer = 'Workarea::Checkout::Fraud::ForterAnalyzer'
+
   config.forter = ActiveSupport::Configurable::Configuration.new
   config.forter.site_id = nil
 

data/config/routes.rb

@@ -1,7 +1,2 @@
-Workarea::Admin::Engine.routes.draw do
-  resources :orders, only: [] do
-    member do
-      get :forter
-    end
-  end
+Rails.application.routes.draw do
 end

data/lib/workarea/forter/version.rb

@@ -1,5 +1,5 @@
 module Workarea
   module Forter
-    VERSION = "1.2.4"
+    VERSION = "1.3.0"
   end
 end

data/test/integration/workarea/admin/forter_order_integration_test.rb

@@ -15,15 +15,15 @@ module Workarea
       def test_shows_error_decision
         order = create_placed_forter_order(email: 'error@workarea.com')
 
-        get admin.forter_order_path(order)
-        message = Workarea::Forter::Decision.first.response.errors.first["message"]
+        get admin.fraud_order_path(order)
+        message = order.fraud_decision.response.errors.first["message"]
         assert(response.body.include?(message))
       end
 
-      def test_returns_flow_order_details
+      def test_returns_forter_order_details
         order = create_placed_forter_order(email: 'approve@workarea.com')
-        decision = Workarea::Forter::Decision.find(order.id)
-        get admin.forter_order_path(order)
+        decision = order.fraud_decision
+        get admin.fraud_order_path(order)
 
         assert(response.body.include?(decision.response.body_message))
         assert(response.body.include?(decision.response.action))

data/test/integration/workarea/storefront/checkouts_integration_test.decorator

@@ -0,0 +1,69 @@
+module Workarea
+  decorate Storefront::CheckoutsIntegrationTest, with: :forter do
+    def test_saving_fraud_decision
+      complete_checkout
+      order = Order.desc(:created_at).first
+
+      assert(order.fraud_decision.present?)
+      assert(order.placed?)
+      refute(order.fraud_suspected_at.present?)
+      assert(order.fraud_decided_at.present?)
+      assert_equal(:approve, order.fraud_decision.decision)
+
+      post storefront.cart_items_path,
+        params: {
+          product_id: product.id,
+          sku: product.skus.first,
+          quantity: 1
+        }
+
+      get storefront.checkout_addresses_path
+      patch storefront.checkout_addresses_path,
+        params: {
+          email: 'decline@workarea.com',
+          billing_address: {
+            first_name:   'Ben',
+            last_name:    'Crouse',
+            street:       '12 N. 3rd St.',
+            city:         'Philadelphia',
+            region:       'PA',
+            postal_code:  '19106',
+            country:      'US',
+            phone_number: '2159251800'
+          },
+          shipping_address: {
+            first_name:   'Ben',
+            last_name:    'Crouse',
+            street:       '22 S. 3rd St.',
+            city:         'Philadelphia',
+            region:       'PA',
+            postal_code:  '19106',
+            country:      'US',
+            phone_number: '2159251800'
+          }
+        }
+      get storefront.checkout_shipping_path
+      patch storefront.checkout_shipping_path
+
+      get storefront.checkout_payment_path
+
+      patch storefront.checkout_place_order_path,
+        params: {
+          payment: 'new_card',
+          credit_card: {
+            number: '1',
+            month:  1,
+            year:   2020,
+            cvv:    '999'
+          }
+        }
+
+      order = Order.desc(:created_at).first
+
+      assert_equal(:declined, order.fraud_decision.decision)
+      assert(order.fraud_suspected_at.present?)
+      assert(order.fraud_decided_at.present?)
+      refute(order.placed?)
+    end
+  end
+end

data/test/integration/workarea/storefront/forter_integration_test.rb

@@ -9,13 +9,13 @@ module Workarea
         order = Workarea::Order.last
         payment = Workarea::Payment.last
 
-        decision = Workarea::Forter::Decision.find(order.id)
+        order.reload
+        decision = order.fraud_decision
 
         refute(decision.response.suspected_fraud?)
 
-        order.reload
-        refute(order.flagged_for_fraud?)
-        refute(payment.flagged_for_fraud?)
+        refute(order.fraud_suspected?)
+        refute(payment.fraud_suspected?)
       end
 
       def test_decision_not_reviewed
@@ -24,9 +24,10 @@ module Workarea
 
         order = Workarea::Order.last
         payment = Workarea::Payment.last
-        decision = Workarea::Forter::Decision.find(order.id)
 
-        refute(payment.flagged_for_fraud?)
+        decision = order.fraud_decision
+
+        refute(payment.fraud_suspected?)
         refute(decision.response.suspected_fraud?)
       end
 
@@ -35,7 +36,9 @@ module Workarea
         complete_checkout("decline@workarea.com", 'W3blinc1')
 
         order = Workarea::Order.last
-        decision = Workarea::Forter::Decision.find(order.id)
+
+        decision = order.fraud_decision
+
         assert(decision.response.suspected_fraud?)
 
         payment = Workarea::Payment.last
@@ -43,13 +46,12 @@ module Workarea
 
         assert(transaction.cancellation.present?)
 
-        order.reload
         payment.reload
 
-        assert(order.flagged_for_fraud?)
+        assert(order.fraud_suspected?)
         assert_equal(:suspected_fraud, order.status)
 
-        assert(payment.flagged_for_fraud?)
+        assert(payment.fraud_suspected?)
         assert_equal(:suspected_fraud, payment.status)
       end
 
@@ -59,9 +61,10 @@ module Workarea
 
         order = Workarea::Order.last
         payment = Workarea::Payment.last
-        decision = Workarea::Forter::Decision.find(order.id)
 
-        refute(payment.flagged_for_fraud?)
+        decision = order.fraud_decision
+
+        refute(payment.fraud_suspected?)
         refute(decision.response.suspected_fraud?)
         assert(decision.response.errors.present?)
       end

data/test/lib/workarea/forter/gateway_test.rb

@@ -16,7 +16,7 @@ module Workarea
         VCR.use_cassette("forter/get_decision", match_requests_on: [:method, :uri]) do
           order = create_placed_forter_order(id: "fortertest1234", email: "approve@forter.com")
 
-          forter_decision = Forter::Decision.find order.id
+          forter_decision = order.fraud_decision
           response = forter_decision.responses.first
           assert response.decision_response.success?
         end
@@ -31,7 +31,6 @@ module Workarea
           response = gateway.create_decision(order.id, hsh)
           assert(response.success?)
 
-
           hsh = {
             orderId: order.id,
             eventTime: Time.new.to_i * 1000,

data/test/models/workarea/checkout/forter_collect_payment_test.rb

@@ -5,56 +5,47 @@ module Workarea
     class ForterCollectPaymentTest < TestCase
       setup :create_models
 
-      def test_rescuing_timeout_errors
-        Workarea::Forter::BogusGateway
-          .any_instance
-          .stubs(:create_decision)
-          .raises(Faraday::Error::TimeoutError)
-        refute(@collect_payment.purchase)
-
-        forter_decision = Forter::Decision.find(@order.id)
-        assert_equal(2, forter_decision.responses.size)
-        forter_decision.responses.each do |response|
-          assert response.timed_out
-        end
+      def test_purchase
+        @collect_payment.purchase
+        @order.reload
+        forter_decision = @order.fraud_decision
+        assert_equal(1, forter_decision.responses.size)
+        assert_equal(:approve, forter_decision.decision)
       end
 
-      def test_with_one_timeout
-        normal_response = Forter.gateway.create_decision(@order.id, Forter::Order.new(@order).to_h)
+      def test_rescuing_timeout_errors
         Workarea::Forter::BogusGateway
           .any_instance
           .stubs(:create_decision)
           .raises(Faraday::Error::TimeoutError)
-          .then
-          .returns(normal_response)
-
         refute(@collect_payment.purchase)
-        forter_decision = Forter::Decision.find(@order.id)
-        assert_equal(2, forter_decision.responses.size)
 
-        assert(forter_decision.responses.first.timed_out)
-        refute(forter_decision.responses.second.timed_out)
+        @order.reload
+        forter_decision = @order.fraud_decision
+        assert_equal(:no_decision, forter_decision.decision)
+
+        assert_equal("An error occured during the fraud check: timeout", forter_decision.message)
       end
 
       private
 
-        def create_models
-          @order = Order.create!(email: 'test@workarea.com', total_price: 5.to_m)
-          @checkout = Checkout.new(@order)
-          @payment = Payment.create!(
-            id: @order.id,
-            address: {
-              first_name: "Ben",
-              last_name: "Crouse",
-              street: "22 S 3rd St",
-              city: "Philadelphia",
-              region: "PA",
-              country: Country['US'],
-              postal_code: 19106
-            }
-          )
-          @collect_payment = CollectPayment.new(@checkout)
-        end
+      def create_models
+        @order = Order.create!(email: 'test@workarea.com', total_price: 5.to_m)
+        @checkout = Checkout.new(@order)
+        @payment = Payment.create!(
+          id: @order.id,
+          address: {
+            first_name: "Ben",
+            last_name: "Crouse",
+            street: "22 S 3rd St",
+            city: "Philadelphia",
+            region: "PA",
+            country: Country['US'],
+            postal_code: 19106
+          }
+        )
+        @collect_payment = CollectPayment.new(@checkout)
+      end
     end
   end
 end

data/test/models/workarea/checkout_test.decorator

@@ -0,0 +1,16 @@
+module Workarea
+  decorate CheckoutTest, with: :forter do
+    def test_place_order_fails_for_fraud
+      @order.email = 'decline@workarea.com'
+      checkout = Checkout.new(@order)
+
+      checkout.expects(:complete?).returns(true)
+      checkout.expects(:shippable?).returns(true)
+      checkout.expects(:payable?).returns(true)
+      checkout.inventory.expects(:purchase).once
+
+      refute(checkout.place_order)
+      refute(@order.reload.placed?)
+    end
+  end
+end

data/test/system/workarea/admin/orders_system_test.decorator

@@ -0,0 +1,12 @@
+module Workarea
+  decorate Admin::OrdersSystemTest, with: :forter do
+    def test_fraud
+      order = create_placed_forter_order(email: 'decline@workarea.com')
+      visit admin.order_path(order)
+      click_link t('workarea.admin.orders.attributes.fraud.title')
+
+      assert(page.has_content?('decline')) # decision
+      assert(page.has_content?(order.fraud_decision.message))
+    end
+  end
+end

data/test/vcr_cassettes/forter/update_status.yml

@@ -5,38 +5,41 @@ http_interactions:
     uri: https://api.forter-secure.com/v2/orders/statusfortertest12345
     body:
       encoding: UTF-8
-      string: '{"orderId":"statusfortertest12345","orderType":"WEB","timeSentToForter":1546030401000,"checkoutTime":1546030397,"primaryRecipient":{"personalDetails":{"firstName":"Ben","lastName":"Crouse"},"address":{"address1":"22
+      string: '{"orderId":"statusfortertest12345","orderType":"WEB","timeSentToForter":1574090964000,"checkoutTime":1574090960,"primaryRecipient":{"personalDetails":{"firstName":"Ben","lastName":"Crouse"},"address":{"address1":"22
         S. 3rd St.","city":"Philadelphia","country":"US","address2":"Second Floor","zip":"19106","region":"PA"},"phone":[{"phone":""}]},"totalAmount":{"amountUSD":"11.00"},"connectionInformation":{"customerIP":"127.0.0.1","userAgent":"Mozilla/5.0
         (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0 Mozilla/5.0
-        (Macintosh; Intel Mac OS X x.y; rv:42.0) Gecko/20100101 Firefox/42.0."},"primaryDeliveryDetails":{"deliveryType":"PHYSICAL","deliveryMethod":"Test
+        (Macintosh; Intel Mac OS X x.y; rv:42.0) Gecko/20100101 Firefox/42.0.","forterTokenCookie":"123ABC"},"primaryDeliveryDetails":{"deliveryType":"PHYSICAL","deliveryMethod":"Test
         0","deliveryPrice":{"amountUSD":"1.00"},"carrier":null},"cartItems":[{"basicItemData":{"name":"Test
-        Product","quantity":2,"type":"TANGIBLE","price":{"amountUSD":"10.00"},"productId":"BCE0E155EF"}}],"payment":[{"billingDetails":{"personalDetails":{"firstName":"Ben","lastName":"Crouse"},"address":{"address1":"22
-        S. 3rd St.","address2":"Second Floor","city":"Philadelphia","country":"US","zip":"19106","region":"PA"},"phone":[{"phone":""}]},"tokenizedCard":{"token":"1","lastFourDigits":"1111","expirationMonth":"01","expirationYear":"2019","cardBrand":"Visa","nameOnCard":"Ben
-        Crouse"}}],"accountOwner":{"firstName":"Ben","lastName":"Crouse","email":"approve@forter.com"}}'
+        Product","quantity":2,"type":"TANGIBLE","price":{"amountUSD":"10.00"},"productId":"BE6FEF44CE"}}],"payment":[{"creditCard":{"bin":"411111","lastFourDigits":"1111","expirationMonth":"01","expirationYear":"2020","cardBrand":"Visa","nameOnCard":"Ben
+        Crouse","paymentGatewayData":{"gatewayName":"not specified","gatewayTransactionId":"53433"},"verificationResults":{"avsFullResult":"","cvvResult":"","authorizationCode":"53433","processorResponseText":"Bogus
+        Gateway: Forced success","processorResponseCode":""}},"billingDetails":{"personalDetails":{"firstName":"Ben","lastName":"Crouse"},"address":{"address1":"12
+        N. 3rd St.","address2":"thrid floor","city":"Philadelphia","country":"US","zip":"19106","region":"PA"},"phone":[{"phone":""}]},"amount":{"amountUSD":"11.00"}}],"accountOwner":{"firstName":"Ben","lastName":"Crouse","email":"approve@forter.com"},"totalDiscount":null}'
     headers:
       Content-Type:
       - application/json
+      X-Forter-Siteid:
+      - 4d12ac5d794c
       Api-Version:
-      - '2.2'
+      - '2.3'
       User-Agent:
       - Faraday v0.15.4
       Authorization:
-      - Basic a
+      - Basic ODZmMjFiZWU3ZTNiMmU1MWY2YTk5NmIxZTYxNTFmOTA4ZDY1ZWQ0Zjo=
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
   response:
     status:
-      code: 401
-      message: Unauthorized
+      code: 200
+      message: OK
     headers:
       Date:
-      - Fri, 28 Dec 2018 20:53:21 GMT
+      - Mon, 18 Nov 2019 15:29:28 GMT
       Content-Type:
       - application/json; charset=utf-8
       Content-Length:
-      - '58'
+      - '186'
       Connection:
       - keep-alive
       Server:
@@ -52,27 +55,29 @@ http_interactions:
       Expires:
       - '0'
       Etag:
-      - W/"3a-ZqDAtEqlVbaEf6c/ziI5qiLtZfk"
+      - W/"ba-Ef/isk7mEOWPRXN9i4trCjru7vk"
       Vary:
       - Accept-Encoding
     body:
       encoding: UTF-8
-      string: '{"status":"failed","message":"unauthorized, invalid site"}'
+      string: '{"status":"success","transaction":"statusfortertest12345","action":"approve","message":"
+        | Link in portal: https://portal.forter.com/dashboard/statusfortertest12345","reasonCode":"Test"}'
     http_version: 
-  recorded_at: Fri, 28 Dec 2018 20:53:21 GMT
+  recorded_at: Mon, 18 Nov 2019 15:29:28 GMT
 - request:
     method: post
     uri: https://api.forter-secure.com/v2/orders/statusfortertest12345
     body:
       encoding: UTF-8
-      string: '{"orderId":"statusfortertest12345","orderType":"WEB","timeSentToForter":1546030401000,"checkoutTime":1546030397,"primaryRecipient":{"personalDetails":{"firstName":"Ben","lastName":"Crouse"},"address":{"address1":"22
+      string: '{"orderId":"statusfortertest12345","orderType":"WEB","timeSentToForter":1574090968000,"checkoutTime":1574090968,"primaryRecipient":{"personalDetails":{"firstName":"Ben","lastName":"Crouse"},"address":{"address1":"22
         S. 3rd St.","city":"Philadelphia","country":"US","address2":"Second Floor","zip":"19106","region":"PA"},"phone":[{"phone":""}]},"totalAmount":{"amountUSD":"11.00"},"connectionInformation":{"customerIP":"127.0.0.1","userAgent":"Mozilla/5.0
         (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0 Mozilla/5.0
-        (Macintosh; Intel Mac OS X x.y; rv:42.0) Gecko/20100101 Firefox/42.0."},"primaryDeliveryDetails":{"deliveryType":"PHYSICAL","deliveryMethod":"Test
+        (Macintosh; Intel Mac OS X x.y; rv:42.0) Gecko/20100101 Firefox/42.0.","forterTokenCookie":"123ABC"},"primaryDeliveryDetails":{"deliveryType":"PHYSICAL","deliveryMethod":"Test
         0","deliveryPrice":{"amountUSD":"1.00"},"carrier":null},"cartItems":[{"basicItemData":{"name":"Test
-        Product","quantity":2,"type":"TANGIBLE","price":{"amountUSD":"10.00"},"productId":"BCE0E155EF"}}],"payment":[{"billingDetails":{"personalDetails":{"firstName":"Ben","lastName":"Crouse"},"address":{"address1":"22
-        S. 3rd St.","address2":"Second Floor","city":"Philadelphia","country":"US","zip":"19106","region":"PA"},"phone":[{"phone":""}]},"tokenizedCard":{"token":"1","lastFourDigits":"1111","expirationMonth":"01","expirationYear":"2019","cardBrand":"Visa","nameOnCard":"Ben
-        Crouse"}}],"accountOwner":{"firstName":"Ben","lastName":"Crouse","email":"approve@forter.com"}}'
+        Product","quantity":2,"type":"TANGIBLE","price":{"amountUSD":"10.00"},"productId":"BE6FEF44CE"}}],"payment":[{"creditCard":{"bin":"411111","lastFourDigits":"1111","expirationMonth":"01","expirationYear":"2020","cardBrand":"Visa","nameOnCard":"Ben
+        Crouse","paymentGatewayData":{"gatewayName":"not specified","gatewayTransactionId":"53433"},"verificationResults":{"avsFullResult":"","cvvResult":"","authorizationCode":"53433","processorResponseText":"Bogus
+        Gateway: Forced success","processorResponseCode":""}},"billingDetails":{"personalDetails":{"firstName":"Ben","lastName":"Crouse"},"address":{"address1":"12
+        N. 3rd St.","address2":"thrid floor","city":"Philadelphia","country":"US","zip":"19106","region":"PA"},"phone":[{"phone":""}]},"amount":{"amountUSD":"11.00"}}],"accountOwner":{"firstName":"Ben","lastName":"Crouse","email":"approve@forter.com"},"totalDiscount":null}'
     headers:
       Content-Type:
       - application/json
@@ -83,7 +88,7 @@ http_interactions:
       User-Agent:
       - Faraday v0.15.4
       Authorization:
-      - Basic a
+      - Basic ODZmMjFiZWU3ZTNiMmU1MWY2YTk5NmIxZTYxNTFmOTA4ZDY1ZWQ0Zjo=
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
@@ -94,7 +99,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Fri, 28 Dec 2018 20:53:21 GMT
+      - Mon, 18 Nov 2019 15:29:37 GMT
       Content-Type:
       - application/json; charset=utf-8
       Content-Length:
@@ -122,13 +127,13 @@ http_interactions:
       string: '{"status":"success","transaction":"statusfortertest12345","action":"approve","message":"
         | Link in portal: https://portal.forter.com/dashboard/statusfortertest12345","reasonCode":"Test"}'
     http_version: 
-  recorded_at: Fri, 28 Dec 2018 20:53:21 GMT
+  recorded_at: Mon, 18 Nov 2019 15:29:37 GMT
 - request:
     method: put
     uri: https://api.forter-secure.com/v2/status/statusfortertest12345
     body:
       encoding: UTF-8
-      string: '{"orderId":"statusfortertest12345","eventTime":1546030401000,"updatedStatus":"CANCELED_BY_MERCHANT"}'
+      string: '{"orderId":"statusfortertest12345","eventTime":1574090977000,"updatedStatus":"CANCELED_BY_MERCHANT"}'
     headers:
       Content-Type:
       - application/json
@@ -139,7 +144,7 @@ http_interactions:
       User-Agent:
       - Faraday v0.15.4
       Authorization:
-      - Basic a
+      - Basic ODZmMjFiZWU3ZTNiMmU1MWY2YTk5NmIxZTYxNTFmOTA4ZDY1ZWQ0Zjo=
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
@@ -150,7 +155,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Fri, 28 Dec 2018 20:53:21 GMT
+      - Mon, 18 Nov 2019 15:29:38 GMT
       Content-Type:
       - application/json; charset=utf-8
       Content-Length:
@@ -178,5 +183,5 @@ http_interactions:
       string: '{"status":"success","message":"Transaction #statusfortertest12345 status
         recieved"}'
     http_version: 
-  recorded_at: Fri, 28 Dec 2018 20:53:21 GMT
+  recorded_at: Mon, 18 Nov 2019 15:29:38 GMT
 recorded_with: VCR 2.9.3

data/test/workers/forter/update_status_test.rb

@@ -3,7 +3,7 @@ require 'test_helper'
 module Workarea
   class Forter::UpdateStatusTest < TestCase
     def test_decision_status_update
-      decision = Workarea::Forter::Decision.create(id: '1234')
+      order = create_placed_order
 
       details_hash = {
         orderId: 1234,
@@ -11,11 +11,11 @@ module Workarea
         updatedStatus: "CANCELED_BY_MERCHANT"
       }
 
-      Workarea::Forter::UpdateStatus.new.perform(decision.id, details_hash)
+      Workarea::Forter::UpdateStatus.new.perform(order.id, details_hash)
 
-      decision.reload
+      order.reload
 
-      assert_equal("CANCELED_BY_MERCHANT", decision.external_order_status)
+      assert_equal("CANCELED_BY_MERCHANT", order.fraud_decision.external_order_status)
     end
   end
 end

data/workarea-forter.gemspec

@@ -13,6 +13,6 @@ Gem::Specification.new do |s|
   s.files       = `git ls-files`.split("\n")
   s.license = 'Business Software License'
 
-  s.add_dependency 'workarea', '~> 3.x', '>= 3.4'
+  s.add_dependency 'workarea', '~> 3.x', '>= 3.5'
   s.add_dependency 'faraday'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workarea-forter
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.3.0
 platform: ruby
 authors:
 - Jeff Yucis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-16 00:00:00.000000000 Z
+date: 2019-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: workarea
@@ -19,7 +19,7 @@ dependencies:
         version: 3.x
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '3.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 3.x
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -67,14 +67,15 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- app/controllers/workarea/admin/orders_controller.decorator
 - app/controllers/workarea/storefront/application_controller.decorator
 - app/models/search/admin/order.decorator
+- app/models/workarea/checkout.decorator
 - app/models/workarea/checkout/collect_payment.decorator
-- app/models/workarea/forter/decision.rb
+- app/models/workarea/checkout/fraud/forter_analyzer.rb
 - app/models/workarea/forter/response.rb
 - app/models/workarea/fulfillment.decorator
 - app/models/workarea/order.decorator
+- app/models/workarea/order/fraud_decision.decorator
 - app/models/workarea/order/status/suspected_fraud.rb
 - app/models/workarea/payment.decorator
 - app/models/workarea/payment/saved_credit_card.decorator
@@ -88,9 +89,7 @@ files:
 - app/services/workarea/forter/tender/gift_card.rb
 - app/services/workarea/forter/tender/paypal.rb
 - app/services/workarea/forter/tender/store_credit.rb
-- app/view_models/workarea/admin/order_view_model.decorator
-- app/views/workarea/admin/orders/_forter.html.haml
-- app/views/workarea/admin/orders/forter.html.haml
+- app/views/workarea/admin/orders/fraud.html.haml
 - app/views/workarea/storefront/_forter_tracking.html.haml
 - app/workers/forter/update_status.rb
 - app/workers/workarea/save_user_order_details.decorator
@@ -144,15 +143,17 @@ files:
 - test/integration/workarea/forter_cybersource_response_code_integration_test.rb
 - test/integration/workarea/forter_moneris_response_code_integration_test.rb
 - test/integration/workarea/forter_payflow_pro_response_code_test.rb
+- test/integration/workarea/storefront/checkouts_integration_test.decorator
 - test/integration/workarea/storefront/forter_integration_test.rb
 - test/lib/workarea/forter/gateway_test.rb
 - test/models/workarea/checkout/forter_collect_payment_test.rb
+- test/models/workarea/checkout_test.decorator
 - test/models/workarea/forter_payment_test.rb
 - test/models/workarea/payment/forter_credit_card_test.rb
 - test/models/workarea/payment/forter_saved_credit_card_test.rb
 - test/services/workarea/forter/order_test.rb
 - test/support/workarea/forter_api_config.rb
-- test/system/workarea/admin/forter_system_test.rb
+- test/system/workarea/admin/orders_system_test.decorator
 - test/system/workarea/storefront/forter_braintree_checkout_system_test.rb
 - test/system/workarea/storefront/forter_tracking_system_test.rb
 - test/system/workarea/storefront/guest_checkout_system_test.decorator
@@ -169,7 +170,6 @@ files:
 - test/vcr_cassettes/forter/system/braintree_declined.yml
 - test/vcr_cassettes/forter/system/braintree_not_reviewed.yml
 - test/vcr_cassettes/forter/update_status.yml
-- test/view_models/workarea/storefront/order_view_model_test.decorator
 - test/workers/forter/update_status_test.rb
 - workarea-forter.gemspec
 homepage: https://github.com/workarea-commerce/workarea-forter

data/app/controllers/workarea/admin/orders_controller.decorator

@@ -1,6 +0,0 @@
-module Workarea
-  decorate Admin::OrdersController, with: :forter do
-    def fraud
-    end
-  end
-end

data/app/models/workarea/forter/decision.rb

@@ -1,18 +0,0 @@
-module Workarea
-  module Forter
-    class Decision
-      include ApplicationDocument
-
-      embeds_many :responses, class_name: 'Workarea::Forter::Response'
-      field :external_order_status, type: String, default: "PROCESSING"
-
-      index(created_at: -1)
-
-      # the last response returned from the forter service.
-      def response
-        return if responses.empty?
-        responses.sort_by { |r| r.created_at.to_i }.last.decision_response
-      end
-    end
-  end
-end

data/app/view_models/workarea/admin/order_view_model.decorator

@@ -1,7 +0,0 @@
-module Workarea
-  decorate Admin::OrderViewModel, with: :forter do
-    def decision
-      @decision = Workarea::Forter::Decision.find(model.id) rescue nil
-    end
-  end
-end

data/app/views/workarea/admin/orders/_forter.html.haml

@@ -1,18 +0,0 @@
-- if order.decision.present?
-  .grid__cell
-    .card{ class: card_classes(:forter, local_assigns[:active]) }
-      = link_to forter_order_path(order), class: 'card__header' do
-        %span.card__header-text= t('workarea.admin.orders.cards.forter.title')
-        = inline_svg 'workarea/admin/icons/link.svg', class: 'card__icon'
-
-      - if local_assigns[:active].blank?
-        .card__body
-          %ul.list-reset
-            %li
-              %strong= t('workarea.admin.orders.cards.forter.decision')
-              = order.decision.response&.action
-
-            - if order.decision.response&.reason_code.present?
-              %li
-                %strong= t('workarea.admin.orders.cards.forter.reason_code')
-                = order.decision.response.reason_code

data/test/system/workarea/admin/forter_system_test.rb

@@ -1,31 +0,0 @@
-require 'test_helper'
-
-module Workarea
-  module Adming
-    class ForterSystemTest < Workarea::SystemTest
-      include Admin::IntegrationTest
-
-      def test_viewing_forter_order_admin
-        checkout = create_purchasable_checkout
-        order = checkout.order
-
-        normal_response = Forter.gateway.create_decision(
-          order.id,
-          Forter::Order.new(order).to_h
-        )
-        Workarea::Forter::BogusGateway
-          .any_instance
-          .stubs(:create_decision)
-          .raises(Faraday::Error::TimeoutError)
-          .then
-          .returns(normal_response)
-
-        assert(checkout.place_order)
-
-        visit admin.forter_order_path order
-
-        assert page.has_content?("timeout")
-      end
-    end
-  end
-end

data/test/view_models/workarea/storefront/order_view_model_test.decorator

@@ -1,10 +0,0 @@
-module Workarea
-  decorate Storefront::OrderViewModelTest, with: :forter do
-
-    def set_order
-      @order = Order.new
-      Workarea::Forter::Decision.create(id: @order.id)
-
-    end
-  end
-end