workarea-api 4.5.3 → 4.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0e1cb3e9913b2746955a162453b9c25864562b2e0cb4e567d1f0cd0a3b202e38
-  data.tar.gz: bbc070da292f5002261deca67eb84056f7b3e837cf2f057154c7cc465e6a1a1f
+  metadata.gz: bb882700d49c189d82c8986183a1cba9750f01187f172fcc81988d27e2236ab1
+  data.tar.gz: 7de993c7945ed5934c9c3bdd9d1bb50d278876c915c5d46c01686100e520d1cb
 SHA512:
-  metadata.gz: 97857f0599e2a0afc84641a14075b126f37e6ce047ac6d38489e210968c2ff04b8d4e82f1378a5a99c5832b86a8bf8a16dbb0cb17fcba00aeb690d0e1f207556
-  data.tar.gz: 3ee7e29e9c513cc012bdfe9dcaafce64c00adc8d18d4d3073ed46208715168df10708f093bef81d93028cbdff2f8ddb8d49a02c0a1ee51baf665878bcc4148dd
+  metadata.gz: 103ac8773fa6881af720616002bc3e1ff8bfbbb98d232de9527f4e2755de9299775254a6bedbd8201393812977dd7d9854c59120ca5ee2e277be4f158d3b3939
+  data.tar.gz: a9907fd80fa4797e28a6cfc460a5720fdf809510bb0dc8cfb8c4d97f974389d1a3900ee1ae11e6890f3afe8321d84f09547761fb0c4acff914226b12e77cb78e

data/CHANGELOG.md

@@ -1,3 +1,27 @@
+Workarea Api 4.5.4 (2020-08-19)
+--------------------------------------------------------------------------------
+
+*   Handle non-persisted recommendation settings
+
+    This uses `find_or_initialize` to match our usage of
+    `Recommendation::Settings` elsewhere in the platform.
+
+    Fixes #19
+    Ben Crouse
+
+*   Add Documentation Test for Failed Checkout Update
+
+    This documents the scenario in which a checkout update fails to persist,
+    and thus the API returns a `422` error to signify its failure. It
+    depends on the code changes in workarea-commerce/workarea#481, and thus
+    we will need to bump the Workarea version to restrict its upgrade to
+    users of v3.5.17 and beyond.
+
+    API-14
+    Tom Scott
+
+
+
 Workarea Api 4.5.3 (2020-03-26)
 --------------------------------------------------------------------------------
 

data/Rakefile

@@ -6,6 +6,8 @@ rescue LoadError
 end
 
 require 'rails'
+require "action_view/railtie"
+
 require 'workarea/core'
 require 'rake/testtask'
 require 'date'

data/admin/app/controllers/workarea/api/admin/recommendation_settings_controller.rb

@@ -114,7 +114,7 @@ module Workarea
         private
 
         def find_recommendation_settings
-          @recommendation_settings = Recommendation::Settings.find(params[:product_id])
+          @recommendation_settings = Recommendation::Settings.find_or_initialize_by(id: params[:product_id])
         end
       end
     end

data/admin/test/integration/workarea/api/admin/recommendation_settings_integration_test.rb

@@ -35,6 +35,20 @@ module Workarea
 
           assert_equal(['foo'], recommendation_settings.reload.product_ids)
         end
+
+        def test_unpersisted_recommendation_settings
+          get admin_api.product_recommendation_settings_path(@product.id)
+          result = JSON.parse(response.body)['recommendation_settings']
+          assert_equal(@product.id, result['_id'])
+          assert_equal(0, Recommendation::Settings.count)
+
+          patch admin_api.product_recommendation_settings_path(@product.id),
+            params: { recommendation_settings: { product_ids: ['foo'] } }
+
+          assert_equal(1, Recommendation::Settings.count)
+          assert_equal(@product.id, Recommendation::Settings.first.id)
+          assert_equal(['foo'], Recommendation::Settings.first.product_ids)
+        end
       end
     end
   end

data/lib/workarea/api/version.rb

@@ -1,5 +1,5 @@
 module Workarea
   module Api
-    VERSION = '4.5.3'.freeze
+    VERSION = '4.5.4'.freeze
   end
 end

data/storefront/test/documentation/workarea/api/storefront/checkouts_documentation_test.rb

@@ -85,6 +85,27 @@ module Workarea
           end
         end
 
+        def test_and_document_update_failure
+          description 'Failure to update a checkout'
+          route storefront_api.checkout_path(':id')
+          explanation <<-EOS
+            This is an example of what occurs when you fail to send in the correct parameters for your checkout.
+          EOS
+
+          record_request do
+            patch storefront_api.checkout_path(@order),
+              as: :json,
+              params: {
+                email: 'susanb@workarea.com',
+                shipping_address: address.except(:first_name),
+                billing_address: address.except(:last_name),
+                shipping_service: 'Express'
+              }
+
+            assert_equal(422, response.status)
+          end
+        end
+
         def test_and_document_complete
           description 'Completing a checkout'
           route storefront_api.complete_checkout_path(':id')

data/storefront/test/documentation/workarea/api/storefront/validation_documentation_test.rb

@@ -72,7 +72,7 @@ module Workarea
                 }
               }
 
-            assert_equal(200, response.status)
+            assert_equal(422, response.status)
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: workarea-api
 version: !ruby/object:Gem::Version
-  version: 4.5.3
+  version: 4.5.4
 platform: ruby
 authors:
 - Ben Crouse
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-26 00:00:00.000000000 Z
+date: 2020-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: workarea
@@ -37,28 +37,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.5.3
+        version: 4.5.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.5.3
+        version: 4.5.4
 - !ruby/object:Gem::Dependency
   name: workarea-api-admin
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.5.3
+        version: 4.5.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.5.3
+        version: 4.5.4
 - !ruby/object:Gem::Dependency
   name: raddocs
   requirement: !ruby/object:Gem::Requirement
@@ -755,7 +755,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Adds a JSON REST API to the Workarea Commerce Platform